[{"id":3676420,"web_url":"http://patchwork.ozlabs.org/comment/3676420/","msgid":"<546FSeECSqm-ORhiEUYCVw@nvidia.com>","list_archive_url":null,"date":"2026-04-13T03:07:01","subject":"\n Re: [PATCH 1/5] staging: media: tegra-video: add NULL checks for\n of_device_get_match_data()","submitter":{"id":26499,"url":"http://patchwork.ozlabs.org/api/people/26499/","name":"Mikko Perttunen","email":"mperttunen@nvidia.com"},"content":"On Monday, April 13, 2026 5:50 AM Alexandru Hossu wrote:\n> tegra_csi_probe(), tegra_vi_probe(), and tegra_vip_probe() all call\n> of_device_get_match_data() to retrieve SoC-specific data from the device\n> tree match table, but none of them check the return value for NULL before\n> eventually dereferencing it.\n> \n> In tegra_csi_probe(), the pointer is dereferenced on the very next\n> statement via csi->soc->num_clks. In tegra_vi_probe(), it is dereferenced\n> later via vi->soc->ops. In tegra_vip_probe(), vip->soc is stored and then\n> dereferenced at runtime via vip->soc->ops->vip_start_streaming(). A NULL\n> return would cause a kernel NULL pointer dereference in each case.\n> \n> Add a NULL check returning -ENODEV in all three probe functions, consistent\n> with the defensive pattern already used in similar staging drivers such as\n> drivers/staging/media/sunxi/cedrus/cedrus_hw.c.\n> \n> Signed-off-by: Alexandru Hossu \n> ---\n> drivers/staging/media/tegra-video/csi.c | 2 ++\n> drivers/staging/media/tegra-video/vi.c | 2 ++\n> drivers/staging/media/tegra-video/vip.c | 2 ++\n> 3 files changed, 6 insertions(+)\n> \n> diff --git a/drivers/staging/media/tegra-video/csi.c b/drivers/staging/media/tegra-video/csi.c\n> index 7842104ca933..33369a8c803a 100644\n> --- a/drivers/staging/media/tegra-video/csi.c\n> +++ b/drivers/staging/media/tegra-video/csi.c\n> @@ -781,6 +781,8 @@ static int tegra_csi_probe(struct platform_device *pdev)\n> \t\treturn PTR_ERR(csi->iomem);\n> \n> \tcsi->soc = of_device_get_match_data(&pdev->dev);\n> +\tif (!csi->soc)\n> +\t\treturn -ENODEV;\n> \n> \tcsi->clks = devm_kcalloc(&pdev->dev, csi->soc->num_clks,\n> \t\t\t\t sizeof(*csi->clks), GFP_KERNEL);\n> diff --git a/drivers/staging/media/tegra-video/vi.c b/drivers/staging/media/tegra-video/vi.c\n> index d1d934e361f7..f3b749f059f8 100644\n> --- a/drivers/staging/media/tegra-video/vi.c\n> +++ b/drivers/staging/media/tegra-video/vi.c\n> @@ -1907,6 +1907,8 @@ static int tegra_vi_probe(struct platform_device *pdev)\n> \t\treturn PTR_ERR(vi->iomem);\n> \n> \tvi->soc = of_device_get_match_data(&pdev->dev);\n> +\tif (!vi->soc)\n> +\t\treturn -ENODEV;\n> \n> \tvi->clk = devm_clk_get(&pdev->dev, NULL);\n> \tif (IS_ERR(vi->clk)) {\n> diff --git a/drivers/staging/media/tegra-video/vip.c b/drivers/staging/media/tegra-video/vip.c\n> index 80cd3b113125..148c68ceb605 100644\n> --- a/drivers/staging/media/tegra-video/vip.c\n> +++ b/drivers/staging/media/tegra-video/vip.c\n> @@ -236,6 +236,8 @@ static int tegra_vip_probe(struct platform_device *pdev)\n> \t\treturn -ENOMEM;\n> \n> \tvip->soc = of_device_get_match_data(&pdev->dev);\n> +\tif (!vip->soc)\n> +\t\treturn -ENODEV;\n> \n> \tvip->dev = &pdev->dev;\n> \tplatform_set_drvdata(pdev, vip);\n> -- \n> 2.53.0\n> \n> \n\nThese devices are only probed through device tree, so we know the \nreturned pointer is always non-NULL. Typically we don't check in such \ncases.\n\nThanks\nMikko","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=DXGWiN8F;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13725-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=\"DXGWiN8F\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.101.61.49","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com","smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=nvidia.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nvidia.com;"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvC5020LTz1yGC\n\tfor ; Mon, 13 Apr 2026 13:07:32 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 5CA843007357\n\tfor ; Mon, 13 Apr 2026 03:07:18 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 35A9A22D7B9;\n\tMon, 13 Apr 2026 03:07:18 +0000 (UTC)","from DM1PR04CU001.outbound.protection.outlook.com\n (mail-centralusazon11010049.outbound.protection.outlook.com [52.101.61.49])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id D261340DFAC;\n\tMon, 13 Apr 2026 03:07:16 +0000 (UTC)","from SJ2PR12MB9161.namprd12.prod.outlook.com (2603:10b6:a03:566::20)\n by DS0PR12MB8815.namprd12.prod.outlook.com (2603:10b6:8:14f::16) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9791.35; Mon, 13 Apr\n 2026 03:07:12 +0000","from SJ2PR12MB9161.namprd12.prod.outlook.com\n ([fe80::d9d1:8c49:a703:b017]) by SJ2PR12MB9161.namprd12.prod.outlook.com\n ([fe80::d9d1:8c49:a703:b017%4]) with mapi id 15.20.9769.044; Mon, 13 Apr 2026\n 03:07:11 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776049638; cv=fail;\n b=ib/Gx2UC3qNThZirNRNvPY+sVrOB4saR3YCVffFFmrgjkmaB+7eNJAMH2NhTvcMIRBR45NFolp632GbYdcdCTzlD1+ytPqQwHP6UTyc1a3H8MLnAj398mIPYG+vNRqKsSZzEzzQqPlKsSWCe/FqFLP8Xy1S4bDsWFpCFG5Np6GQ=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=ZCIYZqZ8056ZwZnqj8yaDIhbUBC57q3cnyHoVNK4vH4bvvBrfy6f5rZhIrq35+H7LsF4wObW/hRQ/FxuU8okMHBklOHbThKj+xd/ixg9H+00O6tLrI9RN1yoHb3lTvo3JJfvq2jrjkqaeKILowj8nyZj1KQp20nlCyKa5ek/djtaVYyNDqP3IlUEBP5J9Q98J6pAtHcW785TNYJQ1O2pri0PXUsjdgEXKXGMUTQQzr1WFfWBJIAtDQMZlCC0kvwB52/PuhAbjF7ieq5QJwBvLPaZDNh4d1PU3YFsyXZUFEtXCuzYlMmLvYAu6D0XYieEhai1r7xs6Wg2OYgknfzfUQ=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776049638; c=relaxed/simple;\n\tbh=xSW03ZOIoMebvJFpiHhQKzHHZiuDxivVStwWztjQKoQ=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t Content-Type:MIME-Version;\n b=Hl7lMsKbNxV04/zRpttZT6aeV2rydVX5tawifmgqpNXoPHZa+n04lLr+1e7gEdNrbhp9EJdKotxTjgX59CPLwfKJJui2S38FhMRLOVdxf/6OPJEVFvW1lcXK5VG/rBdthwy19u3ri613KfOQTl4K/el2THvp+EBNc5wOAt7/+7M=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=OCYWU5l9SKAPERPdB/e8bVdQaCHxW1eRCG1T971uBQs=;\n b=cw9S2C2a4tht/vMTopnqJiCpcKyd9vV1yTwQRGLKsFak6CQdRjohCYTXgKIqn/3T5hdvZ4KIpjYpmCbgp0pRrSLHo3ZYSJDViJOxAZ2PYHbQjtAe8SmF9wvJK5Xeh3xW+N33tOeT+l0axkkPkUfRVhMuKgfk4FWFFSZHu0wNGmQJIEenZ04pownNcK4MPVKA5Aee5oOcr/vauMiB81Y29Ey/lvrTf699cxmIJGKeQT63v4+7Gp7FEoNcpCwajOK2uDTrGOwdnuAYcrleOZwRfZmCB8MQNbjJ16BMfS4czWb90whDAND5NOmKuV0FfpxiBmwOKgIM+0HpPrB15voq9A=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com;\n spf=fail smtp.mailfrom=nvidia.com;\n dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=DXGWiN8F; arc=fail smtp.client-ip=52.101.61.49","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;\n dkim=pass header.d=nvidia.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=OCYWU5l9SKAPERPdB/e8bVdQaCHxW1eRCG1T971uBQs=;\n b=DXGWiN8FmzlYHWUlHx4E3EHI7RCu3V8zL5DdfFGAyb7riokuycp1DmZIGfge4Ca7tD0SKRJDoAUQEF+VWZWi6e0SRCmSWbm7yeKBq1jzBM1Czukkbg+TwCuFGG+PQY7fPU0fTSmVAhrUkF/MKTlNICIUlIxLbC2izrp3KOg/UT0vMVglZc9Ja3t7hRl4AqLhtUaR9ZgtChI7NWZtpa9Ct0f9yj3N9Un76fYg2TKsBGC+Fak7PyPOYH+mIyh/naM9bUp/N5A6T/n+Jo6XGt7DvR7TWpTY+KMBBQiwn9tyEzQAuq9D3Lrj828pXS4AL+pDU1FhQZbjvgngdBsbtrQV8w==","From":"Mikko Perttunen ","To":"linux-media@vger.kernel.org, linux-tegra@vger.kernel.org,\n Alexandru Hossu ","Cc":"thierry.reding@gmail.com, jonathanh@nvidia.com, skomatineni@nvidia.com,\n luca.ceresoli@bootlin.com, mchehab@kernel.org, gregkh@linuxfoundation.org,\n linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,\n Alexandru Hossu ","Subject":"\n Re: [PATCH 1/5] staging: media: tegra-video: add NULL checks for\n of_device_get_match_data()","Date":"Mon, 13 Apr 2026 12:07:01 +0900","Message-ID":"<546FSeECSqm-ORhiEUYCVw@nvidia.com>","In-Reply-To":"<20260412205057.386856-1-hossu.alexandru@gmail.com>","References":"<20260412205057.386856-1-hossu.alexandru@gmail.com>","Content-Transfer-Encoding":"quoted-printable","Content-Type":"text/plain; charset=\"utf-8\"","X-ClientProxiedBy":"TY4P301CA0006.JPNP301.PROD.OUTLOOK.COM\n (2603:1096:405:26f::10) To SJ2PR12MB9161.namprd12.prod.outlook.com\n (2603:10b6:a03:566::20)","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"SJ2PR12MB9161:EE_|DS0PR12MB8815:EE_","X-MS-Office365-Filtering-Correlation-Id":"8241dd82-bbc6-4672-4abe-08de9909c18b","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n\tBCL:0;ARA:13230040|1800799024|376014|10070799003|366016|18002099003|56012099003|22082099003;","X-Microsoft-Antispam-Message-Info":"\n\tsxrhAP+ubU9cPPlKXwG7VbmG/Qa9Cf/qMvV59lzYc43NU9Z+Yfpwd4zgdd7lUDdSjE3xBB0irhm8yqsQEt3vNI8moccWSKoeZqVmDszz84OTI2WQCToFlWbAmgsczlH4buwpPKf7fKq7KfTjRhVSZ/vmqs/X0CihYeQpfefWcPikmm+pigbHdbBX1TeERWBIBuDJNwznXxLc2ALCxg54VeJ2mJ7mMq7RlA9uE6pM4UjBrwxas5/aw/A+Ym0oE8sFHYpmUTBdGBC2k8hiI53wosxTn0U0nYRS1xlX7RTbzbC0nnJWCrdVsDwZ9l+Opw3Ds2nVtPFE0uBHJePoUGNvwvpKo4OkZHS5JaxhL4+lQTbwdUVaN6SNZeOk0uddy/wLYnCHTcEdHSZcSVlb89Ybpwso9xRh9FydMlClUkVIUP9Fr56uxrOGAokeTQSoMY3fxBnsPLe1JqOiYo6Mb/oh2ozKIZ95gt3d7IxUQFVnn5VHDQZ1viSeet1KUPEXz+ypLgabxmFQQhi2jb/vtEQRkmY+0ThvA1Mjx1e/4EKEhPAHTtIZ6aj4UUjN1/JL5v+zQGeN5UBWsgzfG8ep4zTyM/z6KhDWBjB/NaXn0bm1WVDS+yzC4h4vSyRIDT5rKuxJXyzDNHeBQUOITJHR6j0w9h+bDmJTOz2XFj5b6arkZEmPzA+I/khsQfFIfh1tiwvHUtYgzzK8ihh3KEMl0kbDy9hxqGgdJyMWP8vG+x/jMLU=","X-Forefront-Antispam-Report":"\n\tCIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR12MB9161.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(10070799003)(366016)(18002099003)(56012099003)(22082099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"2","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?by/30KO3+pmU9o2VVXKgB6wU/c2A?=\n\t=?utf-8?q?GNk2kUlT0ET7rnNUg+kmOSOKg+zthEk9nJvu/F1wtfT+YnfldgIuCPH+KtXlcFyKm?=\n\t=?utf-8?q?VojoGUXqIQH4SaQTOy6L3LeDIoilw89rsra2SIKbi0DGmfIY38b/uA2eEFAshdajA?=\n\t=?utf-8?q?rnnHnq1tNqBBwGgGzNxbbJlwFn2P1zKpcq61h9v31nT48o/FwfYg3UMBw5F7PZuFr?=\n\t=?utf-8?q?KJ4of2eZG+TatQfJV9eM18yJRu0BZkqEsFk5/1b/w4pmX6YNxPskN468EjWN4yN+/?=\n\t=?utf-8?q?G/Q/f1vw1RS3/25wcdLNNQsrXKiZYaJSmxEnQVtwqAeT4geAbzi3R0/3j/jIgzaEq?=\n\t=?utf-8?q?WGeLuYWE+efjJ4T6Be3q2bga7ZS0Av/BLIGIsKN/leqH2UGY5C9su2D3Cc+U9V2jb?=\n\t=?utf-8?q?xyRdYWolwtU+/ZiUG3bLRXYnE30o2AjrKuX8iZYExRtfySNWrsZ4mO5L950jdwPRZ?=\n\t=?utf-8?q?J2h+g9sK9PtSoRIzPainsO2dL2sMIuJSBbkkZnV9MtVtR2npCt1Y15fn9+485AaFo?=\n\t=?utf-8?q?W5e9Su8Yua1q+oEsPtJ5LyLWkaX8MY/MYiqbA124ZWptFx1tASVnwdhUihyZKjCeS?=\n\t=?utf-8?q?UuhKkhQvJscRDZw+BdOX583XIzxGnlepsCXTn2BgTDDljC6Non+oaEiT34rXcz0Sv?=\n\t=?utf-8?q?vmx6stvV6OvntAhofQGijifHJDtOozyJhJLRXdsYAzwHSFf3ql5YcnrbQuK3aNKEF?=\n\t=?utf-8?q?uJ3EyCb9Tgg5/0xqg5wS4dhnIkWhVQmZaqBl7eIdceuS9quz1ViVYhr3cWteOhl/f?=\n\t=?utf-8?q?6TXVZDolZ97lm6dov58Y724GXJnXiHgIVZNDaz6i0Ylm8WN5/SlRhRCgr5zE61E+L?=\n\t=?utf-8?q?VvNxl9zMgy7wACxqmcuX4anqDI9lFru6cGn7lDgKbJabBZ2e8kkI7W6uUto5e/2Yj?=\n\t=?utf-8?q?QgxqmXJrFJDpn9MwgKVgaVOL0DecaVBue2cBl73JwoVdj/GnxK1EzKhvZdYJoSSAt?=\n\t=?utf-8?q?R2c4UnzSZnNtVTcjHd6oYUyYI/OeKnMC3MstsN6D8QoVt1E8KCTbkH5QCzhyg2mQR?=\n\t=?utf-8?q?085gJ0xD43sIf5hxHDt/4WW9KM6RcV8Yv3glDr8SUXwVZ+KlSpPOwwaSUKzfg7+Hh?=\n\t=?utf-8?q?mj6XJUMwCTo1dno77f7N/xVpQ3gQGtUIbCOlaJcOFUJIojpKgGHkAKDomcbzJWX5o?=\n\t=?utf-8?q?MKZnquB4HUCLEBDL51R+L/i2C64fPU9G7LWZsPF2c1X402msw18XnAXmdxbpetZX0?=\n\t=?utf-8?q?sGBiyeSIhaPHaGXVGndJZl+eL4VVIPVoFDjtUA22l63nyQE7k50OP0+wnRkyk0k2i?=\n\t=?utf-8?q?i6dQiX2BA2eKTBOwuHopR3PAInQdSMzFHYA9zbMINPOM+UM9SVBxejG2rnYalq9bb?=\n\t=?utf-8?q?xarBM8I+xzANz0ZgTUJZaZZIV/Bjh+7zy1Uv31MmXB9XYqhoJmCEhaCyLJ/Opnley?=\n\t=?utf-8?q?V0hV6c3qTRTMu97jc9beCkJKloVNXrBMZ1KjLsjRLDv3KSpxL5qTwwJNEmAUb3xyg?=\n\t=?utf-8?q?fLNVltyRnDOLbZwqLQabfMV8cKuE6F8Mb8S2x4QRENIf7Sgr1AEPoU6jbCneFcrtC?=\n\t=?utf-8?q?597DIU/lDlLpdS6XN1yLqdG+aHnrfbElzuFczmIHcJJXvs8D6ewbDyf2Ya+/DWV/j?=\n\t=?utf-8?q?OqghATOkTVdS4qPus0/iAYrZka9qw7RUnipkzKtmbuDCIGxqq20ELauyCT0R3t/JM?=\n\t=?utf-8?q?6Y8+ORjkVnhHvul2DGaj/Z/f2AcjaHOuNRAWRnbIppWBsxZx+M0RfVqv6y9SP+THa?=\n\t=?utf-8?q?fVFxLZYxE0jl5YGh4?=","X-MS-Exchange-AntiSpam-MessageData-1":"J3tAn6sLBJVKRw==","X-OriginatorOrg":"Nvidia.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 8241dd82-bbc6-4672-4abe-08de9909c18b","X-MS-Exchange-CrossTenant-AuthSource":"SJ2PR12MB9161.namprd12.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"13 Apr 2026 03:07:11.7036\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"43083d15-7273-40c1-b7db-39efd9ccc17a","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n JRhEfFGiZsWsofz6bk7Ug1nU8rnUsYSamvBw+Gtg1V7E3QS2e+7DyHQ4FZcOtiM+nvaSjGDhdZ38d9AeWnsfMA==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DS0PR12MB8815"}},{"id":3676456,"web_url":"http://patchwork.ozlabs.org/comment/3676456/","msgid":"<69dc7d6b.a70a0220.2403d.c1ad@mx.google.com>","list_archive_url":null,"date":"2026-04-13T05:21:47","subject":"Re: [PATCH 1/5] staging: media: tegra-video: add NULL checks for\n of_device_get_match_data()","submitter":{"id":92777,"url":"http://patchwork.ozlabs.org/api/people/92777/","name":"Alexandru Hossu","email":"hossu.alexandru@gmail.com"},"content":"On Mon, Apr 13, 2026 at 05:07 AM, Mikko Perttunen wrote:\n> These devices are only probed through device tree, so we know the\n> returned pointer is always non-NULL. Typically we don't check in such\n> cases.\n\nThanks for the explanation, will drop this patch.\n\nAlexandru","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=Vzf3yRKl;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13726-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"Vzf3yRKl\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.218.53","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvG4323zVz1xtJ\n\tfor ; Mon, 13 Apr 2026 15:21:55 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 9D99F3005756\n\tfor ; Mon, 13 Apr 2026 05:21:52 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 793FF37C924;\n\tMon, 13 Apr 2026 05:21:52 +0000 (UTC)","from mail-ej1-f53.google.com (mail-ej1-f53.google.com\n [209.85.218.53])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 1885C226863\n\tfor ; Mon, 13 Apr 2026 05:21:50 +0000 (UTC)","by mail-ej1-f53.google.com with SMTP id\n a640c23a62f3a-b97f9587e6eso524407166b.3\n for ;\n Sun, 12 Apr 2026 22:21:50 -0700 (PDT)","from ahossu.localdomain ([88.202.160.248])\n by smtp.gmail.com with ESMTPSA id\n 4fb4d7f45d1cf-671505caa61sm629377a12.14.2026.04.12.22.21.46\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 12 Apr 2026 22:21:47 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776057712; cv=none;\n b=jcTa3YNUN20aHRiwj5oErxFxEqWLvfpBs9rRThpIiXS+LoFPpDnf7k/mtSCccNeYVGE9cboSK/yfoxN4ZA8lV2pS+wO8Oit7Q4BmMF+rS68JqfDn8kOQepeseHgV5j0tZJ7rRXDsxV26qVYSFJwBC1uPrSvkthcsx886nL8y8LI=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776057712; c=relaxed/simple;\n\tbh=FbcdWUz+LzlC5UIGJNd7kkF95ZZIl4IOCm0ByFtZut8=;\n\th=Message-ID:Date:Content-Type:MIME-Version:From:To:Cc:Subject:\n\t In-Reply-To:References;\n b=F7BR3iAzouxsKRKvNy2s+sFa+melYtwxmQfvxkneDE/u/RtF0OYAQE7txZDbQC0OYGANRm7VzYqDoonBZwSu2YxhdCaz3y8x9+VlYSukESy7d+hJzUq8v5+zq4idAk0FkNlYMXppGNag0QRhMJcFByY0oVTu8xvRgKAcOkep/oA=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=Vzf3yRKl; arc=none smtp.client-ip=209.85.218.53","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776057709; x=1776662509;\n darn=vger.kernel.org;\n h=references:in-reply-to:subject:cc:to:from:content-transfer-encoding\n :mime-version:date:message-id:from:to:cc:subject:date:message-id\n :reply-to;\n bh=FbcdWUz+LzlC5UIGJNd7kkF95ZZIl4IOCm0ByFtZut8=;\n b=Vzf3yRKl1dNH2SWpkE4OxEpXLzCNo3Gs+xohtuS0xBNFb2344mFHKG4rSdrHOVFFfu\n CoQnsw6CGroWOh12xaOfmf3y5NXEIAZuIsiGQ5N7ckJf3E2MRxygQF/VOjcdcpjlJGcs\n MxQT3NsFkL9ZBKEvRrKky563KOJ2K7FGydWX69RVKmaIjt+5y82kfyLHy+pQs5aFZLmp\n zDaxGbXW2iIq3G3fIBE36/FBJ86enmNPcLunFJ80I04lerh97E+rdGH3otuUxoyJXrEi\n /i5zO+aoaVJlgBZ5fJsPeWTt73A1BIaalrZXsMbvFgFZUjL/sOY2N1sAcpW87kIbbcF5\n wNaQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776057709; x=1776662509;\n h=references:in-reply-to:subject:cc:to:from:content-transfer-encoding\n :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=FbcdWUz+LzlC5UIGJNd7kkF95ZZIl4IOCm0ByFtZut8=;\n b=CEF4IWa+eij4+SbiqqwEtUn7sC2ht/i4FTF/k0k0aFIbXrGi+QtfQe/lq++b9A1AxQ\n HVe5VyEJdqHsUHS4kTurYNGgQZOOkPSSAGJBNFn+XByn7biHfhm+p/gV8Q6R1jFWq4AQ\n D+8HXRoqTtRmhQavzDUYgBL+zeoIvAFPs6VP8B55tNLkjWl1WLwersW2i+W4OHYid96o\n XXkzAyIEZ48l3jCHJaRxPRgM7slnCW07nEK6612LkyXE3JuqyBjq0fBzst72bhhSEVA0\n /pFstrrLLicHXsN03PUNhmX2jg2BG2Nb1BCBQJW2I0Xk7/deFDYwjbhluwqeC1yMvko6\n Z6ww==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+PulsUs6KhfR06lm3ycPugdsgP3M/cISjmH/pTrtfdKU7DCrcAK7jGIBvSsjhOCuzFqSBfOyk18+uuHA==@vger.kernel.org","X-Gm-Message-State":"AOJu0YyclBsv1ukEpGJUXvbVVTewy8xxUnw0eliDy+zpvJSnRZavzMKI\n\tzEuohO+J6lWIKWzBvG7q3pMG1tweCs/UkmohthmB1naYHKxsnbqA4Jg2","X-Gm-Gg":"AeBDieugeKoo+Z6bspzFDhb3vnJqAhyEVxayuYd6uiKCipCPgFdaY+YU7TDL5dNACIY\n\tQbPHo8+VoKQrboMRSyJ+kh4G50t0o04ymJzarav1aHyk0RWHdPJWpOSxblvuA3m9vmxvRw0HdDV\n\toKrIT3VTA+jw6gJ0qd0DG3bMXBwBMVOXDuoKok6fPVIUtKD82yHf0UDHcrkxg4RG8Eg3gEMHpZq\n\tjMShq6YASjQbnJQG9q8FOqs2XdyOlHnjwCh4ixi/IumgrQflw2qEIjc+NLTyxEp14q1QrM4AXIT\n\tsK7N/Dzcnv2mq8yL6jAQOu7xxNhivch1Cl9PbtH58Yl7tqtx+kAwBUKMI1G5kHIH2FyR5kmVLB/\n\t6tSybrRYn/oD/c9uqyORXw9zxMNCq5mt8pB7Zm5+xShaaFT2knv+kANiK/owUET4YjOIVrpZiI8\n\tXSLsv5Hf7RT3wT7dxtT2Smv25YjWsdxpuURzF21of6BybtV/geGCe04YCBAnrNh9tMsyegFBH+y\n\t6+SB++7/W+uCRalWeprK5SoGEvqYrDvnutvVsnoh6Dz3GVlZxP0ztlEzLL4IQ==","X-Received":"by 2002:a17:907:7251:b0:b9d:eeb9:b992 with SMTP id\n a640c23a62f3a-b9deeb9b9eemr68012066b.23.1776057709077;\n Sun, 12 Apr 2026 22:21:49 -0700 (PDT)","Message-ID":"<69dc7d6b.a70a0220.2403d.c1ad@mx.google.com>","Date":"Sun, 12 Apr 2026 22:21:47 -0700 (PDT)","Content-Type":"text/plain; charset=\"us-ascii\"","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"7bit","From":"Alexandru Hossu ","To":"Mikko Perttunen ","Cc":"linux-media@vger.kernel.org, linux-tegra@vger.kernel.org,\n thierry.reding@gmail.com, jonathanh@nvidia.com, skomatineni@nvidia.com,\n luca.ceresoli@bootlin.com, mchehab@kernel.org, gregkh@linuxfoundation.org,\n linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH 1/5] staging: media: tegra-video: add NULL checks for\n of_device_get_match_data()","In-Reply-To":"<20260412205057.386856-1-hossu.alexandru@gmail.com>","References":"<20260412205057.386856-1-hossu.alexandru@gmail.com>"}}]