[{"id":3676815,"web_url":"http://patchwork.ozlabs.org/comment/3676815/","msgid":"","list_archive_url":null,"date":"2026-04-13T14:57:27","subject":"Re: [PATCH 8/8] drivers/core: use memdup() instead of\n malloc()+memcpy()","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 2026-04-12T19:59:41, Rasmus Villemoes wrote:\n> drivers/core: use memdup() instead of malloc()+memcpy()\n>\n> Use memdup() instead of open-coding it.\n>\n> In the dm_setup_inst() case, there was never any reason to use\n> calloc(), as the whole allocation is definitely initialized via the\n> immediately following memcpy().\n>\n> Signed-off-by: Rasmus Villemoes \n>\n> drivers/core/acpi.c | 3 +--\n> drivers/core/ofnode.c | 3 +--\n> drivers/core/root.c | 3 +--\n> 3 files changed, 3 insertions(+), 6 deletions(-)\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=b/aLgcYw;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"b/aLgcYw\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvVt26T5gz1xtJ\n\tfor ; Tue, 14 Apr 2026 00:59:06 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 612AC841D7;\n\tMon, 13 Apr 2026 16:58:59 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id A8829841D7; Mon, 13 Apr 2026 16:58:57 +0200 (CEST)","from mail-ej1-x629.google.com (mail-ej1-x629.google.com\n [IPv6:2a00:1450:4864:20::629])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 1000084258\n for ; Mon, 13 Apr 2026 16:58:55 +0200 (CEST)","by mail-ej1-x629.google.com with SMTP id\n a640c23a62f3a-b9c3e2cf3c0so704360766b.1\n for ; Mon, 13 Apr 2026 07:58:55 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776092334; cv=none;\n d=google.com; s=arc-20240605;\n b=AUoIdksTugwIDlEkaNF6lcSLnyhTCWc+GsGboTWkiHygkEZdFekxYIGsZxdiGi5GHG\n T4nH7Ie7PsF2VvrxSSp5G53kaf51aTbnOT6WyiV1CJKiXl0XC8cmC2Eyx997JbsX3vtR\n zNkQQpLUdxNQzrFmmDOhB9gj0C11pHwmS8UJgIZWsCut/g3DwPZgBAd1+jwoKMtMYEhN\n qr8s6NRh8JgOboSA1gyLLcj8/m8hXLo7xuLLFn+knRYx3hb6H3qSYCB2eDlDyFhV4aWe\n iO8o3QDCzwkuiIIez2gaK4e5+AwH9ec23Bn3YkIyhC+J8S54J83/9C5/EDQTSHD+zGpY\n I4mw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=aesQnOoWTHlvvfhmig+pf1Sri4gfxsrEPFOLhM6/NXg=;\n fh=dF+eCHOIT6SIbAzI5tBwPFZclvSQgQQ7Zo1JXO6SSnQ=;\n b=KetoSHx0ejcft9j6cv09cWZc6Vi4FvR0kKg1j3oY6xts3liQ3eQFdHQix7FKRyKTWt\n lQRI4K/oyLQx0TRAeEMA54G9wwyWwThWliO2gIPBtGPaCeeVE0yCeNc5WwSNEnBsQXTk\n NWu95kRz9G73Eie1nw407XeXrapNazPCvd0E5HOggH+5Z2fUcD2qlUR8OLJHpjvNBUie\n MYoIBvZbHuP5Re/vymbhku7U7kdxb6mUyseldKAuMYIKrkVYAr9fGNUHJqCjrKl6tnJh\n TNM1RcYYhDvj5QtHzanGtRhfneMhq1FazZe7xDHK8FRjENbxG0KrfVu+cwO5+CDpo43F\n bwCg==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776092334; x=1776697134; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=aesQnOoWTHlvvfhmig+pf1Sri4gfxsrEPFOLhM6/NXg=;\n b=b/aLgcYwgZX5jvXWFLVuQh4QpYpNBvZXjHJNTE8wNUpt6jTbQEd+R3jsu/qAthq2Qg\n NbfQESdwBR1rI91EEqy1r5JCLoJhSkfxpdVw1RLvGoCTTgH5Ko+rGpNIAgEsX0I5Nrk6\n vnQOd0hNmHJfY31RsmDlZtwAy/rmCzA21tpCw=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776092334; x=1776697134;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=aesQnOoWTHlvvfhmig+pf1Sri4gfxsrEPFOLhM6/NXg=;\n b=VXvl7r1Lb3i4T7THXvU1mw/93Q2t/AsAFwLDUh0i6nn65jRHXvYO8msX6bXGyIoUEG\n AebQHYDD8iNYrDnnM5RDO/4Ol+pQhISNXGHQGl7sCEmZKUJ9j4F7QCmtyBT+ztqevtqc\n XO7v+gQN+HVh8uCYyZhLjsOjAJCdPpbCgTQddNwpbiEO6Tfq77AocjH/2jXW4hxBJQ7S\n +nZ0J9w0ALdNOFXbIbILTL/KbRmM68ge5g/IaMOClaTfy97OkKiR+6uH3UaOF8T4iIcC\n WBXThW9XalGpfpZyodH8UDbiRehmK3qyp9U1mdXpiDOQH94GPexrTsQJKFvZP4rUnZj3\n zOYQ==","X-Gm-Message-State":"AOJu0YwMLZrpSj8LYWxEojERCsym/MC2d57GmZfeN5NWmxLTp+2JEyBc\n uEFJzyEmOu3ScGFLi66nC8OmRPA6S87+No1p7xfcpSFx4tBMDFDvfq0g1yx33I5/8BL1pEI9FDZ\n NY9Oly2q3Qj2IKB8NsfhyrkBqACgegKv71lDhtP5M","X-Gm-Gg":"AeBDieuw29IYjv5wkaOawtHz5CBR7WFhDeHNLdqpB5qKamtoNsN1DCmVV5rXczd9H6H\n QPcHrLufOVzNHpP4/hKzUMmNjBANILryKNEjZVUw41Ne/xAuolV0vTBjmvOQ98d8UUFpkuvE8w2\n GAdocc+lCfqixP0qFPZ4NM3ZyWryVV3yD4iVpC6rD5kiI0pBF3MNrGOuyGn0aV5bN8BbxGBhKMy\n 0hjqjWE8ZH53Q0pHYPpCBXYimlqAp2U1DQ8kkEQVc7spxESu46BcJDHJEp3fQyVP75zvWNXUsrO\n wGzOYA==","X-Received":"by 2002:a17:907:c908:b0:b9d:3b68:954c with SMTP id\n a640c23a62f3a-b9d727aa0cbmr570914366b.24.1776092334465; Mon, 13 Apr 2026\n 07:58:54 -0700 (PDT)","MIME-Version":"1.0","References":"<20260412195947.1982729-1-ravi@prevas.dk>\n <20260412195947.1982729-9-ravi@prevas.dk>","In-Reply-To":"<20260412195947.1982729-9-ravi@prevas.dk>","From":"Simon Glass ","Date":"Mon, 13 Apr 2026 08:57:27 -0600","X-Gm-Features":"AQROBzDtMCWSzIEWthkcgDyoePUzgmy7gkheukuEAWWBbagVtyru4z2pPLuF-Ec","Message-ID":"\n ","Subject":"Re: [PATCH 8/8] drivers/core: use memdup() instead of\n malloc()+memcpy()","To":"ravi@prevas.dk","Cc":"u-boot@lists.denx.de, Tom Rini ,\n Simon Glass ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]