[{"id":3676813,"web_url":"http://patchwork.ozlabs.org/comment/3676813/","msgid":"","list_archive_url":null,"date":"2026-04-13T14:57:24","subject":"Re: [PATCH 6/8] lib/hashtable.c: use memdup_nul() in himport_r","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 2026-04-12T19:59:41, Rasmus Villemoes wrote:\n> lib/hashtable.c: use memdup_nul() in himport_r\n>\n> We have memdup_nul() for exactly this pattern of duplicating a block\n> of memory and ensuring there's a nul byte after the copy.\n>\n> Signed-off-by: Rasmus Villemoes \n>\n> lib/hashtable.c | 7 +++----\n> 1 file changed, 3 insertions(+), 4 deletions(-)\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=X6BsY4XU;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"X6BsY4XU\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvVsj40lGz1xtJ\n\tfor ; Tue, 14 Apr 2026 00:58:49 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id E356C84198;\n\tMon, 13 Apr 2026 16:58:45 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id A283284242; Mon, 13 Apr 2026 16:58:44 +0200 (CEST)","from mail-ej1-x630.google.com (mail-ej1-x630.google.com\n [IPv6:2a00:1450:4864:20::630])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id C202883DC9\n for ; Mon, 13 Apr 2026 16:58:42 +0200 (CEST)","by mail-ej1-x630.google.com with SMTP id\n a640c23a62f3a-b9c603ec2dfso592288366b.1\n for ; Mon, 13 Apr 2026 07:58:42 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776092322; cv=none;\n d=google.com; s=arc-20240605;\n b=UcCOrXo7rjHGRjO743D7mV6vi0JJNYK4nx1IFZCv8rKrRyeSSvIO5rW3AwSyEn0Fin\n /c+yf+mZuh2XSSgnRYQKqUEWDf4KPeFT8Veo0dbiu1QxzP/Xeilw8qxzr4pD5l3s7hRf\n S6uKxwWzeOYQqiJxMWD4Fum3E9aTPAB14zCjGV+C+V3bT6CS1VtS8M3eKCm6o0BSGEWt\n /bS8f1hVqwu7dcsWvXc7iShnxnJ6wDGt79nZhRB0ojKuZN1LthWGQOwBzB9uL1oAHQD4\n zeHMFLaS60yjh9XAJ+HXWZJzixi2os8tsKBPpSEvXoDQYNwnM9CGoUAxEoo5DrAFeLAY\n ESpg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=wLjIA4fpYAenbwDKeIjEZgnHEad0fFNSN6lNdrWuTe0=;\n fh=dF+eCHOIT6SIbAzI5tBwPFZclvSQgQQ7Zo1JXO6SSnQ=;\n b=VBeRX9GKhiA0P6MUj/IyC/6yzesvJGLyeF8QzWpwJhLEYSS42YVcysDYxyOY6nNf6Y\n zfepTe/ch9Ouxuzyb91VwaYoCdeGmjVA2SyO1lUCNZPnQlE4L+DCSrLz9zFTU1Z2zjX5\n 4HJehnsnuxie1aRaKUuZqjJNWvQd8uofJPhSTaPaCSUzwLcv62VLp2T3IoYhMiBH+q2m\n QkcbsBmgA/KfHZXsRaX7O4rdhWi5xzP7Vx+opxnVsIlyanhzAmv5bs8obEc+8T+ZpM2u\n sCvbyc359UClUEW/9LIXZO75hsYODVzZBO7M1MWEbyUMtMTjgTrs0/Ct1jYxmh5gdqcp\n AaYA==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776092322; x=1776697122; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=wLjIA4fpYAenbwDKeIjEZgnHEad0fFNSN6lNdrWuTe0=;\n b=X6BsY4XUHpjrYJkpLBMHYuRFwIvciQ/SNE7Xy2M6EKKZ2GEp+gog9hECUnanV8BPYl\n juiVgE/09vj20nAy7lXBIHWxWyNDK9V1SC7hLdXzrcrzm0e+K47+9Q05XvdTNc3ct1sP\n NKLqtvaGbiEyyOJRff0tVvjRplQ+7lQIICE8k=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776092322; x=1776697122;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=wLjIA4fpYAenbwDKeIjEZgnHEad0fFNSN6lNdrWuTe0=;\n b=pgm+qyRfOctRz9JoOYQyfRpXUcYWiB7ZL2UpMZDLPOFsllsfORuPiNI7PB7AVeNdTc\n l0QA4AKyTSPplzeqX4WJOlSjJC1pr97xVL2afFutCx+3E1mnG0qyEioaGVX0miTwb7FC\n THgHq2CeEpIrYu00cuF2PehrQa/vOLsEA52iCDRbJs2dIJ38z81unpQHB7LphL1Sqrkr\n 9aC+55tRC0X7wKeTBMJKzNPraaX4JVTjJ/NLVay8458YJqsfHR5PN3j8yCFmW50p726N\n Fb1276RrL1tP15YEHbvnVsDBGDn2zbCGy9THqJJEcIQl+FAh4c1iK2gOj6d9EInroKxp\n njag==","X-Gm-Message-State":"AOJu0YwLpI1tOpz0dG1Hnq9P5iTjfUXAofhz/Th8rPVcainAH6p9XOvW\n omqkJTAD1Lb/h/7KEgv641m+Kmr0ckKDmkmxdiq1FJCy9lv8EEzwKRkKBWEHTBCnJ/0JQ1UyJ94\n mMKksk1nmMVcKVnJZT5p8rlQS7ojMe3vCaJZ28Bql","X-Gm-Gg":"AeBDievZC+OD0315HbGoS4vGAvanzFrqvtAyQzdw0pdAEEq8HFwYxcv5OERsP3V15Lq\n qMUH/s/oyYzJKunfi/Vu7rFAlz1qSn0e81NX6P6GobOWOBKZFTMfeH0Ct3K0yqWnpzQQIL8lmxx\n nnRky5MsDSG5+tW7cHf42Qz8towEW4iGbvbaoIi+t3nz1Ktu48D2qvP5qjMTy+C2AjrkPX/QXPt\n YuDWaFP7Xbj/KVs/JpmANSUwwT916v5HwQh75K05aNdVtz5cP7x37TazQuwC+QJytENfOp5CxKM\n NdqJ9Q==","X-Received":"by 2002:a17:907:e981:b0:b97:1d24:bfed with SMTP id\n a640c23a62f3a-b9d72991f8dmr775694566b.41.1776092322249; Mon, 13 Apr 2026\n 07:58:42 -0700 (PDT)","MIME-Version":"1.0","References":"<20260412195947.1982729-1-ravi@prevas.dk>\n <20260412195947.1982729-7-ravi@prevas.dk>","In-Reply-To":"<20260412195947.1982729-7-ravi@prevas.dk>","From":"Simon Glass ","Date":"Mon, 13 Apr 2026 08:57:24 -0600","X-Gm-Features":"AQROBzAK0RNMoV9t97aU-Wcz25-WMTp9X9HpDGc1Gw2P-hHxK6Z01Jlh-FljIGg","Message-ID":"\n ","Subject":"Re: [PATCH 6/8] lib/hashtable.c: use memdup_nul() in himport_r","To":"ravi@prevas.dk","Cc":"u-boot@lists.denx.de, Tom Rini ,\n Simon Glass ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]