[{"id":3676812,"web_url":"http://patchwork.ozlabs.org/comment/3676812/","msgid":"","list_archive_url":null,"date":"2026-04-13T14:57:15","subject":"Re: [PATCH 4/8] lib/string.c: introduce memdup_nul() helper","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 2026-04-12T19:59:41, Rasmus Villemoes wrote:\n> lib/string.c: introduce memdup_nul() helper\n>\n> This is completely analogous to the linux kernel's kmemdup_nul()\n> helper, apart from the lack of the gfp_t argument: Allocate a buffer\n> of size {len}+1, copy {len} bytes from the given buffer, and add a\n> final nul byte.\n>\n> This pattern exists in a number of places, so this helper can reduce\n> some boilerplate code.\n>\n> Signed-off-by: Rasmus Villemoes \n>\n> include/linux/string.h | 13 +++++++++++++\n> lib/string.c | 15 +++++++++++++++\n> 2 files changed, 28 insertions(+)\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=FJoNSTj9;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"FJoNSTj9\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvVsY5SFVz1xtJ\n\tfor ; Tue, 14 Apr 2026 00:58:41 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id A6350841C2;\n\tMon, 13 Apr 2026 16:58:34 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id C8DE684227; Mon, 13 Apr 2026 16:58:33 +0200 (CEST)","from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com\n [IPv6:2a00:1450:4864:20::62e])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id DDA8B83DC9\n for ; Mon, 13 Apr 2026 16:58:31 +0200 (CEST)","by mail-ej1-x62e.google.com with SMTP id\n a640c23a62f3a-b9e00649769so73198766b.3\n for ; Mon, 13 Apr 2026 07:58:31 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776092311; cv=none;\n d=google.com; s=arc-20240605;\n b=bWCdU/5/aggzlBMZUXZBKl+nb7FX4hI9FWu8aIIC9+HMI1oeEHpH12Da/pcPK/aDo6\n MevKz+h+XIR2WsN1H4IXMR0P88ZOdmyT8UOQfnQh8O2Tm0GszHMpkYWKQu3kA/PM1mgB\n 6tEpG/WseY9KcVT67VQ6Ntn+LQlZABKeZXX9F3Gs7GhLAVE9+BL7lxXU0OKwcrGCYGrl\n PuIR/EyA/8U05vJU7bOcrnZwv+Vse5/gPHTY0v6vGFpRE0V9TPsjlrG9RyMXXnurAZGh\n bI5O/qk/xEpPVRmZk2D8yXv5AGbsp5vqi2CL5Jq1LIPnbeptWUXRCFW8x80YTdP5Cmlh\n +iSg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=Xudkgl9s/oECjWJll9DS9vDCWUIVBz67i6pjE9OdJ9M=;\n fh=dF+eCHOIT6SIbAzI5tBwPFZclvSQgQQ7Zo1JXO6SSnQ=;\n b=ffXjipKlRGOZGryWRn4A7ozobA77NOdPgrSzYBXzWTZ9oPfmDVbWr9ShuLIwCXYUyY\n aIFp7ocZpf0s/D6fDALL6exn9I/zd0wuWeyrMIR753bnUJ8e8+E55FitjcO8B+VgcMFN\n qzwr+uJMCzG350hG6Ws5sesW4eeJlhwfb6bUrg5me4yRN8cIbauivkVfpgdeprxdx7qy\n 2QHq88vqRv6jr61jFJouSuclaFE4yPVGVmzHwuUj3Lp9HOS7T+HFVsxOgheAhMGUcEMU\n g1uysISnBOhkSt5M+P4vl2vGwx2bhKtabcrfpM4V3REcP8usxYkDr8OrZcM1Cmv4Bu2H\n Ko3w==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776092311; x=1776697111; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=Xudkgl9s/oECjWJll9DS9vDCWUIVBz67i6pjE9OdJ9M=;\n b=FJoNSTj9xOm+rE5RusZ65AF6Lj/w6X6lQtK58zfDMQqPKaBA5JkMT0noaOZEUXA1wj\n nJYASFpLt+41o48qpXz9UBCCOwx2EYryqT7WdgGhHB0VIX+8XBTGqSqqmCSCY0hlC10A\n vY+EZYT42et14xIg5Yw7ETr8VXoYYFxGhIDh8=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776092311; x=1776697111;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Xudkgl9s/oECjWJll9DS9vDCWUIVBz67i6pjE9OdJ9M=;\n b=lkuajO9HTvIu2BVFVEC4EF+9T6AVEg4HTmHPymtl6VK8jrHTvItDOFQSzUnx8kRoO9\n UCIzvU1ZSPnQSq2B4Gvr3dYjLDk4D1VQghlCaKYq9JaDnBN8thNgfxjieAcc+P2MiVPM\n nwW8IgSTYi2gyF8cwKuPu+Y0rLeFCr2KBwqfP0pRpuMnkCQJFD/HCngxv6K+pdzIA2FO\n 7OVqpAcydbzf5HUCngz+rdBYHLw2oWVKE59cgCxoZrC1jl/j5zHOWndkOdTBkhGFNqw9\n ilOSTH9h5+ehvY9FCF2k5FE/J8zplXgDwluX29QdhNI56QZFZx8QBFF2ktdSvOgiPcLo\n 1R4A==","X-Gm-Message-State":"AOJu0YzdcV2cpKNUenSqLF0pl1/YuDCbp5l0wbNp6vDGz//2VJh/s9Wy\n LwT+HFoEy0mEaQi0qaM8qNzw2Yo0V5ZeeFklOgxRXH+MJU3m7hXcOnKjTR272FKoCv4eEWzbu97\n G6jhSaca7GTNmlt7cpt+OtAO8nfomJfDhs9MBFvF6","X-Gm-Gg":"AeBDies9CDK5OVaiwR5YHBPw1xzCs6K2CZSgM4wr8R9IsMGqsiol7ffBx82dDejD//H\n g/gz8kK8uvloOjT7Kqvm/hsd5VQgMvqMQ9KmFy/1IOVbXX/1pBTmHcYLMPqXBtlKW4WiyzDv5Al\n BMmRY3RDsJq3QFCKC6b/lcmoUTCKxiVTjtr6gbHTzMjE4JGfjtB3YaaatV4+IpMtaEOYQGdMPLH\n teWXQVoYXrW2vMzjBB6xvgOsBxKjIgkzyvXxrjV3ylQnFimooqj8K946A0QA6403MeGE+KASPtd\n xgJwXg==","X-Received":"by 2002:a17:907:e106:b0:b98:595c:a76f with SMTP id\n a640c23a62f3a-b9d7279304cmr481666866b.16.1776092311194; Mon, 13 Apr 2026\n 07:58:31 -0700 (PDT)","MIME-Version":"1.0","References":"<20260412195947.1982729-1-ravi@prevas.dk>\n <20260412195947.1982729-5-ravi@prevas.dk>","In-Reply-To":"<20260412195947.1982729-5-ravi@prevas.dk>","From":"Simon Glass ","Date":"Mon, 13 Apr 2026 08:57:15 -0600","X-Gm-Features":"AQROBzANCGKSlz5V9Ao3YdNmX_5Z6-xn8vUezppu7HOmN5cTOyydKsJBT4x6Seg","Message-ID":"\n ","Subject":"Re: [PATCH 4/8] lib/string.c: introduce memdup_nul() helper","To":"ravi@prevas.dk","Cc":"u-boot@lists.denx.de, Tom Rini ,\n Simon Glass ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]