[{"id":3676807,"web_url":"http://patchwork.ozlabs.org/comment/3676807/","msgid":"","list_archive_url":null,"date":"2026-04-13T14:56:51","subject":"Re: [PATCH 1/8] string: fix prototype of memdup()","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 2026-04-12T19:59:41, Rasmus Villemoes wrote:\n> string: fix prototype of memdup()\n>\n> It doesn't make sense to restrict memdup() to only return char*\n> pointers, especially when it is already defined to accept void*. This\n> makes it uglier to use to e.g. duplicate a struct.\n>\n> Make it return void*, just as kmemdup() does in the kernel (and which\n> our kmemdup() in fact also does).\n>\n> While in here, make a small optimization: memcpy() is defined to\n> return the destination register, so we write this in a way that the\n> compiler may do a tail call.\n>\n> Signed-off-by: Rasmus Villemoes \n>\n> include/linux/string.h | 2 +-\n> lib/string.c | 8 +++-----\n> 2 files changed, 4 insertions(+), 6 deletions(-)\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=OyWbv9Xu;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"OyWbv9Xu\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvVr50DT3z1xtJ\n\tfor ; Tue, 14 Apr 2026 00:57:24 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id B13DE83DC9;\n\tMon, 13 Apr 2026 16:57:16 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 489798407D; Mon, 13 Apr 2026 16:57:14 +0200 (CEST)","from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com\n [IPv6:2607:f8b0:4864:20::42f])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 210E4839D5\n for ; Mon, 13 Apr 2026 16:57:12 +0200 (CEST)","by mail-pf1-x42f.google.com with SMTP id\n d2e1a72fcca58-82f351ca23cso570288b3a.2\n for ; Mon, 13 Apr 2026 07:57:12 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776092230; cv=none;\n d=google.com; s=arc-20240605;\n b=BWCe3GLTC06Bj4/LlCmZZYxRge2zvvkYatHcv/7ZooaHEqY0GVxDMbEY+UxOrtYAfN\n Oc42tzoEcaCv5jDVeSDofQprbjjBCgd6CI2zz7TDK2LNedsJ7ibYLm49ak/xEDCZIKjz\n fSZLv6MYXIG2Oas9CTqbMXJOuUmNQ1PBA7tkXJdjgr/zEEywMrbRZ96j4lvTclGHdWiv\n FGP9bDANW2DABJs659Em0q9nfJ8ixjvir8dpcnSmeC9dUXvRC6YuaQMKpQEGLj4we9i0\n QDU6DvYUXzfymZfPpaXfVpAbiEoD3R0OOZR9Ht3psKym4eRvV/NKwNPUwT/WfFGnuiKA\n fqBQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=V7+YvyKXGIOFikLuuMc+s6VBGn0tbW96ODkEQ8ar0aY=;\n fh=dF+eCHOIT6SIbAzI5tBwPFZclvSQgQQ7Zo1JXO6SSnQ=;\n b=OENuvEYmYsVPifBKqZPiU9/R93JV22uw696IQc0dgJty2srUNegnY+hSX6U9C3QvPp\n XxsnYLzOEbGo8BjrdZ1rbRGu7cM6Zc2BlVR7S9Z9unS3n96EKYxkuZiIIcTQxtEHKkjT\n HjZ1UNk9SKaYX/4xbOvOg6jqlUibVFXz6omx4aG37/ly7vF1yIfQAzMub9gHIkJ0qEPS\n N08PvUZfOoUSxPFctNYYeoUr3qyVOL0Drkfs87SDyLC7qJ/6XK8tAatdS5r+QoKZkqGl\n 1jMo2CObuMsnsPUfuPsnt0RAsSr2zRQ6sHJnYDMo6su4BehAFFeia+0QESrZbwxYU8bL\n /KOQ==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776092230; x=1776697030; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=V7+YvyKXGIOFikLuuMc+s6VBGn0tbW96ODkEQ8ar0aY=;\n b=OyWbv9XupDjTym+LILpVni5FsSqkq6q66mH3pp0Aj9/m1XIj3076jFlrycpCxSJXdN\n eYgbmXsVuz//xxYOybnvaKBV2t2LV3pbvE+nF9d3LBXFEYrryHhuXNVbN5AOe7eBKxPQ\n kUz94RTpv5Pv2kQqWjc7yvVkSwmxuC/vyVZag=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776092230; x=1776697030;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=V7+YvyKXGIOFikLuuMc+s6VBGn0tbW96ODkEQ8ar0aY=;\n b=FvI2tw03Vea9otR0HGlBag+EETOlluI5RQyQaMBw9a//UD03ttCTw1Ax6WbVl+wgPP\n Ecj1Lyytm/6/cWTAF93oUaKBCCDhgzvZ15aF9V62c21+PZxut8fGk6yuq+aD5B2urkBk\n 6b/AWsqy2sGNcZAC/TlDF0jomiFMlnLp+tUXWY1XmQx0oyWGFJSw0+w5YQMhlcAH238k\n HnnPrky7Aa5JIcxXZbNqGWbZCv0Sobugq8IKrK8Jdv40wzLq2ZtYLGlcmyfP9w9idF4p\n VM919QHM7PsitJhurMOFYBG7jkjy4rV84p1B4Xvf9GphH5eD/Xujt9CjTIvU08NNTChH\n tFnw==","X-Gm-Message-State":"AOJu0YxWwFfAf6KkQm81q2SoXOEVC8l/g9SkO8CtTywOuCLneUg3ARxI\n N+IQ1YmkB5h5vHZ1xKAjHYespDISm3VJy5tg4g/iAFA1TtQBgqBZjBeAgG3YcpwqGixCplmnUKn\n geFhEjc8M8pmCfwHb7se4f5vegFubKaUjVi6/AsSo7wY5d07Hjrs=","X-Gm-Gg":"AeBDievbSBIUCgGIflgH+KRRoOG9A0UQUyii3b7vOEIyHF7DZw+QmWxEDqmlolCIyeG\n HB2HOtGgI82M8DnRsW6OnJG+9abnEoepkeVi00yS7C2hARCnbMbYnOBM8S0eT+DfC1njcAblPvG\n /r9rbgnZenT9Hfnfc7fAmj+1O2MJ5unDanCtaN9u+lF52zo+6h50RtYdKUU/1e07UeNC+H1Xf9q\n eUbiV2JMSK9mWIHPFq6L3Y9mRrg0x4hqRZuU7Qipzp9Tn6RBbPwbb8qdqN9+as1nax7YtVQYql5\n 36JqBw==","X-Received":"by 2002:a05:6a00:1946:b0:82c:e1a0:3453 with SMTP id\n d2e1a72fcca58-82f0c3568e4mr13475537b3a.26.1776092230567; Mon, 13 Apr 2026\n 07:57:10 -0700 (PDT)","MIME-Version":"1.0","References":"<20260412195947.1982729-1-ravi@prevas.dk>\n <20260412195947.1982729-2-ravi@prevas.dk>","In-Reply-To":"<20260412195947.1982729-2-ravi@prevas.dk>","From":"Simon Glass ","Date":"Mon, 13 Apr 2026 08:56:51 -0600","X-Gm-Features":"AQROBzCsra2KaF5eTfgceXJDWeqfDSEKNrTPPdThXfcwVnmsP6Di9xBjrbbLLDE","Message-ID":"\n ","Subject":"Re: [PATCH 1/8] string: fix prototype of memdup()","To":"ravi@prevas.dk","Cc":"u-boot@lists.denx.de, Tom Rini ,\n Simon Glass ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]