[{"id":3676809,"web_url":"http://patchwork.ozlabs.org/comment/3676809/","msgid":"","list_archive_url":null,"date":"2026-04-13T14:56:54","subject":"Re: [PATCH 2/8] stdio: drop stdio_clone","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 2026-04-12T19:59:41, Rasmus Villemoes wrote:\n> stdio: drop stdio_clone\n>\n> The helper stdio_clone only has a single caller, so it certainly\n> doesn't need to be public. But in fact, it is merely an open-coded\n> memdup() - which for some reason uses calloc() even if the whole\n> allocation is obviously immediately overwritten.\n>\n> Drop it and just use memdup() directly.\n>\n> Signed-off-by: Rasmus Villemoes \n>\n> common/stdio.c | 18 +-----------------\n> include/stdio_dev.h | 1 -\n> 2 files changed, 1 insertion(+), 18 deletions(-)\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=fyh0THlA;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"fyh0THlA\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvVrJ2v1xz1xtJ\n\tfor ; Tue, 14 Apr 2026 00:57:36 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id B52D7841C2;\n\tMon, 13 Apr 2026 16:57:33 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id BA30F84222; Mon, 13 Apr 2026 16:57:32 +0200 (CEST)","from mail-pl1-x629.google.com (mail-pl1-x629.google.com\n [IPv6:2607:f8b0:4864:20::629])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 943F0839D5\n for ; Mon, 13 Apr 2026 16:57:30 +0200 (CEST)","by mail-pl1-x629.google.com with SMTP id\n d9443c01a7336-2addb31945aso27424025ad.1\n for ; Mon, 13 Apr 2026 07:57:30 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776092249; cv=none;\n d=google.com; s=arc-20240605;\n b=ciD64os6m5a2qXvNeiW/S6I2K7K1+GiGUQMeuLhoQ4KQ/P13wbAQE1b9AoCNGPc4lR\n sL+7eoiQBfbJZxl/qcEkvx5uQfd9Ai5NlSB68x/ZS3GxKDiai9EpPB7ELGhykEjtnufQ\n 8ffLF1XZKdfUJo5/Z6v2b+cXhzgYMlJoizLQKCtxt7a3bdPic8JaIScdYS/hcqtLApzL\n BRh2+Tj0vnENFWZD11NDKlYXU3Q8pTN+1+Y36cr5meJ9c3O4D1CDTSRxWsIcFiC1Ima6\n a5WtxOr60NefttEBpswED55GH6YZ7TRgPs2Rax/Gc73WDelBDewUw1PdO1xOsYeDbsBL\n G2Dg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=tQdewbT840Q2kS8U8J5AyTyNzsfkHprGuYEFIkF5QD8=;\n fh=dF+eCHOIT6SIbAzI5tBwPFZclvSQgQQ7Zo1JXO6SSnQ=;\n b=lUa0gG3Ca/+XRLAxFTI/YJzdMKj/2dcbDW4fZvtGmCJYjjWfWRIViE+ZE7eK/YZj+X\n qeOJCh/4gWdx4AQAIgdgTSz5j/cErIZrqKUaQHOkMa0Er+aJl02NVWIShQsrERzJ5pKG\n m8hA8jtrl4Y6No4ophDpIFI98AKVGtfFDfZSIXZplzxeVnRDCR0PiuhW3jHQbM22j+5a\n 5NkDrB+LW9Mym+yravMKEW8fN51HBOHOAWepCkkd8WE1HC1LbXY4Syn8ActXCX/le2jq\n ivNPgSsi9A2jPPCSZPavf2VciA0ul1xelFL+KUcoCuAAUhPvoUrpbJli1mNthwCc5MGJ\n mNew==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776092249; x=1776697049; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=tQdewbT840Q2kS8U8J5AyTyNzsfkHprGuYEFIkF5QD8=;\n b=fyh0THlAfqajopUlfFxGh4WXXIXNTRt9HhBI3EZ4jO5L8vTIb9oKSAvHniL5nyODNu\n Z7aI7Qnhbc7XCoaE99Z3yTwlmyLAoX4oezZrKwveuF91bK7ow4NMqe8wLk3eM6UscTKG\n PUu+jxQIbcK7iTzAJXTtloiQg77lxi4/qc/LI=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776092249; x=1776697049;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=tQdewbT840Q2kS8U8J5AyTyNzsfkHprGuYEFIkF5QD8=;\n b=XSqJZdHn7CjstZlLkzYpPHrTQNk4ugu6luI3hlWizf30/z15NKwVpdtqqcqL1ihlOz\n jwCnB1RhOdLA8W0cbhkX+twbKFQotqpxDv05GyTVEkUtJ2cBxJvuYGO3l9xit1MwbJJs\n hbGMI3upD4mnyrw/NAlBxb7UjfP+7TOZ2mJqSXvf4sndFQ+fHC9nxgJpAXjV8jGysrHp\n NJ8nj3ghM/ukTx/iCVSB9nCsjPErgUAOm9X2gqkDnuO158ZRMzmVUaP/P+DqSANGeuQV\n 0AL7soN/85aFh+RIF1juyl/rjUsikrgo9O05JyD1wk3km+yg4zs9VHQhtoosO1Mqm5kn\n CI2g==","X-Gm-Message-State":"AOJu0Ywtxz2jitQa4GxBhHpkfg3vX1BeDS8O0wLKmfkBcasvIpGWrL0A\n UbLJf93b0mXDo5UlLvfdaK5jcoeiErxSzY3rzkLLgvxJ5PZar0p3rFw/P2g1IAhUrAjaiCeCaV/\n 017iDnF2hxVOQIC1ZtseVe/bqlZ0iMa9Z3HtKjr+k","X-Gm-Gg":"AeBDievXjcbTAM2GAe2mV5sEdCocH1FIsMJoK6MpnXAiB8Fqd2NcyGDiSxlWqKBIHQe\n 2yUGQ0QeNOZ+I2Sq5TNXddLKUypO4jMd4ccl97bMLKyFqjVL/UVSB5bKR4Yi0lfm8f6gANpd/pZ\n hkCfagKx8qsw9oUrEWtRkFFByCLOw1laaPA30Ao8JJQWA5dwGW5jvZTRdMEu19V0D9MdpSfQmnO\n XE6rVsc2EUqkRvBr1CDYWl0pJvYFvQVm721AtmPl/GmmmMJIC/+Eb0456YUUy84t2gb0Y+ntVOi\n WwsrUg==","X-Received":"by 2002:a17:903:1104:b0:2b2:ecc6:5e28 with SMTP id\n d9443c01a7336-2b2ecc66307mr65325045ad.25.1776092248845; Mon, 13 Apr 2026\n 07:57:28 -0700 (PDT)","MIME-Version":"1.0","References":"<20260412195947.1982729-1-ravi@prevas.dk>\n <20260412195947.1982729-3-ravi@prevas.dk>","In-Reply-To":"<20260412195947.1982729-3-ravi@prevas.dk>","From":"Simon Glass ","Date":"Mon, 13 Apr 2026 08:56:54 -0600","X-Gm-Features":"AQROBzC9tNDFCzvn9qX_ipCcIWXiTrfz7pPkl8t2b8PMOioyNECMD1ksN1GJv68","Message-ID":"\n ","Subject":"Re: [PATCH 2/8] stdio: drop stdio_clone","To":"ravi@prevas.dk","Cc":"u-boot@lists.denx.de, Tom Rini ,\n Simon Glass ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]