[{"id":3676529,"web_url":"http://patchwork.ozlabs.org/comment/3676529/","msgid":"<adyjsMVQ0QMr5DUe@stanley.mountain>","list_archive_url":null,"date":"2026-04-13T08:05:04","subject":"Re: [PATCH] media: tegra-video: tegra210: remove redundant NULL\n check in dequeue_buf_done","submitter":{"id":389,"url":"http://patchwork.ozlabs.org/api/people/389/","name":"Dan Carpenter","email":"error27@gmail.com"},"content":"On Sun, Apr 12, 2026 at 05:24:16PM +0000, Hungyu Lin wrote:\n> list_first_entry() does not returns NULL when the list is known to be\n> non-empty. The NULL check before list_del_init() is therefore\n> redundant.\n> \n> Remove the unnecessary check.\n> \n> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>\n> ---\n\nThanks!\n\nReviewed-by: Dan Carpenter <error27@gmail.com>\n\nregards,\ndan carpenter","headers":{"Return-Path":"\n <linux-tegra+bounces-13736-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=ineHvU4g;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13736-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"ineHvU4g\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.128.50","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvKhY1sxXz1yDF\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 13 Apr 2026 18:05:17 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 5A9D53003985\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 13 Apr 2026 08:05:13 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id B678A3A4535;\n\tMon, 13 Apr 2026 08:05:12 +0000 (UTC)","from mail-wm1-f50.google.com (mail-wm1-f50.google.com\n [209.85.128.50])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 275A23A3E7A\n\tfor <linux-tegra@vger.kernel.org>; Mon, 13 Apr 2026 08:05:10 +0000 (UTC)","by mail-wm1-f50.google.com with SMTP id\n 5b1f17b1804b1-488afb0427eso51823845e9.1\n        for <linux-tegra@vger.kernel.org>;\n Mon, 13 Apr 2026 01:05:10 -0700 (PDT)","from localhost ([196.207.164.177])\n        by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d63e46713sm31856761f8f.21.2026.04.13.01.05.07\n        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n        Mon, 13 Apr 2026 01:05:07 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776067512; cv=none;\n b=s8MqbCg3EHtT0J6obFHqwZFesKDB83u2x64SQ2Z+STnmVnMHbZtKG4PHpftjwLDU/MDBcNPcBFzpQexp3tQ+Hyu/i6Eat/OxLwGlA3LCLNKkQoR/TsV7KzMWzJGHIiqkNNL+Ia+lifvBeoz9fM4lLrPU6W8LyQjf8xeo5QpdUFM=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776067512; c=relaxed/simple;\n\tbh=cdFk9qYNkWRkyL4yx5fX1+zERqhUHhUkyMOAmjOBvQM=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=CxLCMtvEJPhePYT7I+Igw4GVQ27iv+aFLip1LsCX6TBsJh2NJMtpQyJUZy49Xg5Vf21jfVw1rldNTjy7hrFcIGQMAZpC6Vn4ey62OS5nbRtnYbYSLmPYkk4ScfEin+9ZVz4fHU+ZjAiFLg6kntvZp1Cl1oM+iiOmdF3ayzvekok=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=ineHvU4g; arc=none smtp.client-ip=209.85.128.50","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=gmail.com; s=20251104; t=1776067509; x=1776672309;\n darn=vger.kernel.org;\n        h=in-reply-to:content-disposition:mime-version:references:message-id\n         :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n        bh=bgVAXUp4ABfEYNGLPdeyADY9E6Zgs1iS/q+7Ud1//rk=;\n        b=ineHvU4gXhmxQQ3gBc+nmcpIO6+QMOO4XU64M+LNB2aoviynyOjs4X9qGwxodvu3SJ\n         ZWpMb+ff4fA9PvHalRoBsufpQ9wn6gCEGxD+tTcH9Uf5ukkkI0XX0OkH0AN+SS7NDZsy\n         SvKvK+Dt5P3FO1XdkXsQSj+k93d/nywDwQOS3GJ/gT9seHkMZsVpRP84z2Y7sgq6evMr\n         tktJOwXR9Keutsb0+F8TiFYkVt5GhU4Eq9eD4Xzx2c1x1xrnjtz258yPlpSCwWrLPwQG\n         c0Dao5QOMQzccyLg6NsBeQ8FBIpH2R6rVZTXpvQISomxK4wZSyADkNVTy8oIAIQ0o1Ql\n         7V6A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=1e100.net; s=20251104; t=1776067509; x=1776672309;\n        h=in-reply-to:content-disposition:mime-version:references:message-id\n         :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n         :subject:date:message-id:reply-to;\n        bh=bgVAXUp4ABfEYNGLPdeyADY9E6Zgs1iS/q+7Ud1//rk=;\n        b=aqhQfKHaKT3g0eyDrL7IWOrJdyCyEFYh42YiEj8fQ/K+K9iRc8hS/d+owgR0RWtdm/\n         5nJDaRFT3kq676GUYlwONCjlPOY+b0U7Qdg9o/oZLDv+YTbQFO4a0IuRnlZy8Y6kMq0z\n         D7UVqCxSNEDTYTpFIDr/MXbiGH++Uj/FnYaqeD9Kzb0HPg1QRwp0NFOW2XDS28LtBYVe\n         YlEbEW+zNrcqSZw+imZkRxYRf0SZu3FabLiTf0AmGbLRoj+V09KWuYHn6VvXgTS0R3qQ\n         pCfo6636/vmmfQ598LywiqHp5Iy7G0VUUqqh1p5d72LP4mvcvs6x10YSCRMeUbuqjcQA\n         b3bA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8zK/VmTAYZxnvEghlbUoAB+yy0FrLYcrtFpZDYYqhogF/sA13yzXQE8vN2CMJNPEJuJhz7m43vGedSMQ==@vger.kernel.org","X-Gm-Message-State":"AOJu0YwqeXFO0xV3yxSPugkiSXlJnskU7W0vC9zDulksSpO/nhgEblrt\n\tpuHl6HLe4VV9RrL2ukYfRyCSgFV9g6UYLTDi6w2y1DDF1RpoZbrx3/YB","X-Gm-Gg":"AeBDievm4it9w7ArMfNlXGahb1/+UwPr5/Ktr8uniHkUFRroPfwN6zFCggIyPWebyjB\n\tjPWhBdp0CcXahBaZGik1diI9demjfGNlJsFBITMG0v2bWgdwpOOARlSodAHiwLMKh6bX96JaOY7\n\tFiCw0qbP4BK5qBo0JFz4h2/Vd0NsSsp5RqgAvabC+hfW+SQvai3SrvLxx4/pTyZN6afyNhFeb2q\n\t2WNKNlXHj372AU/qlDlQD99NKw7n+c4cU56L2lgHGBUyn6Eu/xYavd1auJXMqteV5E2JXTnPdgO\n\t6H06N8nGkldUlNBuXl0Dsx6P/QqBDn3QUSETWnvVo4UoO88/dY6jlWAladQ4KvIRZW+vkGy29mA\n\tDY1e42iVXXhZYA8I2hkIi+JkFibBZOTyCh53ooO82CgwyhKPKeOo/y7qDFYnnHw9AUbHClfJyV6\n\tJBuq0OlT2zRRsLWIiCta3xkJ/K1Jn9Zw==","X-Received":"by 2002:a05:600c:4f83:b0:488:7ff5:2c67 with SMTP id\n 5b1f17b1804b1-488d67f0aa2mr148620055e9.12.1776067508380;\n        Mon, 13 Apr 2026 01:05:08 -0700 (PDT)","Date":"Mon, 13 Apr 2026 11:05:04 +0300","From":"Dan Carpenter <error27@gmail.com>","To":"Hungyu Lin <dennylin0707@gmail.com>","Cc":"thierry.reding@gmail.com, jonathanh@nvidia.com, skomatineni@nvidia.com,\n\tluca.ceresoli@bootlin.com, mchehab@kernel.org,\n\tgregkh@linuxfoundation.org, linux-media@vger.kernel.org,\n\tlinux-tegra@vger.kernel.org, linux-staging@lists.linux.dev,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH] media: tegra-video: tegra210: remove redundant NULL\n check in dequeue_buf_done","Message-ID":"<adyjsMVQ0QMr5DUe@stanley.mountain>","References":"<20260412172416.33052-1-dennylin0707@gmail.com>","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"<linux-tegra.vger.kernel.org>","List-Subscribe":"<mailto:linux-tegra+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-tegra+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260412172416.33052-1-dennylin0707@gmail.com>"}}]