[{"id":3676524,"web_url":"http://patchwork.ozlabs.org/comment/3676524/","msgid":"","list_archive_url":null,"date":"2026-04-13T07:53:08","subject":"Re: [PATCH] media: tegra-video: vi: validate format index before\n bitmap_set","submitter":{"id":389,"url":"http://patchwork.ozlabs.org/api/people/389/","name":"Dan Carpenter","email":"error27@gmail.com"},"content":"On Sun, Apr 12, 2026 at 03:48:43PM +0000, Hungyu Lin wrote:\n> tegra_get_format_idx_by_code() returns -1 when no matching format\n> is found. vi_tpg_fmts_bitmap_init() used the returned index directly\n> in bitmap_set(), which may lead to an out-of-bounds access when the\n> format is not present.\n> \n> This can occur when TPG is enabled on SoCs whose video_formats[]\n> table does not include the requested media bus formats.\n> \n> Validate the index before calling bitmap_set().\n> \n> Signed-off-by: Hungyu Lin \n> ---\n\nThis isn't a bug which can occur in real life since the index is\nalways found... If there were really a bug, like say someone were\nwriting a new driver and messed up, then this would just paper over\nthe issue and make the bug harder to find, so in a way it makes the\ncode worse.\n\nregards,\ndan carpenter","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=gIPnpE8v;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13734-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"gIPnpE8v\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.128.47","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvKVc1Jrwz1y2d\n\tfor ; Mon, 13 Apr 2026 17:56:40 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id E0EF23000B83\n\tfor ; Mon, 13 Apr 2026 07:53:15 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 2D82739D6EF;\n\tMon, 13 Apr 2026 07:53:15 +0000 (UTC)","from mail-wm1-f47.google.com (mail-wm1-f47.google.com\n [209.85.128.47])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id C3EFA39A06A\n\tfor ; Mon, 13 Apr 2026 07:53:13 +0000 (UTC)","by mail-wm1-f47.google.com with SMTP id\n 5b1f17b1804b1-48334ee0aeaso38133905e9.1\n for ;\n Mon, 13 Apr 2026 00:53:13 -0700 (PDT)","from localhost ([196.207.164.177])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488d5934a6dsm303076735e9.11.2026.04.13.00.53.10\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 13 Apr 2026 00:53:11 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776066795; cv=none;\n b=Myp/+yeCOT3XSt2sI9ZYSDoXFVGBrX5DB7eGmZKd96HHyD56Pcq9jjo8ZtCeLgX0OrNf/4fHoBNxfvxlwExwwASg8bDIn3rBB8QQIbyLWXHQtQSaJVmQ3mVb5JNhHROQzgnki996Em9yPITf2nqkjE0bBEpyPhcEMmLeI0xSmHI=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776066795; c=relaxed/simple;\n\tbh=qURxmoeHtBYQQZeErf/My6lgX3gSGhOBzfCSynLVIZY=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=Jp0IjIDIcr1Nk8LhYHnL+J/NEugcoMfIrhV6IAzHdbTBpvkhApP2OAV+lBdR7ObbLsxFdAPrDkKzS5EgHfnecjvepcBn+RZ71Yb8KHkq+5nwG/d6N8o7Az6MkK8rkaEgnOsxqTA/I3WM6+EL0gHl6r6jKm7aJAgbZPZSsZnl5To=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=gIPnpE8v; arc=none smtp.client-ip=209.85.128.47","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776066792; x=1776671592;\n darn=vger.kernel.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=5p9ZJZXABKCmpzl6zl3MItAQjfacdhE/eXpBJaxRNq8=;\n b=gIPnpE8vbQ2exAGgrElXM9dU70STAef4BFQKq90nihInyVoyXpgKxCEw9mlrbFj/kb\n S7S2h29ltdHHG1qeJlNWHgChOWm4Y/rRWEHgQfr7mtHD28Gwn5JRKrUgLV23IdRmzjfh\n tH/sr/QfsRO6eB+jLU7niWKVOc4qQedHYsXeySRo8lNL/JvS0PFbu9kza7Kb9Q+Fcgt3\n 5RqJTNbgeTkk9JUtJyiUQGmRAmW158HQhRcDcZvh3ZWAPQA+nkuG31bU7MWKeIPNVyOz\n 00Pm/L89QHb1AycLywmnOIkay8/dEdX4WqzI71z0Oc6S6kpHojXywOsVeg+nNj899hpZ\n oKDw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776066792; x=1776671592;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=5p9ZJZXABKCmpzl6zl3MItAQjfacdhE/eXpBJaxRNq8=;\n b=JalueKgqPhUHtYpZnEfhFdM0IT8ode5CCx1MHtILEvZVcvlScdtbX+Kblo0HzeT7Nz\n 1EvAFhNupzUmTUlmAoLz6jnb3ZLAtZbNZpdDiZdqlHZE4L4c+IpHXWel9LlTcO023iXx\n x8YI1srenBhvlkB2+HRLXbdcu2ZL+iSN+qO1GTkn0qfglPnZOui+Kvp9vL5JnXSSKJEu\n Qj4GpwjT4ftfVs7qx/Ca8hPpbz7o9QGi86dnhetpKPgZQEJcRLmnJ+5AKxySb+4UC1Kz\n VvTWvPH2MjPfn8HLc3Qohw4bPlTH19cZzwkRRhukzNZtydi91lh+gE3M0/LXku2vW0JJ\n 6uMA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9/6BgO7+0C7wZ7R/Kjc/nz5rJwd6y30bLgldTRrRFE4sSHkoOlZaQHXLnvH4H6iYVUIM8mUksv3KVA0A==@vger.kernel.org","X-Gm-Message-State":"AOJu0YyTYCpnbiAhAODbtDNcDI7Kp5qus/dEaWMtogUREjRCIM/iIkWT\n\tkquOQQ3eXdxlZWjx0zrOXoYOdJp7jZdIrvw0ZeDOqnrGJjgOqEnbhaIq","X-Gm-Gg":"AeBDietMF3rliSf+gxexMUU1uicnPw8Sc1CY9GpZYPooMLDDwtf9hX7TvzN/jG8cCsf\n\tYWVi1ofCaLQbCXHu3fMVYc+87z5tzZNz8BcPdEDUAIk6w2uzRSVg6x4pQt3duSCeB6sZGQfEU/W\n\tKrZIsw0i0HNfpoKX7hwb/iwLWUs/Cfs8oS9eShy5V3KF7XIshQHfDphpl8pgeJQc+tRDE8FeOPK\n\tipuJNRJtaDPs0JCk9O85/P0H9xa/RlNpv2HDSv/UjR8CKJ36tk9evzIHuoDkfdcd2J7ZEjqc05H\n\tPtpDvt+HvWRuxhoDHHVyenpUvYVh/DnLyr80k0xxrTrf0isBtAO9xr7GT79kV6pJYYus4kwd3YG\n\tSiRJdPr0b0vUfymGK9wSHXH5WrK7p+sZtw+jBz0ul+3bjV5kC6P4h7xRyX07jwz96nNtdAwONLj\n\tXA150Z49oRS+h+3MN5UJBhPYr2i9rN9g==","X-Received":"by 2002:a05:600c:a11c:b0:487:2671:fb8f with SMTP id\n 5b1f17b1804b1-488d67fa40fmr115755205e9.8.1776066792070;\n Mon, 13 Apr 2026 00:53:12 -0700 (PDT)","Date":"Mon, 13 Apr 2026 10:53:08 +0300","From":"Dan Carpenter ","To":"Hungyu Lin ","Cc":"thierry.reding@gmail.com, jonathanh@nvidia.com, skomatineni@nvidia.com,\n\tluca.ceresoli@bootlin.com, mchehab@kernel.org,\n\tgregkh@linuxfoundation.org, linux-media@vger.kernel.org,\n\tlinux-tegra@vger.kernel.org, linux-staging@lists.linux.dev,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH] media: tegra-video: vi: validate format index before\n bitmap_set","Message-ID":"","References":"<20260412154843.29056-1-dennylin0707@gmail.com>","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260412154843.29056-1-dennylin0707@gmail.com>"}}]