[{"id":3676314,"web_url":"http://patchwork.ozlabs.org/comment/3676314/","msgid":"<7cf53a95-76a2-4be9-a57b-0887a28bbe3a@gmail.com>","list_archive_url":null,"date":"2026-04-12T16:32:15","subject":"Re: [PATCH v=2] ata: libata-scsi: fix requeue of deferred ATA\n PASS-THROUGH commands","submitter":{"id":79394,"url":"http://patchwork.ozlabs.org/api/people/79394/","name":"Sergey Shtylyov","email":"sergei.shtylyov@gmail.com"},"content":"On 4/12/26 6:36 PM, Igor Pylypiv wrote:\n\n> Commit 0ea84089dbf6 (\"ata: libata-scsi: avoid Non-NCQ command starvation\")\n> introduced ata_scsi_requeue_deferred_qc() to handle commands deferred\n> during resets or NCQ failures. This deferral logic completed commands\n> with DID_SOFT_ERROR to trigger a retry in the SCSI mid-layer.\n> \n> However, DID_SOFT_ERROR is subject to scsi_cmd_retry_allowed() checks.\n> ATA PASS-THROUGH commands sent via SG_IO ioctl have scmd->allowed set\n> to zero. This causes the mid-layer to fail the command immediately\n> instead of retrying, even though the command was never actually issued\n> to the hardware.\n> \n> Switch to DID_REQUEUE to ensure these commands are inserted back into\n> the request queue regardless of retry limits.\n> \n> Fixes: 0ea84089dbf6 (\"ata: libata-scsi: avoid Non-NCQ command starvation\")\n> Reviewed-by: Damien Le Moal \n> Signed-off-by: Igor Pylypiv \n> ---\n> \n> Changes from v1:\n> - Dropped the usage of set_host_byte() because it is logically a separate\n> change from what this commit is fixing. set_host_byte() does not clear\n> the status byte and the ML byte.\n> \n> drivers/ata/libata-scsi.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c\n> index 3b65df914ebb..cd607911d724 100644\n> --- a/drivers/ata/libata-scsi.c\n> +++ b/drivers/ata/libata-scsi.c\n[...]\n> @@ -1701,7 +1701,7 @@ void ata_scsi_requeue_deferred_qc(struct ata_port *ap)\n> \tap->deferred_qc = NULL;\n> \tcancel_work(&ap->deferred_qc_work);\n> \tata_qc_free(qc);\n> -\tscmd->result = (DID_SOFT_ERROR << 16);\n> +\tscmd->result = (DID_REQUEUE << 16);\n\n You could drop the useless parens, while at it...\n\n> \tscsi_done(scmd);\n> }\n> \n\nMBR, Sergey","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ide@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=nNtzmO+s;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-ide+bounces-5479-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"nNtzmO+s\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.208.176","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftx0S2KYnz1yGg\n\tfor ; Mon, 13 Apr 2026 02:32:39 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id BE4373004DC5\n\tfor ; Sun, 12 Apr 2026 16:32:28 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 74BCC2F1FEF;\n\tSun, 12 Apr 2026 16:32:21 +0000 (UTC)","from mail-lj1-f176.google.com (mail-lj1-f176.google.com\n [209.85.208.176])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id F15D02DA765\n\tfor ; Sun, 12 Apr 2026 16:32:19 +0000 (UTC)","by mail-lj1-f176.google.com with SMTP id\n 38308e7fff4ca-38e12c67a6fso32740971fa.1\n for ; Sun, 12 Apr 2026 09:32:19 -0700 (PDT)","from ?IPV6:2a00:1fa0:2f6:3ecd:1aeb:dc21:a8b0:f47f?\n ([2a00:1fa0:2f6:3ecd:1aeb:dc21:a8b0:f47f])\n by smtp.gmail.com with ESMTPSA id\n 38308e7fff4ca-38e495ae96fsm17725851fa.39.2026.04.12.09.32.16\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Sun, 12 Apr 2026 09:32:17 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776011541; cv=none;\n b=fHT3JHs8RmekAg9Ys2+ROXd+YPLbB/U8pO3cqoFVIGOwhD2EJCzMIhTxWHSZGo4LxzJLTDXDK2wdhS3dUbPY38wTN/43W5XX4ReO+pe+HFKG4lOVSLP5ZIzMfuJ8XXacRUq2ukQZ9c2n4UOA6kF1LBXmVyE452yYht837YIwnLU=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776011541; c=relaxed/simple;\n\tbh=N9zrlSTKQS45AFKICqF0j/XBy6/Y0wUUsIg3ODDjpBI=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=Zq1OxmT5+XPK768D9ZYnG+BSEzDcKV20vNtqboAqPy9zZK+R4+WkdSUAAZ16BSI8K+62Yyz7nVCdwcDwGZMNRbYIVtARZy1X12URTOlhmU78VpYgL1pkJR69tpw4lbAFwHwUy8vS7cOZcWKfYyNqHSgs0o2Ida3+HdSrvESr+5A=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=nNtzmO+s; arc=none smtp.client-ip=209.85.208.176","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776011538; x=1776616338;\n darn=vger.kernel.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=/bcpisGuz2lQhjFsaoHWs5e0zfTCqxg+SMoBVOvRKSw=;\n b=nNtzmO+sg74EDsBMxCiY4TW5o7PwzRa9giC0oVY8OTrEpNT/hr+3Nupw3WCQ1T74Gd\n k4kjjfihGQ4BGeEPZ5AG2VSRVvTQrpk7+HdyoEJ1m5iwzPp2H8DS9rMZgIqdI1JAQ1sd\n GlMukWuqpVwAz6cFfp6HsFz9CtS0LY8gjmDSVW7MTOHWwGDP5TRj0e4mzsMgqjpWuXfB\n s1dUCFKMEIBIkGekrxFbePm8fhn8AMJ34pJDnUY7Qv4fwflDWG5PrLubyNm3awnKt6jd\n noMiLp5ij3xx1c7Ued85usI9QfoOkmVSV5u8wxfrhwJII29wzJK9BMgHGPPP8s5kddM2\n CkwA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776011538; x=1776616338;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=/bcpisGuz2lQhjFsaoHWs5e0zfTCqxg+SMoBVOvRKSw=;\n b=hravwI7rgX8jFvF6RI5IMaBla2jMfQbC7v2QUdvamSMjcc63oPL/mvPqfJrCUJEmXg\n S1MtC5GOc4j2TtzpKNWWdiHXj6bsTVZIcLDVwC6uYuzk17Q/eyc9M2HD5fonmpsiOzUt\n +BJhGSy/NgVGPMzCDsorWWohr3Csnzjxh7VSGRU4xk+vXlLQFMHeO+By6kauiJiqZZ9k\n HPp4PVLTlifZzgsgLUQ1AHECJC7qrZbp4/XJMPyul7zl0DMkFWntVwYdMyB/l4Ht1nVJ\n dwd39YdWL4YI/CrcdqVbcdtQKwzXmMR0ydkmlGVSri6FW/yl3zMbmLDMR25VBtaUnqux\n I2Lg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+0uFesrX0wx+0qGnpeNXNruxzPK11rvWqTotmIzrduu6rVa1P7cQDjkmvAqreio0QG1FJGd9gXrAY=@vger.kernel.org","X-Gm-Message-State":"AOJu0Yyp4NaeiGotnzIAAQkH0N9aQXXMjGWZ9wKRbWqojAv9cZYKv24O\n\tA1SCImFqvwTb6FD0LOPEaQGWTJVD6LI8pD6uSECCci1Z0w6C24ZRpknm","X-Gm-Gg":"AeBDiescUApu1YR8WZ7RH0Sm9ut0443/IQ9DEwLH775ABfa+6LyJsc+rb8LbOF71XKL\n\tX8NmXZWFXTDUza94GNPOgR+ujJhfTe3YykZ2B32qLUSLdoBARZTlZfAEr80q16/4/mxTxfMHimO\n\tj9D3JlgOlEn6Pjv0yN5eVa0i0Fjql76FMPqcmsyKPEf9/uANpVBbhBd1jJ/48vKR326o/2TN/Re\n\teYrstymM3kR8Utjv7xYrdGk3n5JCnObVqiEvtB+gH+Z4Ff1NDocRxoIpwm0818/8LPfkcEdKJlq\n\tugtcm6H1OhTjwN0DhYGgGyllAs18pqTtgJl0eQ9t83LoUNfBEvmheh4MPr23sidvcgAHPoOq4Mw\n\tGtny+PQR+ounCj+bIhwVxCPOktiKMt5NtWDGkji1B7ZjHCflyE33+9OeFz9/oKsvcVyw7FB61re\n\tQn0dha9PJ+ZkT3nj2U8QGevt8vQPx7dLc1KwgVJru0ey7c1oE1N6EQg7x13KaAy4ROXqpJOJqnD\n\tXcAlmU=","X-Received":"by 2002:a2e:8a87:0:b0:38e:2de3:f8ad with SMTP id\n 38308e7fff4ca-38e4bdcac07mr32216401fa.4.1776011537827;\n Sun, 12 Apr 2026 09:32:17 -0700 (PDT)","Message-ID":"<7cf53a95-76a2-4be9-a57b-0887a28bbe3a@gmail.com>","Date":"Sun, 12 Apr 2026 19:32:15 +0300","Precedence":"bulk","X-Mailing-List":"linux-ide@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v=2] ata: libata-scsi: fix requeue of deferred ATA\n PASS-THROUGH commands","To":"Igor Pylypiv , Damien Le Moal ,\n Niklas Cassel ","Cc":"\"Martin K. Petersen\" ,\n John Garry , Xingui Yang ,\n linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org","References":"<20260412153637.475606-1-ipylypiv@google.com>","Content-Language":"en-US","From":"Sergey Shtylyov ","In-Reply-To":"<20260412153637.475606-1-ipylypiv@google.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit"}},{"id":3676355,"web_url":"http://patchwork.ozlabs.org/comment/3676355/","msgid":"<177601670536.2584527.11395508886922734288.b4-ty@kernel.org>","list_archive_url":null,"date":"2026-04-12T18:11:19","subject":"Re: [PATCH v=2] ata: libata-scsi: fix requeue of deferred ATA\n PASS-THROUGH commands","submitter":{"id":87751,"url":"http://patchwork.ozlabs.org/api/people/87751/","name":"Niklas Cassel","email":"cassel@kernel.org"},"content":"On Sun, 12 Apr 2026 08:36:37 -0700, Igor Pylypiv wrote:\n> Commit 0ea84089dbf6 (\"ata: libata-scsi: avoid Non-NCQ command starvation\")\n> introduced ata_scsi_requeue_deferred_qc() to handle commands deferred\n> during resets or NCQ failures. This deferral logic completed commands\n> with DID_SOFT_ERROR to trigger a retry in the SCSI mid-layer.\n> \n> However, DID_SOFT_ERROR is subject to scsi_cmd_retry_allowed() checks.\n> ATA PASS-THROUGH commands sent via SG_IO ioctl have scmd->allowed set\n> to zero. This causes the mid-layer to fail the command immediately\n> instead of retrying, even though the command was never actually issued\n> to the hardware.\n> \n> [...]\n\nHello Igor,\n\nConsidering that Linus is expected for release 7.0 any minute now (it is\nalready Sunday afternoon), it seems too late to send this as a PR for 7.0.\n\nThe fix will have to be backported to v7.0 stable instead.\n\nTherefore, I rebased your patch on libata/for-next\n(without any parens - the comment from Sergey).\n\n\nApplied to libata/linux.git (for-7.1), thanks!\n\n[1/1] ata: libata-scsi: fix requeue of deferred ATA PASS-THROUGH commands\n https://git.kernel.org/libata/linux/c/8ebf408e\n\nKind regards,\nNiklas","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ide@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=MfRM66Io;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-ide+bounces-5480-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"MfRM66Io\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftzBm3g6pz1yCx\n\tfor ; Mon, 13 Apr 2026 04:11:44 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 79D3C3002D2C\n\tfor ; Sun, 12 Apr 2026 18:11:41 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id C8E7C35DA4A;\n\tSun, 12 Apr 2026 18:11:37 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id A5D812DC332;\n\tSun, 12 Apr 2026 18:11:37 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 9882CC19424;\n\tSun, 12 Apr 2026 18:11:35 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776017497; cv=none;\n b=eKKuW9Ga+i6kDcMwCfY6TVS4wv6LcqoVcs5/qS0Bwk9UMWGHS+/v647jgMOOIJt34fYvZIV3dtcyogsarLIPbVZqBc5S51TXHSCckKNWxTLbA1s1Ir3/gX+nlPFgZjTDXX2XS/UVp/FjBsSkKYjv0xvwb9PICo31WVgCZq/JErw=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776017497; c=relaxed/simple;\n\tbh=Ju/fJaO2pcbpcQjv6kJ9VPfdZqlRPZmb3O6vkUO04AQ=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=IEBvDLJBKfmvQ62IAJ2aQxuEfaXmH3bJDoOFjRXrqzBvmbgwW2xqJhpVnuHcsJt8p2Y9iy5ngJ9RBmlbKvuPvtBOU+tQiHC8d1CtZurcBL83+qvyMB41dF48ApY924k1Tbaci+ugrWaSfETQ1tddRXry47zkD9z4YU9E0ewQ3gI=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=MfRM66Io; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776017497;\n\tbh=Ju/fJaO2pcbpcQjv6kJ9VPfdZqlRPZmb3O6vkUO04AQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=MfRM66IoZq1R/p8UUwRKHFdLLMpKFmW0ooy/RqqBFk0KWEx7AHR+AFgo/qoS0f7cM\n\t Z+kFnpWp3YQNE7rtVQM+LloPbl1nHMUG9iLrTZFeePy3QF9ah9cO5M6xNdda5bPSUs\n\t A85I5FkM3L+Khi14PDSpusmui/rOIqYXLXCbpvOHOWx8uSF6268eTqlisSGgEAsJf1\n\t ZrWyEnl5VR5dD51leMRarYa0dkEcQOHdF9+7z+lCZ3Wln3RqdrW5aE2WL3dsmeu1ta\n\t vZd1UBuvByniTkvP1kiiTnjfgVTJZGZuaFFR+49+FqbdlIe1kDNOgJ4tUmG/ze2Y7O\n\t YU3MQWy99ZCuQ==","From":"Niklas Cassel ","To":"Damien Le Moal ,\n\tIgor Pylypiv ,\n\tlinux-kernel@vger.kernel.org","Cc":"Niklas Cassel ,\n\t\"Martin K. Petersen\" ,\n\tJohn Garry ,\n\tXingui Yang ,\n\tlinux-ide@vger.kernel.org,\n\tSergey Shtylyov ","Subject":"Re: [PATCH v=2] ata: libata-scsi: fix requeue of deferred ATA\n PASS-THROUGH commands","Date":"Sun, 12 Apr 2026 20:11:19 +0200","Message-ID":"<177601670536.2584527.11395508886922734288.b4-ty@kernel.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260412153637.475606-1-ipylypiv@google.com>","References":"<20260412153637.475606-1-ipylypiv@google.com>","Precedence":"bulk","X-Mailing-List":"linux-ide@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1214; i=cassel@kernel.org;\n h=from:subject:message-id; bh=Ju/fJaO2pcbpcQjv6kJ9VPfdZqlRPZmb3O6vkUO04AQ=;\n b=owGbwMvMwCV2MsVw8cxjvkWMp9WSGDJvP3DbvEZHVD0/MWhJyTWTr4px6dc9q9T39CbPt255b\n W5SV9nZUcrCIMbFICumyOL7w2V/cbf7lOOKd2xg5rAygQxh4OIUgIk8rWb4X8Q754nEaZaFDw7z\n CVWt2vIm0Hm66qW9eqaxc5X3nf9fnMXI8MxKh41nZekkqXc2If+Xqn66dNveSZelrFz6+a5VfbP\n deQE=","X-Developer-Key":"i=cassel@kernel.org; a=openpgp;\n fpr=5ADE635C0E631CBBD5BE065A352FE6582ED9B5DA","Content-Transfer-Encoding":"8bit"}}]