[{"id":3678074,"web_url":"http://patchwork.ozlabs.org/comment/3678074/","msgid":"","list_archive_url":null,"date":"2026-04-16T10:14:54","subject":"Re: [PATCH] misc: microchip: pci1xxxx: fix IRQ vector leak in\n gp_aux_bus_probe()","submitter":{"id":91722,"url":"http://patchwork.ozlabs.org/api/people/91722/","name":"Guangshuo Li","email":"lgs201920130244@gmail.com"},"content":"Hi，\n\nOn Sun, 12 Apr 2026 at 21:34, Guangshuo Li wrote:\n>\n> gp_aux_bus_probe() allocates IRQ vectors with pci_alloc_irq_vectors()\n> before initializing and adding the second auxiliary device.\n>\n> When pci_irq_vector(), auxiliary_device_init() or auxiliary_device_add()\n> for the second auxiliary device fails, the function unwinds the auxiliary\n> devices and ida allocations, but leaves the allocated IRQ vectors behind.\n>\n> Add a dedicated error path to call pci_free_irq_vectors() after IRQ\n> vectors have been allocated successfully.\n>\n> Fixes: 393fc2f5948f (\"misc: microchip: pci1xxxx: load auxiliary bus driver for the PIO function in the multi-function endpoint of pci1xxxx device.\")\n> Cc: stable@vger.kernel.org\n> Signed-off-by: Guangshuo Li \n> ---\n> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c | 7 +++++--\n> 1 file changed, 5 insertions(+), 2 deletions(-)\n>\n> diff --git a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c\n> index 34c9be437432..5e1f99a35100 100644\n> --- a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c\n> +++ b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c\n> @@ -93,14 +93,14 @@ static int gp_aux_bus_probe(struct pci_dev *pdev, const struct pci_device_id *id\n>\n> retval = pci_irq_vector(pdev, 0);\n> if (retval < 0)\n> - goto err_aux_dev_init_1;\n> + goto err_irq_vectors;\n>\n> pdev->irq = retval;\n> aux_bus->aux_device_wrapper[1]->gp_aux_data.irq_num = pdev->irq;\n>\n> retval = auxiliary_device_init(&aux_bus->aux_device_wrapper[1]->aux_dev);\n> if (retval < 0)\n> - goto err_aux_dev_init_1;\n> + goto err_irq_vectors;\n>\n> retval = auxiliary_device_add(&aux_bus->aux_device_wrapper[1]->aux_dev);\n> if (retval)\n> @@ -113,6 +113,9 @@ static int gp_aux_bus_probe(struct pci_dev *pdev, const struct pci_device_id *id\n>\n> err_aux_dev_add_1:\n> auxiliary_device_uninit(&aux_bus->aux_device_wrapper[1]->aux_dev);\n> +\n> +err_irq_vectors:\n> + pci_free_irq_vectors(pdev);\n> goto err_aux_dev_add_0;\n>\n> err_aux_dev_init_1:\n> --\n> 2.43.0\n>\n\nI re-checked this issue on our side and found that my previous\nanalysis was incorrect. This patch is therefore not needed.\n\nI'll drop this patch.\n\nSorry for the noise, and thanks.\n\nGuangshuo","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=gKXuQdC9;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35193-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"gKXuQdC9\"","smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=74.125.224.41","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxDTG51W7z1yDF\n\tfor ; Thu, 16 Apr 2026 20:17:06 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 251B630AB066\n\tfor ; Thu, 16 Apr 2026 10:15:15 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id CE879313558;\n\tThu, 16 Apr 2026 10:15:11 +0000 (UTC)","from mail-yx1-f41.google.com (mail-yx1-f41.google.com\n [74.125.224.41])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id BFB6739EF04\n\tfor ; Thu, 16 Apr 2026 10:15:09 +0000 (UTC)","by mail-yx1-f41.google.com with SMTP id\n 956f58d0204a3-6501d242e3fso7423241d50.0\n for ;\n Thu, 16 Apr 2026 03:15:09 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776334511; cv=pass;\n b=HXkFXwIBw+gyNrqimRHm0fEDNMQuPRq7kYP8cHj//F78x548uCJYrQfv7aeT3DdncrCxnVy3GYA8QU6Oj7WDzf0caOzsf2uqbf7DN2pAcS1M1QmjhuupWgVbyz3bW7Bfff9YITT5sM+dE6/Mm57dT2JEMxsf7agpWR7nN/7/3+A=","i=1; a=rsa-sha256; t=1776334509; cv=none;\n d=google.com; s=arc-20240605;\n b=CnRYVD+zcnjedliqXkpQfk5MxVOxZH2jwUOLj/Ijpa7Kk7xSqKAQAL8Bd1oEmvRIeR\n q7tpwDuZsd8pWT5oWNWeRT7XXZXDI89o2b6gTB8RqVGHa1bmDz/MEznGl43rvXiKtVCg\n j+PNdMa3BE9B/Zv4rt7xOVpfsebGf2sE1uf9O4EwWB6HmuJEyaeikES2pLj02pfzK/MV\n poSB4oZZUlS+HCUUDcdQApsNsQhhRBPpgCJ6vNjWMOQox5axg5FTyMBnns+HxVWWV6Pe\n rY3DUa0dWlnQvtJ/RjubRIla5ws5WN3Y64FQGZ0xfj0Z4OR8QNTffdhoeu/cjuA6e4UE\n 7aUw=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776334511; c=relaxed/simple;\n\tbh=W14sY8rFVQP5R86DvhFB8pwK3PIqD2viK/+q2E9YJ5A=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=heogdfqpenAxNvGHJmEvaiD2h04rVrYq8oniDwgduMhHqumy69JDBG2gz3xgvO8ASGyehwwDMis2dYTk7IR9/z2vmGb703egdrmF0Hn2DsBxSJTk0vf3l98d6gXDh11V+LWqRnGJnp807FKKY7pwqcj6hlSNgFkpsCKXlOG3RSE=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=MIU0mNT5q/kCll0NZpz4oa7I+7IP+1P1zx78jkbqb28=;\n fh=IfuqZzxv0CS6z09iAe0CSUIZLpHCMqx6xhJVTQflvVY=;\n b=bUSM8CPshpLdq7odxduntB9cDSHNVp9FZtFoYLp4wBq4Ot4hL3y64PlCqSjLlvAyCy\n tlL+Z7lpJe2g/0UhBidNdWd9BdVzHFioEaF6+HbtMPmA38t/J8yMf0LWpBAc8O2dZiFK\n 3GGVxmVRZmCsaNl3xnNvcZxONlZoaD6Mmj32Dnqm1iCJ5cb5bbUCK3aquVpDfw1qKS4j\n h2YzzUUCwITcOx2wlDNcq48Z0xNhLEj/k3a4B3E+TiAGOWIHQ87ogaWCKGwsIaLSmAh9\n T4oNIaSEB4LgzgOCaRcbs/aAsCfn4vX3/jA2Dde5QtWpihx6VSBiXvZ7BT/g6ftA8tye\n uAMg==;\n darn=vger.kernel.org"],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=gKXuQdC9; arc=pass smtp.client-ip=74.125.224.41","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776334509; x=1776939309;\n darn=vger.kernel.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=MIU0mNT5q/kCll0NZpz4oa7I+7IP+1P1zx78jkbqb28=;\n b=gKXuQdC91ojrprddfuB+MM5IqwwSTDX3RwvSyRUgLazw8NYB0gwlLSis5TQ5hfqGJ/\n 3n8oWodXQIc3Oepd0gK8snZoq6EUdx5d1IhNAU9vu2nxLslkGyBmOTpGjb8AMxPnRAGH\n 3qYYaj7pix3wE2VsIANblF6vCuIz46REiZBk/r+K3Ik9atZY+F7/VVC0I/jkyijkf0v0\n 3E3XQxildQhQlmwR2/HxjE99+zJwmGwVqLPIn0rxdZc215ttJUSvdgT22lb6s2MJ8Go+\n ebwp7NrOG8gtsmiU48hIbobm/zUSW0vxXg4yFUiD3BWOh9WQvbNJfjk1x7jNMGNOQF2c\n xUJw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776334509; x=1776939309;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=MIU0mNT5q/kCll0NZpz4oa7I+7IP+1P1zx78jkbqb28=;\n b=Ua0UKmC9HqNE2n5C5efPtHszrtS3iw0FhTPUzNrqe6Oo8cHeYtKlGpTjDsdyURohzO\n OHQ2kcWWIpNK0y8JX8sIlSgmjRfcubh2l+cCYHlktXXv3rBtEM6qcvxslM3n4Nln//bd\n J2R+/Zh/lPK6i3wKQln3sunxMt8C+M0SMo0ONolzIy4dQV9nrUZwrUu4L/lVo8NNIaSu\n QFu6GBy6zRSRFPLFj35rbdqmlSWkjgHvj72B6CNFRHR2gy+5Ws04Wz6yD8Wf1DeDHYht\n Lqde/mLAMSWJYJ+2R/J4FCw4YT4Vo/FLaZrsDlGUTQdtyuU4v18oSWN6sp3m2a/rGAKF\n 2zEg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9poPdSpxxxHgeuQWfB9q/oblZnhUUIaQMAeWmBdRjeQibcTnhllJuXvqmZDjxvySEoQVx2hlHOzMfW@vger.kernel.org","X-Gm-Message-State":"AOJu0YxdXt5GV8bqvVfAlQSXxuj9Xwh4umHHb5k9UCmgMNG+kmAiOfFU\n\tsyAWbcR9l0HDgdWYjzoNkvG+6SsOULpTB+cN7j8nPQX/jeGqjuGF9m2blHjizCd8198XZunOCQA\n\tYvURim7f+cPR6Mk7qGG71/dv6UH+ynK4=","X-Gm-Gg":"AeBDievcPNHF/U0wDxsdJ83UsDN6N0pyHSj++a7USNu57SupL5pLADl95jl66Deivmd\n\tOKimibDAECo3DVY6opsttske0EeQCP9moiRzb3k9Ni/yTQgHySy/n2EQ1AvGj4TQbaSlK+9gQe0\n\tR4NZHSyTy5obMym06yjKhZ6/qeRh1Ku2da0zIrnE96v20v3MgaegnfM4aYOov6zIWfSbRMxWvLu\n\tqGEG/VKQY0XTNXB4DaEJRjhup7xPgxFknZtqF0NqsTDJIGDTXWZQb565EhAsTxf0pspEfnJgJiJ\n\tP3hPgX9MnPFhJ5ws9AqR","X-Received":"by 2002:a53:df4a:0:b0:64a:d04e:a340 with SMTP id\n 956f58d0204a3-65198a57036mr16625320d50.11.1776334508728; Thu, 16 Apr 2026\n 03:15:08 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260412133356.2536585-1-lgs201920130244@gmail.com>","In-Reply-To":"<20260412133356.2536585-1-lgs201920130244@gmail.com>","From":"Guangshuo Li ","Date":"Thu, 16 Apr 2026 18:14:54 +0800","X-Gm-Features":"AQROBzAzpUVwDqsuwaFup_uU3Pw92c3_Go_sblTv00ait3DeiQxzl9cHn1aUjew","Message-ID":"\n ","Subject":"Re: [PATCH] misc: microchip: pci1xxxx: fix IRQ vector leak in\n gp_aux_bus_probe()","To":"\"Vaibhaav Ram T.L\" ,\n\tKumaravel Thiagarajan ,\n Arnd Bergmann ,\n\tGreg Kroah-Hartman , linux-gpio@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Cc":"stable@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}}]