[{"id":3676457,"web_url":"http://patchwork.ozlabs.org/comment/3676457/","msgid":"<14329248-0c4a-46a6-ae32-a30dc10dc1d0@linux.ibm.com>","date":"2026-04-13T05:22:44","subject":"Re: [PATCH v2] ppc/fadump: invoke kmsg_dump in fadump panic path","submitter":{"id":77202,"url":"http://patchwork.ozlabs.org/api/people/77202/","name":"Sourabh Jain","email":"sourabhjain@linux.ibm.com"},"content":"On 12/04/26 17:00, Shivang Upadhyay wrote:\n> fadump is registered in panic_notifier_list and gets triggered before\n> kmsg_dump_desc() in the panic path. As a result, kmsg_dumpers such as\n> pstore are not executed during fadump crashes.\n>\n> This is problematic because pstore provides a critical fallback mechanism\n> for crash analysis. When fadump fails to successfully reboot the system\n> or capture a dump, pstore logs may be the only available information from\n> the crashed kernel. Without invoking kmsg_dump_desc() in the fadump path,\n> we lose this valuable diagnostic data.\n>\n> Invoke kmsg_dump_desc() from the fadump panic handler, but only when\n> fadump is actually registered (checked via should_fadump_crash()). This\n> ensures kmsg_dumpers are called without duplicating the call that occurs\n> later in panic() when fadump is not active.\n>\n> The call is placed before crash_fadump() to ensure logs are captured\n> before the system attempts to trigger the firmware-assisted dump.\n>\n> Cc: Hari Bathini \n> Cc: Madhavan Srinivasan \n> Cc: Mahesh Salgaonkar \n> Cc: Michael Ellerman \n> Cc: Ritesh Harjani (IBM) \n> Reported-by: Shirisha G \n> Suggested-by: Sourabh Jain \n> Signed-off-by: Shivang Upadhyay \n> ---\n> Changelog:\n>\n> v2:\n> address comments from Sourabh, and sashikio-ai\n> added should_fadump_crash()\n>\n> v1:\n> https://lore.kernel.org/all/20260407054341.308710-1-shivangu@linux.ibm.com/\n> ---\n> arch/powerpc/kernel/setup-common.c | 8 ++++++++\n> 1 file changed, 8 insertions(+)\n>\n> diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c\n> index b1761909c23f..87afc8003a03 100644\n> --- a/arch/powerpc/kernel/setup-common.c\n> +++ b/arch/powerpc/kernel/setup-common.c\n> @@ -68,6 +68,7 @@\n> #include \n> #include \n> #include \n> +#include \n> \n> #include \"setup.h\"\n> \n> @@ -744,6 +745,13 @@ static int ppc_panic_fadump_handler(struct notifier_block *this,\n> \t */\n> \thard_irq_disable();\n> \n> +\t/*\n> +\t * Invoke kmsg_dump (e.g., pstore) before crash_fadump() as fadump\n> +\t * runs before panic()'s kmsg_dump_desc() call.\n> +\t */\n> +\tif (should_fadump_crash())\n> +\t\tkmsg_dump_desc(KMSG_DUMP_PANIC, (char *)ptr);\n> +\n> \t/*\n> \t * If firmware-assisted dump has been registered then trigger\n> \t * its callback and let the firmware handles everything else.\n\nChanges look good to me.\n\nFeel free to add:\nReviewed-by: Sourabh Jain \n\n- Sourabh Jain","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=H3H3jg26;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19661-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=148.163.156.1","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=H3H3jg26;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com\n (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n envelope-from=sourabhjain@linux.ibm.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvG5j1Kw8z1xtJ\n\tfor ; Mon, 13 Apr 2026 15:23:20 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fvG5Z549Hz2yrZ;\n\tMon, 13 Apr 2026 15:23:14 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n [148.163.156.1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fvG5Y29lwz2yFY\n\tfor ; Mon, 13 Apr 2026 15:23:12 +1000 (AEST)","from pps.filterd (m0360083.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63CBbPOL2314896;\n\tMon, 13 Apr 2026 05:22:54 GMT","from ppma12.dal12v.mail.ibm.com\n (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dfdt3p4m6-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tMon, 13 Apr 2026 05:22:53 +0000 (GMT)","from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1])\n\tby ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 63D2cOuG015149;\n\tMon, 13 Apr 2026 05:22:52 GMT","from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227])\n\tby ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4dg0msbwpf-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tMon, 13 Apr 2026 05:22:52 +0000","from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com\n [10.20.54.101])\n\tby smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63D5MmJN50987314\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tMon, 13 Apr 2026 05:22:48 GMT","from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id B8F3720043;\n\tMon, 13 Apr 2026 05:22:48 +0000 (GMT)","from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id C0E8320040;\n\tMon, 13 Apr 2026 05:22:45 +0000 (GMT)","from [9.124.215.143] (unknown [9.124.215.143])\n\tby smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP;\n\tMon, 13 Apr 2026 05:22:45 +0000 (GMT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776057794;\n\tcv=none;\n b=PopCslmglh4tQg1gDnJY02XAapnNakd5WwQZ9gz3aOxoSj50+OqSzCpv8D63XNCfKfdgKKHhx7RRByKhxJsNHmX1TJ1uG5EF10xmWSUsr4D2KRhvgL26H1dqSgypG9UtqJVao5kNQ0+6OfoDD3Ma8PdhY7YtujLivJheqDD5RCV/is86K2XvFMugJtt+HzNWH1jE0DicBsfMLJSnBW4LO2qA5Sx0FqyE5RMD5+CYfJfmMq2pQf9lgudNjlAfZy7KYrLY4+3K0I5CUijf2nlr0gcs2VfEXwDIMOXv3WeHTTttKnrReG+R2fb0SPW/arPuPVH3rKSWvsuRvjxheRUPsQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776057794; c=relaxed/relaxed;\n\tbh=UNt9bCxnTGM8jnsiit74ZajSXUFNNLBnJS/R7xGI86Y=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=S6O1eCU/qDWSOgv2kMUmQBjuxzNJaFDfmDed4jF9X4lHBclA1l6Y+DUDg2SZzRIxm6vWWGvG1os1SvlTNqG9yyerMcM5ZVXBD1uIBV1b/B5L41GYe2OJ6VpE72Kk22JY0qfhyDCHI5Zuu8ygJOMuERjcuNNqQ6QcBFHnbGbQnVgPlOiCnAW1RnAXbSbsKQDRpDBQeUFOtOOZ0pCUfiZn6FHcJyXMrhTk3EFi3PgF7ZYeeeRSaBKPzwhlw3jNalXZYAq8prvh1q8EnWqdIEg3vcWTxlEVElUYTZDjqpNpx2LkyzSVlEyqP2RkOgOM/eNNmtw6UjIdL28jiG/OWeI1LA==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=H3H3jg26; dkim-atps=neutral;\n spf=pass (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n envelope-from=sourabhjain@linux.ibm.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=pp1; bh=UNt9bC\n\txnTGM8jnsiit74ZajSXUFNNLBnJS/R7xGI86Y=; b=H3H3jg26ssDT9mvMI+fcx/\n\tRrBzIhiVpeopgV3/ZNUsWVhqYusUhpisKqHA9Fu8RoNg5TljgSnUUnb+mGfZeisn\n\tscg8/jv+SZQXJdfTRKHajRAMq6PdGnSxOUVVDlSKc6gJLGE6pLKQ60G0YMsbtOnI\n\tmxtJ+DgWfn21YKZzcnfkcXntJ8JuIO3JNiVSgRV6XpHUY/M+ZiaUKk0oeBe+i8Uc\n\tTbV0u77KKyWYuQJmFux5La1mWs1N74pARsGDGIoRjPdxncuejwkPO+fXebYj/ysI\n\tw/i0GdidFJiydcGryiUk7Ropq6V5Fb/YQDbwret+2NqNF4SwbBkc+GP67EfVY56w\n\t==","Message-ID":"<14329248-0c4a-46a6-ae32-a30dc10dc1d0@linux.ibm.com>","Date":"Mon, 13 Apr 2026 10:52:44 +0530","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2] ppc/fadump: invoke kmsg_dump in fadump panic path","To":"Shivang Upadhyay , linuxppc-dev@lists.ozlabs.org,\n linux-kernel@vger.kernel.org","Cc":"maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com,\n chleroy@kernel.org, kees@kernel.org, tony.luck@intel.com,\n gpiccoli@igalia.com, ritesh.list@gmail.com, rppt@kernel.org,\n Hari Bathini ,\n Mahesh Salgaonkar ,\n Shirisha G ","References":"<20260412113057.46090-1-shivangu@linux.ibm.com>","Content-Language":"en-US","From":"Sourabh Jain ","In-Reply-To":"<20260412113057.46090-1-shivangu@linux.ibm.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","X-Proofpoint-Reinject":"loops=2 maxloops=12","X-Proofpoint-ORIG-GUID":"IH7kdniHn2CQrGeMt-nnAP2bMNQD49cv","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDEzMDA0OCBTYWx0ZWRfX1KQbtbhDxdd7\n I3d0vR4GX7CcOAIMyDIb1DCpYv5hYsU6aOr50l9aeaMSRVhn+i6KZcTSlJ3S849S9YPWBkmTsUc\n HgXSIz3J+E1N3agwHmWwVeSnnikXip9sJ+YWAWwm49/55DmaEItwLcErnaeplYDvLYkGfvpR610\n vYphd1EujzNFtUYoXPeA9PqEkNB+nChphebUbOBauWILIg0GuqGzX8NCzmLyzN6ZJYsM7o2TqJM\n H7UFLcxelXYCvbbnLqeoftZnkrTOnNDk8T4psMd23rh9JsIxovpLkrbrXrTm9LajKco0ki9ZtjR\n XbkoUHVhKSWHkHRTv+SvSiRHY4JNceGpHj8LyNKG0LdNBz/fy6CcnoQmDgjDOwlubq8hsHq3t0o\n OF1Ba5SR2R2i2veCbei9x76D/8cq24nE9yNx3K0VSmaMfAgYRIXEkU3en9xph/2++hi2szaNiZT\n f4KIfKVRjAnx7pvyhAg==","X-Proofpoint-GUID":"xhwX0rdguQ3Lv0PIA7PbzktUBpLH2gFo","X-Authority-Analysis":"v=2.4 cv=WpEb99fv c=1 sm=1 tr=0 ts=69dc7dad cx=c_pps\n a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=iQ6ETzBq9ecOQQE5vZCe:22 a=VwQbUJbxAAAA:8\n a=VnNF1IyMAAAA:8 a=pGLkceISAAAA:8 a=AFqkCBWJvsyecdCc_mkA:9 a=QEXdDO2ut3YA:10","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-13_01,2026-04-09_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n priorityscore=1501 phishscore=0 bulkscore=0 adultscore=0 spamscore=0\n malwarescore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0\n impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000\n definitions=main-2604130048","X-Spam-Status":"No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,\n\tSPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}},{"id":3676459,"web_url":"http://patchwork.ozlabs.org/comment/3676459/","msgid":"<0497cd26faa406ca1cd7a6c49227eb439e18e270.camel@linux.ibm.com>","date":"2026-04-13T05:23:52","subject":"Re: [PATCH v2] ppc/fadump: invoke kmsg_dump in fadump panic path","submitter":{"id":91952,"url":"http://patchwork.ozlabs.org/api/people/91952/","name":"Shivang Upadhyay","email":"shivangu@linux.ibm.com"},"content":"On Mon, 2026-04-13 at 10:52 +0530, Sourabh Jain wrote:\n> Changes look good to me.\n> \n> Feel free to add:\n> Reviewed-by: Sourabh Jain \n> \n> - Sourabh Jain\n\nThanks\n~Shivang.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=kjbxUZ8P;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19662-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=148.163.156.1","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=kjbxUZ8P;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com\n (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n envelope-from=shivangu@linux.ibm.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvG6V1gHyz1xtJ\n\tfor ; Mon, 13 Apr 2026 15:24:02 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fvG6V0gLrz2yrZ;\n\tMon, 13 Apr 2026 15:24:02 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n [148.163.156.1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fvG6T1wKVz2yFY\n\tfor ; Mon, 13 Apr 2026 15:24:01 +1000 (AEST)","from pps.filterd (m0353729.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63CKbKeL3050353;\n\tMon, 13 Apr 2026 05:23:59 GMT","from ppma23.wdc07v.mail.ibm.com\n (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dfdyqp2hw-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tMon, 13 Apr 2026 05:23:59 +0000 (GMT)","from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1])\n\tby ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 63D45gll004188;\n\tMon, 13 Apr 2026 05:23:58 GMT","from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226])\n\tby ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4dg24k3pyg-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tMon, 13 Apr 2026 05:23:58 +0000","from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com\n [10.20.54.102])\n\tby smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63D5Nst549152286\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tMon, 13 Apr 2026 05:23:54 GMT","from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 2C1BE20043;\n\tMon, 13 Apr 2026 05:23:54 +0000 (GMT)","from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 575D820040;\n\tMon, 13 Apr 2026 05:23:53 +0000 (GMT)","from shivang.upadyay (unknown [9.123.12.247])\n\tby smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP;\n\tMon, 13 Apr 2026 05:23:53 +0000 (GMT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776057841;\n\tcv=none;\n b=OtP5ivgfLnUldSYyeApFazZh5IPgECUEfRsPqq+NUIpbmD+FX0JqwbKwVDcaBx6OxyaGBu+l55qGu9Kj6pUUMOdrA7SCKqEgbwyFU3QjhFugQdbNyMHdiGWxQGA9ZXaDjihiLYMaCCqA0hq6F3KzRBJ/jYfFW+vSoMvcPGvGvz4hMuk/lKOh4mYcjE/N2pW77nXEq2M54CFPsLd3Lzs0/JkjGBwqUxBaQD/GDn19uGlh15Qc0NZtzWIDOd/7TTHVXW6qRp4evsuSHOGSj/83vIeCZ2KmPrPE9shkzpkroFYMn9alp4oMZ8hgqDaKJicCrWy0sRr81YT0ANP24MkbBA==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776057841; c=relaxed/relaxed;\n\tbh=g66oGdErVbAYwnMXLsa/Q1L8W4j7ho6qdSj1fbUkMpQ=;\n\th=Message-ID:Subject:From:To:Date:In-Reply-To:References:\n\t Content-Type:MIME-Version;\n b=ijVT3RrUnvVZEYwmctFiS82SkJEBUNxUvUEX+ZBskq3Gz+PZ2U15L6s7Cxx8yAh/QPJ5Jpsp0fSJ0N2P1/dcxi+bL68HTjajE1CiW8SqRitbI1v1IYKHRkigkPJlMvyFu2z1O+2eAA44m6INzg/JAOwyZ3l4G0Pmt27IR8/mMkPWkKa/eum4HLJr7z5FBc3l54pGGhO+/9V/EevjM5/ZnegOPns223GxnNrx9FgcZwgCjl023bN4YERMlOxxWNxMsRYaKLkh0xbcJXosM8V0FdIHRECZo4UT6wltOHe4uuuFPWwBtPo6nS6JrGwF1SHH08htil4J6/BbeyDT3G0hyw==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=kjbxUZ8P; dkim-atps=neutral;\n spf=pass (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n envelope-from=shivangu@linux.ibm.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=\n\tcontent-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=pp1; bh=g66oGd\n\tErVbAYwnMXLsa/Q1L8W4j7ho6qdSj1fbUkMpQ=; b=kjbxUZ8P5yNrXj0RLkn9ab\n\tZ5d/gZnHue0E0nmyJg4Fa4Oi0+b8/2uJtl7Xb2IMFfmMbFpuRLYmpq7C4D57ERQO\n\tq5qqLuaRit0uyJE4+DJgyGOxR6WRaWbsxonsz3t/3/A5FIkqR6pNWr9Ej0kD93Up\n\tsEoXzn3hGYe2Gaj8GKD4hikk7MEuHfgOTXQlXwMj8ghD6IGacz51NcrKWcbtbMn2\n\tlS3yEeMf44l+fg+GAMp19/30hWcBKb82SiI68FlO04H+g7NxjAPA2WEkOTObe3fr\n\tNAfxiefokbI4FBaQfFtzGUyXhvZ/k0FU2MVLstvEZQSoPxnBAbO3YrDVnoP2NCXg\n\t==","Message-ID":"<0497cd26faa406ca1cd7a6c49227eb439e18e270.camel@linux.ibm.com>","Subject":"Re: [PATCH v2] ppc/fadump: invoke kmsg_dump in fadump panic path","From":"Shivang Upadhyay ","To":"Sourabh Jain , linuxppc-dev@lists.ozlabs.org,\n linux-kernel@vger.kernel.org","Date":"Mon, 13 Apr 2026 10:53:52 +0530","In-Reply-To":"<14329248-0c4a-46a6-ae32-a30dc10dc1d0@linux.ibm.com>","References":"<20260412113057.46090-1-shivangu@linux.ibm.com>\n\t <14329248-0c4a-46a6-ae32-a30dc10dc1d0@linux.ibm.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","User-Agent":"Evolution 3.56.2 (3.56.2-2.fc42) ","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","X-TM-AS-GCONF":"00","X-Authority-Analysis":"v=2.4 cv=ErTiaycA c=1 sm=1 tr=0 ts=69dc7def cx=c_pps\n a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=uAbxVGIbfxUO_5tXvNgY:22 a=VnNF1IyMAAAA:8\n a=_bbIk2df9rHDcjtLxoMA:9 a=QEXdDO2ut3YA:10","X-Proofpoint-ORIG-GUID":"eJXS3q62LQ0PGvuHM0UFmDSnMY5Sg9Zk","X-Proofpoint-GUID":"eJXS3q62LQ0PGvuHM0UFmDSnMY5Sg9Zk","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDEzMDA0OCBTYWx0ZWRfXxrsQ//tUNO1c\n Ypt7NmytglLsvoPDiE4TYsehyJXJUBcS0N8Cmy51IQbS0cnCkgyns1xAd+81k9ZW8ghGu/U+UQc\n d1O7dGbUO0RPOhmKL6M0xXn8LWwbTfPd6h9hBYgly8a5NWUYz9vhlujPjzWLMZVbueD+8T7kp4Q\n 10y/B291AeHBuqGSFze+V1g7s59ryksv7aBAuiqi5H9Sd1dpm4Smo0OL+jWQpvJOAzmezCpXBTK\n sBSPgT9YCKOZ7amWt5xQLbZAMxvIbi8tPTCIX1ONz2baBkWYXVCEYWQ2gzfyGoO2+B/NCznq4iG\n M+LvzzwZuuE5Vf9gJ68Sy3uItVUxb9Pd9kkW41KprA76e+Pr5wr7UPe+FxIwYcczFawQTu8mQer\n +ne8mDNxRpsZ9CN1QCBb1PsfLDoZMGorz3Id69QAktIGXqZXLloQ9GcnBMAmlqa+Yt7y1sR4lcm\n PtJFIFPgKFeyij6zZHw==","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-13_01,2026-04-09_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n malwarescore=0 adultscore=0 suspectscore=0 bulkscore=0 clxscore=1015\n priorityscore=1501 lowpriorityscore=0 phishscore=0 spamscore=0\n impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000\n definitions=main-2604130048","X-Spam-Status":"No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,\n\tSPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}},{"id":3676627,"web_url":"http://patchwork.ozlabs.org/comment/3676627/","msgid":"","date":"2026-04-13T10:11:01","subject":"Re: [PATCH v2] ppc/fadump: invoke kmsg_dump in fadump panic path","submitter":{"id":74752,"url":"http://patchwork.ozlabs.org/api/people/74752/","name":"Mahesh J Salgaonkar","email":"mahesh@linux.ibm.com"},"content":"On 2026-04-12 17:00:57 Sun, Shivang Upadhyay wrote:\n> fadump is registered in panic_notifier_list and gets triggered before\n> kmsg_dump_desc() in the panic path. As a result, kmsg_dumpers such as\n> pstore are not executed during fadump crashes.\n> \n> This is problematic because pstore provides a critical fallback mechanism\n> for crash analysis. When fadump fails to successfully reboot the system\n> or capture a dump, pstore logs may be the only available information from\n> the crashed kernel. Without invoking kmsg_dump_desc() in the fadump path,\n> we lose this valuable diagnostic data.\n> \n> Invoke kmsg_dump_desc() from the fadump panic handler, but only when\n> fadump is actually registered (checked via should_fadump_crash()). This\n> ensures kmsg_dumpers are called without duplicating the call that occurs\n> later in panic() when fadump is not active.\n> \n> The call is placed before crash_fadump() to ensure logs are captured\n> before the system attempts to trigger the firmware-assisted dump.\n> \n> Cc: Hari Bathini \n> Cc: Madhavan Srinivasan \n> Cc: Mahesh Salgaonkar \n> Cc: Michael Ellerman \n> Cc: Ritesh Harjani (IBM) \n> Reported-by: Shirisha G \n> Suggested-by: Sourabh Jain \n> Signed-off-by: Shivang Upadhyay \n> ---\n> Changelog:\n> \n> v2:\n> address comments from Sourabh, and sashikio-ai\n> added should_fadump_crash()\n> \n> v1:\n> https://lore.kernel.org/all/20260407054341.308710-1-shivangu@linux.ibm.com/\n> ---\n> arch/powerpc/kernel/setup-common.c | 8 ++++++++\n> 1 file changed, 8 insertions(+)\n> \n> diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c\n> index b1761909c23f..87afc8003a03 100644\n> --- a/arch/powerpc/kernel/setup-common.c\n> +++ b/arch/powerpc/kernel/setup-common.c\n> @@ -68,6 +68,7 @@\n> #include \n> #include \n> #include \n> +#include \n> \n> #include \"setup.h\"\n> \n> @@ -744,6 +745,13 @@ static int ppc_panic_fadump_handler(struct notifier_block *this,\n> \t */\n> \thard_irq_disable();\n> \n> +\t/*\n> +\t * Invoke kmsg_dump (e.g., pstore) before crash_fadump() as fadump\n> +\t * runs before panic()'s kmsg_dump_desc() call.\n> +\t */\n> +\tif (should_fadump_crash())\n> +\t\tkmsg_dump_desc(KMSG_DUMP_PANIC, (char *)ptr);\n> +\n\nLooks good to me.\n\nReviewed-by: Mahesh Salgaonkar \n\nThanks,\n-Mahesh.\n> \t/*\n> \t * If firmware-assisted dump has been registered then trigger\n> \t * its callback and let the firmware handles everything else.\n> -- \n> 2.53.0\n> \n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=dtoIgWwD;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19676-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=148.163.158.5","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=dtoIgWwD;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com\n (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com;\n envelope-from=mahesh@linux.ibm.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvNVB3q31z1y2d\n\tfor ; Mon, 13 Apr 2026 20:11:30 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fvNV96pVrz2yrZ;\n\tMon, 13 Apr 2026 20:11:29 +1000 (AEST)","from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n [148.163.158.5])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fvNV81mw3z2ySb\n\tfor ; Mon, 13 Apr 2026 20:11:27 +1000 (AEST)","from pps.filterd (m0353725.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63D0vT4x3430311;\n\tMon, 13 Apr 2026 10:11:11 GMT","from ppma23.wdc07v.mail.ibm.com\n (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dfcqexu3h-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tMon, 13 Apr 2026 10:11:10 +0000 (GMT)","from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1])\n\tby ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 63D9JnEA004175;\n\tMon, 13 Apr 2026 10:11:09 GMT","from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226])\n\tby ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4dg24k4k3r-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tMon, 13 Apr 2026 10:11:09 +0000","from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com\n [10.20.54.106])\n\tby smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63DAB5Bk52691238\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tMon, 13 Apr 2026 10:11:05 GMT","from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id C541F2004F;\n\tMon, 13 Apr 2026 10:11:05 +0000 (GMT)","from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 4654E20063;\n\tMon, 13 Apr 2026 10:11:03 +0000 (GMT)","from linux.ibm.com (unknown [9.123.6.78])\n\tby smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTPS;\n\tMon, 13 Apr 2026 10:11:03 +0000 (GMT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776075089;\n\tcv=none;\n b=eCSadW4G+mhaimYQVoAiEbehGQpGgq50Q73zwc5ajNoikEP5frZ2q2aovI6lTPhojhq0Sjs9v5SFHuhonW7c5Tb9EmTy2Tqj1IUBmvx38C6Pt4rARIo3pf+Xx+StbturkMn7mUEfmXhumrCniP8YJK4PHyDZDQWZBm0c4oDblS3BWegIp6J/Z7VTMZg4yuFrbC/EW89jyh43c1kSvHYMPWh5f7vB11UctUfKkj0aMWVGoTKuz8jt9aVDrB/XYDGwzYDXoqGiZofjqSEfthkwkZlCm43TEzWfMbA+3s58z5uhnKWyqadHIACLXl94HDbLIi6L5s95mPv8vr5GRc1Lnw==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776075089; c=relaxed/relaxed;\n\tbh=AWDfc31HqOX7X7I9EB451LOTOynfK5gKa0CUNeVaAXU=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=a2Pcd2crXwH+AgfqLAQf2VUzZGHcOP3tTMgBhKUYweis6IOafFDiaLq8y3mZVr/RQR42adiRenChNnsScWyOiR00KXFQHi4fahOOhoo1QPOKiczAa7G7tm3h1LJPGQQXw4qXXTuV6hblWNpzMg2DNxdoTX4BGPdHmLDAytmWEWsx35uY0BR/eaJeQyHIjy/ysOYq5gi1WGhKyaBBL8pQH9DNeSmNBL1NqtC/iq90KHM+eb1fAxO3psxvcyoDr4hAM2QpYT1zvknaDfgXq9A82fALr5RRI7H8xKYC0eIEt0tebfvJ40ntcnhv4skokwMn5GwNIa3TMb6PUuF0KBgk0w==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=dtoIgWwD; dkim-atps=neutral;\n spf=pass (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com;\n envelope-from=mahesh@linux.ibm.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-type:date:from:in-reply-to:message-id:mime-version\n\t:references:reply-to:subject:to; s=pp1; bh=AWDfc31HqOX7X7I9EB451\n\tLOTOynfK5gKa0CUNeVaAXU=; b=dtoIgWwDRm8irWjEDjG4JEgGChgfR7ubyDgc6\n\tFjYjL4pP4ry1kGgEVXoys+hM83E4V3kaCYD6ohi1MVzw1mHoqKninEtgtKAJZ8HX\n\t3qkgDcuYa1DqUSOeD/Iq7l6cfBzJlxI2ucMv8d5WUJF2PEc/1r4HibwzoeukFnE9\n\tMu4p/n6/O5KrVRV2DoyEEUhzr6Q5ohcopMPUMNyuWdM6CXd0ywtJ0jT8fxvG8tRd\n\tmkywTNkataNWQXav2SqM81t5fcj9A81J2rPTSacXLVBgKqTRM6NRiIdyTzxGHUZ6\n\tHqOqvXcUfLqijCVPn6zh5GGiUl31KMg4f083/kXOxPM1CvhDA==","Date":"Mon, 13 Apr 2026 15:41:01 +0530","From":"Mahesh J Salgaonkar ","To":"Shivang Upadhyay ","Cc":"linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,\n maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com,\n chleroy@kernel.org, kees@kernel.org, tony.luck@intel.com,\n gpiccoli@igalia.com, ritesh.list@gmail.com, rppt@kernel.org,\n Hari Bathini ,\n Shirisha G ,\n Sourabh Jain ","Subject":"Re: [PATCH v2] ppc/fadump: invoke kmsg_dump in fadump panic path","Message-ID":"","Reply-To":"mahesh@linux.ibm.com","References":"<20260412113057.46090-1-shivangu@linux.ibm.com>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260412113057.46090-1-shivangu@linux.ibm.com>","X-TM-AS-GCONF":"00","X-Proofpoint-Reinject":"loops=2 maxloops=12","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDEzMDA5NiBTYWx0ZWRfX4vAbFqFtr/TX\n gk3cBypSkJIvCUd6LxpxK/JrZYi7eIwgk3ujaunEs9Lm/3ODuIdr7CanqGneSGsDULJFwkoUYYI\n WDagmIJOa1KAnFHQ6E6uQZZesC41UaEfTRp7gm6eJX4yRO43bt/TgHrk/MauV8mqxO0QnSrQtao\n 71rzOWKOC5ubcEgoeWqN96H+fsrox4vV7CqBfay3juhlQuIuXQbFt4jfACyyKQbMgcxr80w95rz\n Z2uUbaYqnoaBRGKHhPyjc/MzCy9ETJGX5+inEYW+ub2G4NkxgATaqpmySz0M6Cf9c6WOdJoQdCK\n T8303Yp0j1eyHReBVhXV/+UGUuLSkaSSFBZF5onHWjJPSJX6F5b6/nRjCfq0V09RxgWf9PqYEkO\n EePYEXps6UialenVDh0bZvScFuvVb2O6IkugIQq6NLuYFb0ae4R2TImG7GzWPSnHLqD+oP37ffb\n OwUVNpvDPO15p7IpJ4Q==","X-Proofpoint-GUID":"B60NViVCc_7uerikIIw-TolAXwccSV9d","X-Proofpoint-ORIG-GUID":"7ar2RWTPLcEOZG4C2B4Gt9QJGO15uhhi","X-Authority-Analysis":"v=2.4 cv=YemNIQRf c=1 sm=1 tr=0 ts=69dcc13e cx=c_pps\n a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17\n a=kj9zAlcOel0A:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=VwQbUJbxAAAA:8\n a=VnNF1IyMAAAA:8 a=pGLkceISAAAA:8 a=WMeMqPS48f8hHYZQQtcA:9 a=CjuIK1q_8ugA:10","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-13_02,2026-04-13_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n spamscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1011\n impostorscore=0 bulkscore=0 malwarescore=0 suspectscore=0 phishscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604130096","X-Spam-Status":"No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,\n\tSPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}},{"id":3677459,"web_url":"http://patchwork.ozlabs.org/comment/3677459/","msgid":"<94c902b07348fc8f406590c923387a532db4b7c6.camel@linux.ibm.com>","date":"2026-04-15T04:41:05","subject":"Re: [PATCH v2] ppc/fadump: invoke kmsg_dump in fadump panic path","submitter":{"id":87143,"url":"http://patchwork.ozlabs.org/api/people/87143/","name":"Shirisha ganta","email":"shirisha@linux.ibm.com"},"content":"On Sun, 2026-04-12 at 17:00 +0530, Shivang Upadhyay wrote:\n> fadump is registered in panic_notifier_list and gets triggered before\n> kmsg_dump_desc() in the panic path. As a result, kmsg_dumpers such as\n> pstore are not executed during fadump crashes.\n> \n> This is problematic because pstore provides a critical fallback\n> mechanism\n> for crash analysis. When fadump fails to successfully reboot the\n> system\n> or capture a dump, pstore logs may be the only available information\n> from\n> the crashed kernel. Without invoking kmsg_dump_desc() in the fadump\n> path,\n> we lose this valuable diagnostic data.\n> \n> Invoke kmsg_dump_desc() from the fadump panic handler, but only when\n> fadump is actually registered (checked via should_fadump_crash()).\n> This\n> ensures kmsg_dumpers are called without duplicating the call that\n> occurs\n> later in panic() when fadump is not active.\n> \n> The call is placed before crash_fadump() to ensure logs are captured\n> before the system attempts to trigger the firmware-assisted dump.\n> \n> Cc: Hari Bathini \n> Cc: Madhavan Srinivasan \n> Cc: Mahesh Salgaonkar \n> Cc: Michael Ellerman \n> Cc: Ritesh Harjani (IBM) \n> Reported-by: Shirisha G \n> Suggested-by: Sourabh Jain \n> Signed-off-by: Shivang Upadhyay \n> ---\n\nHi,\nTested this patch and dmesg-nvram file under /sys/fs/pstore is\ngetting updated with this patch after triggering dump with fadump\n\nwithout this patch:\n# ls -ltrh\ntotal 0\n-r--r--r--. 1 root root 6.5K Apr 2 06:22 dmesg-nvram-1\n-r--r--r--. 1 root root 2.6K Apr 15 00:07 powerpc-common-nvram-6\n-r--r--r--. 1 root root 2.1K Apr 15 00:07 rtas-nvram-1\n-r--r--r--. 1 root root 688 Apr 15 00:07 powerpc-ofw-nvram-5\n\nWith this patch:\n# ls -ltrh\ntotal 0\n-r--r--r--. 1 root root 6.4K Apr 15\n00:36 dmesg-nvram-1\n-r--r--r--. 1 root root 2.6K Apr 15 00:37 powerpc-\ncommon-nvram-6\n-r--r--r--. 1 root root 2.1K Apr 15 00:37 rtas-nvram-1\n-r-\n-r--r--. 1 root root 688 Apr 15 00:37 powerpc-ofw-nvram-5\n\n\nPlease add\nbelow tag\nTested-by: Shirisha G \n> Changelog:\n> \n> v2:\n> address comments from Sourabh, and sashikio-ai\n> added should_fadump_crash()\n> \n> v1:\n> \n> https://lore.kernel.org/all/20260407054341.308710-1-shivangu@linux.ibm.com/\n> ---\n> arch/powerpc/kernel/setup-common.c | 8 ++++++++\n> 1 file changed, 8 insertions(+)\n> \n> diff --git a/arch/powerpc/kernel/setup-common.c\n> b/arch/powerpc/kernel/setup-common.c\n> index b1761909c23f..87afc8003a03 100644\n> --- a/arch/powerpc/kernel/setup-common.c\n> +++ b/arch/powerpc/kernel/setup-common.c\n> @@ -68,6 +68,7 @@\n> #include \n> #include \n> #include \n> +#include \n> \n> #include \"setup.h\"\n> \n> @@ -744,6 +745,13 @@ static int ppc_panic_fadump_handler(struct\n> notifier_block *this,\n> \t */\n> \thard_irq_disable();\n> \n> +\t/*\n> +\t * Invoke kmsg_dump (e.g., pstore) before crash_fadump() as\n> fadump\n> +\t * runs before panic()'s kmsg_dump_desc() call.\n> +\t */\n> +\tif (should_fadump_crash())\n> +\t\tkmsg_dump_desc(KMSG_DUMP_PANIC, (char *)ptr);\n> +\n> \t/*\n> \t * If firmware-assisted dump has been registered then trigger\n> \t * its callback and let the firmware handles everything else.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=Uli8ofuw;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19748-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=148.163.158.5","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=Uli8ofuw;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com\n (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com;\n envelope-from=shirisha@linux.ibm.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwT4l5ZQNz1yCv\n\tfor ; Wed, 15 Apr 2026 14:41:42 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fwT4c6Wwjz2yvT;\n\tWed, 15 Apr 2026 14:41:36 +1000 (AEST)","from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n [148.163.158.5])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fwT4b3kjDz2xS3\n\tfor ; Wed, 15 Apr 2026 14:41:34 +1000 (AEST)","from pps.filterd (m0356516.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63F3qqMx1860603;\n\tWed, 15 Apr 2026 04:41:15 GMT","from ppma11.dal12v.mail.ibm.com\n (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dh89pdyvw-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tWed, 15 Apr 2026 04:41:14 +0000 (GMT)","from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1])\n\tby ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 63ENCxrD025809;\n\tWed, 15 Apr 2026 04:41:14 GMT","from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224])\n\tby ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4dg3b1mepu-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tWed, 15 Apr 2026 04:41:14 +0000","from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com\n [10.20.54.102])\n\tby smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63F4fAqx28574186\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tWed, 15 Apr 2026 04:41:10 GMT","from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 97BA320040;\n\tWed, 15 Apr 2026 04:41:10 +0000 (GMT)","from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 0CDB720043;\n\tWed, 15 Apr 2026 04:41:07 +0000 (GMT)","from li-d12addcc-2792-11b2-a85c-bd8df30615ab.ibm.com (unknown\n [9.43.92.110])\n\tby smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP;\n\tWed, 15 Apr 2026 04:41:06 +0000 (GMT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776228096;\n\tcv=none;\n b=TKdImWKpDx1QjV7UZQe79zTnIfKQL0IL4ok+EFJUtyAsdIoDY2AsubCdgwP91KvlPoJ4/m1/iZj4nAhudNQatMNYmYBGQjQggKzv9z5kOxBnHPOpI/NpXtyZEkHIvqoxWv6E+rxQMnW3YOWjV3306gZdawLb6g+TQzPhhplGB0nXpPHWJwDsAk46pB3z/Z8CjJcFszLO6Ra9jPg95nVL4azS+pSsaIEJ2TXabWdbOTTr/HFfQu0g3fdjBy+CLXdg0HdXDb7xYacaSnw2l88LYFsR1MWL7l0XY0oxUxfcz+IBa8hxahy/9PpWifGbxuX0xCceiyT+vGy1hD/V96dlyg==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776228096; c=relaxed/relaxed;\n\tbh=SlXVWEDwM3MxJBKrS8GwnOlBHVkSM0XuaX2fOdWoAkQ=;\n\th=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References:\n\t Content-Type:Mime-Version;\n b=DYYfl/GbqNZm0cCEoNyjAtzCI2RlEz01g106uZqCsHOdoRUbo8q8TryS6y6tJm8XpGM3GPL8KcPJzTqvYmo3r5ibA7A2RCsuVNhsw3NiMMc6YswszEQzVld0fVcPIwjrCFJW54wYc4nlDPiJDJyrGysVdsEe4QGRdIHVSqaxIk3qmIjlEiUQxeoIHRd58lWeHbUJEhHB1kWhdlaOt070YKnnawYpiT4qhFrtHFzmt/0zpVgoJXH+Rwri9NG+VbaZTPdCm2g+cX/tsye6SYW+AUHs6OP9PS29WZSKHCP58tWASKwg3JL3Q1oUYCVy9DTRqqd7NlrshLrmfY7M8l8iVg==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=Uli8ofuw; dkim-atps=neutral;\n spf=pass (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com;\n envelope-from=shirisha@linux.ibm.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=pp1; bh=SlXVWE\n\tDwM3MxJBKrS8GwnOlBHVkSM0XuaX2fOdWoAkQ=; b=Uli8ofuwWMlU6UMu5+CFhp\n\tKfyD68ePINV1IWdFybu5RIp+tMESUS3VuECoLy/FEkUEvCCwp8ZVI+cKxSRy9VgN\n\tKlVyVoaB8ZOQeC/qzzllW+aCZ+ucM7ubvpWotDsFefGRvwqw9dkZhiw6LQMkRNBz\n\t4dP3JiEM3wQxevD7FyB3X0/3Req/IpOUbvDaXzaHhRYb44AL4dIx0V11X0cJ1Wtx\n\tW4uh8Am3mEQluF6DRXsQqSa1haoq1CyzcTRoTXd8l5ez6xbkz78GzFI6Iuve02sv\n\t+Y1jSgfw54xw4OzML3CwOLgS2i6Dp0RmT0NowPbwWiSklgu2eWUH5M/NUfQ3dDWw\n\t==","Message-ID":"<94c902b07348fc8f406590c923387a532db4b7c6.camel@linux.ibm.com>","Subject":"Re: [PATCH v2] ppc/fadump: invoke kmsg_dump in fadump panic path","From":"Shirisha ganta ","To":"Shivang Upadhyay , linuxppc-dev@lists.ozlabs.org,\n linux-kernel@vger.kernel.org","Cc":"maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com,\n chleroy@kernel.org, kees@kernel.org, tony.luck@intel.com,\n gpiccoli@igalia.com, ritesh.list@gmail.com, rppt@kernel.org,\n Hari Bathini\n ,\n Mahesh Salgaonkar ,\n Sourabh Jain ","Date":"Wed, 15 Apr 2026 10:11:05 +0530","In-Reply-To":"<20260412113057.46090-1-shivangu@linux.ibm.com>","References":"<20260412113057.46090-1-shivangu@linux.ibm.com>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.28.5 (3.28.5-26.el8_10) ","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","X-Proofpoint-Reinject":"loops=2 maxloops=12","X-Proofpoint-GUID":"68ROyXmkRqmFLvjzxpK4EqU-2elquNs3","X-Proofpoint-ORIG-GUID":"_-vnYKujRhQ-vj7A0pf_FN45EzjgBhh7","X-Authority-Analysis":"v=2.4 cv=WbE8rUhX c=1 sm=1 tr=0 ts=69df16eb cx=c_pps\n a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=Y2IxJ9c9Rs8Kov3niI8_:22 a=VwQbUJbxAAAA:8\n a=VnNF1IyMAAAA:8 a=pGLkceISAAAA:8 a=kTg7Ve40sHeub7HmClsA:9 a=QEXdDO2ut3YA:10","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDE1MDAzNyBTYWx0ZWRfX50sGbHGiW6Ua\n fHLTNb3kTBNQG3Pp+UM+YRTHILxgbpg1ps8hASaYGq2Ve2DAYK7LoZbqFJwW6pCkCrVhnyxeDcG\n G8TurZrUXz6C2/YSOF8Ab2Db9VEEjpZshvffi6SmDG+EF/cFygaZvw+FQUl9zIm+C2WW7bDSMSb\n 8ECxNbPRnqWKbWizZRDlmdGtagveIB4iN51WfMB98Pm1TKF4wIg0pt0CtdGK86M2H43TeFA/1co\n N17rcNCEpzNEC4G8kXDuAErXJfCcCdTt+Qtr5GpOI53qw2f4mt8yAQAy81goGw2czsoFAY5wSbq\n j1CtoZzX6Gsh90Wv4cmsiqDEGgNqQ4dPlxYINCacedSL8LnPc+WOg7TPpcnlsrSIHRE4E509/pt\n ZfqCPUWhq/hGyGzVXl41TeFP7PqDHCesIKiWxZ+n5jI9+2CLs9tpVOledQz69eaqA2rv05qBBia\n MXxfcC6J8uoauuXet3Q==","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-14_04,2026-04-13_04,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n suspectscore=0 bulkscore=0 priorityscore=1501 spamscore=0 clxscore=1011\n phishscore=0 impostorscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604150037","X-Spam-Status":"No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,\n\tSPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]