[{"id":3676518,"web_url":"http://patchwork.ozlabs.org/comment/3676518/","msgid":"","list_archive_url":null,"date":"2026-04-13T07:37:37","subject":"Re: [PATCH 2/2] staging: media: tegra-video: add missing error\n checks in vi_tpg_fmts_bitmap_init()","submitter":{"id":389,"url":"http://patchwork.ozlabs.org/api/people/389/","name":"Dan Carpenter","email":"error27@gmail.com"},"content":"On Sun, Apr 12, 2026 at 10:48:08AM +0200, Alexandru Hossu wrote:\n> tegra_get_format_idx_by_code() returns -1 when the requested format is\n> not found in the SoC format table. vi_tpg_fmts_bitmap_init() does not\n> check this return value before passing it to bitmap_set(). A negative\n> index converted to unsigned would result in an out-of-bounds memory\n> access, corrupting adjacent kernel memory.\n> \n> Add WARN_ON() guards so that any future SoC addition or Kconfig change\n> that exposes this path fails loudly rather than silently corrupting memory.\n> \n> Signed-off-by: Alexandru Hossu \n> ---\n\npatch 1 is missing. Also the little change log under the --- is missing.\nhttps://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/\nAnd I want you do change the commit message to say that it's not a real\nlife bugfix.\n\n> drivers/staging/media/tegra-video/vi.c | 16 ++++++++++++++--\n> 1 file changed, 14 insertions(+), 2 deletions(-)\n> \n> diff --git a/drivers/staging/media/tegra-video/vi.c b/drivers/staging/media/tegra-video/vi.c\n> index afc7327ef318..d1d934e361f7 100644\n> --- a/drivers/staging/media/tegra-video/vi.c\n> +++ b/drivers/staging/media/tegra-video/vi.c\n> @@ -1017,7 +1017,7 @@ static int tegra_channel_setup_ctrl_handler(struct tegra_vi_channel *chan)\n> }\n> \n> /* VI only support 2 formats in TPG mode */\n> -static void vi_tpg_fmts_bitmap_init(struct tegra_vi_channel *chan)\n> +static int vi_tpg_fmts_bitmap_init(struct tegra_vi_channel *chan)\n> {\n> \tint index;\n> \n> @@ -1025,12 +1025,22 @@ static void vi_tpg_fmts_bitmap_init(struct tegra_vi_channel *chan)\n> \n> \tindex = tegra_get_format_idx_by_code(chan->vi,\n> \t\t\t\t\t MEDIA_BUS_FMT_SRGGB10_1X10, 0);\n> +\tif (index < 0) {\n> +\t\tdev_err(chan->vi->dev, \"format SRGGB10_1X10 not found\\n\");\n> +\t\treturn -EINVAL;\n\nChange tegra_get_format_idx_by_code() to return -EINVAL instead.\n\nregards,\ndan carpenter","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=Y2wJYjxW;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13733-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"Y2wJYjxW\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.221.45","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvKCP3dVwz1yGg\n\tfor ; Mon, 13 Apr 2026 17:43:29 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 26DB030427E3\n\tfor ; Mon, 13 Apr 2026 07:37:44 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id EC8CB396B8E;\n\tMon, 13 Apr 2026 07:37:43 +0000 (UTC)","from mail-wr1-f45.google.com (mail-wr1-f45.google.com\n [209.85.221.45])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E401396B76\n\tfor ; Mon, 13 Apr 2026 07:37:42 +0000 (UTC)","by mail-wr1-f45.google.com with SMTP id\n ffacd0b85a97d-43d75312379so550482f8f.1\n for ;\n Mon, 13 Apr 2026 00:37:42 -0700 (PDT)","from localhost ([196.207.164.177])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d6f4bf2b4sm15213667f8f.20.2026.04.13.00.37.39\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 13 Apr 2026 00:37:40 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776065863; cv=none;\n b=fks3buCLTH/EOthlXwsmXuORSm5r56T+VbKgjROwpWd37fDSTsDPWh8XMYdUh6zW9kelK6Vra+M9vmET8t32xMo+vR4kSKjPxPmMjLiF+zZPZuMAf5rhiDENXi0015LzaA9aFAy4VjTozcS2FzDIp0++t3+943F5O89zKzVDIkM=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776065863; c=relaxed/simple;\n\tbh=SC3qj+zSPrXC7x148ssSlAOSsrLh6sGlRiQ6lldj1q8=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=i122ThhTFgGrCSB1gYyoaxa0eptTYOmZn8NqRKOBRQdn4HBVMB9RVC1HD4OzkTJ9CTAYv7KWzF3Pgr8FzHOcsltZS7d39ZhUuFVnR/QfuijNAhX1eBKpJFg4gibmCemiYSot6qG1uk+UhlO/YD13SPMjZPu7xcCSQF3VhDUxHkg=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=Y2wJYjxW; arc=none smtp.client-ip=209.85.221.45","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776065861; x=1776670661;\n darn=vger.kernel.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=i0t7dfofWTApgTDHYz2jvCuOmi04UnlECznc19h2Ol4=;\n b=Y2wJYjxW8dF+sxGCY6h6//xdFZjIdrWhDcMuhZ2OLcmpVZud991/hGeZvd0KEDilSC\n CKE6kNNf6+xtyExxaCtoO4kfeN5I0ZB75iguSubit4OR9WSADV/gg2O1wxAjTWiubyvI\n W5zR50ospipf1Wzs3JDGfQGjGyFFgWCSWqWFdqKRVoH2hmUQzBcJvQ7mXd6RFUJtYjeQ\n pfrjDA6APBLF9GF1wwcel2uJQXOXLXIttCybTEEQ/geYoOXgbBV1xztvvFtrdEX4pa6N\n EZKsBIizix5uvE2dG9Mdp2Cq3QmiRaUBeiO4bRwXHkX0t2mbcmgL3pka9RMTiYk66xkO\n 1vdA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776065861; x=1776670661;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=i0t7dfofWTApgTDHYz2jvCuOmi04UnlECznc19h2Ol4=;\n b=PXER3BMkKH3LyCCFqJLS2pia3SnEO0qfOv+3Yr2Owh87f0ECFQCkgiZWxmCJXgPdap\n aBATcYvcvjN2mqY2MtcsjppVpaHllMmvZOmCpct0ZSp6A/F8r0rAvIA/oDbuq7zBHLXN\n bSK4NwdSoiO+oYDAmd5XyWy4y3xLqhmvhu4hnnT3p1/AsICH2zJJ49Fp3HpQ1vhCpaQz\n vLxY4XLGTRaG53eEjIVLj7yvp+Jooy8wBSiZsl3Eec88BXbosl3mcf2uklKnUW3JibS/\n EZSScD54D177sPDM0v2tEh+KKbgTXTdgx5U5Q7mBigwggHBp0O81PXmdyDo9x4Ti2pyn\n z4FQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8rCMiql2qPLDp6Ovj/TZVwhlddDPNX/R0L3O20uS3sgHIUDiN75uA8KJpQYrZZzBmm/TLzZ5FksN9JYw==@vger.kernel.org","X-Gm-Message-State":"AOJu0YwlLbp89DhnJBVWkbsWAh6H0uDb6U9RzEHAqprjGtI3G6619RzI\n\tOT1s940TH7LAvj4sWJfBqlIMWzUkDuzkhnbT+CaP4zR4DOKtxD2eLcyny+QUcTAb","X-Gm-Gg":"AeBDievRvR6u4i0Oy6WzpMOMCz412b07XR8MIDwLyRq2PMHY6UCmn/7qtc074MgLUZR\n\tdm4JSP/Dt272a9+ZNvjkiaeYziUinNkj1HYJXkQ3S/K1yWSS9E1YXJ8zBY0hJDw2Mb6+a4zxQJE\n\tSDP+nAfM1CqYmeRNtndV5kKfWJ9IlZEnSWDPW53pzLG0c2MyvcO/4z+ALpj0SYMitk6e0R6vA6y\n\tpJfsZAAL+j43hdbEcZtqhNOAj2ySXNV1viYeqB/hKMuvS9SX+4jvKh21tw98ntmr3QZlR5mE6hI\n\tNR6seM2/TpVy8jWmv0dOvPLUk2JSFL49Am0qIpMOLHzYgV9NOgzvLBCH3wAsLYKPLH0OZ/qgsg8\n\tgdG9hLgwr2N25ZjLicn12sAlmcnBOEg4s/Smcqmp8VxLxz4goCy9pZ+wikwgUim79tNOYRtBaze\n\topkH/E9UOL4kIOx2bbDAA=","X-Received":"by 2002:a05:6000:25ca:b0:43b:5091:39db with SMTP id\n ffacd0b85a97d-43d649740c0mr18904434f8f.13.1776065860668;\n Mon, 13 Apr 2026 00:37:40 -0700 (PDT)","Date":"Mon, 13 Apr 2026 10:37:37 +0300","From":"Dan Carpenter ","To":"Alexandru Hossu ","Cc":"Greg Kroah-Hartman ,\n\tThierry Reding ,\n\tSowjanya Komatineni ,\n\tJonathan Hunter ,\n\tLuca Ceresoli ,\n\tMauro Carvalho Chehab ,\n\tlinux-media@vger.kernel.org, linux-tegra@vger.kernel.org,\n\tlinux-staging@lists.linux.dev, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH 2/2] staging: media: tegra-video: add missing error\n checks in vi_tpg_fmts_bitmap_init()","Message-ID":"","References":"<20260412045245.GA2019381@kroah.com>\n <20260412084808.232010-1-hossu.alexandru@gmail.com>","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260412084808.232010-1-hossu.alexandru@gmail.com>"}}]