[{"id":3676509,"web_url":"http://patchwork.ozlabs.org/comment/3676509/","msgid":"","list_archive_url":null,"date":"2026-04-13T07:34:05","subject":"Re: [PATCH] media: tegra-video: vi: fix invalid u32 return value in\n format lookup","submitter":{"id":389,"url":"http://patchwork.ozlabs.org/api/people/389/","name":"Dan Carpenter","email":"error27@gmail.com"},"content":"On Sun, Apr 12, 2026 at 12:02:45AM +0000, Hungyu Lin wrote:\n> tegra_get_format_fourcc_by_idx() returns a u32 but uses -EINVAL\n> to signal an out-of-bounds index. This results in a large unsigned\n> value being returned, which may be interpreted as a valid fourcc.\n> \n> Return 0 instead to indicate an invalid format.\n> \n> Callers assign the return value directly to pixelformat, so returning\n> an error code encoded in u32 is unsafe.\n> \n> Signed-off-by: Hungyu Lin \n> ---\n> drivers/staging/media/tegra-video/vi.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/drivers/staging/media/tegra-video/vi.c b/drivers/staging/media/tegra-video/vi.c\n> index 9c0b38585d63..966792a6ec19 100644\n> --- a/drivers/staging/media/tegra-video/vi.c\n> +++ b/drivers/staging/media/tegra-video/vi.c\n> @@ -81,7 +81,7 @@ static u32 tegra_get_format_fourcc_by_idx(struct tegra_vi *vi,\n> \t\t\t\t\t unsigned int index)\n> {\n> \tif (index >= vi->soc->nformats)\n> -\t\treturn -EINVAL;\n> +\t\treturn 0;\n\nSomeone else just sent a patch for this which added error checking to\nthe caller. I liked that approach better. (I haven't checked to see\nif your approach works).\n\nBut either way this needs further review to see if the bug is actually\nreal and if so what is the Fixes tag?\n\nregards,\ndan carpenter","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=E0xUq+Q4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13732-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"E0xUq+Q4\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.221.51","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvK0n09myz1xtJ\n\tfor ; Mon, 13 Apr 2026 17:34:17 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 9BE163002B24\n\tfor ; Mon, 13 Apr 2026 07:34:13 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id F0A32366055;\n\tMon, 13 Apr 2026 07:34:12 +0000 (UTC)","from mail-wr1-f51.google.com (mail-wr1-f51.google.com\n [209.85.221.51])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 54FFE391E65\n\tfor ; Mon, 13 Apr 2026 07:34:11 +0000 (UTC)","by mail-wr1-f51.google.com with SMTP id\n ffacd0b85a97d-43d04fc3bf2so2407858f8f.3\n for ;\n Mon, 13 Apr 2026 00:34:11 -0700 (PDT)","from localhost ([196.207.164.177])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d6f4bf2b4sm15189470f8f.20.2026.04.13.00.34.08\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 13 Apr 2026 00:34:08 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776065652; cv=none;\n b=irFiObJ2tVfRbaVZm//ajdQDYK/bcdTRS5+QDp8n32oUmI1O+XushhiG7JCyR/kiyzZW7C3IRqk5yMpZhUcxAQo/fP3xY6BbNDxsxdJgfdy4Jq1gYtNwIgyCm+fJE3jrroXKbgEvfuYmVtDBCm9HcUaYPqCVsSCiYy9eSWClH+k=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776065652; c=relaxed/simple;\n\tbh=e6BQAZGUgVAkgKcYanzsYKMx63YC+gNCChBKEtZTy5Q=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=af0T9Y7w1Rc0mtrzfm6MrC+h0A369AcqrgX/7Gxk8/Zckywh5D2j0EL+moJ7KnG4m1d/dHnSRcDj1VJFHLVu66lIYCGamz+ACmtews1daw/zz4HxrecVNEbsB1JgMjcRFtGd3MgwjRO8Pwghilf0/HcaELhOcAV6kxcNs3qtiNY=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=E0xUq+Q4; arc=none smtp.client-ip=209.85.221.51","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776065650; x=1776670450;\n darn=vger.kernel.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=6HEasNH32115c+BoQHyOfy+FArvbq95odOHWQ7HgwtU=;\n b=E0xUq+Q4qhtBwrOWeaPcMpTD2As0MFGwL/PO1h25s/6Utw+tkSbYs0QFZQyQOx69RT\n /YGrf4eOMqCecwQzcP0vOagV+KZjyjPTuDldHo/6z2LcQP+q4O9VzILrHgJLjpPanbCk\n m3B5Ag/BbKXc/HfO2Mf9JjfnZZVvaOs6a1fwx5YwEM1iQUET/brQr8kPtXc5I0fL/h1F\n zzF5RiLvNsvl/fUzMU68pfEVhDg/4ZQIJlHugfgIU8Grq+SucwWInIATKoY3psiRPwfg\n eIF5Xd1lzXNTYv7QfM60u+6pqvIPW4mwp426B36WOqWaQ3nkwGH5fweEXe5ySyZ2vren\n MF1Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776065650; x=1776670450;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=6HEasNH32115c+BoQHyOfy+FArvbq95odOHWQ7HgwtU=;\n b=NDnNtyska4AoVzCvFnJzVFvJsjUdSKxQuT/TONfAF15MVDhlCU6Q7CdaJKUELmlRhK\n bcNv3PErRrSjCWhxDibZR9UBBTugqZdUZN0WYAk6cJ2kPCT7tm/R/nWVXcEXYUvTCFaM\n ltETwMq+TSGTEu38NFR8v15w9Qu1yV9UEVYxX/A9VkZQewJVrsNjqiy3fki7dseptxR+\n lhXpa5JcOBcVrdUED4KMKLLBrww+Nl3Hb3vkzB4DHlVKIFKeMNo5PzUym2MgV4uhLl5L\n bDQhpMDA0q2IEEIsucusPvY65/4ukmMUwYbYQsccWLmYhwN0COtBt4A8zw5Aig1zTVrK\n PZqQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+twXC4F+PN88yLT0zgN2kC7hUnT9s8Na1hm4zqfINDn89ostGsHeEn7tr0w6zgss1p+16tREUt4PhOzw==@vger.kernel.org","X-Gm-Message-State":"AOJu0Yx4BMoYevgI4ARwjT9SfAEAKKWACAoRkz0ilE13hKbinJ8/Z2iX\n\tgLG2eDMHGh+HA3j9ZEDtuAEGdwJNya8loUJRcGWzJKucUGlDH3/rUUlgU5XhrOx+","X-Gm-Gg":"AeBDieujUPYIOm//1iN3i7w2ZKQEjIYl70/xlsC41P2uXHxtycjiFRXbqPIkjb9uctx\n\t1s7FmS/IB7g2pqF0lzId1itJbdpmyN34q8BeDIR4AD616nhF8zxpWlVQsTnMXp8ueeI9Nh0XNUC\n\th8fZwg1fGEzOyiiFBk4ls+5fifGMz144QFS0CfPARHFj2P4EhGogx7PQBgMqzmn0dcW0bzIXIsN\n\tVaRtCAmFkbgPxdinWu8WSnM6miJ9X9IMbXRDStZzn9U6ceiilUL4kaI65FmQcnpza2E94Qojs70\n\tIcBKXh94uGEeAFcLFqlN0Vp0OM7HEPlZMqtW4+cKRs0LR/BPAUme6/pHr4VXscH/DSYerrNzvde\n\tg+ltbEB/oVwpmxRxKaeLDvjnA9caD7DZHTp9IRcvUYwUfQ6cgnd4p54yD2fFnfgVDCeIRqG09yL\n\t+Ipd+03i69FkMeQjCTCEU=","X-Received":"by 2002:a05:6000:25c6:b0:43d:7cb5:43a6 with SMTP id\n ffacd0b85a97d-43d7cb5513amr831948f8f.2.1776065649604;\n Mon, 13 Apr 2026 00:34:09 -0700 (PDT)","Date":"Mon, 13 Apr 2026 10:34:05 +0300","From":"Dan Carpenter ","To":"Hungyu Lin ","Cc":"thierry.reding@gmail.com, jonathanh@nvidia.com, skomatineni@nvidia.com,\n\tluca.ceresoli@bootlin.com, mchehab@kernel.org,\n\tgregkh@linuxfoundation.org, linux-media@vger.kernel.org,\n\tlinux-tegra@vger.kernel.org, linux-staging@lists.linux.dev,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH] media: tegra-video: vi: fix invalid u32 return value in\n format lookup","Message-ID":"","References":"<20260412000245.26696-1-dennylin0707@gmail.com>","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260412000245.26696-1-dennylin0707@gmail.com>"}}]