[{"id":3676505,"web_url":"http://patchwork.ozlabs.org/comment/3676505/","msgid":"","list_archive_url":null,"date":"2026-04-13T07:27:06","subject":"Re: [PATCH 1/2] staging: media: tegra-video: fix wrong return type\n in tegra_get_format_fourcc_by_idx()","submitter":{"id":389,"url":"http://patchwork.ozlabs.org/api/people/389/","name":"Dan Carpenter","email":"error27@gmail.com"},"content":"On Sat, Apr 11, 2026 at 11:10:04PM +0200, Alexandru Hossu wrote:\n> The function is declared to return u32, but returns -EINVAL on the error\n> path. Due to implicit conversion, -EINVAL (-22) becomes 0xFFFFFFEA as u32,\n> which is an invalid V4L2 pixel format value.\n> \n> The caller tegra_channel_enum_format() assigns this garbage value directly\n> to f->pixelformat and returns 0 (success) to userspace via VIDIOC_ENUM_FMT,\n> giving applications a silently wrong format descriptor instead of an error.\n> \n> Fix this by changing the return type to int and propagating the error\n> correctly in the caller.\n> \n> Signed-off-by: Alexandru Hossu \n> ---\n\nDo you think you could analyse this to see if it's a real bug or not.\nIf it is then give it a Fixes tag.\n\nregards,\ndan carpenter","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=odHyLPlB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13731-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"odHyLPlB\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.128.44","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvJs14Q8Zz1yDF\n\tfor ; Mon, 13 Apr 2026 17:27:33 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id E2833300B182\n\tfor ; Mon, 13 Apr 2026 07:27:14 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 929FE3932ED;\n\tMon, 13 Apr 2026 07:27:14 +0000 (UTC)","from mail-wm1-f44.google.com (mail-wm1-f44.google.com\n [209.85.128.44])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 118F73932CE\n\tfor ; Mon, 13 Apr 2026 07:27:12 +0000 (UTC)","by mail-wm1-f44.google.com with SMTP id\n 5b1f17b1804b1-488a041eae5so29029275e9.1\n for ;\n Mon, 13 Apr 2026 00:27:12 -0700 (PDT)","from localhost ([196.207.164.177])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d7400708dsm12208844f8f.25.2026.04.13.00.27.09\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 13 Apr 2026 00:27:10 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776065234; cv=none;\n b=tVUnxV3I4eppF8pKUGIqQKiq+7nMKpwweH3Og4/AkFANqAGPnI7pzCHQ5jU1F0Sl7D23Qs/YhOZoR7P5pqU2fzKh585RC5jPbXVLHMYlYZ2poqAIVGgGUrEmM0oT+V2qWIaYkpqtGFhJmCioAhAu5I5xTilWVy8c1yEuBiJSnrU=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776065234; c=relaxed/simple;\n\tbh=TMX0GVYUcC/4pa4IA0Xg1yJG8EYpQyDgj0o91746WJo=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=LTlxUKP42mS9WBRtpMog9Dfn3lR4Cr+0oiE4mxFyFqgZ521NW2cVqEPO9L+entsr7KRyFIPD2xz730//mr0yEdO8jUX4c9NfQUAPutjEWOAia321JUU5LchKFQu3uXl+MZdVSCiH/Gy/nrYkXhzRIAr1RfZsGPVZKSZcZCzdm1Y=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=odHyLPlB; arc=none smtp.client-ip=209.85.128.44","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776065231; x=1776670031;\n darn=vger.kernel.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=vB8fTOutsfZIie2qCEI929IdjXgTwcdUZphinUXaVGs=;\n b=odHyLPlBEcIBHkOx3uUBySRtigfT6eq5C7VXwuAGaxfu78t173EIFl2Z3QocvwqGDA\n i+H3UFgRmGexfz6KhKj+r6Xf4N0Cx3oVnCtY1T0OqDk5foPObshX36kAwtdco/b35PiR\n BJYDgR7Zfz+rZRV6kQYpe/nH+RUa7fgVnUybgys3QOgz+3Q4WOo7mJKM19Kfoh1T2Dxt\n ohHux8bSWp6G+vgkuXE1P/+oqxJnfLsWOu4BcfKdxKKL06Du3t+mkc/+sfyXAOKOFQT/\n RRFImocuKQA4fEgqiVCviIV5rVR8EKNyQLDO8yMRoBLP6qT2UnbgwD4MTHLVYSQk6oL/\n +6tg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776065231; x=1776670031;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=vB8fTOutsfZIie2qCEI929IdjXgTwcdUZphinUXaVGs=;\n b=REsW1nnAixbVKrbPU5cPktLKNyoVshbUjc+LWqVMURvBJ2FXWdE0c5I2PEqHGoPfDw\n VxZrBZcXzmZiLcoHeCUC3LLkFg4qG/97LLtrWiXM7q5DXj1ReXznJH843yYvMKjQiWwl\n aD+RalfrzfTYSw3eblKlU1eO4sbgP7gk1YDiDYY7JUEUzLU4hPOaolxjfuVXJKHiwzZO\n Hglkt6Hz5UsQKT1RZ0Nb+vJPnvTkKBKV11W2KeVpxgh8pLM31/nerMq4DeZQVroOVPHw\n OhrdTEDkdBpPbbCPVtNshUtBsdTBv9CE7eQLZBSmjsjEIPTwxphuIaxvoS/jHNZwMtSy\n S5ng==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+hDglbzUHFCcmBCO0R28sQ/Vz2+pf4kUIB0fyl6r0jhMHYHw1ExnTVxNEoTF0kqLTSUGzoGUTXpFzX2g==@vger.kernel.org","X-Gm-Message-State":"AOJu0Yyu7T3Sn8ZIlKmUtyX+4NSI0HJT/TNKbTOTmPGU5MJKO2cocXo6\n\tIdj2Pto2Wg3IPWtndgpYiITAoR2LOUZzLW4UrOCf17XyGeIxLvOfj/ex","X-Gm-Gg":"AeBDietIFLk3LUpdNOtZKQLORNxLAcbTSHfF/WqEJZ6PgQ46epZOXC3/9XZb3Zd1TZy\n\thwK6tZbf4HGXaAWAQbmHiQefqLdJM05+6jCLx7B6Fs/q13iqQ0lV4j6iF7tFJbQT1Hxr2kaJJH3\n\t5BX7PVAenTK7dlsCysWuCKSUye2WobzutVQQvxF8Ikaj7hdtTQz0CSLAkC5qaSRtpk0Ia1qB5PK\n\tWRa3ODXiU41Hi041sNzF7xjteqeEZ13dJuZHtGdndxgM+OkPYq1/7kMkkoP34V4xNwAeVf9Tcos\n\tQYM/2vPDMBfVnZt/gbmNgy765p0gqoCN9YT5d1M1RKI7ZWtPhh1PkGBG4LMupKLMQnFOBb83H+Q\n\t1A6xKXJ7TdxthBTAF5UrmAr8NYHPbzZT6WCxHGlCeAYp3+IdpvS9XrTwONQmiOMHAzREAw/c3+k\n\tngSNFaPmc1MmomOW0fnnQ=","X-Received":"by 2002:a05:6000:1447:b0:43c:fdd9:1890 with SMTP id\n ffacd0b85a97d-43d642c999dmr16766155f8f.51.1776065231364;\n Mon, 13 Apr 2026 00:27:11 -0700 (PDT)","Date":"Mon, 13 Apr 2026 10:27:06 +0300","From":"Dan Carpenter ","To":"Alexandru Hossu ","Cc":"Thierry Reding ,\n\tSowjanya Komatineni ,\n\tJonathan Hunter ,\n\tLuca Ceresoli ,\n\tMauro Carvalho Chehab ,\n\tGreg Kroah-Hartman ,\n\tlinux-media@vger.kernel.org, linux-tegra@vger.kernel.org,\n\tlinux-staging@lists.linux.dev, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH 1/2] staging: media: tegra-video: fix wrong return type\n in tegra_get_format_fourcc_by_idx()","Message-ID":"","References":"<20260411211006.150782-1-hossu.alexandru@gmail.com>","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260411211006.150782-1-hossu.alexandru@gmail.com>"}}]