[{"id":3676234,"web_url":"http://patchwork.ozlabs.org/comment/3676234/","msgid":"<2026041250-footwear-ashes-84da@gregkh>","list_archive_url":null,"date":"2026-04-12T04:52:44","subject":"Re: [PATCH 2/2] staging: media: tegra-video: add missing error\n checks in vi_tpg_fmts_bitmap_init()","submitter":{"id":11800,"url":"http://patchwork.ozlabs.org/api/people/11800/","name":"Greg Kroah-Hartman","email":"gregkh@linuxfoundation.org"},"content":"On Sat, Apr 11, 2026 at 11:10:05PM +0200, Alexandru Hossu wrote:\n> tegra_get_format_idx_by_code() returns -1 when the requested format is\n> not found in the SoC format table. vi_tpg_fmts_bitmap_init() does not\n> check this return value before passing it to bitmap_set(). A negative\n> index converted to unsigned would result in an out-of-bounds memory\n> access, corrupting adjacent kernel memory.\n> \n> Add WARN_ON() guards so that any future SoC addition or Kconfig change\n> that exposes this path fails loudly rather than silently corrupting memory.\n\nThat is not \"failing\" that is \"rebooting the box and loosing all of the\nuser's data\" for when panic-on-warn is set, that will happen.\n\nPlease don't do that, if this can be handled by logic, then handle it,\nreport the error, and move on. Don't crash systems.\n\nthanks,\n\ngreg k-h","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org\n header.a=rsa-sha256 header.s=korg header.b=qVOXrKHG;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13713-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=linuxfoundation.org\n header.i=@linuxfoundation.org header.b=\"qVOXrKHG\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftdT51qkRz1xtJ\n\tfor ; Sun, 12 Apr 2026 14:52:56 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 1F36F3016485\n\tfor ; Sun, 12 Apr 2026 04:52:49 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 0478E364032;\n\tSun, 12 Apr 2026 04:52:48 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id AB1AC2C027C;\n\tSun, 12 Apr 2026 04:52:47 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id ACD94C19424;\n\tSun, 12 Apr 2026 04:52:46 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775969567; cv=none;\n b=JxAyietBRKwE0tlppELKuRRPMZtKoujpyF4Utx5F3ylKofsJWGiS25YxfGXcCzP1/mHsGANE+Xq1639UOE5diQ2xWt5UwsX8N32g/l1IbZY42kfSyfVimCSmuhzV+YhK6Y6LJP8kfajtaJvVnSSMhN1F4nRc/MF2h28hICB/zp4=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775969567; c=relaxed/simple;\n\tbh=vCNTuqhCplT0OgoGRN8meGqKIW1Zum6FeqiTRsFcJLQ=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=X3AOW1mjth8T7Pn+hzE07Ync+gDpBiSeF1TLUEH5oiT/+9HGWEr9nmbph+tG9lfaBZkHMGBaPCBDKI/ZOC7/NJu4/fCdfThw07y8jbftHya8PPS1pZbxA5TVmpB3g3Fws+Qzjkv8jhSOm8xcJ4terkqV4qVsLNJ/f3fQ4gMT+L4=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (1024-bit key) header.d=linuxfoundation.org\n header.i=@linuxfoundation.org header.b=qVOXrKHG;\n arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;\n\ts=korg; t=1775969567;\n\tbh=vCNTuqhCplT0OgoGRN8meGqKIW1Zum6FeqiTRsFcJLQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=qVOXrKHG3cmWWG3mBJkpTzVM9oGzfl6THntyvKryHTLSk4DKmUd44nH9BMpTRd0Dn\n\t 6mn8+HS4YSgWXfbpBcUjRQrkeeG4rLLbkRbnspjOx8hwYbBxyap46k8wwYN1SeJuSJ\n\t nIEUrJN4j5sA7SFfc3jhmCao3UsOU2TfcmoXEGqc=","Date":"Sun, 12 Apr 2026 06:52:44 +0200","From":"Greg Kroah-Hartman ","To":"Alexandru Hossu ","Cc":"Thierry Reding ,\n\tSowjanya Komatineni ,\n\tJonathan Hunter ,\n\tLuca Ceresoli ,\n\tMauro Carvalho Chehab ,\n\tlinux-media@vger.kernel.org, linux-tegra@vger.kernel.org,\n\tlinux-staging@lists.linux.dev, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH 2/2] staging: media: tegra-video: add missing error\n checks in vi_tpg_fmts_bitmap_init()","Message-ID":"<2026041250-footwear-ashes-84da@gregkh>","References":"<20260411211006.150782-1-hossu.alexandru@gmail.com>\n <20260411211006.150782-2-hossu.alexandru@gmail.com>","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260411211006.150782-2-hossu.alexandru@gmail.com>"}},{"id":3676503,"web_url":"http://patchwork.ozlabs.org/comment/3676503/","msgid":"","list_archive_url":null,"date":"2026-04-13T07:21:28","subject":"Re: [PATCH 2/2] staging: media: tegra-video: add missing error\n checks in vi_tpg_fmts_bitmap_init()","submitter":{"id":389,"url":"http://patchwork.ozlabs.org/api/people/389/","name":"Dan Carpenter","email":"error27@gmail.com"},"content":"On Sat, Apr 11, 2026 at 11:10:05PM +0200, Alexandru Hossu wrote:\n> tegra_get_format_idx_by_code() returns -1 when the requested format is\n> not found in the SoC format table. vi_tpg_fmts_bitmap_init() does not\n> check this return value before passing it to bitmap_set(). A negative\n> index converted to unsigned would result in an out-of-bounds memory\n> access, corrupting adjacent kernel memory.\n> \n> Add WARN_ON() guards so that any future SoC addition or Kconfig change\n> that exposes this path fails loudly rather than silently corrupting memory.\n> \n> Signed-off-by: Alexandru Hossu \n> ---\n> drivers/staging/media/tegra-video/vi.c | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/drivers/staging/media/tegra-video/vi.c b/drivers/staging/media/tegra-video/vi.c\n> index afc7327ef318..e6416ea8503e 100644\n> --- a/drivers/staging/media/tegra-video/vi.c\n> +++ b/drivers/staging/media/tegra-video/vi.c\n> @@ -1025,11 +1025,15 @@ static void vi_tpg_fmts_bitmap_init(struct tegra_vi_channel *chan)\n> \n> \tindex = tegra_get_format_idx_by_code(chan->vi,\n> \t\t\t\t\t MEDIA_BUS_FMT_SRGGB10_1X10, 0);\n\nThis will only fail if we can't find MEDIA_BUS_FMT_SRGGB10_1X10 in\nthe tegra210_video_formats array. The commit message makes it sound\nlike this fixes a memory corruption bug, but it can only happen if\nthe memory is already corrupted beyond hope.\n\nPlease write the commit message to be more clear that this is not\na real issue in existing kernels.\n\nregards,\ndan carpenter","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=V1jEkIGW;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13730-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"V1jEkIGW\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.221.44","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvJkD20yqz1xtJ\n\tfor ; Mon, 13 Apr 2026 17:21:40 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 0C05830022EE\n\tfor ; Mon, 13 Apr 2026 07:21:37 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id D7258392825;\n\tMon, 13 Apr 2026 07:21:35 +0000 (UTC)","from mail-wr1-f44.google.com (mail-wr1-f44.google.com\n [209.85.221.44])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 62F8B3612E2\n\tfor ; Mon, 13 Apr 2026 07:21:34 +0000 (UTC)","by mail-wr1-f44.google.com with SMTP id\n ffacd0b85a97d-43d7605ec91so734157f8f.3\n for ;\n Mon, 13 Apr 2026 00:21:34 -0700 (PDT)","from localhost ([196.207.164.177])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d7c135fd6sm3713097f8f.28.2026.04.13.00.21.31\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 13 Apr 2026 00:21:31 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776064895; cv=none;\n b=I7yYdI2yZUavXFZKeVOFFTbBHmik6gtV3PdClzkYEYjEDVKSLqJax5n0eBywTVgfo4UkoG3XCUt7TwR2zkrtto5FS9A+IK/pgsNgJKrbptmEnRd4+PNNsCl+6uMH/2AUJpdaZV1s5hnFFMnFrKj1CPTSzxmYgnI47tETteaYYno=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776064895; c=relaxed/simple;\n\tbh=dPLuupoDLLr+Wx19Z3u7DYxO18a6a48VRDBlxNU+JIg=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=GkAsvWWcXu9I/RvYVJ4brDoO12JCDEO+uOYXIV3f60qdoTYwfATmk2XRvsIAk5745LI18QHSlSeOPG52Gypj8ysnNbZkyzUbbaEyKjhFRRlkTiDejcmt1Uo26ePKY/xKxEhkrcLugzBP9BS7s/pxZn/Hfy7W8jeivzHUK1fa+0g=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=V1jEkIGW; arc=none smtp.client-ip=209.85.221.44","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776064893; x=1776669693;\n darn=vger.kernel.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=iw4ljpgUqAKzzrRRr5hlS15ea4IPkp99uerSPaTGYwg=;\n b=V1jEkIGWqG/8/6P6LxcgA4AGNYqZ+EbUWeu/rDfz2cAaywc7oCBZ0bLzhP7OkWPeOv\n AHr6P1KOBXsl/x1Hi3A6FFTUcYmVL/lpdXUJUFsgDMhCWLF+7qwmumf71NEPz7L9mq3i\n aVJE7mAc31AOHz8L6cyGoCRSBIv9ofBta42XMCqkwodI/X/jJ6u+Y/8qF+LNYb0DTAhI\n sQt9P+Sr5FvRdBrNtNVEfVbQg+3yARWn5j4k2hoDGdhUEBOmdKfbHXSWkbnwDqAXi16m\n leUiAtPRFKR++co+h9FArK+FMkrpI9wZU8HeJECK3GBfjZJVJUSGbHMDEFpO1V1lp7Ip\n vP9g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776064893; x=1776669693;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=iw4ljpgUqAKzzrRRr5hlS15ea4IPkp99uerSPaTGYwg=;\n b=NRGmCLuqLODT63pJLcJlw/Xd8JFyW6g15FnZfYTHZ4bTyyLuaMUmwoPDNuqevMzhsd\n wvuFcKJNxHZvmXDaqks24yTK0S65TuhN1LBowz9dz885t1lHZjG+rCWBqMYffF5MHlsy\n f0TEctI0hfsClhsM2MRl3W2qvFeCXTATA2dU/ukkDHYXRT35dXZwZbffQVApFwHUvRNP\n vubB+PKgjy7UKRW3zCoEWBWROdQZlRCvwFrKdCKmqWVqT0u3f3dZNGofjjypsWhWM3KP\n Qfd1N3xeHdjcgmiHrUOJ7fz/bE3pqaAuUpiWC9Vty+rduyAv1l2UFlsWtnzYvtQ6/yNw\n QmCw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/TjLVx2kgF9I+Wv8ZFn6TtjMm6rvebpzDzBRAbcE5wY/dPoS8Qjke3lzHrF6YuEc1QrFyUF3ZU23xsDA==@vger.kernel.org","X-Gm-Message-State":"AOJu0Yz3EsCNoQkpApmcNg6jNvno+OqPoDoXb/hyrA4PDfhLHx8jCeic\n\tZG+D9p1Ox1me3t8sF+afIzB4KVYBvhO9BNWvHJktFth2t9Rd0sH/7bIt","X-Gm-Gg":"AeBDietuGUUIgrrlfU2VrKWnEHPiInSnQQ5p0f0hkBOiCh5JiVnXe0CwLuemLnCSfyU\n\t+XYMbnS2Gb9GUpiGHFuclKWmwoZQFhNaMCRX7ythCDUpOdjaujPpDkj7m/qwVhgp/SNNVmaxVW9\n\tghFWBsLdA16ieighAlU5c1NA0OagE/n983vw7mJWDyAamBO2eSynjUT/Gl9oaC8MQTRrpHsQu06\n\tUbH36QXVCQH0YIvU1g0t7t1LCo4N5I9BqsWrG4kcphSohvbQ5QZ7Ne1UXODrhLZb+RI7lDwbOtG\n\t33AI8I4kp2c7y8HPIgDrLOPZo0FZxdjBqNpMCUHD6Z9Ut9fy2Eh70jbxgdC/Nxub6As1xvvDUNZ\n\t5R4mYuYO9L2sJDYQFNvzZUq5yVslDM+Tmqqa/YibPgCyemQQ+5Jyn0nO6STbloqxzxUjJgX8XzT\n\tM+NWSTPmBYfWj1Pzkq13cEoBmbKv5iYQ==","X-Received":"by 2002:a5d:4b05:0:b0:43d:7508:c9c6 with SMTP id\n ffacd0b85a97d-43d7508ccafmr4141774f8f.28.1776064892744;\n Mon, 13 Apr 2026 00:21:32 -0700 (PDT)","Date":"Mon, 13 Apr 2026 10:21:28 +0300","From":"Dan Carpenter ","To":"Alexandru Hossu ","Cc":"Thierry Reding ,\n\tSowjanya Komatineni ,\n\tJonathan Hunter ,\n\tLuca Ceresoli ,\n\tMauro Carvalho Chehab ,\n\tGreg Kroah-Hartman ,\n\tlinux-media@vger.kernel.org, linux-tegra@vger.kernel.org,\n\tlinux-staging@lists.linux.dev, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH 2/2] staging: media: tegra-video: add missing error\n checks in vi_tpg_fmts_bitmap_init()","Message-ID":"","References":"<20260411211006.150782-1-hossu.alexandru@gmail.com>\n <20260411211006.150782-2-hossu.alexandru@gmail.com>","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260411211006.150782-2-hossu.alexandru@gmail.com>"}}]