[{"id":3676888,"web_url":"http://patchwork.ozlabs.org/comment/3676888/","msgid":"<6b0940df-ba58-4e89-be03-f7e83dc241b5@gmx.de>","list_archive_url":null,"date":"2026-04-13T19:20:30","subject":"Re: [PATCH,fortran] Fix Bug 93554 - [13/14/15/16 Regression] ICE in\n expand_oacc_for ...","submitter":{"id":21263,"url":"http://patchwork.ozlabs.org/api/people/21263/","name":"Harald Anlauf","email":"anlauf@gmx.de"},"content":"Hi Jerry, Chris,\n\nAm 11.04.26 um 6:54 PM schrieb Jerry D:\n> The attached patch look fairly simple.\n> \n> Regression tested on x86_64.\n> \n> I plan to commit this one in a little while.\n\nDoes this need RM approval? It's a change below gcc/ .\n\n> I wanted to note that most of these regressions we have been fixing have \n> been around a long time. I suspect they were not causing too much grief \n> in the real world or someone would have fixed them already. Regardless, \n> we want to clean these up as much as we can to improve robustness in \n> gfortran-16.\n> \n> Thanks all,\n> \n> Regards.\n> \n> Jerry\n> ---\n> fortran: Fix ICE in expand_oacc_for with private derived type\n>  [PR93554]\n> \n> Using a derived type with an allocatable component in a private clause\n> on an OpenACC loop caused an ICE in expand_oacc_for because the\n> finalization code for the allocatable component inserted additional\n> basic blocks between the loop's continuation/entry blocks and the exit\n> block, violating the strict CFG assertions.\n> \n> The assertions checked that BRANCH_EDGE(entry_bb)->dest == exit_bb and\n> FALLTHRU_EDGE(cont_bb)->dest == exit_bb, but with finalization blocks\n> these edges can point to intermediate blocks rather than directly to\n> the exit.  Relax the assertions to only verify the expected edge count\n> (two successors) without requiring specific destinations.\n> \n>     PR fortran/93554\n> \n> gcc/ChangeLog:\n> \n>     * omp-expand.cc (expand_oacc_for): Relax entry_bb and cont_bb\n>     assertions to allow intermediate blocks from finalization code.\n>     Remove exit_bb predecessor count assertion.\n> \n> gcc/testsuite/ChangeLog:\n> \n>     * gfortran.dg/goacc/pr93554.f90: New test.\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n dmarc=fail (p=quarantine dis=none) header.from=gmx.de","sourceware.org; spf=pass smtp.mailfrom=m.gmane-mx.org","server2.sourceware.org;\n arc=none smtp.remote-ip=116.202.254.214"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvchP2bpbz1y2d\n\tfor ; Tue, 14 Apr 2026 05:21:07 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id B8DB24BA2E07\n\tfor ; Mon, 13 Apr 2026 19:21:04 +0000 (GMT)","from ciao.gmane.io (ciao.gmane.io [116.202.254.214])\n by sourceware.org (Postfix) with ESMTPS id E43114BA2E04\n for ; Mon, 13 Apr 2026 19:20:37 +0000 (GMT)","from list by ciao.gmane.io with local (Exim 4.92)\n (envelope-from ) id 1wCMpo-0006sp-47\n for gcc-patches@gcc.gnu.org; Mon, 13 Apr 2026 21:20:36 +0200"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org B8DB24BA2E07","OpenDKIM Filter v2.11.0 sourceware.org E43114BA2E04"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org E43114BA2E04","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org E43114BA2E04","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776108038; cv=none;\n b=WORkebJrORQAe7SsFtrLqAm/FBgtaGnkfTXghrEWY2EAHnnaA037mwDabCbsgsF9JcKg/3sok9FKXhALpL0/l94WRcri+zFPWMgUVLBXOgBC9lJqS9xYYbzWG91dXkk5bsE1Tk+AprbMh2osJy1oRZDl+tHJm8KlEF3PLGkB3V8=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776108038; c=relaxed/simple;\n bh=5qLteMLs0ze7qdzCqVsZAtYRpkrsAz9Stw2foB5klgM=;\n h=To:From:Subject:Date:Message-ID:Mime-Version;\n b=Ldoo+iWuXlvykeGlstH0KFcA+ia1bF4CSeOn7y/qsJECmGzcAKYLQnE1qUqH1g3XDkZnvu20M1UQe9ENNQpnPBhZqrfTD+obp5ber4BhflcyEv1kOJhfqSh8WXzUdJAnWGWuyU0WQEvd/44kK0WmVCd0QJzdUhbbQbFfHnhgfHs=","ARC-Authentication-Results":"i=1; server2.sourceware.org","X-Injected-Via-Gmane":"http://gmane.org/","To":"gcc-patches@gcc.gnu.org","From":"Harald Anlauf ","Subject":"Re: [PATCH,fortran] Fix Bug 93554 - [13/14/15/16 Regression] ICE in\n expand_oacc_for ...","Date":"Mon, 13 Apr 2026 21:20:30 +0200","Message-ID":"<6b0940df-ba58-4e89-be03-f7e83dc241b5@gmx.de>","References":"","Mime-Version":"1.0","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","User-Agent":"Mozilla Thunderbird","Content-Language":"en-US","In-Reply-To":"","Cc":"fortran@gcc.gnu.org","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}},{"id":3676899,"web_url":"http://patchwork.ozlabs.org/comment/3676899/","msgid":"","list_archive_url":null,"date":"2026-04-13T19:38:51","subject":"Re: [PATCH,fortran] Fix Bug 93554 - [13/14/15/16 Regression] ICE in\n expand_oacc_for ...","submitter":{"id":78264,"url":"http://patchwork.ozlabs.org/api/people/78264/","name":"Jerry D","email":"jvdelisle2@gmail.com"},"content":"On 4/13/26 12:20 PM, Harald Anlauf wrote:\n> Hi Jerry, Chris,\n> \n> Am 11.04.26 um 6:54 PM schrieb Jerry D:\n>> The attached patch look fairly simple.\n>>\n>> Regression tested on x86_64.\n>>\n>> I plan to commit this one in a little while.\n> \n> Does this need RM approval?  It's a change below gcc/ .\n\n\nWe were given a week at the start of last week.\n\nThis one is pushed already as of April 11, 2026\n\nNo worries here.\n\nJerry\n\n--- snip ---","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=LkSguVA9;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=LkSguVA9","sourceware.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","sourceware.org; spf=pass smtp.mailfrom=gmail.com","server2.sourceware.org;\n arc=none smtp.remote-ip=209.85.214.178"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvd5s26qXz1y2d\n\tfor ; Tue, 14 Apr 2026 05:39:43 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id C5A6E4BA2E2D\n\tfor ; Mon, 13 Apr 2026 19:39:41 +0000 (GMT)","from mail-pl1-f178.google.com (mail-pl1-f178.google.com\n [209.85.214.178])\n by sourceware.org (Postfix) with ESMTPS id EFBC94BA2E07\n for ; Mon, 13 Apr 2026 19:38:53 +0000 (GMT)","by mail-pl1-f178.google.com with SMTP id\n d9443c01a7336-2ab077e3f32so23067505ad.3\n for ; Mon, 13 Apr 2026 12:38:53 -0700 (PDT)","from [10.168.168.23] ([50.37.179.80])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b2d4f2f8e7sm118416575ad.65.2026.04.13.12.38.51\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 13 Apr 2026 12:38:51 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org C5A6E4BA2E2D","OpenDKIM Filter v2.11.0 sourceware.org EFBC94BA2E07"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org EFBC94BA2E07","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org EFBC94BA2E07","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776109134; cv=none;\n b=lljLy9aPqGfGpG92AflPAiRQHeqqfmpDhxeE5je6UjhG7jfGg7zJklwtd6EPanJz/xAggedbL+kMu74odYYKgNOUPprDY7s+zisHfk3BEm/a7F2FLZiVcRo7fjYl06Qr58+O2icEeuFF/7G1VoPhzIh0kNzoLhIcyHgEN3hR3sk=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776109134; c=relaxed/simple;\n bh=tEyhx/DFU+OMvGC4nWHZ8E0SkzrHQyZKqUt5F0bUAX0=;\n h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From;\n b=KM1r+Z6kk0iQMUihUPX/sRaO1pRhU0EqRCLLMwU5EF2UOpczLFsTHke7Kk4n8O2miaIGs0lJvWEjCekbG74lG0mnMg6x+C6vniuihPa+0E3admA624vBCxq++VBJ4OYpgyQDVse5dS6ON5A8ADLBYFB/Pfbv2J6R79eRsBdh0A4=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776109133; x=1776713933; darn=gcc.gnu.org;\n h=content-transfer-encoding:in-reply-to:autocrypt:from\n :content-language:references:cc:to:subject:user-agent:mime-version\n :date:message-id:from:to:cc:subject:date:message-id:reply-to;\n bh=dXighEG8FovnWjoYEao8DVjLg89haW+glu2d+94hpkg=;\n b=LkSguVA9xISTFRkAhy1WuXNQcL68HxRcm7ACJAX7WvoPZV1qDo518o7Q/O34JVkfA8\n MsdOD8Gez8ckzzKfT8BJKob9EmnUxFJShZ1n7gFQADqxJvUvPRIzuYVr73U0GaIeJg9l\n 4HnKFL9T/JrBRtxfUDX5gCXY4xTlstX/bpuyttY0ln6XFDu6YN0y7/AUYAEOQAEZ7+JD\n v2kbZUjg1Pacy+KbfoPJKSsza26sUOrMuSiEeQei58UH7rCrCeAr8d0/sC6nfqCwga/c\n lTr3H7e8ih3ZeglrtTxV6tyPd58fFryHRj7mq45CSpSVxK3UVkY8y9TxhL9H4kKZpIFF\n d9aw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776109133; x=1776713933;\n h=content-transfer-encoding:in-reply-to:autocrypt:from\n :content-language:references:cc:to:subject:user-agent:mime-version\n :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=dXighEG8FovnWjoYEao8DVjLg89haW+glu2d+94hpkg=;\n b=oVs4FisFt5gHQ8W9F+DshcMBOBnJRcAUvAo3CUkFcZeLh5T/hogXlBbOx4GFxTqaHL\n yW9bD8Lz7TuUSusFBcm70/2SE5a9lUxH5BM7VUCsGVlzucs8EaVyjF7V71UReP3Yj7YI\n RthLaxPmEDuW4GYuOBXj885b98gq0U9QT5SmGLjUe1eVXTOVfK0vdKI7UK8GPCKpTi8l\n bUu1Tx3az6KrlQ5bmVkt4ZKprzPsz9Ucs88gnH6vft52lDf6j2LCDYyopiy874SI4Xcs\n zl8rENJHFNxQM2YYEUqu8FJjRl4U7hnDfNnMdQSv5y9rG4+uaQ5jIAVn77oAffvJy1ky\n fe6Q==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8W1tOCXMHgbjGLe5bSm14nBDl8YyK16i5b8AEH3m8kwdaJUIXj0pjo1JgGmSgV0p/xN3LV8h6kXdwvJw==@gcc.gnu.org","X-Gm-Message-State":"AOJu0YxIuaFzDGOT7Q33TTniJk0Me5xr999gIDQQqOM8V24fAyLkud5r\n sw6WhjZw7bUK90SYBUpnyhTZrTb/+pIH81TXgwhvWwjhTklPqC/03EvX","X-Gm-Gg":"AeBDiev4qKeDwiTETkv0VLgk+Yso4HPXylNnAMM+/5UyvbqwTCPGRP333QX1wniKYNx\n wgXGRLPKK7Wricl9GqZKjOSLYleE7/vPo4WZFEE8w6adPkxJendUeG8eSIaxK22TxkFB2M0Aqk5\n 3m13xFWnMEt+40cmYt54x0I75jAAaPOfoyrXKrPMEV1V/gV6l1BymwuMl/bmm0zFMnucWREvOd9\n pGhRIlKUBeEjF+tu+ufl1qvzffvO1UNvxpN7yXjZnk91bDBFD11lqOSdyI+w/D7XGYu7VL+4OOx\n 7DOWwej4g95enqCSuaKNV6HTJTaxEKid3WqaZD8MQ1e2Ii3FGZhQn1+pyYarpHfTZvzu48e4CJ4\n 95sLwMiFQdg3P7gXeBl9ndqw4QH5DMUHBeEVJ6HHoecYyawf85GMHaoVHVhy+R+NCfa1ywbrT/V\n IU06hyHb47SkRhZ5SmPnNMa310a2U=","X-Received":"by 2002:a17:902:f551:b0:2b2:5515:661c with SMTP id\n d9443c01a7336-2b2d5a34bf5mr134526675ad.31.1776109132500;\n Mon, 13 Apr 2026 12:38:52 -0700 (PDT)","Message-ID":"","Date":"Mon, 13 Apr 2026 12:38:51 -0700","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH,fortran] Fix Bug 93554 - [13/14/15/16 Regression] ICE in\n expand_oacc_for ...","To":"Harald Anlauf , gfortran ,\n gcc-patches ","Cc":"Paul Richard Thomas ,\n Christopher Albert ","References":"\n <6b0940df-ba58-4e89-be03-f7e83dc241b5@gmx.de>","Content-Language":"en-US","From":"Jerry D ","Autocrypt":"addr=jvdelisle2@gmail.com; keydata=\n xjMEY5TlkxYJKwYBBAHaRw8BAQdAyrkRDhmJhSTTlV/50gJLlvliU6/Lm5C9ViKV8T9y1GnN\n HkplcnJ5IEQgPGp2ZGVsaXNsZTJAZ21haWwuY29tPsKJBBMWCAAxFiEEOFR0TS0390uh8dRV\n uWXAJaWpwWoFAmOU5ZMCGwMECwkIBwUVCAkKCwUWAgMBAAAKCRC5ZcAlpanBalsJAP4wdCiH\n 2Of9oZv1QWgZ/AVdbWFM3Fv47/WZQHOXfoZ9HgD6AkXrKeJ+6usST7PEaDJjptaViT1fLiYY\n V/6XaOKSsgLOOARjlOWTEgorBgEEAZdVAQUBAQdAdA7PczYnl07vnOT9oP/wvvMDd4HP09Zl\n g3LzwXQJWT8DAQgHwngEGBYIACAWIQQ4VHRNLTf3S6Hx1FW5ZcAlpanBagUCY5TlkwIbDAAK\n CRC5ZcAlpanBasF/AQCa5WjlsVpLsEiggZyT18MOJNAdeRd7wkGDUrwedHrvawD/cE1H+/Ms\n L1ZwvQiLfGdx8crigQqWTQyos4kH8Wx82wc=","In-Reply-To":"<6b0940df-ba58-4e89-be03-f7e83dc241b5@gmx.de>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}}]