[{"id":3676652,"web_url":"http://patchwork.ozlabs.org/comment/3676652/","msgid":"<IA3PR11MB89867D9A3665ECA17BE60ED7E5242@IA3PR11MB8986.namprd11.prod.outlook.com>","list_archive_url":null,"date":"2026-04-13T11:06:28","subject":"Re: [Intel-wired-lan] [PATCH net] idpf: fix double free and\n use-after-free in aux device error paths","submitter":{"id":75597,"url":"http://patchwork.ozlabs.org/api/people/75597/","name":"Loktionov, Aleksandr","email":"aleksandr.loktionov@intel.com"},"content":"> -----Original Message-----\n> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf\n> Of Greg Kroah-Hartman\n> Sent: Saturday, April 11, 2026 12:12 PM\n> To: intel-wired-lan@lists.osuosl.org\n> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Greg Kroah-\n> Hartman <gregkh@linuxfoundation.org>; Nguyen, Anthony L\n> <anthony.l.nguyen@intel.com>; Kitszel, Przemyslaw\n> <przemyslaw.kitszel@intel.com>; Andrew Lunn <andrew+netdev@lunn.ch>;\n> David S. Miller <davem@davemloft.net>; Eric Dumazet\n> <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni\n> <pabeni@redhat.com>; stable <stable@kernel.org>\n> Subject: [Intel-wired-lan] [PATCH net] idpf: fix double free and use-\n> after-free in aux device error paths\n> \n> When auxiliary_device_add() fails in idpf_plug_vport_aux_dev() or\n> idpf_plug_core_aux_dev(), the err_aux_dev_add label calls\n> auxiliary_device_uninit() and falls through to err_aux_dev_init.  The\n> uninit call will trigger put_device(), which invokes the release\n> callback (idpf_vport_adev_release / idpf_core_adev_release) that frees\n> iadev.  The fall-through then reads adev->id from the freed iadev for\n> ida_free() and double-frees iadev with kfree().\n> \n> Free the IDA slot and clear the back-pointer before uninit, while adev\n> is still valid, then return immediately.\n> \n> Commit 65637c3a1811 65637c3a1811 (\"idpf: fix UAF in RDMA core aux dev\n> deinitialization\") fixed the same use-after-free in the matching\n> unplug path in this file but missed both probe error paths.\n> \n> Cc: Tony Nguyen <anthony.l.nguyen@intel.com>\n> Cc: Przemek Kitszel <przemyslaw.kitszel@intel.com>\n> Cc: Andrew Lunn <andrew+netdev@lunn.ch>\n> Cc: \"David S. Miller\" <davem@davemloft.net>\n> Cc: Eric Dumazet <edumazet@google.com>\n> Cc: Jakub Kicinski <kuba@kernel.org>\n> Cc: Paolo Abeni <pabeni@redhat.com>\n> Cc: stable <stable@kernel.org>\n> Fixes: be91128c579c (\"idpf: implement RDMA vport auxiliary dev create,\n> init, and destroy\")\n> Fixes: f4312e6bfa2a (\"idpf: implement core RDMA auxiliary dev create,\n> init, and destroy\")\n> Assisted-by: gregkh_clanker_t1000\n> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>\n> ---\n> Note, these cleanup paths are messy, but I couldn't see a simpler way\n> without a lot more rework, so I choose the simple way :)\n> \n>  drivers/net/ethernet/intel/idpf/idpf_idc.c | 6 ++++++\n>  1 file changed, 6 insertions(+)\n> \n> diff --git a/drivers/net/ethernet/intel/idpf/idpf_idc.c\n> b/drivers/net/ethernet/intel/idpf/idpf_idc.c\n> index 7e4f4ac92653..b7d6b08fc89e 100644\n> --- a/drivers/net/ethernet/intel/idpf/idpf_idc.c\n> +++ b/drivers/net/ethernet/intel/idpf/idpf_idc.c\n> @@ -90,7 +90,10 @@ static int idpf_plug_vport_aux_dev(struct\n> iidc_rdma_core_dev_info *cdev_info,\n>  \treturn 0;\n> \n>  err_aux_dev_add:\n> +\tida_free(&idpf_idc_ida, adev->id);\n> +\tvdev_info->adev = NULL;\n>  \tauxiliary_device_uninit(adev);\n> +\treturn ret;\n>  err_aux_dev_init:\n>  \tida_free(&idpf_idc_ida, adev->id);\n>  err_ida_alloc:\n> @@ -228,7 +231,10 @@ static int idpf_plug_core_aux_dev(struct\n> iidc_rdma_core_dev_info *cdev_info)\n>  \treturn 0;\n> \n>  err_aux_dev_add:\n> +\tida_free(&idpf_idc_ida, adev->id);\n> +\tcdev_info->adev = NULL;\n>  \tauxiliary_device_uninit(adev);\n> +\treturn ret;\n>  err_aux_dev_init:\n>  \tida_free(&idpf_idc_ida, adev->id);\n>  err_ida_alloc:\n> --\n> 2.53.0\n\nReviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>","headers":{"Return-Path":"<intel-wired-lan-bounces@osuosl.org>","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=iwbmQL8F;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvPjt2mcHz1yDF\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 13 Apr 2026 21:06:40 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 56A4860E16;\n\tMon, 13 Apr 2026 11:06:38 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id QM_NTuZMfX29; Mon, 13 Apr 2026 11:06:36 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id A698B60E0C;\n\tMon, 13 Apr 2026 11:06:36 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id 92D11283\n for <intel-wired-lan@lists.osuosl.org>; Mon, 13 Apr 2026 11:06:35 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 78348400BB\n for <intel-wired-lan@lists.osuosl.org>; Mon, 13 Apr 2026 11:06:35 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 4WQaaXQ4IbXB for <intel-wired-lan@lists.osuosl.org>;\n Mon, 13 Apr 2026 11:06:34 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.18])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 6FCE7400A0\n for <intel-wired-lan@lists.osuosl.org>; Mon, 13 Apr 2026 11:06:33 +0000 (UTC)","from fmviesa003.fm.intel.com ([10.60.135.143])\n by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2026 04:06:33 -0700","from fmsmsx903.amr.corp.intel.com ([10.18.126.92])\n by fmviesa003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2026 04:06:33 -0700","from FMSMSX901.amr.corp.intel.com (10.18.126.90) by\n fmsmsx903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Mon, 13 Apr 2026 04:06:32 -0700","from fmsedg903.ED.cps.intel.com (10.1.192.145) by\n FMSMSX901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Mon, 13 Apr 2026 04:06:32 -0700","from SN4PR0501CU005.outbound.protection.outlook.com (40.93.194.29)\n by edgegateway.intel.com (192.55.55.83) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Mon, 13 Apr 2026 04:06:31 -0700","from IA3PR11MB8986.namprd11.prod.outlook.com (2603:10b6:208:577::21)\n by CY8PR11MB6841.namprd11.prod.outlook.com (2603:10b6:930:62::11)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.20; Mon, 13 Apr\n 2026 11:06:29 +0000","from IA3PR11MB8986.namprd11.prod.outlook.com\n ([fe80::e6f0:6afb:6ef9:ab5c]) by IA3PR11MB8986.namprd11.prod.outlook.com\n ([fe80::e6f0:6afb:6ef9:ab5c%5]) with mapi id 15.20.9745.012; Mon, 13 Apr 2026\n 11:06:28 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org A698B60E0C","OpenDKIM Filter v2.11.0 smtp2.osuosl.org 6FCE7400A0"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776078396;\n\tbh=aaUQkm3ji4uWuAHcc09ZH0307zoZoU5oSbymUpchdyw=;\n\th=From:To:CC:Date:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=iwbmQL8FC52mEZV81+/BeZaGHto5i/Vg0hFuuWnZ5N9JmBzaTtZdAO4SVqCna7yDp\n\t adcpTsuiYFx7Ud3nB5TQ+kR37Z6M5ROUrfza40XWzXJaNufL8MUR7VQ1KCUK/FEI93\n\t ubUJf3OAEo2Ym23zKuy4XfVB51hQl4MFZK+lzgVk4vPdQhJICl0kbU6MVvICi9ZGST\n\t +Vaq2VndkwagXEDpkWiyq3Nr6bF/Z8Hy9kYSNYozYjYCUyFkEyZ37eD7N9EdZngXNk\n\t MVrpWsuA3KP5ADskEQNEhrQd5uyro3Cw58tWwn4Mhl8LyBo1DS1y2ailbm0ZQ0zMt0\n\t fx2Lq7TDqen7A==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.18;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=<UNKNOWN>","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org 6FCE7400A0","X-CSE-ConnectionGUID":["JgI4ekiWSfq7cPNcOXpzRg==","mlvWuf6pQ36MZO9UaIyyFw=="],"X-CSE-MsgGUID":["YArqW/nYQVSZYpuO/w15gQ==","+B8Kz/1WTead0PEI+pYKKw=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11757\"; a=\"76175838\"","E=Sophos;i=\"6.23,177,1770624000\"; d=\"scan'208\";a=\"76175838\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=aGqJWnRxWYdNAMCV0/RRjfsvNmr8JRF8DJphqZXAWDsXjVvCtfm41Fhn1kB8WmVhL2x4p2K8KiA0rBSQ4OMSZDjDFCm+ocCVrSqcUbvrZ57lwRCGiu7xFsYR39fRgH58c1FxX8fs5WVo1p7xA2GF4jQR9zxY2QNt2XsiegPtbhVZlwdux8PP3N1hKSLMhRRkJ5y7ezDvg/kWFZV42Rczkq8mZ8oM3twkAEcDvvZ0NX6bv5PS+GKOM3uU93gRxd6n1HQvDGR+KmKl6vtbgYbR7RzO2saVXO31C+oVSt8+8u4AGBR8LIKicGA3ATZ0QXo1u0FQBtFz64b6q+lwKBegsA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=aaUQkm3ji4uWuAHcc09ZH0307zoZoU5oSbymUpchdyw=;\n b=iSHgVw79zRbMvHw+5kyyoEZzfOVPlGiyYF/10vLFKbya6izMK+k1F5B7g91Y/mYQMaOWOwR9/A5BRSW4p2ouIJEvSORtBDxGpkw5H6Os0GDSb4Ln7Y1U/zsMO5+SH1hd0zOTg0mQXUzuw3OpHuccEPoKLfvQP388J0sXTf3CArTvqbcexP6m+sJqBJ+pMZY6DMZd5/2gzF8Sd1DcpPZYe67gZpoLC4jYlUHq0GubGL6yjHOnDjQExdu12r8Ejp9Pd3oq1F2SuUjbzLfmo39IBDw7lOI7Sd3ypGJFTFc5FwxApjkYavGjzJLXB5oVeZBEOBMXP2QeXdfCX27sf6x5wg==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","From":"\"Loktionov, Aleksandr\" <aleksandr.loktionov@intel.com>","To":"Greg Kroah-Hartman <gregkh@linuxfoundation.org>,\n \"intel-wired-lan@lists.osuosl.org\" <intel-wired-lan@lists.osuosl.org>","CC":"\"netdev@vger.kernel.org\" <netdev@vger.kernel.org>,\n \"linux-kernel@vger.kernel.org\" <linux-kernel@vger.kernel.org>, \"Nguyen,\n Anthony L\" <anthony.l.nguyen@intel.com>, \"Kitszel, Przemyslaw\"\n <przemyslaw.kitszel@intel.com>, Andrew Lunn <andrew+netdev@lunn.ch>, \"David\n S. Miller\" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, \"Jakub\n Kicinski\" <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, stable\n <stable@kernel.org>","Thread-Topic":"[Intel-wired-lan] [PATCH net] idpf: fix double free and\n use-after-free in aux device error paths","Thread-Index":"AQHcyZu/E8M8djZt4kS6cHaoKhkcRrXc191w","Date":"Mon, 13 Apr 2026 11:06:28 +0000","Message-ID":"\n <IA3PR11MB89867D9A3665ECA17BE60ED7E5242@IA3PR11MB8986.namprd11.prod.outlook.com>","References":"<2026041116-retail-bagginess-250f@gregkh>","In-Reply-To":"<2026041116-retail-bagginess-250f@gregkh>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"IA3PR11MB8986:EE_|CY8PR11MB6841:EE_","x-ms-office365-filtering-correlation-id":"02cfbcc5-12c7-4a5e-71ab-08de994cb647","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"BCL:0;\n ARA:13230040|376014|7416014|366016|1800799024|38070700021|18002099003|22082099003|56012099003;","x-microsoft-antispam-message-info":"\n ywiKFFVNcM5Hj8vTWe4bBfhbxe7mQINahQZCoE6npU9aRaEwbM9SombKlzPc/3OrnyBly7xUiS/Kboi5B91mjGuww3Dw15bdMVze65RG4rPio7E2zJPoVn9LVp4TbetlEf6M47FtpTEJ9P3XcEdBlcRcG6mJS8XKnCdfyMtdfO6im3sOZPP7Hh9MMcfrU5ilgq7S0NAUJsHfrQ5OWFAhwzWT7I8nHwtmxFWtP9IMArBgpkYY4SU5+i6a5PaEyLrmOUBFIHbYI6CpU8HgPPzoAI2vrkNJt5SOegLhfsIZrwO72bA5af/17p2tqEdNnWW+oXlTMOIKDbHqvcO5SYpihTl0Xc4qUhKFdo2CMSkR1SHGF5CaJmI4wMe1Uhsm+0shWttwgyE2RB9K4Xb9TJYZow/Kg2/qwdDQEVzJ63tCq3PRZECJj7HjrRSZnS6s34uUCb4WdsDOeEtWutoSs4oZSu/5URopbg69Bu0sleIZZBOA5Gj771sTT/jMFD5GkDLjVggI+gtbEc2qODxLMo/VhPmwa3tSa6H4N5Yu8ym7H8dP6ArgftX99Vib/RzhCKA1/T550Ti/GtPSYb5mBLDnIhXGccuj8GexOps93SmZoOlpBpI8B3TSGH9nuv09IrfiNhlZcTJ8DoQTHbrHxDi2j84drU16+GrVx96XS66IiRnwv7WdU9LF468H2UQz5uAqj2r0K5gkE3Ky9kHB6p+cYuopfFeCpEI+fMFBEVgDCF2ZIdssCWtE/5pnjHO29fVu3f7dcPXiyX7xL7quoZULVygL+uD/jS2IHd0T1ZaVp2M=","x-forefront-antispam-report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:IA3PR11MB8986.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(376014)(7416014)(366016)(1800799024)(38070700021)(18002099003)(22082099003)(56012099003);\n DIR:OUT; SFP:1101;","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"\n dZpxGD4v9W8zWJC3cb4OMAyD6U1UCLVIlm4bKUf8CO5edEZmTbIv/pjQIsN4IvLAoFOM9tXovM30mdx1s169daRyNsX4mIugsmMj0bROmuSEDrOjiNIwnBzjfuwoQ/C50FgCnm8k2QWQSiEwynP5y8rF0Osy3yw1Liy2seQn32mA0eHGfHBWOxIlgvjVYp/AWd81X15F0kS89K2YuhKq44CEXz75XLYOD6xiYeZ/0kUUeQ70jRIoE7OYmkbHiHWavkGHUanVP4Max0K+Re11f0Y63UWZo+jDhQ+1nC/pXkecWFoG/qN1QoiCFVc/0CSLWHDnXMfYS79TVlxKBGl9R0pT6NzETZTpgVYm+VTxxe94G3Nt+7QUjGgVcn9/UXnfkMGIKS7dJSqu7LW0cy20eaZep0H10dVNLLq3oZMUj3WiJuLzK2RtsMijAeRCn5DjpXz914kB3bqmomP7eYD52uo9YuIVSijkc4LjCRLxT31tVFuQYawoM5haZlbp9pmrsWk5u0LM3P9dptoHx6i98c8e0OJTpqeIvZJZlDOKMmhyMDY+KGTLEGkEUCLPpiOYGSAWTFwd8R42g1c6Z+6KePnnz3qz9cq1Eul82ujgWnmV10Vrumt2+EDQcyhxEk5bmAb9NmG+GkQLviM2b6F8kiV4fA4w+60I9f81tnYVKoVyU2tSnKI2iT9vJcX427VTFbWnO9WZyrgamIkjmYx8qMNwARUHZJQlGl0WiKOeD8jatBaJVLVMEUfKla7RxlvNjOEcOrLkMY76tMzwdqxz+hr5UkD1g9H8QAIO0cZ2tcSWF0cf6iN8W+/G1lfu8YoiEGVKalyFMAfWNkEAiq2bx6I1DBOcSELapzXWD/s1nO8Mi+5pXldoGwtqd85MzusMi+HcxcgrfJl4nb+z456lrWza/rrILnTDJ6LztDfgGt7ZvdZdu/TXDem9OS5XPqytL2PX/1DLhiQ9yutzRuCKhYiCHv+ZE6HbYtofliYLLvApk8MsWaWkZTtklxSH5pupMxdG/Mf+ly3h7VjjA8GEC5AguAc6Ou+6LS0vnkgq6gGDvMsOL3alaJoxpMBI88x3fD9LZwbt4aQjkHUrcVkJcaC3OboN3CuSlf/lTQzSMmlFILw1YhxIONIKXxHYXzQvGJMMkei9KhUWu9GMVjyT9kGdiUbdWX3O55lKjo6ETJX+BTevrbMwcAbWB2GRJfRLcs1iszC3B4BU5zRhU9hujfziTJrEmpU6LO+3ZKD9N70VkdlayVhePrTGwmje0mq7FgXFT8tDgmmT3CUOGWVJWfIMXIAmtXLmzjfl2acfV8EO/62moeoUtWhwC8Y5t00fYYp9g27jvJuOs4MatSg/2pPYp9u1qdb4erhXhALIaqSlkGQTpxykrXPvS+8UVVtpFO71tptVn5+LaJJh9wFWdw+LbQ+6L23gBZtcHMkC55UEhzqeslTTh+uqCtwnBWZYATc/ZwHve+YwDTCYdkP721jqZmqKIx1bwVTXBOoS2uNI+6o25TE9XuShtl5iFG3dYtQclN+Y6oGX/KyNVVmI7rCeOOzxg7X/ld5qqvCfEp2ZGwRXXuFp0Q/gSz3FtX0Ui5pn8sF64HHAgWQgLjBPRdxVwSF4TpnUaP/SISXKLhIwNhLeBu5DKH2WOGp4eKQdUZy/N7uisRtt9PE3oWcMJKFJAgCOaoPalP0SBTT3XHUmkfbTNsHjeTHhsj57vhgXrollYN3mKrU24/Dz4otSWO+Ei1hasrrLpuzA+vKcMb4=","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-Exchange-RoutingPolicyChecked":"\n L4KbBUS3i/6lfAE+PsTtCMKxHuWoPF1fEPLF2LNTZJVuEJi+brYMGQWtLl1gy3Q1KSYie2ycIfAMxPl53tB6JpzZD0ZsM7dJdTvU7gU24cHexMrM1zLJy3mPcUJtCAJT4bxgfMbk/GEkFYNrl92e1hNQgGij/Sk+eFnNHPuiUoKAOEUiRtgNjcDshHwW24m3HUoQi8srWrU+OH6eVexetAH2Bx0nmp42omooZox7T677VFPG1624XhrCxz+6MPLv879f07/0T7mEGtFE0SZS35Ir0IQ1//RFw3xNVkVlUvKx1/1aX/r+zh01uEC2z32/55xiFozJasJd30PEVGt5cw==","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"IA3PR11MB8986.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 02cfbcc5-12c7-4a5e-71ab-08de994cb647","X-MS-Exchange-CrossTenant-originalarrivaltime":"13 Apr 2026 11:06:28.7827 (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n 0ogz87aWeiLiYwGkOwKNNSWfTG0kcC+a4QYMhjLYn/q/CwXU/VGR5oV4yOgu9it4QwTz+Xae4jROTrIycTcnn1GiwCuP1Ir+YifuhdH8FYU=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CY8PR11MB6841","X-OriginatorOrg":"intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776078395; x=1807614395;\n h=from:to:cc:subject:date:message-id:references:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=KBK2E7QiyKADSHTVjqsnMKUr82SRUu8zpVloX1ccoXU=;\n b=nc0mOszhur/hdYvKaWqEKv0YCZn4kTn8UYg1pBq0yBS5PA41gZHBVnxb\n U92pbRHtfDXA+g6PDp22y+X2GukN6dNbLZWXv1V00o4gKyGV8/txKkECF\n DCEVJiDHM5szKOdGs4YMEa2q/lPfKFKu+vdhyWmutI/sZpqFPNXhE+1yv\n Y7yZoR4BzBU5ATS6ro4NktN2upUQjACEQUbcNCF1FXrpIEt/j4YyNFNtJ\n sIA9ySFLTuOuINWh4cq5M6REb1Yh58FIUmvlJjtQBrMkdqZIegaDTTBDW\n AO4uA0KkP81mwUdMq5BNOzBQCKPrwCauviAPhTPdUPZPTV3BJdfrl2H81\n Q==;","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp2.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=nc0mOszh","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Subject":"Re: [Intel-wired-lan] [PATCH net] idpf: fix double free and\n use-after-free in aux device error paths","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>","List-Unsubscribe":"<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>","List-Archive":"<http://lists.osuosl.org/pipermail/intel-wired-lan/>","List-Post":"<mailto:intel-wired-lan@osuosl.org>","List-Help":"<mailto:intel-wired-lan-request@osuosl.org?subject=help>","List-Subscribe":"<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>"}},{"id":3676992,"web_url":"http://patchwork.ozlabs.org/comment/3676992/","msgid":"<193fdf9e-db5f-4ae0-9a8e-d7049fa74ee6@intel.com>","list_archive_url":null,"date":"2026-04-14T00:46:54","subject":"Re: [Intel-wired-lan] [PATCH net] idpf: fix double free and\n use-after-free in aux device error paths","submitter":{"id":9784,"url":"http://patchwork.ozlabs.org/api/people/9784/","name":"Jacob Keller","email":"jacob.e.keller@intel.com"},"content":"On 4/11/2026 3:12 AM, Greg Kroah-Hartman wrote:\n> When auxiliary_device_add() fails in idpf_plug_vport_aux_dev() or\n> idpf_plug_core_aux_dev(), the err_aux_dev_add label calls\n> auxiliary_device_uninit() and falls through to err_aux_dev_init.  The\n> uninit call will trigger put_device(), which invokes the release\n> callback (idpf_vport_adev_release / idpf_core_adev_release) that frees\n> iadev.  The fall-through then reads adev->id from the freed iadev for\n> ida_free() and double-frees iadev with kfree().\n> \n> Free the IDA slot and clear the back-pointer before uninit, while adev\n> is still valid, then return immediately.\n> \n> Commit 65637c3a1811 65637c3a1811 (\"idpf: fix UAF in RDMA core aux dev\n> deinitialization\") fixed the same use-after-free in the matching unplug\n> path in this file but missed both probe error paths.\n> \n> Cc: Tony Nguyen <anthony.l.nguyen@intel.com>\n> Cc: Przemek Kitszel <przemyslaw.kitszel@intel.com>\n> Cc: Andrew Lunn <andrew+netdev@lunn.ch>\n> Cc: \"David S. Miller\" <davem@davemloft.net>\n> Cc: Eric Dumazet <edumazet@google.com>\n> Cc: Jakub Kicinski <kuba@kernel.org>\n> Cc: Paolo Abeni <pabeni@redhat.com>\n> Cc: stable <stable@kernel.org>\n> Fixes: be91128c579c (\"idpf: implement RDMA vport auxiliary dev create, init, and destroy\")\n> Fixes: f4312e6bfa2a (\"idpf: implement core RDMA auxiliary dev create, init, and destroy\")\n> Assisted-by: gregkh_clanker_t1000\n> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>\n> ---\n\nThis is targeted at [net]. The fix seems straight forward enough.\n@Jakub, I have no objections if you want to pull this directly. I am not\nsure our validation team will find anything when testing since this is\nan error path that is historically been difficult for us to test.\n\nI'm also fine with taking it through iwl-net if you prefer, but just\nwant to avoid duplicate work if you're already considering it.\n\n> Note, these cleanup paths are messy, but I couldn't see a simpler way\n> without a lot more rework, so I choose the simple way :)\n> \n\nYea, I didn't see a better way either.\n\nThanks,\nJake","headers":{"Return-Path":"<intel-wired-lan-bounces@osuosl.org>","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=7XJ/3HDw;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvlwY4K01z1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 14 Apr 2026 10:47:07 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id DACCC427DF;\n\tTue, 14 Apr 2026 00:47:04 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id pg4cJitNba4R; Tue, 14 Apr 2026 00:47:03 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 48F81427DD;\n\tTue, 14 Apr 2026 00:47:03 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id 91217283\n for <intel-wired-lan@lists.osuosl.org>; Tue, 14 Apr 2026 00:47:02 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 8EF7D42332\n for <intel-wired-lan@lists.osuosl.org>; Tue, 14 Apr 2026 00:47:02 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Gv7_B103bBlJ for <intel-wired-lan@lists.osuosl.org>;\n Tue, 14 Apr 2026 00:47:01 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.18])\n by smtp2.osuosl.org (Postfix) with ESMTPS id AC9B8402A4\n for <intel-wired-lan@lists.osuosl.org>; Tue, 14 Apr 2026 00:47:01 +0000 (UTC)","from orviesa003.jf.intel.com ([10.64.159.143])\n by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2026 17:47:00 -0700","from orsmsx902.amr.corp.intel.com ([10.22.229.24])\n by orviesa003.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2026 17:47:01 -0700","from ORSMSX901.amr.corp.intel.com (10.22.229.23) by\n ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Mon, 13 Apr 2026 17:46:59 -0700","from ORSEDG901.ED.cps.intel.com (10.7.248.11) by\n ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Mon, 13 Apr 2026 17:46:59 -0700","from SN4PR2101CU001.outbound.protection.outlook.com (40.93.195.69)\n by edgegateway.intel.com (134.134.137.111) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Mon, 13 Apr 2026 17:46:59 -0700","from DS0PR11MB7579.namprd11.prod.outlook.com (2603:10b6:8:14d::5) by\n DS0PR11MB7785.namprd11.prod.outlook.com (2603:10b6:8:f1::8) with\n Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9769.48; Tue, 14 Apr 2026 00:46:57 +0000","from DS0PR11MB7579.namprd11.prod.outlook.com\n ([fe80::4199:4cb5:cf88:e79e]) by DS0PR11MB7579.namprd11.prod.outlook.com\n ([fe80::4199:4cb5:cf88:e79e%5]) with mapi id 15.20.9818.014; Tue, 14 Apr 2026\n 00:46:57 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 48F81427DD","OpenDKIM Filter v2.11.0 smtp2.osuosl.org AC9B8402A4"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776127623;\n\tbh=dByCiFUKFC0gnLHfCvFxk7BLtQXcJtwrXIIh8ViFps8=;\n\th=Date:To:CC:References:From:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=7XJ/3HDwY+N1gBPT45UzDUgByJe1gafr1LcMaxxxCB6acAWcnEr5wyhC9cwKuX2rj\n\t vlOkl0jAIHrD9iDvrbG2rEifhC50fezZ49WU7S08VhOMf1NwOdXojbKFzuKJOACmMu\n\t SpRRjZUAG6fPMc2vSdohPzSm7fpvQrRXYDy0HNveQl/YUrOmTckl3a/4U1aNZFUxbP\n\t yI48tUg2kEBWNLs6KcO6OiAXbbqVZqTGJTi5509rXDnev/3w9OokGyFkX2i3sfeAhl\n\t j6z+flg+GvbhzRNufkooxu+Dh/cF5Uw3Indap7n1xBpO2jsN41x3gIWvSofdO6FRom\n\t ctwOSEASqZMLQ==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.18;\n helo=mgamail.intel.com; envelope-from=jacob.e.keller@intel.com;\n receiver=<UNKNOWN>","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org AC9B8402A4","X-CSE-ConnectionGUID":["M4HcGgEJTtCNkoJ1q/KNwA==","0J9HbI62Sxisd6pSvNfXIA=="],"X-CSE-MsgGUID":["sTl779jMR9abQyg7ccNpag==","/RICMNQBRe6kxlsZT/FDQQ=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11758\"; a=\"76238581\"","E=Sophos;i=\"6.23,178,1770624000\"; d=\"scan'208\";a=\"76238581\"","E=Sophos;i=\"6.23,178,1770624000\"; d=\"scan'208\";a=\"233965560\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=Nrkq3KICbRK8IFu1uR17aCDwUUVWOzPafyilJaq3HyKiZNEBsLoDWpuMrYK5rUqp6YszzVTgD2P7L/RJ4DpO2P4Ut/eDgneVGw7kLujwFmfyEunD2nN0yGXe6A5P3z3Y2eV0fFPHyTa3KTKLs5PNiDwV/l5sBpkokGIGw+cb3xHodnFbDXobDV8mVnC6PQyU6m7SHKogQq4gKehzA+FD3yk3l7BiSoc66OCOwvXuaNVMTUsBi3XyFawPd7ECNICDj6laXM9gi+w+3f02U3ZMB5f0apGEIuHVF7HTDy91D35xxHRj5kCZ+BKT8dd42B/vCZ+OH6U0LcMvZPdd9wsirQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=dByCiFUKFC0gnLHfCvFxk7BLtQXcJtwrXIIh8ViFps8=;\n b=lYx98lCdEkL4X0xek9xgJYULCXFQaBS6MuLQSodEyrvDaz2wS6Ftb4eV6dHpy8/2uCismpImWMgb2fiY/uWHqHNLciYDrWvFyr6JkyFcrpup1WRxuIQD/Adep/g55NMwWvSh1Xw1PNGnGJJ82zKeJnxddSUOxtT+/CA9fFi1hGBgRBrSYIaPCD313JJsyFuzg6tx4DajBcw1Sia4CbF7mLCUyHUJtPwMhuDQyaFD/Dtna+gcoO0SSGApTFB6/Hw9Ls0L0J+QdA3Yjrfbft6LRXvKIa8DeEwiF803jz5L0WAmc+/ayTzLAeHN816lVV4PL15w9IQXniAfegKtmnrX7g==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","Message-ID":"<193fdf9e-db5f-4ae0-9a8e-d7049fa74ee6@intel.com>","Date":"Mon, 13 Apr 2026 17:46:54 -0700","User-Agent":"Mozilla Thunderbird","To":"Greg Kroah-Hartman <gregkh@linuxfoundation.org>,\n <intel-wired-lan@lists.osuosl.org>, \"netdev@vger.kernel.org\"\n <netdev@vger.kernel.org>, Jakub Kicinski <kuba@kernel.org>","CC":"<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Tony Nguyen\n <anthony.l.nguyen@intel.com>, Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n Andrew Lunn <andrew+netdev@lunn.ch>, \"David S. Miller\" <davem@davemloft.net>,\n Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, \"Paolo\n Abeni\" <pabeni@redhat.com>, stable <stable@kernel.org>","References":"<2026041116-retail-bagginess-250f@gregkh>","Content-Language":"en-US","From":"Jacob Keller <jacob.e.keller@intel.com>","In-Reply-To":"<2026041116-retail-bagginess-250f@gregkh>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"MW4PR02CA0028.namprd02.prod.outlook.com\n (2603:10b6:303:16d::7) To DS0PR11MB7579.namprd11.prod.outlook.com\n (2603:10b6:8:14d::5)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"DS0PR11MB7579:EE_|DS0PR11MB7785:EE_","X-MS-Office365-Filtering-Correlation-Id":"e169e9db-4d55-42f8-93c0-08de99bf54a1","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|1800799024|366016|376014|7416014|18002099003|56012099003|22082099003;","X-Microsoft-Antispam-Message-Info":"\n PP+qiXr7VRc/I4WP+9FhsQPEtbZ2Kx29OI7qQfGzszGRxVcHrt3WlodUbrAg/PtZS25aCquG4bcheC4ZNaw4vxThN6uU0GwBBq9/SvWYBIHvhwMyPZM1czZUpmwSqD83u8LpJuU6E9OXA1ymq0zftaDKAOr4zjN1TnaF3yZNPmgrvRO4JOcGdfCkXN5GXWPMsLeIq3XpffOHiHylIlZIBNeOMABlzn7O6f+weBfA6Ac/6LZwC0VvR1p5mb06N8oiD6QTXkJIj40oV6t0ueFhXlVsCWQVVgVGMPNRJj58d+CDcTf5816shs8wNHt0+ax3attyP6CxPlN8XX3CtB8vCGDlMK+emDtVwS0rrJdBuglJFOiGcgmIHMM3iBdXMXYzUQUs9EkhKO8ufJfyo2v80R53DmWNrqf5ApB5D8ngEJwl44G+q1ktfaem1ui+JgbRtEIGPdoiJ6NeJVPqwFZEnrVn+wwATFm7zV/MD/waRmFU3KPs00qF6AhP78Hnb9kdXmXnamZQoufxhYSjI1QEu+ZhKAPlPuiWs3S4eGpGhBCl9K4CFfQP/rGtttnEiP+pkWDfORhjXWEw3zBGTmuq0x3540kCgWD+SWc19YWasSXOuUnto1h4UiH2x0Go1v9tsietXeggH3QkefEOBYDoJ2BRnIUzwaCXGZjpQNaKVIwpCQqtAQeVIpeqk99ttCzLeRjB5L8aARIHoHQj2YkREmZNjljeIhvrRS9rdJMtujw=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DS0PR11MB7579.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(1800799024)(366016)(376014)(7416014)(18002099003)(56012099003)(22082099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?0T0UlPUDxzxPoWAuK5dOgxMd5Kq1?=\n\t=?utf-8?q?Lsy3haIPYXnbhRaEgKwtjZmlddniUlmIfwge/L/wfeFRgUnH6vfTxgl4AK+69RVvt?=\n\t=?utf-8?q?8DtKHUaKQvpGuOb4zOBaKwHbyhXh6/i4BrPgV3Wv2SlL/J9wegKmbsn5PTv82SlJ2?=\n\t=?utf-8?q?HObA66fsHQkO97Bo3A8wO//NJnn1nWG7Dw7CYvNprmIR9y/eMSw9ZKPR6a6/TGefc?=\n\t=?utf-8?q?agKMTVzutTHfku+P/xE836t/l/IBtgJry6QalZhoVue5g2xhPZ8wTnUXN14F0DHWD?=\n\t=?utf-8?q?Yc1z4aYV3ZV0w4MdU50HRE728hPmP9UlkpM1odQIWQ0CAYYb8v/FtN+xt3Glmv+DD?=\n\t=?utf-8?q?jyHiMoQufm1j+rS7EhhAfjAqOOfXg2H431qKM6Obuic7tCqllznxGWOnjOw3PjS1P?=\n\t=?utf-8?q?Z/6r4SOMhGmUysRs3LradIO9JgJVZg/puHr8kLrNoADwiuBoa0hU4vKyQwAW4VEgF?=\n\t=?utf-8?q?EoDjGt6hgumAla0RxZr7BzDZjpPoazJaOwZXPoozNVa1nRr2ivjrfdKUzpL68yuTL?=\n\t=?utf-8?q?CFBe4AVcJw6ZaDxehKroQF9vDcjZgcEKfwzWr2i3M3JM0e4zp0KPsj+dha6KFxQS8?=\n\t=?utf-8?q?o9rxyzIGI8nWxjocB/yYB2m5HzHUUKd4ReVAu5xCNUWlDcrK6sgBUNPA/gYj+7TPX?=\n\t=?utf-8?q?NANb2LF66UH6cJj8OgaFbWn0MYmerYOEds/RDHtdb2QrCe5RvgvteW3t92rWtkkDi?=\n\t=?utf-8?q?KhfZuOTNgAv/goxIx9TgPveRo7TfbeZKDCoBcQXGIc+aKyNg1CLSP/yKt7htpSdBj?=\n\t=?utf-8?q?DesTzyi8leT3RPGoK9rCqv0/GtyG2hcC47lLuncbZE4UDcmPjmuAXJRU89+LWJV0e?=\n\t=?utf-8?q?f6rj6/7yfGMkGg64O8MTKy5ZeYzrC0m//jA8hM+AQpYana307Udp50eSogilgWjjI?=\n\t=?utf-8?q?hN2wpL4nu6rQuoHkIsbHfe5y454gykdjELitu8Dc1ChJd/Ky9GIZaRT8vQb3C7T1C?=\n\t=?utf-8?q?rlbUeKypY6l3EnGTLvoSkDQtLPtqiwaPH4DhhxN7MIPdyOZOm74wmdAHAjRjxRh8H?=\n\t=?utf-8?q?bSNCW7wyUJI9dW0vmcwtHCW1cUHztmeeL//pKCcMcZk5XlYT1OWRobSvzocgzhmDg?=\n\t=?utf-8?q?PFRLOt/PQ/BzcooY06ISkxTJKZfObkZxsG8Y4zv7xlm8ifMjh8DgW0biZiOoEO1gy?=\n\t=?utf-8?q?g7hrCruCNZJbZtAE4zt0VOZi8+MPu5BbM94sqbQKyw1zpYDPLzLukVNvcNVe1dbfX?=\n\t=?utf-8?q?WOROdXGn6utRrqrHbgioChEX8AiA9ZJHabEQr/dr1DUv57WYDaVUqbhgSEgqAFJJ5?=\n\t=?utf-8?q?q+Vq9YV2mHqqJQZ/pUWIyoFdrau4w2taRWHatoGl5F7uPhIN/8N0OxpEEDpY+nncF?=\n\t=?utf-8?q?sD/N7Oe8Zbyour0EIWUNNCQXNztgOKD/ueSkEw0OL9pb4BdA8XnhB+1ILcs9HXnJN?=\n\t=?utf-8?q?KsLewtmMdC2s5TsNyeIlqp2qgQkXWE1rPwc2UZ+JPFStogil4b5LjrBWS+0xOmKmC?=\n\t=?utf-8?q?UrkWDB7eWkjG6Y7eGMd9oIYSrxvbdGSs9QOubIYOfmBOGG2hg3DHPu3G0H5Itel21?=\n\t=?utf-8?q?/C3ZOzdoS10Y9pyJLYo4+ZGM+RMwGnZa6Tru0IS1FU63wHfOVnIpBMz+Ln3pif794?=\n\t=?utf-8?q?VZvOBIa/36kaZ/S1J7I5OJVzffuORrm4Geb1u1aWYnuYX7FtXSFP6Q74LG8+OEeeu?=\n\t=?utf-8?q?zzsdPAQ6d7sKPwWNQTT2DkiPn9250FfQ=3D=3D?=","X-Exchange-RoutingPolicyChecked":"\n gZaF8nh7R4okZ1opvEO3cKdmLI5SL/IEw38tznyHjEQqRc8UPAYLAGlWxTp35S8k2HZOtfBDdv0Hrm8cWFW2eEORcoVpvCuruXrZbKAml+Y1DI/Q7rQ1iqCriX1cCFx5nAvQraJmHEHvcU82dwyCazaTSXDEunx90uiENHsqWGsjsd2TgXVLIZTQrJ/6HpjXbz1lW9Gz+YFlFqFS5VCuLg3pVWg/ai7DmItIK/nnXVZuFLZPqW63dNVrx0u75+HdHxEsfiSaD96V5iAscBrlFR/aBAYQqlo7+atu9hUTombcmyEOetL2bgmeK3yrgWK0519vyrjtzLV/EPUmmr05Rw==","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n e169e9db-4d55-42f8-93c0-08de99bf54a1","X-MS-Exchange-CrossTenant-AuthSource":"DS0PR11MB7579.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"14 Apr 2026 00:46:57.2707 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n esgpJdqrnfV5p1kGo20Fiwk/7LLXPRBa9xfbRKQ8xwgRPT+DLRlCJvlMyHJ9oiTqaz/cWUOpkqbyQ/dXtYvWxGAIcLivQ5M92jWTkiM5rds=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DS0PR11MB7785","X-OriginatorOrg":"intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776127622; x=1807663622;\n h=message-id:date:subject:to:cc:references:from:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=VPDLZmNy8uRtrzRATp4EDfzDAw6oGSkuJt0YKYyMQ9s=;\n b=FzEQmmezp3dHm+uT+N1MWeb1cI5vZ1WUOcbx4D0BCwg9IaSfKfSdpWR2\n 8UmygW9vDDXbO3XNalyih3vexcV4DPlgLeddDirOTrgO3DmDa7j323E8z\n kzT8/SMcjVC61/D6Oa2rl4SBZRcKJUgUMeUhQz4o7bR7FPMxHdY25Wad3\n 2Cg79ES1btBQ6Im8Ql+NhWk+ZBeUIwhNk0E9wAulzlfsQG/eiTQjCRtRH\n gtSW8kFnGTxChvIhYK6l6QB42krIuTKU+auZZqWNoSd1iQiM1q2GvKfIt\n R7DPa1ebn1a9m+pV4ckAQuRq9BvgNZ34V0eKSdxLS6pOkT3t87RXfRVzl\n w==;","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp2.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=FzEQmmez","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Subject":"Re: [Intel-wired-lan] [PATCH net] idpf: fix double free and\n use-after-free in aux device error paths","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>","List-Unsubscribe":"<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>","List-Archive":"<http://lists.osuosl.org/pipermail/intel-wired-lan/>","List-Post":"<mailto:intel-wired-lan@osuosl.org>","List-Help":"<mailto:intel-wired-lan-request@osuosl.org?subject=help>","List-Subscribe":"<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>"}},{"id":3677037,"web_url":"http://patchwork.ozlabs.org/comment/3677037/","msgid":"<afefe8b5-5bd9-4019-9d12-5ee2a7f577a2@molgen.mpg.de>","list_archive_url":null,"date":"2026-04-14T06:54:55","subject":"Re: [Intel-wired-lan] [PATCH net] idpf: fix double free and\n use-after-free in aux device error paths","submitter":{"id":70275,"url":"http://patchwork.ozlabs.org/api/people/70275/","name":"Paul Menzel","email":"pmenzel@molgen.mpg.de"},"content":"Dear Greg,\n\n\nThank you for the patch.\n\nAm 11.04.26 um 12:12 schrieb Greg Kroah-Hartman:\n> When auxiliary_device_add() fails in idpf_plug_vport_aux_dev() or\n> idpf_plug_core_aux_dev(), the err_aux_dev_add label calls\n> auxiliary_device_uninit() and falls through to err_aux_dev_init.  The\n> uninit call will trigger put_device(), which invokes the release\n> callback (idpf_vport_adev_release / idpf_core_adev_release) that frees\n> iadev.  The fall-through then reads adev->id from the freed iadev for\n> ida_free() and double-frees iadev with kfree().\n> \n> Free the IDA slot and clear the back-pointer before uninit, while adev\n> is still valid, then return immediately.\n> \n> Commit 65637c3a1811 65637c3a1811 (\"idpf: fix UAF in RDMA core aux dev\n\nThe commit hash is pasted twice.\n\n> deinitialization\") fixed the same use-after-free in the matching unplug\n> path in this file but missed both probe error paths.\n> \n> Cc: Tony Nguyen <anthony.l.nguyen@intel.com>\n> Cc: Przemek Kitszel <przemyslaw.kitszel@intel.com>\n> Cc: Andrew Lunn <andrew+netdev@lunn.ch>\n> Cc: \"David S. Miller\" <davem@davemloft.net>\n> Cc: Eric Dumazet <edumazet@google.com>\n> Cc: Jakub Kicinski <kuba@kernel.org>\n> Cc: Paolo Abeni <pabeni@redhat.com>\n> Cc: stable <stable@kernel.org>\n> Fixes: be91128c579c (\"idpf: implement RDMA vport auxiliary dev create, init, and destroy\")\n> Fixes: f4312e6bfa2a (\"idpf: implement core RDMA auxiliary dev create, init, and destroy\")\n> Assisted-by: gregkh_clanker_t1000\n> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>\n> ---\n> Note, these cleanup paths are messy, but I couldn't see a simpler way\n> without a lot more rework, so I choose the simple way :)\n> \n>   drivers/net/ethernet/intel/idpf/idpf_idc.c | 6 ++++++\n>   1 file changed, 6 insertions(+)\n> \n> diff --git a/drivers/net/ethernet/intel/idpf/idpf_idc.c b/drivers/net/ethernet/intel/idpf/idpf_idc.c\n> index 7e4f4ac92653..b7d6b08fc89e 100644\n> --- a/drivers/net/ethernet/intel/idpf/idpf_idc.c\n> +++ b/drivers/net/ethernet/intel/idpf/idpf_idc.c\n> @@ -90,7 +90,10 @@ static int idpf_plug_vport_aux_dev(struct iidc_rdma_core_dev_info *cdev_info,\n>   \treturn 0;\n>   \n>   err_aux_dev_add:\n> +\tida_free(&idpf_idc_ida, adev->id);\n> +\tvdev_info->adev = NULL;\n>   \tauxiliary_device_uninit(adev);\n> +\treturn ret;\n>   err_aux_dev_init:\n>   \tida_free(&idpf_idc_ida, adev->id);\n>   err_ida_alloc:\n> @@ -228,7 +231,10 @@ static int idpf_plug_core_aux_dev(struct iidc_rdma_core_dev_info *cdev_info)\n>   \treturn 0;\n>   \n>   err_aux_dev_add:\n> +\tida_free(&idpf_idc_ida, adev->id);\n> +\tcdev_info->adev = NULL;\n>   \tauxiliary_device_uninit(adev);\n> +\treturn ret;\n>   err_aux_dev_init:\n>   \tida_free(&idpf_idc_ida, adev->id);\n>   err_ida_alloc:\n\nReviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>\n\ngemini/gemini-3.1-pro-preview has two comments [1]. Maybe the driver \ndevelopers could judge their relevance.\n\n\nKind regards,\n\nPaul\n\n\n[1]: \nhttps://sashiko.dev/#/patchset/2026041116-retail-bagginess-250f%40gregkh","headers":{"Return-Path":"<intel-wired-lan-bounces@osuosl.org>","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=mSiWkQKu;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvw5h2J9qz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 14 Apr 2026 16:55:34 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id DB79342989;\n\tTue, 14 Apr 2026 06:55:31 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id V9hnQjh-hU-L; Tue, 14 Apr 2026 06:55:30 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 4962842943;\n\tTue, 14 Apr 2026 06:55:30 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n by lists1.osuosl.org (Postfix) with ESMTP id 6D8E2283\n for <intel-wired-lan@lists.osuosl.org>; Tue, 14 Apr 2026 06:55:28 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 5C2A761CA0\n for <intel-wired-lan@lists.osuosl.org>; Tue, 14 Apr 2026 06:55:28 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id M8EUYLZA4hYM for <intel-wired-lan@lists.osuosl.org>;\n Tue, 14 Apr 2026 06:55:27 +0000 (UTC)","from mx3.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 4855661C9F\n for <intel-wired-lan@lists.osuosl.org>; Tue, 14 Apr 2026 06:55:25 +0000 (UTC)","from [192.168.0.192] (ip5f5af0da.dynamic.kabel-deutschland.de\n [95.90.240.218])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested) (Authenticated sender: pmenzel)\n by mx.molgen.mpg.de (Postfix) with ESMTPSA id EA7B24C2C37D56;\n Tue, 14 Apr 2026 08:54:55 +0200 (CEST)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 4962842943","OpenDKIM Filter v2.11.0 smtp3.osuosl.org 4855661C9F"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776149730;\n\tbh=NPOxW66OC5+qt/FYwtAj6gqnS+FknS6WgNOVN+0ojIU=;\n\th=Date:To:Cc:References:From:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=mSiWkQKuY5ftAFHazN+FezdHeY5qr0XYEv7NpcpOs2pWqdS1ThU3KdvjPesrMVHCT\n\t UXp9wTYRgkMbUQroDtfatJLyV/gXdkGf/HcDezCgV7Xkail/na99sC/RAd7DCk3Ipn\n\t 3w67Hr/v7kz6AwCBhxw8P55BcsDNCNNoxicDvoVJavo3I5HX2ic28l4b4nJ3//6mfq\n\t 6h/5drsBtahJEiIR+y4XaOeWjpNX6kt/gzE9dtgTE4xJVpUavE44q1drDDXvp/JB92\n\t NOakVhEM88ZdpYcdrxkcBdXQ1ZM0HD9f0rU48k8+Rc4ZHDutmCK9e9TVHLq2l8rMdV\n\t k9+HuWn73z0OA==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=141.14.17.11;\n helo=mx3.molgen.mpg.de; envelope-from=pmenzel@molgen.mpg.de;\n receiver=<UNKNOWN>","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org 4855661C9F","Message-ID":"<afefe8b5-5bd9-4019-9d12-5ee2a7f577a2@molgen.mpg.de>","Date":"Tue, 14 Apr 2026 08:54:55 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","To":"Greg Kroah-Hartman <gregkh@linuxfoundation.org>","Cc":"intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,\n linux-kernel@vger.kernel.org, Tony Nguyen <anthony.l.nguyen@intel.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n Andrew Lunn <andrew+netdev@lunn.ch>, \"David S. Miller\"\n <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,\n Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,\n stable <stable@kernel.org>","References":"<2026041116-retail-bagginess-250f@gregkh>","Content-Language":"en-US","From":"Paul Menzel <pmenzel@molgen.mpg.de>","In-Reply-To":"<2026041116-retail-bagginess-250f@gregkh>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-Mailman-Original-Authentication-Results":"smtp3.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=molgen.mpg.de","Subject":"Re: [Intel-wired-lan] [PATCH net] idpf: fix double free and\n use-after-free in aux device error paths","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>","List-Unsubscribe":"<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>","List-Archive":"<http://lists.osuosl.org/pipermail/intel-wired-lan/>","List-Post":"<mailto:intel-wired-lan@osuosl.org>","List-Help":"<mailto:intel-wired-lan-request@osuosl.org?subject=help>","List-Subscribe":"<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>"}},{"id":3677055,"web_url":"http://patchwork.ozlabs.org/comment/3677055/","msgid":"<2026041432-tapestry-condition-22ff@gregkh>","list_archive_url":null,"date":"2026-04-14T08:00:06","subject":"Re: [Intel-wired-lan] [PATCH net] idpf: fix double free and\n use-after-free in aux device error paths","submitter":{"id":11800,"url":"http://patchwork.ozlabs.org/api/people/11800/","name":"Greg Kroah-Hartman","email":"gregkh@linuxfoundation.org"},"content":"On Tue, Apr 14, 2026 at 08:54:55AM +0200, Paul Menzel wrote:\n> Dear Greg,\n> \n> \n> Thank you for the patch.\n> \n> Am 11.04.26 um 12:12 schrieb Greg Kroah-Hartman:\n> > When auxiliary_device_add() fails in idpf_plug_vport_aux_dev() or\n> > idpf_plug_core_aux_dev(), the err_aux_dev_add label calls\n> > auxiliary_device_uninit() and falls through to err_aux_dev_init.  The\n> > uninit call will trigger put_device(), which invokes the release\n> > callback (idpf_vport_adev_release / idpf_core_adev_release) that frees\n> > iadev.  The fall-through then reads adev->id from the freed iadev for\n> > ida_free() and double-frees iadev with kfree().\n> > \n> > Free the IDA slot and clear the back-pointer before uninit, while adev\n> > is still valid, then return immediately.\n> > \n> > Commit 65637c3a1811 65637c3a1811 (\"idpf: fix UAF in RDMA core aux dev\n> \n> The commit hash is pasted twice.\n\nArgh, when I cut/paste from my terminal that happened, my fault.\n\n> > deinitialization\") fixed the same use-after-free in the matching unplug\n> > path in this file but missed both probe error paths.\n> > \n> > Cc: Tony Nguyen <anthony.l.nguyen@intel.com>\n> > Cc: Przemek Kitszel <przemyslaw.kitszel@intel.com>\n> > Cc: Andrew Lunn <andrew+netdev@lunn.ch>\n> > Cc: \"David S. Miller\" <davem@davemloft.net>\n> > Cc: Eric Dumazet <edumazet@google.com>\n> > Cc: Jakub Kicinski <kuba@kernel.org>\n> > Cc: Paolo Abeni <pabeni@redhat.com>\n> > Cc: stable <stable@kernel.org>\n> > Fixes: be91128c579c (\"idpf: implement RDMA vport auxiliary dev create, init, and destroy\")\n> > Fixes: f4312e6bfa2a (\"idpf: implement core RDMA auxiliary dev create, init, and destroy\")\n> > Assisted-by: gregkh_clanker_t1000\n> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>\n> > ---\n> > Note, these cleanup paths are messy, but I couldn't see a simpler way\n> > without a lot more rework, so I choose the simple way :)\n> > \n> >   drivers/net/ethernet/intel/idpf/idpf_idc.c | 6 ++++++\n> >   1 file changed, 6 insertions(+)\n> > \n> > diff --git a/drivers/net/ethernet/intel/idpf/idpf_idc.c b/drivers/net/ethernet/intel/idpf/idpf_idc.c\n> > index 7e4f4ac92653..b7d6b08fc89e 100644\n> > --- a/drivers/net/ethernet/intel/idpf/idpf_idc.c\n> > +++ b/drivers/net/ethernet/intel/idpf/idpf_idc.c\n> > @@ -90,7 +90,10 @@ static int idpf_plug_vport_aux_dev(struct iidc_rdma_core_dev_info *cdev_info,\n> >   \treturn 0;\n> >   err_aux_dev_add:\n> > +\tida_free(&idpf_idc_ida, adev->id);\n> > +\tvdev_info->adev = NULL;\n> >   \tauxiliary_device_uninit(adev);\n> > +\treturn ret;\n> >   err_aux_dev_init:\n> >   \tida_free(&idpf_idc_ida, adev->id);\n> >   err_ida_alloc:\n> > @@ -228,7 +231,10 @@ static int idpf_plug_core_aux_dev(struct iidc_rdma_core_dev_info *cdev_info)\n> >   \treturn 0;\n> >   err_aux_dev_add:\n> > +\tida_free(&idpf_idc_ida, adev->id);\n> > +\tcdev_info->adev = NULL;\n> >   \tauxiliary_device_uninit(adev);\n> > +\treturn ret;\n> >   err_aux_dev_init:\n> >   \tida_free(&idpf_idc_ida, adev->id);\n> >   err_ida_alloc:\n> \n> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>\n> \n> gemini/gemini-3.1-pro-preview has two comments [1]. Maybe the driver\n> developers could judge their relevance.\n\nThese \"pre-existing\" reports are getting annoying.  While they are nice\nto see for driver authors, it makes developers sending bug fixes in feel\nlike they are forced to do \"more\".  I think they are trying to tune this\nto be a bit more sane...\n\nthanks,\n\ngreg k-h","headers":{"Return-Path":"<intel-wired-lan-bounces@osuosl.org>","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=AlYjVW/1;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvxYX6KZRz1yDF\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 14 Apr 2026 18:01:18 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 3415B40534;\n\tTue, 14 Apr 2026 08:01:16 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id SszouSl0G-9p; Tue, 14 Apr 2026 08:01:12 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 4CF70405C0;\n\tTue, 14 Apr 2026 08:01:12 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id 53374375\n for <intel-wired-lan@lists.osuosl.org>; Tue, 14 Apr 2026 08:01:10 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id E89284079A\n for <intel-wired-lan@lists.osuosl.org>; Tue, 14 Apr 2026 08:00:37 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id dfHXb68aN6Bl for <intel-wired-lan@lists.osuosl.org>;\n Tue, 14 Apr 2026 08:00:37 +0000 (UTC)","from sea.source.kernel.org (sea.source.kernel.org\n [IPv6:2600:3c0a:e001:78e:0:1991:8:25])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 3B55740519\n for <intel-wired-lan@lists.osuosl.org>; Tue, 14 Apr 2026 08:00:36 +0000 (UTC)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by sea.source.kernel.org (Postfix) with ESMTP id 466194417A;\n Tue, 14 Apr 2026 08:00:36 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id B1922C19425;\n Tue, 14 Apr 2026 08:00:35 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 4CF70405C0","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 3B55740519"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776153672;\n\tbh=sFHWKsoMKxTHM/ceTsagg24FwpJSaNkmOaFHpvuQ4DE=;\n\th=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=AlYjVW/1kYEmC/x2vkC5ffJzX48n3TWfTncwhPlUOkWgO2WSQL5A0S5KgDqsg6CIl\n\t lh26rBGVi/E62PlTvD7tf7fs+UUF3K53T+L9B/cRoJvGsaplupU4IUnnqCY0pVCfUM\n\t 6X9Y+YMYNCUCxy6k04NqTWVyKYkPzYeLxQOC57+JvK0cTD8Y0w4VuF/jqRevaf6nP2\n\t V0m9HytEzAaPBPllFEyli/51FqsesjZwkU+BGr+h7xnyiYIJoD8hVVbdHwo+RJwgV3\n\t t8VY5puatKRipzYxMtnpBOcBAKR2vfqRTLV5wVwwfYi4pwejOgXOLvMq7KkkNalgTR\n\t KYwbnXWkAe0rQ==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org;\n envelope-from=gregkh@linuxfoundation.org; receiver=<UNKNOWN>","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 3B55740519","Date":"Tue, 14 Apr 2026 10:00:06 +0200","From":"Greg Kroah-Hartman <gregkh@linuxfoundation.org>","To":"Paul Menzel <pmenzel@molgen.mpg.de>","Cc":"intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,\n linux-kernel@vger.kernel.org, Tony Nguyen <anthony.l.nguyen@intel.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n Andrew Lunn <andrew+netdev@lunn.ch>,\n \"David S. Miller\" <davem@davemloft.net>,\n Eric Dumazet <edumazet@google.com>,\n Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,\n stable <stable@kernel.org>","Message-ID":"<2026041432-tapestry-condition-22ff@gregkh>","References":"<2026041116-retail-bagginess-250f@gregkh>\n <afefe8b5-5bd9-4019-9d12-5ee2a7f577a2@molgen.mpg.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<afefe8b5-5bd9-4019-9d12-5ee2a7f577a2@molgen.mpg.de>","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=linuxfoundation.org;\n s=korg; t=1776153636;\n bh=wVp6VFTURygsoghzYoYKFP8ZTFf9WBviBiJBhkIUNAM=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=DouCmozLwuDvvUGnIMpqz0RM3dfCWjXbeibZx/ghMTjGwjW/c8XS5RUuVETaXBPAB\n KAg6/HcgBzBDtA+8G3sobBBUQ+aADKKK6j0mo7SoA12I18pmJdG5PziSWRlXKN4oPY\n rjIvhmTqjCzzD3eUE+FgBlyp2zPisfgq/i69k/Ac=","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=linuxfoundation.org","smtp4.osuosl.org;\n dkim=pass (1024-bit key,\n unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org\n header.a=rsa-sha256 header.s=korg header.b=DouCmozL"],"Subject":"Re: [Intel-wired-lan] [PATCH net] idpf: fix double free and\n use-after-free in aux device error paths","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>","List-Unsubscribe":"<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>","List-Archive":"<http://lists.osuosl.org/pipermail/intel-wired-lan/>","List-Post":"<mailto:intel-wired-lan@osuosl.org>","List-Help":"<mailto:intel-wired-lan-request@osuosl.org?subject=help>","List-Subscribe":"<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>"}}]