[{"id":3676129,"web_url":"http://patchwork.ozlabs.org/comment/3676129/","msgid":"<20260411094623.3963-1-ltp-ci@noreply.github.com>","list_archive_url":null,"date":"2026-04-11T09:46:23","subject":"Re: [LTP] userfaultfd: Use two-step handshake to probe features","submitter":{"id":93118,"url":"http://patchwork.ozlabs.org/api/people/93118/","name":null,"email":"acervesato@ltp-agent"},"content":"Hi Ricardo,\n\nour agent completed the review of the patch.\n\nThe agent can sometimes produce false positives although often its\nfindings are genuine. If you find issues with the review, please\ncomment this email or ignore the suggestions.\n\nOn Sat, 11 Apr 2026 11:24:51 +0200, Ricardo Branco wrote:\n> userfaultfd: Use two-step handshake to probe features\n\n> + if (!(uffdio_api.features & UFFD_FEATURE_PAGEFAULT_FLAG_WP))\n> + tst_brk(TCONF, \"UFFD_FEATURE_PAGEFAULT_FLAG_WP not supported\");\n> + SAFE_CLOSE(uffd);\n\ntst_brk() longjmps out of run(), so SAFE_CLOSE never executes — close uffd\nbefore calling tst_brk(). userfaultfd05.c also has no .cleanup, so the page\nmmap from set_pages() leaks too; add .cleanup = reset_pages to struct tst_test.\n\n[...]\n\n> + if (!(uffdio_api.features & UFFD_FEATURE_POISON))\n> + tst_brk(TCONF, \"UFFD_FEATURE_POISON not supported\");\n> + SAFE_CLOSE(uffd);\n\nSame issue: close uffd before calling tst_brk().\n\nRegards,\nLTP AI Reviewer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out2.suse.de;\n\tnone"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ft8Yd5htSz1y2d\n\tfor ; Sat, 11 Apr 2026 20:10:13 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 829E43E268F\n\tfor ; Sat, 11 Apr 2026 12:10:11 +0200 (CEST)","from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [217.194.8.6])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id D1AAF3E1476\n for ; Sat, 11 Apr 2026 11:46:33 +0200 (CEST)","from smtp-out2.suse.de (smtp-out2.suse.de\n [IPv6:2a07:de40:b251:101:10:150:64:2])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 5DC4F1400153\n for ; Sat, 11 Apr 2026 11:46:32 +0200 (CEST)","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id 2550C5BD0B;\n Sat, 11 Apr 2026 09:46:30 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7CC1E4A2C9;\n Sat, 11 Apr 2026 09:46:29 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id pPIpFXUY2mmOOgAAD6G6ig\n (envelope-from <>); Sat, 11 Apr 2026 09:46:29 +0000"],"From":"acervesato@ltp-agent","To":"Ricardo Branco ","Date":"Sat, 11 Apr 2026 09:46:23 +0000","Message-ID":"<20260411094623.3963-1-ltp-ci@noreply.github.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260411092452.211540-1-rbranco@suse.de>","References":"<20260411092452.211540-1-rbranco@suse.de>","MIME-Version":"1.0","X-Spamd-Result":"default: False [-8.30 / 50.00]; REPLY(-4.00)[];\n BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n FROM_NO_DN(0.00)[]; RCVD_TLS_ALL(0.00)[];\n MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[];\n RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWO(0.00)[2];\n TO_DN_SOME(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com];\n RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,\n noreply.github.com:mid]","X-Spam-Score":"-8.30","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=7.0 tests=SPF_HELO_NONE shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-6.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-6.smtp.seeweb.it","X-Virus-Status":"Clean","X-Mailman-Approved-At":"Sat, 11 Apr 2026 12:10:08 +0200","Subject":"Re: [LTP] userfaultfd: Use two-step handshake to probe features","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}},{"id":3676137,"web_url":"http://patchwork.ozlabs.org/comment/3676137/","msgid":"<20260411103939.3994-1-ltp-ci@noreply.github.com>","list_archive_url":null,"date":"2026-04-11T10:39:39","subject":"Re: [LTP] userfaultfd: Use two-step handshake to probe features","submitter":{"id":93118,"url":"http://patchwork.ozlabs.org/api/people/93118/","name":null,"email":"acervesato@ltp-agent"},"content":"Hi Ricardo,\n\nour agent completed the review of the patch.\n\nOn Sat, 11 Apr 2026 11:24:51 +0200, Ricardo Branco wrote:\n> userfaultfd: Use two-step handshake to probe features\n\n> Fix this by using the required two-step handshake and skip with TCONF\n> if the required feature bit is absent.\n\nThe patch is fixing a bug (UFFDIO_API EINVAL causing TBROK instead of\nTCONF); please add a Fixes: tag pointing to the commit that introduced\nthe incorrect single-step setup.\n\n> Link: https://github.com/linux-test-project/ltp/issues/1289\n\n[...]\n\nRegards,\nLTP AI Reviewer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=213.254.12.146; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out2.suse.de;\n\tnone"],"Received":["from picard.linux.it (picard.linux.it [213.254.12.146])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ft9pz4wPbz1yGb\n\tfor ; Sat, 11 Apr 2026 21:06:51 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id EFA203E2697\n\tfor ; Sat, 11 Apr 2026 13:06:47 +0200 (CEST)","from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [217.194.8.3])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id B36623E1043\n for ; Sat, 11 Apr 2026 12:39:46 +0200 (CEST)","from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 2C4551A00241\n for ; Sat, 11 Apr 2026 12:39:45 +0200 (CEST)","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id 2C9135BD3F;\n Sat, 11 Apr 2026 10:39:45 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A28CB4A2FF;\n Sat, 11 Apr 2026 10:39:44 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id dHj/H/Ak2mnqbAAAD6G6ig\n (envelope-from <>); Sat, 11 Apr 2026 10:39:44 +0000"],"From":"acervesato@ltp-agent","To":"Ricardo Branco ","Date":"Sat, 11 Apr 2026 10:39:39 +0000","Message-ID":"<20260411103939.3994-1-ltp-ci@noreply.github.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260411092452.211540-1-rbranco@suse.de>","References":"<20260411092452.211540-1-rbranco@suse.de>","MIME-Version":"1.0","X-Rspamd-Pre-Result":["action=no action; module=replies;\n Message is reply to one we originated","action=no action; module=replies;\n Message is reply to one we originated"],"X-Rspamd-Server":"rspamd2.dmz-prg2.suse.org","X-Spamd-Result":"default: False [-4.00 / 50.00];\n\tREPLY(-4.00)[]","X-Rspamd-Queue-Id":"2C9135BD3F","X-Rspamd-Action":"no action","X-Spam-Score":"-4.00","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=7.0 tests=SPF_HELO_NONE shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-3.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-3.smtp.seeweb.it","X-Virus-Status":"Clean","X-Mailman-Approved-At":"Sat, 11 Apr 2026 13:06:44 +0200","Subject":"Re: [LTP] userfaultfd: Use two-step handshake to probe features","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]