[{"id":3676676,"web_url":"http://patchwork.ozlabs.org/comment/3676676/","msgid":"<683c3e65-4589-b3a1-ac51-6d7e2b679944@linux.intel.com>","date":"2026-04-13T11:45:32","subject":"Re: [PATCH v4 16/24] alpha/PCI: Remove WARN from __pci_mmap_fits()","submitter":{"id":83553,"url":"http://patchwork.ozlabs.org/api/people/83553/","name":"Ilpo Järvinen","email":"ilpo.jarvinen@linux.intel.com"},"content":"On Sat, 11 Apr 2026, Krzysztof Wilczyński wrote:\n\n> Remove the WARN() that fires when userspace attempts to mmap beyond\n> the BAR bounds. The check still returns 0 to reject the mapping,\n> but the warning is excessive for normal operation.\n> \n> A similar warning was removed from the PCI core in the commit\n> 3b519e4ea618 (\"PCI: fix size checks for mmap() on /proc/bus/pci files\").\n> \n> Signed-off-by: Krzysztof Wilczyński \n> ---\n> arch/alpha/kernel/pci-sysfs.c | 8 +-------\n> 1 file changed, 1 insertion(+), 7 deletions(-)\n> \n> diff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c\n> index 2748000a7486..c136603ddf2c 100644\n> --- a/arch/alpha/kernel/pci-sysfs.c\n> +++ b/arch/alpha/kernel/pci-sysfs.c\n> @@ -48,13 +48,7 @@ static int __pci_mmap_fits(struct pci_dev *pdev, int num,\n> \tstart = vma->vm_pgoff;\n> \tsize = ((len - 1) >> (PAGE_SHIFT - shift)) + 1;\n> \n> -\tif (start < size && size - start >= nr)\n> -\t\treturn 1;\n> -\tWARN(1, \"process \\\"%s\\\" tried to map%s 0x%08lx-0x%08lx on %s BAR %d \"\n> -\t\t\"(size 0x%08lx)\\n\",\n> -\t\tcurrent->comm, sparse ? \" sparse\" : \"\", start, start + nr,\n> -\t\tpci_name(pdev), num, size);\n> -\treturn 0;\n> +\treturn start < size && size - start >= nr;\n> }\n> \n> /**\n> \n\nReviewed-by: Ilpo Järvinen ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=dFecN39Q;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19684-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=192.198.163.10","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=dFecN39Q;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.intel.com\n (client-ip=192.198.163.10; helo=mgamail.intel.com;\n envelope-from=ilpo.jarvinen@linux.intel.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvQb56t6Pz1xtJ\n\tfor ; Mon, 13 Apr 2026 21:45:53 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fvQb55r3cz2yjV;\n\tMon, 13 Apr 2026 21:45:53 +1000 (AEST)","from mgamail.intel.com (mgamail.intel.com [192.198.163.10])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fvQb43Spcz2yDk\n\tfor ; Mon, 13 Apr 2026 21:45:52 +1000 (AEST)","from fmviesa004.fm.intel.com ([10.60.135.144])\n by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2026 04:45:49 -0700","from ijarvine-mobl1.ger.corp.intel.com (HELO localhost)\n ([10.245.245.63])\n by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2026 04:45:41 -0700"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776080753;\n\tcv=none;\n b=REsa9L7Sh5JG6hGwxjTkMrUs26CSqbjothn5Xn8L5bjAUUjy7FINvb4THiceH10InUlMOMTqmpicm+lNPk4NJIf4Esy9ADVGsLK/VqwlYJcjM5PzxuOzKlb3eQADHmOTSBaT75PiE6/0U5s5CRXtV2Kr792qo8NE9iaZZwtLqKiwC9xQejHRVNpKnZrlS/nES/YPnum0xSUI912D81U0Lvc3ObjQF2wVv9Y9HnbRH59S1f7eyzY4L98usEr1w3VUxYTWplov3UMHW37ddqXEU1r/e++nkmcp7j7QXyUHJCsObH5wJRQST1Jik2QvCclwIDB7EQXCGatj1D3A7jlK0Q==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776080753; c=relaxed/relaxed;\n\tbh=c1FAGHuyjhipUADF7LLDKYzSAhODhm1PpHvjU2C5dVA=;\n\th=From:Date:To:cc:Subject:In-Reply-To:Message-ID:References:\n\t MIME-Version:Content-Type;\n b=oEvnRP2ZDwXSe0pqavKup2KJpG6u1eKjzDcTf97bUUZO2GW6sziLu3i7IDf9dSDSl2QWDsf72D3iHGGotrzf7vHy9BrVUuk5nZ2QCpqN8KnlKwyfiOlx8C9wAFsgIu5drqNpjxWN+8pxc/djz/mdmSeGnrpqcJnExHfF/+4+GuD4v6O+PtOCyK2cZ5IND5NUCdHlz5xim9lbFTPnVqxTuW7cCYcdG4dEbWPWvzpP3f8uPZ21JD2tIdcNauiH9krI02pme17+EbCPPBQ3pUGM1qtyeSf+3lIzLRSHm1KpNNdyuzts7bJpMfVm9wxGPsINYHz4z9dKeEEgj5BBbS1Rdg==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=dFecN39Q; dkim-atps=neutral;\n spf=pass (client-ip=192.198.163.10; helo=mgamail.intel.com;\n envelope-from=ilpo.jarvinen@linux.intel.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=linux.intel.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776080753; x=1807616753;\n h=from:date:to:cc:subject:in-reply-to:message-id:\n references:mime-version;\n bh=MXb8znk6JA5uSw7e9wrvMoeQSHS1hheycQygUFtOceI=;\n b=dFecN39QA5gEfKm94Lfcv/D7pkGvTejcC6j2d4U2R0oj35LRV3BLvaKS\n HN+t5rrC0u18S3567k6IIIKPiewdLXaW9QoFZXQS2vVzwh/GEHvEGgD8f\n vSH6AkI0hlrlKolse1rJyQ/SJzT+p2W0vFfmcNHw15Km6b67AXPxmi1QS\n L3gcPFpldxBRkDAChJZsEzLr5kyxUXpAUqQ5teiCm1/Gseez9PCHmamM6\n tqoCR2soEi2BgNtg1PH8eS8rtf6x6g1VSQK8kdwq1zAHNTPNMd36ivn+1\n voIZNNfzd6oM5SIXEjyc+v9rIzpZSo3MYYPIHzGEh8V/wvQEfdLkPGOxU\n A==;","X-CSE-ConnectionGUID":["uSOWJZSzT6yuZTiVTUENMw==","RZP0kXKVTxepfqH2u5Mj1w=="],"X-CSE-MsgGUID":["oi4Muw0HTlGNxwt2MCRs5w==","hvRUpLyoSQGtB1aLUpdGmg=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11757\"; a=\"88396347\"","E=Sophos;i=\"6.23,177,1770624000\";\n d=\"scan'208\";a=\"88396347\"","E=Sophos;i=\"6.23,177,1770624000\";\n d=\"scan'208\";a=\"231496176\""],"X-ExtLoop1":"1","From":"=?utf-8?q?Ilpo_J=C3=A4rvinen?= ","Date":"Mon, 13 Apr 2026 14:45:32 +0300 (EEST)","To":"=?iso-8859-2?q?Krzysztof_Wilczy=F1ski?= ","cc":"Bjorn Helgaas , Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?iso-8859-2?q?Krzysztof_Ha=B3asa?= ,\n Lukas Wunner , Oliver O'Halloran ,\n Saurabh Singh Sengar ,\n Shuan He ,\n Srivatsa Bhat , linux-pci@vger.kernel.org,\n linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org","Subject":"Re: [PATCH v4 16/24] alpha/PCI: Remove WARN from __pci_mmap_fits()","In-Reply-To":"<20260411080148.471335-17-kwilczynski@kernel.org>","Message-ID":"<683c3e65-4589-b3a1-ac51-6d7e2b679944@linux.intel.com>","References":"<20260411080148.471335-1-kwilczynski@kernel.org>\n <20260411080148.471335-17-kwilczynski@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"multipart/mixed; boundary=\"8323328-1168042318-1776080732=:962\"","X-Spam-Status":"No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]