[{"id":3676684,"web_url":"http://patchwork.ozlabs.org/comment/3676684/","msgid":"","date":"2026-04-13T11:54:55","subject":"Re: [PATCH v4 14/24] alpha/PCI: Clean up pci_mmap_resource()","submitter":{"id":83553,"url":"http://patchwork.ozlabs.org/api/people/83553/","name":"Ilpo Järvinen","email":"ilpo.jarvinen@linux.intel.com"},"content":"On Sat, 11 Apr 2026, Krzysztof Wilczyński wrote:\n\n> Replace open-coded res->flags type checks with new pci_resource_is_mem()\n> and pci_resource_start() helpers. Move the pci_resource_n() call into\n> pcibios_resource_to_bus() and drop the local struct resource pointer.\n> \n> Signed-off-by: Krzysztof Wilczyński \n> ---\n> arch/alpha/kernel/pci-sysfs.c | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c\n> index 7aac5e76dcd6..6c011dab326d 100644\n> --- a/arch/alpha/kernel/pci-sysfs.c\n> +++ b/arch/alpha/kernel/pci-sysfs.c\n> @@ -70,7 +70,6 @@ static int pci_mmap_resource(struct kobject *kobj,\n> {\n> \tstruct pci_dev *pdev = to_pci_dev(kobj_to_dev(kobj));\n> \tint barno = (unsigned long)attr->private;\n> -\tstruct resource *res = pci_resource_n(pdev, barno);\n> \tenum pci_mmap_state mmap_type;\n> \tstruct pci_bus_region bar;\n> \tint ret;\n> @@ -79,15 +78,16 @@ static int pci_mmap_resource(struct kobject *kobj,\n> \tif (ret)\n> \t\treturn ret;\n> \n> -\tif ((res->flags & IORESOURCE_MEM) && iomem_is_exclusive(res->start))\n> +\tif (pci_resource_is_mem(pdev, barno) &&\n> +\t iomem_is_exclusive(pci_resource_start(pdev, barno)))\n> \t\treturn -EINVAL;\n> \n> \tif (!__pci_mmap_fits(pdev, barno, vma, sparse))\n> \t\treturn -EINVAL;\n> \n> -\tpcibios_resource_to_bus(pdev->bus, &bar, res);\n> +\tpcibios_resource_to_bus(pdev->bus, &bar, pci_resource_n(pdev, barno));\n> \tvma->vm_pgoff += bar.start >> (PAGE_SHIFT - (sparse ? 5 : 0));\n> -\tmmap_type = res->flags & IORESOURCE_MEM ? pci_mmap_mem : pci_mmap_io;\n> +\tmmap_type = pci_resource_is_mem(pdev, barno) ? pci_mmap_mem : pci_mmap_io;\n> \n> \treturn hose_mmap_page_range(pdev->sysdata, vma, mmap_type, sparse);\n> }\n> \n\nReviewed-by: Ilpo Järvinen ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=SzkAE+rr;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19687-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=198.175.65.18","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=SzkAE+rr;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.intel.com\n (client-ip=198.175.65.18; helo=mgamail.intel.com;\n envelope-from=ilpo.jarvinen@linux.intel.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvQnr0j6wz1y2d\n\tfor ; Mon, 13 Apr 2026 21:55:12 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fvQnq6gBCz2yrl;\n\tMon, 13 Apr 2026 21:55:11 +1000 (AEST)","from mgamail.intel.com (mgamail.intel.com [198.175.65.18])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fvQnp1gJDz2yS9\n\tfor ; Mon, 13 Apr 2026 21:55:09 +1000 (AEST)","from fmviesa002.fm.intel.com ([10.60.135.142])\n by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2026 04:55:05 -0700","from ijarvine-mobl1.ger.corp.intel.com (HELO localhost)\n ([10.245.245.63])\n by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2026 04:54:58 -0700"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776081311;\n\tcv=none;\n b=RMoBWaaBiT9WE/lZ+XLP5Y8R+xHALVjYOmJ+Sf7xSfWcZWXRQ+DcZ8OL3gV+U7dK7wF2qFjwX6PTQEEJkXYzF6yDO8c2YJRszCO12JDzp19/iogTIRnp1VXc6IekAQe1wdlV5S0HlmK7k7KLtDwPDuMqTueoD1zMfqeYdWt8k4FoEsFRTV9wK4g4YVBRe9/R6/FGLgZ+ymkSF+LTVU27+l8MYNpov7nG0b7nIH21BD5SVQpUySCpos7HBlGqvjZmiBdYvA29AQp1ChDS1lDh3dinBTPiLzNcPNxROdequiGqDSuCkQld0mwtW2UwuVa4JMtEKg9aa5ksxpFnAxoXtQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776081311; c=relaxed/relaxed;\n\tbh=8A4EsbcgctBgp/jMKS8aEzwZfBFINXltZzMv/SLL/g4=;\n\th=From:Date:To:cc:Subject:In-Reply-To:Message-ID:References:\n\t MIME-Version:Content-Type;\n b=d/dukMSNvuwdlu5/U/rPbPqu1tzilbBH7xNusA02+URN8xzY7m+JjAil8y4mWriBWE616W7LklRd+B4sIhQIustNuJJRwaDDpQElJ89y7Eckk/O/iAZisDdhunLpSrjks+/+oO3TrC/rIKwE3tM4/5vzVNLO2LGOTVpY2KIX2tulzkdYgacw4uhjdQtsxwkrKz90XeaW+JAnvOS5gBsWKwt6rMAYCI+AsX5Y9NN2MXoL5LAmpVB8ImvoyooYOhmKLHG1F/80VaGRxRYW+oLbEEZ3suClmr61AweiX//kLu4cDvbNHGZg1nGsLG/aqk2EApDg4gJHbL1YdRAdhpmYgg==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=SzkAE+rr; dkim-atps=neutral;\n spf=pass (client-ip=198.175.65.18; helo=mgamail.intel.com;\n envelope-from=ilpo.jarvinen@linux.intel.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=linux.intel.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776081310; x=1807617310;\n h=from:date:to:cc:subject:in-reply-to:message-id:\n references:mime-version;\n bh=m4D4xwrjWoPcKd39e9WIlNBkYbShl/QU18qRe1RJS34=;\n b=SzkAE+rrY2MJiai2r4AEEJLk98wMmAsgAYxPxLpH0vW3tSQyq9lFMM8u\n P+4oA/vdZ913sxyH2Jz3ZGuSH7Xa06dxrOt/GOWrN97xIVv3jq3OGI7f1\n ZvwdTT/y64DsmsKWHj8POS+nT4m3zugZcdQzr5Fo5xOPV+zsx5pB095Gu\n UdnIHWxkuO08F1uobzbmmEJ0nfgTFy3A9f4oGZG1byZyjWi2mFon56uol\n bzj+gzSDbYJDB4RgEd98aZJKpBLSf7dy3lSNPbnq9beXXqLV/UKDM1A5b\n wJuUnDZraf/sTVE9c25hn3MBYYRBIxBO0gbpYTeOmwDwhMhxlZchHxyT5\n A==;","X-CSE-ConnectionGUID":["CYW6CHlGTaWD8ZYjyJnHiQ==","lbiB9JauRxu0nvnsRhAtXQ=="],"X-CSE-MsgGUID":["2/YAci/gTVeBAb5kGLi0OQ==","7eAaEOTEQUC6kP4Yz6kYCg=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11757\"; a=\"77030133\"","E=Sophos;i=\"6.23,177,1770624000\";\n d=\"scan'208\";a=\"77030133\"","E=Sophos;i=\"6.23,177,1770624000\";\n d=\"scan'208\";a=\"252959648\""],"X-ExtLoop1":"1","From":"=?utf-8?q?Ilpo_J=C3=A4rvinen?= ","Date":"Mon, 13 Apr 2026 14:54:55 +0300 (EEST)","To":"=?iso-8859-2?q?Krzysztof_Wilczy=F1ski?= ","cc":"Bjorn Helgaas , Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?iso-8859-2?q?Krzysztof_Ha=B3asa?= ,\n Lukas Wunner , Oliver O'Halloran ,\n Saurabh Singh Sengar ,\n Shuan He ,\n Srivatsa Bhat , linux-pci@vger.kernel.org,\n linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org","Subject":"Re: [PATCH v4 14/24] alpha/PCI: Clean up pci_mmap_resource()","In-Reply-To":"<20260411080148.471335-15-kwilczynski@kernel.org>","Message-ID":"","References":"<20260411080148.471335-1-kwilczynski@kernel.org>\n <20260411080148.471335-15-kwilczynski@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"multipart/mixed; boundary=\"8323328-878657269-1776081295=:962\"","X-Spam-Status":"No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]