[{"id":3676682,"web_url":"http://patchwork.ozlabs.org/comment/3676682/","msgid":"<5c4f32d1-0648-31d1-d7c0-661ccec4f8bc@linux.intel.com>","date":"2026-04-13T11:52:49","subject":"Re: [PATCH v4 13/24] alpha/PCI: Use PCI resource accessor macros","submitter":{"id":83553,"url":"http://patchwork.ozlabs.org/api/people/83553/","name":"Ilpo Järvinen","email":"ilpo.jarvinen@linux.intel.com"},"content":"On Sat, 11 Apr 2026, Krzysztof Wilczyński wrote:\n\n> Replace direct pdev->resource[] accesses with pci_resource_n(),\n> and pdev->resource[].flags accesses with pci_resource_flags().\n> \n> No functional changes intended.\n> \n> Reviewed-by: Ilpo Järvinen \n> Signed-off-by: Krzysztof Wilczyński \n> ---\n> arch/alpha/kernel/pci-sysfs.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c\n> index c84867ce31f5..7aac5e76dcd6 100644\n> --- a/arch/alpha/kernel/pci-sysfs.c\n> +++ b/arch/alpha/kernel/pci-sysfs.c\n> @@ -141,7 +141,7 @@ static int sparse_mem_mmap_fits(struct pci_dev *pdev, int num)\n> \tlong dense_offset;\n> \tunsigned long sparse_size;\n> \n> -\tpcibios_resource_to_bus(pdev->bus, &bar, &pdev->resource[num]);\n> +\tpcibios_resource_to_bus(pdev->bus, &bar, pci_resource_n(pdev, num));\n> \n> \t/* All core logic chips have 4G sparse address space, except\n> \t CIA which has 16G (see xxx_SPARSE_MEM and xxx_DENSE_MEM\n> @@ -181,7 +181,7 @@ static int pci_create_attr(struct pci_dev *pdev, int num)\n> \tsuffix = \"\";\t/* Assume bwx machine, normal resourceN files. */\n> \tnlen1 = 10;\n> \n> -\tif (pdev->resource[num].flags & IORESOURCE_MEM) {\n> +\tif (pci_resource_flags(pdev, num) & IORESOURCE_MEM) {\n\nThis could have used the new helper but since this code is going away \nanyway in a later patch it doesn't matter,\n\nReviewed-by: Ilpo Järvinen ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=TS8TraSw;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19686-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=192.198.163.19","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=TS8TraSw;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.intel.com\n (client-ip=192.198.163.19; helo=mgamail.intel.com;\n envelope-from=ilpo.jarvinen@linux.intel.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvQlT1ST9z1yDF\n\tfor ; Mon, 13 Apr 2026 21:53:08 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fvQlS6Fl7z2yrl;\n\tMon, 13 Apr 2026 21:53:08 +1000 (AEST)","from mgamail.intel.com (mgamail.intel.com [192.198.163.19])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fvQlR4MrYz2yS9\n\tfor ; Mon, 13 Apr 2026 21:53:07 +1000 (AEST)","from fmviesa001.fm.intel.com ([10.60.135.141])\n by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2026 04:53:04 -0700","from ijarvine-mobl1.ger.corp.intel.com (HELO localhost)\n ([10.245.245.63])\n by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2026 04:52:54 -0700"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776081188;\n\tcv=none;\n b=UIz6ZKMa2FbVRTndAbO2m6k2Dgf2eGBe87s40cErBEo7eT/4A/nNMysDedCJ4VdcfHM3tzz/nOWNWr6F/ZeLbDJQzxaW1HqcJLrdxmtxWGtEAe3V5AW7VoJ6adP1/IImPQqieSUt8E5w2G1rzKB+Gkl4kL4ByDxOYi3asTDUuqy9IKG+i5VkL49mvUkAali++ZMOX5F8Dyl0ua9D1C8erCRnDwMgP4feKBcL4pD1INB35Ezgcdy7SFKo4Zw8DZRjp7lLXgOCKIhun5Ecq3m2oY35NQJRAUs5JD7QiHIhuJ5KpjqcVDoRHY62nod+HrcFjUbnVBcsEvtFuTbvDw5OoA==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776081188; c=relaxed/relaxed;\n\tbh=Xp1/f8DE27Wv/yXP3ntPLcP3czKhbR8L0cQnmpze/Dc=;\n\th=From:Date:To:cc:Subject:In-Reply-To:Message-ID:References:\n\t MIME-Version:Content-Type;\n b=amDjwatf+zu0dh1hoaIq90ZrC0Fub6L0otsgcF0VShVOBGWbxBdomkLY9BkyV11A3vz4DdS1zIkCBezwgpcIpzDyDcqGAhkcjeEqz6RRcLKjXa+reeles+KKIkWQXYGmaTU7q8dyuFpLfrPdOBisqW8p1VUd9blA2XRWFYc/9seyEh214FepvdvqtONlrCUILRJ3+USJV93wjElmaTh0W539Qo0nSGx1Bnc1wyaMVkywn4V8dEeXEBiFJa8p0tJ5z2L4RRw/F5HCt4OaUoj7SXy5y8LUm8FEjE+i6JuWJvAgD7qqVCdaWHZ1vC6opG+HFR0BCPZRkAqr3vNywjRf+Q==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=TS8TraSw; dkim-atps=neutral;\n spf=pass (client-ip=192.198.163.19; helo=mgamail.intel.com;\n envelope-from=ilpo.jarvinen@linux.intel.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=linux.intel.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776081188; x=1807617188;\n h=from:date:to:cc:subject:in-reply-to:message-id:\n references:mime-version;\n bh=dJVGufupuRzhM0xublRPUyKnOZZPoagICx16HUyrYow=;\n b=TS8TraSwYeghi5TBYGUfwoVOvmFuBvgjUrjzyeSlbAEv25bEWd7ZPchz\n tFjw7Udll5ffOZmTEBBK+gDNN4DNqFBY2t/qTbImvyzTZrDCFF6NBLjId\n hphQimAk2ktrjf5tPAD30wMWPAz/Uo0RX+CB6CGXVc+n469TISegYXxG3\n z0jzlFkMlraQt1DQ5gGshUiTXOboUwcyd2U8nA3nsPSXQ2GqogfvwgtCg\n DG7TFOlSYYu5Ru7+a76mIwOXeT8e0+TdLkA0Y3RwMQpodVWElyYJ7O8+K\n DamLbHLsvqSV6VI8ZVBldyZEG+QgViueqptRMFSIFMySW+0LDQk6s/5NQ\n g==;","X-CSE-ConnectionGUID":["khFgoeAlRIqX5GCHkqx1mQ==","Qi86xDZ0TgiVjehP4JCm2w=="],"X-CSE-MsgGUID":["3f8ALSS4T9W+dMIYGiq1Tw==","nvS2V3eiR/y1R3IE9KDruQ=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11757\"; a=\"76046437\"","E=Sophos;i=\"6.23,177,1770624000\";\n d=\"scan'208\";a=\"76046437\"","E=Sophos;i=\"6.23,177,1770624000\";\n d=\"scan'208\";a=\"253165075\""],"X-ExtLoop1":"1","From":"=?utf-8?q?Ilpo_J=C3=A4rvinen?= ","Date":"Mon, 13 Apr 2026 14:52:49 +0300 (EEST)","To":"=?iso-8859-2?q?Krzysztof_Wilczy=F1ski?= ","cc":"Bjorn Helgaas , Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?iso-8859-2?q?Krzysztof_Ha=B3asa?= ,\n Lukas Wunner , Oliver O'Halloran ,\n Saurabh Singh Sengar ,\n Shuan He ,\n Srivatsa Bhat , linux-pci@vger.kernel.org,\n linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org","Subject":"Re: [PATCH v4 13/24] alpha/PCI: Use PCI resource accessor macros","In-Reply-To":"<20260411080148.471335-14-kwilczynski@kernel.org>","Message-ID":"<5c4f32d1-0648-31d1-d7c0-661ccec4f8bc@linux.intel.com>","References":"<20260411080148.471335-1-kwilczynski@kernel.org>\n <20260411080148.471335-14-kwilczynski@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"multipart/mixed; boundary=\"8323328-1935294158-1776081169=:962\"","X-Spam-Status":"No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]