[{"id":3676696,"web_url":"http://patchwork.ozlabs.org/comment/3676696/","msgid":"","list_archive_url":null,"date":"2026-04-13T11:59:19","subject":"Re: [PATCH v4 20/24] PCI: Add macros for legacy I/O and memory\n address space sizes","submitter":{"id":83553,"url":"http://patchwork.ozlabs.org/api/people/83553/","name":"Ilpo Järvinen","email":"ilpo.jarvinen@linux.intel.com"},"content":"On Sat, 11 Apr 2026, Krzysztof Wilczyński wrote:\n\n> Add defines for the standard PCI legacy address space sizes,\n> replacing the raw literals used by the legacy sysfs attributes.\n> \n> Suggested-by: Ilpo Järvinen \n> Signed-off-by: Krzysztof Wilczyński \n> ---\n> include/linux/pci.h | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/include/linux/pci.h b/include/linux/pci.h\n> index f6f55005f82d..6b630bac8c08 100644\n> --- a/include/linux/pci.h\n> +++ b/include/linux/pci.h\n> @@ -27,6 +27,7 @@\n> #include \n> \n> #include \n> +#include \n> #include \n> #include \n> #include \n> @@ -1167,6 +1168,10 @@ enum {\n> /* These external functions are only available when PCI support is enabled */\n> #ifdef CONFIG_PCI\n> \n> +/* PCI legacy I/O port and memory address space sizes. */\n> +#define PCI_LEGACY_IO_SIZE\t(SZ_64K - 1)\n> +#define PCI_LEGACY_MEM_SIZE\tSZ_1M\n> +\n> extern unsigned int pci_flags;\n> \n> static inline void pci_set_flags(int flags) { pci_flags = flags; }\n> \n\nShouldn't this also convert the use in pci-sysfs.c (which you now mixed \ninto the static attrs conversion patch)?","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=F+7FwymM;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-52431-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=\"F+7FwymM\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=198.175.65.13","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linux.intel.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvR2x3XyKz1yDF\n\tfor ; Mon, 13 Apr 2026 22:06:33 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 31185307CA16\n\tfor ; Mon, 13 Apr 2026 11:59:35 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id EDB983C0612;\n\tMon, 13 Apr 2026 11:59:33 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.13])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id A59E72D3A69;\n\tMon, 13 Apr 2026 11:59:32 +0000 (UTC)","from fmviesa007.fm.intel.com ([10.60.135.147])\n by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2026 04:59:32 -0700","from ijarvine-mobl1.ger.corp.intel.com (HELO localhost)\n ([10.245.245.63])\n by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2026 04:59:23 -0700"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776081573; cv=none;\n b=g9ES0EKhMKkIUvTvNmU+hgjjSAkLVXOV1AS/MzT5+5BqudyW/ZYd6kKQg9Vk7uoisblYtsDAu7PFltGMnTPH9jpaBOpQqO+GAR/ZU958L4iL5nnp0C5TTblnvYC6SPth0AexTch5Zmw7A2Uh/w3NbzkQ+z4TbVUhXvr2kr9z8uE=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776081573; c=relaxed/simple;\n\tbh=XjCiDo9y+OHrVQDJKUrYSIpvMP1U6UUn5n4372Stk5c=;\n\th=From:Date:To:cc:Subject:In-Reply-To:Message-ID:References:\n\t MIME-Version:Content-Type;\n b=tGLdyYwRyECKjsEvlLS5LRAWAJP8h3aKxyO+l0IT0dwxepEmXf3J/eSi4jCuYEpzlunGt8Tm8UP44ubEXG28jUAe7++ewfilfOVKxgVhs7wxKHSP0BOeyiTSsDZrfpYDx5Q9dR8207fuZE+bP+Oy9rtqkpiMyA4VDWXJTRSn6Y8=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com;\n spf=pass smtp.mailfrom=linux.intel.com;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=F+7FwymM; arc=none smtp.client-ip=198.175.65.13","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776081573; x=1807617573;\n h=from:date:to:cc:subject:in-reply-to:message-id:\n references:mime-version:content-id;\n bh=XjCiDo9y+OHrVQDJKUrYSIpvMP1U6UUn5n4372Stk5c=;\n b=F+7FwymMvCsIaEKXr/DA8heqhpka18pCpxDdg60fZFjw+u/hANFEy+aQ\n nm4DZkpa4bX+1XXXuefDQ2a6oepQlFNhhhS26iBdKbMik9uTbTVP3vO+K\n TryXJ0hergcGsI4qbuuM7D37Pe3nXuR2CugugG8DlaOHWYUtYI3EEJ74t\n IieL1mROPhUq199A5XfHGHAIkNEmVL9QssaWsg9g622+2V7CVxuBPhA/G\n xIuma8x414O/8Am2Pch0oplg73c4457A86RF9tbjXYZwEgoTetBqJ+N9C\n 5j50TdfGm+KC0UhYOYP2ZZe4Y/LhGnITVrZxDvZJbd2WuqByPc2ylxnL7\n Q==;","X-CSE-ConnectionGUID":["NEsLwy3zSc2MWdXv4HNfyQ==","AWmqfKN+SAKDaoql7UTAbw=="],"X-CSE-MsgGUID":["jz0r2Gi/Q6ar4Y2tzuvqOA==","0dDCkOLFShWVnJktOyq7nQ=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11757\"; a=\"88088835\"","E=Sophos;i=\"6.23,177,1770624000\";\n d=\"scan'208\";a=\"88088835\"","E=Sophos;i=\"6.23,177,1770624000\";\n d=\"scan'208\";a=\"226597919\""],"X-ExtLoop1":"1","From":"=?utf-8?q?Ilpo_J=C3=A4rvinen?= ","Date":"Mon, 13 Apr 2026 14:59:19 +0300 (EEST)","To":"=?iso-8859-2?q?Krzysztof_Wilczy=F1ski?= ","cc":"Bjorn Helgaas , Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?iso-8859-2?q?Krzysztof_Ha=B3asa?= ,\n Lukas Wunner , Oliver O'Halloran ,\n Saurabh Singh Sengar ,\n Shuan He ,\n Srivatsa Bhat , linux-pci@vger.kernel.org,\n linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org","Subject":"Re: [PATCH v4 20/24] PCI: Add macros for legacy I/O and memory\n address space sizes","In-Reply-To":"<20260411080148.471335-21-kwilczynski@kernel.org>","Message-ID":"","References":"<20260411080148.471335-1-kwilczynski@kernel.org>\n <20260411080148.471335-21-kwilczynski@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"multipart/mixed; BOUNDARY=\"8323328-972594317-1776081516=:962\"","Content-ID":""}}]