[{"id":3676688,"web_url":"http://patchwork.ozlabs.org/comment/3676688/","msgid":"","list_archive_url":null,"date":"2026-04-13T11:54:55","subject":"Re: [PATCH v4 14/24] alpha/PCI: Clean up pci_mmap_resource()","submitter":{"id":83553,"url":"http://patchwork.ozlabs.org/api/people/83553/","name":"Ilpo Järvinen","email":"ilpo.jarvinen@linux.intel.com"},"content":"On Sat, 11 Apr 2026, Krzysztof Wilczyński wrote:\n\n> Replace open-coded res->flags type checks with new pci_resource_is_mem()\n> and pci_resource_start() helpers. Move the pci_resource_n() call into\n> pcibios_resource_to_bus() and drop the local struct resource pointer.\n> \n> Signed-off-by: Krzysztof Wilczyński \n> ---\n> arch/alpha/kernel/pci-sysfs.c | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c\n> index 7aac5e76dcd6..6c011dab326d 100644\n> --- a/arch/alpha/kernel/pci-sysfs.c\n> +++ b/arch/alpha/kernel/pci-sysfs.c\n> @@ -70,7 +70,6 @@ static int pci_mmap_resource(struct kobject *kobj,\n> {\n> \tstruct pci_dev *pdev = to_pci_dev(kobj_to_dev(kobj));\n> \tint barno = (unsigned long)attr->private;\n> -\tstruct resource *res = pci_resource_n(pdev, barno);\n> \tenum pci_mmap_state mmap_type;\n> \tstruct pci_bus_region bar;\n> \tint ret;\n> @@ -79,15 +78,16 @@ static int pci_mmap_resource(struct kobject *kobj,\n> \tif (ret)\n> \t\treturn ret;\n> \n> -\tif ((res->flags & IORESOURCE_MEM) && iomem_is_exclusive(res->start))\n> +\tif (pci_resource_is_mem(pdev, barno) &&\n> +\t iomem_is_exclusive(pci_resource_start(pdev, barno)))\n> \t\treturn -EINVAL;\n> \n> \tif (!__pci_mmap_fits(pdev, barno, vma, sparse))\n> \t\treturn -EINVAL;\n> \n> -\tpcibios_resource_to_bus(pdev->bus, &bar, res);\n> +\tpcibios_resource_to_bus(pdev->bus, &bar, pci_resource_n(pdev, barno));\n> \tvma->vm_pgoff += bar.start >> (PAGE_SHIFT - (sparse ? 5 : 0));\n> -\tmmap_type = res->flags & IORESOURCE_MEM ? pci_mmap_mem : pci_mmap_io;\n> +\tmmap_type = pci_resource_is_mem(pdev, barno) ? pci_mmap_mem : pci_mmap_io;\n> \n> \treturn hose_mmap_page_range(pdev->sysdata, vma, mmap_type, sparse);\n> }\n> \n\nReviewed-by: Ilpo Järvinen ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=OQZlbsYZ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-52430-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=\"OQZlbsYZ\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=198.175.65.18","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linux.intel.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvQsp3mbwz1y2d\n\tfor ; Mon, 13 Apr 2026 21:58:38 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id B6DAC3006963\n\tfor ; Mon, 13 Apr 2026 11:55:09 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 4A2922405E1;\n\tMon, 13 Apr 2026 11:55:08 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.18])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C3292264A9;\n\tMon, 13 Apr 2026 11:55:06 +0000 (UTC)","from fmviesa002.fm.intel.com ([10.60.135.142])\n by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2026 04:55:05 -0700","from ijarvine-mobl1.ger.corp.intel.com (HELO localhost)\n ([10.245.245.63])\n by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2026 04:54:58 -0700"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776081308; cv=none;\n b=Rpuu5rK7jWeCGBHz8FjpD/6CEKmfoti7sWJcPU2szF3vWfck1mBJQWQsZtJ6Dx9yaTYpoy+jrJZkOdO3NJc2dMoT6mhrH4/APpDTiSBhbNUc9iotSOO6HFuAQFvsqvQm2OtVcZrQVhhpCJtqiXhEHM3t8FlpUzp1RYZf1UfRK3g=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776081308; c=relaxed/simple;\n\tbh=m4D4xwrjWoPcKd39e9WIlNBkYbShl/QU18qRe1RJS34=;\n\th=From:Date:To:cc:Subject:In-Reply-To:Message-ID:References:\n\t MIME-Version:Content-Type;\n b=GemEaTMNo4wBhmRIU+B8gejs/OBCpvk7+2qILmiNLHEkE8QrM6BAe6WHk0CFM2o5qcauBhhMpqUZ5INvjaCubQCDAxElkbCZy6nDkjC171eaiQaYSMkxAPCgoliE1NNNzg5Us9ooyOnHEhNUCdI2alO7H4A0i5lEIboCvfrONbc=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com;\n spf=pass smtp.mailfrom=linux.intel.com;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=OQZlbsYZ; arc=none smtp.client-ip=198.175.65.18","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776081306; x=1807617306;\n h=from:date:to:cc:subject:in-reply-to:message-id:\n references:mime-version;\n bh=m4D4xwrjWoPcKd39e9WIlNBkYbShl/QU18qRe1RJS34=;\n b=OQZlbsYZETUYG5AQvqlM8B9tMXsswA9P0ggVVPB5Iw6LSN+idT2c79F5\n inl2Nx8LuDxgm7Vds8hd1kBwUUFLgPBfWXATYkr5sWbyQ0zSQhzEs5mNf\n LrcU4dfTiS1c7PS+tiKK0Xwb55tkiEs6Mt/IYdIh4mdSO+SazyPR6T+Wh\n QJahsIlstSYiaopzG3VIay3pVXyX3OAG60cvQUDMCME+gFAn7iIcYcTZb\n K+FfpT3xMrrF9TrgV9O9BXqDBtL/LHENUgViFogZnC8C8Y4djI+LqQV9x\n 3U14k4Kh5cOxIsFrfZJwqKwM1wmtsmyD46vfINZAhwJcOtNdZQN+h1DZ8\n w==;","X-CSE-ConnectionGUID":["Xl2NOor/RYCo/g/Uq/rD7A==","lbiB9JauRxu0nvnsRhAtXQ=="],"X-CSE-MsgGUID":["x1aOug5KT02ZcT0IugS2Mg==","7eAaEOTEQUC6kP4Yz6kYCg=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11757\"; a=\"77030139\"","E=Sophos;i=\"6.23,177,1770624000\";\n d=\"scan'208\";a=\"77030139\"","E=Sophos;i=\"6.23,177,1770624000\";\n d=\"scan'208\";a=\"252959648\""],"X-ExtLoop1":"1","From":"=?utf-8?q?Ilpo_J=C3=A4rvinen?= ","Date":"Mon, 13 Apr 2026 14:54:55 +0300 (EEST)","To":"=?iso-8859-2?q?Krzysztof_Wilczy=F1ski?= ","cc":"Bjorn Helgaas , Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?iso-8859-2?q?Krzysztof_Ha=B3asa?= ,\n Lukas Wunner , Oliver O'Halloran ,\n Saurabh Singh Sengar ,\n Shuan He ,\n Srivatsa Bhat , linux-pci@vger.kernel.org,\n linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org","Subject":"Re: [PATCH v4 14/24] alpha/PCI: Clean up pci_mmap_resource()","In-Reply-To":"<20260411080148.471335-15-kwilczynski@kernel.org>","Message-ID":"","References":"<20260411080148.471335-1-kwilczynski@kernel.org>\n <20260411080148.471335-15-kwilczynski@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"multipart/mixed; boundary=\"8323328-878657269-1776081295=:962\""}}]