[{"id":3676685,"web_url":"http://patchwork.ozlabs.org/comment/3676685/","msgid":"<5c4f32d1-0648-31d1-d7c0-661ccec4f8bc@linux.intel.com>","list_archive_url":null,"date":"2026-04-13T11:52:49","subject":"Re: [PATCH v4 13/24] alpha/PCI: Use PCI resource accessor macros","submitter":{"id":83553,"url":"http://patchwork.ozlabs.org/api/people/83553/","name":"Ilpo Järvinen","email":"ilpo.jarvinen@linux.intel.com"},"content":"On Sat, 11 Apr 2026, Krzysztof Wilczyński wrote:\n\n> Replace direct pdev->resource[] accesses with pci_resource_n(),\n> and pdev->resource[].flags accesses with pci_resource_flags().\n> \n> No functional changes intended.\n> \n> Reviewed-by: Ilpo Järvinen \n> Signed-off-by: Krzysztof Wilczyński \n> ---\n> arch/alpha/kernel/pci-sysfs.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c\n> index c84867ce31f5..7aac5e76dcd6 100644\n> --- a/arch/alpha/kernel/pci-sysfs.c\n> +++ b/arch/alpha/kernel/pci-sysfs.c\n> @@ -141,7 +141,7 @@ static int sparse_mem_mmap_fits(struct pci_dev *pdev, int num)\n> \tlong dense_offset;\n> \tunsigned long sparse_size;\n> \n> -\tpcibios_resource_to_bus(pdev->bus, &bar, &pdev->resource[num]);\n> +\tpcibios_resource_to_bus(pdev->bus, &bar, pci_resource_n(pdev, num));\n> \n> \t/* All core logic chips have 4G sparse address space, except\n> \t CIA which has 16G (see xxx_SPARSE_MEM and xxx_DENSE_MEM\n> @@ -181,7 +181,7 @@ static int pci_create_attr(struct pci_dev *pdev, int num)\n> \tsuffix = \"\";\t/* Assume bwx machine, normal resourceN files. */\n> \tnlen1 = 10;\n> \n> -\tif (pdev->resource[num].flags & IORESOURCE_MEM) {\n> +\tif (pci_resource_flags(pdev, num) & IORESOURCE_MEM) {\n\nThis could have used the new helper but since this code is going away \nanyway in a later patch it doesn't matter,\n\nReviewed-by: Ilpo Järvinen ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=FO0sOFOn;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-52429-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=\"FO0sOFOn\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=192.198.163.19","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linux.intel.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvQpd4vZnz1y2d\n\tfor ; Mon, 13 Apr 2026 21:55:53 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id DEF6C304705B\n\tfor ; Mon, 13 Apr 2026 11:53:06 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 53656294A10;\n\tMon, 13 Apr 2026 11:53:06 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.19])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id E068722424C;\n\tMon, 13 Apr 2026 11:53:04 +0000 (UTC)","from fmviesa001.fm.intel.com ([10.60.135.141])\n by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2026 04:53:04 -0700","from ijarvine-mobl1.ger.corp.intel.com (HELO localhost)\n ([10.245.245.63])\n by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2026 04:52:54 -0700"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776081186; cv=none;\n b=S1TXWANIwNr7ah0x8nCajA+xDmS/QjoO3g8P4pXLOmMdOB5wmUDg+nYfSuFIUU1VmsNNEGaNtRFRHTQZ2IFtXUff+nMR16hd4jvzPivSwFsvn9SgwH2zCd6e+ieEn+uVq53fXIs59nyG4JHlSCa+wfXJhht0RFAzuqczYOJHtpc=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776081186; c=relaxed/simple;\n\tbh=dJVGufupuRzhM0xublRPUyKnOZZPoagICx16HUyrYow=;\n\th=From:Date:To:cc:Subject:In-Reply-To:Message-ID:References:\n\t MIME-Version:Content-Type;\n b=nuarDtAKtLZUApipO92PaHkLmBRBpQm6MK5EKtDcn8JpFH/yEnr0ZV8uFn0woDGCiAKuYJ8S3DxXRhZnSEG0hQBajJlANA91LHmu16pKqFv/Ry1q2+zNki6NWGPbrlQI36p7UoXgsrtsaOL4+ywHLZSRsq81wTNDRNsp4quk9Oo=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com;\n spf=pass smtp.mailfrom=linux.intel.com;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=FO0sOFOn; arc=none smtp.client-ip=192.198.163.19","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776081185; x=1807617185;\n h=from:date:to:cc:subject:in-reply-to:message-id:\n references:mime-version;\n bh=dJVGufupuRzhM0xublRPUyKnOZZPoagICx16HUyrYow=;\n b=FO0sOFOnggLoPmrot5QCZXFFZ/Sbx6oBXcaFBTDjJKOxJO4FA1pCymCG\n ziQN9RboWQq+gdu2JTU/Fze1LDzddesNe8VmM5J/n2lero6Ar8JqkA1lL\n Z7RbCllk+qfLyKsgb6pdbIs2S6GGDuN+H/DsVJICmtkIveYRNc07S2hQS\n fE8J/bxdwZxcFv8AaEFd2tIapvEqXAH8NQOXRyusFcE0z+C7ODjH5yeCf\n YEALeXoyPdAxWwXT9wD1CzO2gNarDkJDIIOBK5QQ/hg06PyhNGdJKovH3\n Ca4KlhBvJQgb235o8+UW6/NTa+uTC7oe/uE7LnQRjWfNWVb9u8aDWzdXu\n Q==;","X-CSE-ConnectionGUID":["Tz/GlsPXSc+rmA9LDXQ8cQ==","Qi86xDZ0TgiVjehP4JCm2w=="],"X-CSE-MsgGUID":["H4JckUwhSt6FBvz+Rhp5HA==","nvS2V3eiR/y1R3IE9KDruQ=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11757\"; a=\"76046430\"","E=Sophos;i=\"6.23,177,1770624000\";\n d=\"scan'208\";a=\"76046430\"","E=Sophos;i=\"6.23,177,1770624000\";\n d=\"scan'208\";a=\"253165075\""],"X-ExtLoop1":"1","From":"=?utf-8?q?Ilpo_J=C3=A4rvinen?= ","Date":"Mon, 13 Apr 2026 14:52:49 +0300 (EEST)","To":"=?iso-8859-2?q?Krzysztof_Wilczy=F1ski?= ","cc":"Bjorn Helgaas , Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?iso-8859-2?q?Krzysztof_Ha=B3asa?= ,\n Lukas Wunner , Oliver O'Halloran ,\n Saurabh Singh Sengar ,\n Shuan He ,\n Srivatsa Bhat , linux-pci@vger.kernel.org,\n linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org","Subject":"Re: [PATCH v4 13/24] alpha/PCI: Use PCI resource accessor macros","In-Reply-To":"<20260411080148.471335-14-kwilczynski@kernel.org>","Message-ID":"<5c4f32d1-0648-31d1-d7c0-661ccec4f8bc@linux.intel.com>","References":"<20260411080148.471335-1-kwilczynski@kernel.org>\n <20260411080148.471335-14-kwilczynski@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"multipart/mixed; boundary=\"8323328-1935294158-1776081169=:962\""}}]