[{"id":3676658,"web_url":"http://patchwork.ozlabs.org/comment/3676658/","msgid":"<22b1e95c-4741-66c3-3ef5-5a87daba6056@linux.intel.com>","date":"2026-04-13T11:19:27","subject":"Re: [PATCH v4 02/24] PCI: Add pci_resource_is_io() and\n pci_resource_is_mem()\n helpers","submitter":{"id":83553,"url":"http://patchwork.ozlabs.org/api/people/83553/","name":"Ilpo Järvinen","email":"ilpo.jarvinen@linux.intel.com"},"content":"On Sat, 11 Apr 2026, Krzysztof Wilczyński wrote:\n\n> Add helpers to check whether a PCI resource is of I/O port or\n> memory type. These replace the open-coded pci_resource_flags()\n> with IORESOURCE_IO and IORESOURCE_MEM pattern used across the\n> tree.\n> \n> Suggested-by: Ilpo Järvinen \n> Signed-off-by: Krzysztof Wilczyński \n> ---\n> include/linux/pci.h | 25 +++++++++++++++++++++++++\n> 1 file changed, 25 insertions(+)\n> \n> diff --git a/include/linux/pci.h b/include/linux/pci.h\n> index 1c270f1d5123..05aceb7f1f37 100644\n> --- a/include/linux/pci.h\n> +++ b/include/linux/pci.h\n> @@ -2295,6 +2295,31 @@ int pci_iobar_pfn(struct pci_dev *pdev, int bar, struct vm_area_struct *vma);\n> \tCONCATENATE(__pci_dev_for_each_res, COUNT_ARGS(__VA_ARGS__)) \t\\\n> \t\t (dev, res, __VA_ARGS__)\n> \n> +/**\n> + * pci_resource_is_io - check if a PCI resource is of I/O port type.\n> + * @dev: PCI device to check.\n> + * @resno: The resource number (BAR index) to check.\n> + *\n> + * Returns true if the resource type is I/O port.\n> + */\n> +static inline bool pci_resource_is_io(const struct pci_dev *dev, int resno)\n> +{\n> +\treturn resource_type(pci_resource_n(dev, resno)) == IORESOURCE_IO;\n> +}\n> +\n> +/**\n> + * pci_resource_is_mem - check if a PCI resource is of memory type.\n> + * @dev: PCI device to check.\n> + * @resno: The resource number (BAR index) to check.\n> + *\n> + * Returns true if the resource type is memory, including\n> + * prefetchable memory.\n> + */\n> +static inline bool pci_resource_is_mem(const struct pci_dev *dev, int resno)\n> +{\n> +\treturn resource_type(pci_resource_n(dev, resno)) == IORESOURCE_MEM;\n> +}\n> +\n> /*\n> * Similar to the helpers above, these manipulate per-pci_dev\n> * driver-specific data. They are really just a wrapper around\n> \n\nReviewed-by: Ilpo Järvinen ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=Mz4ce3vH;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19679-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=198.175.65.15","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=Mz4ce3vH;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.intel.com\n (client-ip=198.175.65.15; helo=mgamail.intel.com;\n envelope-from=ilpo.jarvinen@linux.intel.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvQ141vhhz1xtJ\n\tfor ; Mon, 13 Apr 2026 21:19:50 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fvQ112Yhmz2yjV;\n\tMon, 13 Apr 2026 21:19:49 +1000 (AEST)","from mgamail.intel.com (mgamail.intel.com [198.175.65.15])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fvQ0x3KRXz2yS9\n\tfor ; Mon, 13 Apr 2026 21:19:42 +1000 (AEST)","from orviesa005.jf.intel.com ([10.64.159.145])\n by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2026 04:19:38 -0700","from ijarvine-mobl1.ger.corp.intel.com (HELO localhost)\n ([10.245.245.63])\n by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2026 04:19:30 -0700"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776079189;\n\tcv=none;\n b=iLkdgz18BpR8H6sTjrAJ+7SblcivFSVw8IzWi6QcG/Ju/QtaFAdKlLdOdwyBPjy5GhZCWGr2l0wfKxlX20yh7oYKVV9RNx6huncTd6yHW1n+LYW3MEBF5VnbLFUJCfqh3YFUO5I15i9JIxCY8gNjQobhpN+yFP+V0M1zPLd2y/qfYEdNF772rVkS7IwxrskzXdCD7c66ev8vcA1wMvkKEc/BFKq2HyD6DDTIf3CgUO9n25MXt7jVEPxK70uEwukCu09n2aCETO4EGfb12t3FIYKPi0fWsPX5BpVtMtQS1v8qLPOdf8vgMSHIXNNKyjGijgFnGyU+RTiNGvfnWYU/Ew==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776079189; c=relaxed/relaxed;\n\tbh=FARcUhYNpZjwLnnPL43yYu/rcQKJ4x/Tu7Rb0vwVPQI=;\n\th=From:Date:To:cc:Subject:In-Reply-To:Message-ID:References:\n\t MIME-Version:Content-Type;\n b=Kl2C9fJHLz5HGoX4S8xhp/LSKinsTwKnhvZcbgkyLyCVc+vyzeYZMLuZ1fmaSq8s4t410OMB86pIoYeuB7TvzGCSYy6aZkX8Qb1Bz6SV8GLLbUlg+maYHOqsC6HPI1Jcyljqe9dul1IJdwFwA3sqNs/YoE/8POpsUOGk+/7XJapjK5lBCK5Kw5pO+JhGu+WB5tnziKg3+Qxr663e5hCzMuUCAFUSqtZu8arSO32rjSDZfvaaeUTp31alaEI04djxgrc9+xhQzVvP4KboMuUO9UHO1Ip7lux9LTMNRdT6hKp9Y40grgq4cYxv0DcMbFNv4RUm404U0nog2/YFvNTr9w==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=Mz4ce3vH; dkim-atps=neutral;\n spf=pass (client-ip=198.175.65.15; helo=mgamail.intel.com;\n envelope-from=ilpo.jarvinen@linux.intel.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=linux.intel.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776079186; x=1807615186;\n h=from:date:to:cc:subject:in-reply-to:message-id:\n references:mime-version;\n bh=CVbVKb2nM0zwk8+T+WrSIwjJaIItZ5z+YYob7tPm2q0=;\n b=Mz4ce3vHWYTr2o2br+gKJUkb0vzdFmUYRXTHVuHmNQK46GVj6Q0n71E7\n OMXmBXuPLXmzudsEiBIbaFejoIZBxkqU6Jqa85xafapJ704lDARaZ67hz\n KQHJhoR8Yv77LAueYBSjKhOmtLrlY1VgvR8sC+emXcNfqACOJ3O9AMRwB\n RSFNBrBWuFLFd+icSrLmx5LrjNPSp0nq//GzQZ0SPHm3oVuW774Yufz28\n aR3q/JLADSSyE64qXURYHfMHXBvobWRPkEQLwUZK2fXwmEnZE5lrBzQxU\n 1fp8H2K9PCOU9e/dMC1cAy7++Vxl6wTuAIQ25KO2X3HqNuIjF1QgVukxJ\n Q==;","X-CSE-ConnectionGUID":["sE5cCx6TT+K9EHv/lE5Kog==","+OGPYEbfShKT7eOQV1rdjg=="],"X-CSE-MsgGUID":["GwvRxoXCRgmlDoGpd4M/bw==","gjMpAYX/ROeP86KL5DHTBg=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11757\"; a=\"80597618\"","E=Sophos;i=\"6.23,177,1770624000\";\n d=\"scan'208\";a=\"80597618\"","E=Sophos;i=\"6.23,177,1770624000\";\n d=\"scan'208\";a=\"234741721\""],"X-ExtLoop1":"1","From":"=?utf-8?q?Ilpo_J=C3=A4rvinen?= ","Date":"Mon, 13 Apr 2026 14:19:27 +0300 (EEST)","To":"=?iso-8859-2?q?Krzysztof_Wilczy=F1ski?= ","cc":"Bjorn Helgaas , Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?iso-8859-2?q?Krzysztof_Ha=B3asa?= ,\n Lukas Wunner , Oliver O'Halloran ,\n Saurabh Singh Sengar ,\n Shuan He ,\n Srivatsa Bhat , linux-pci@vger.kernel.org,\n linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org","Subject":"Re: [PATCH v4 02/24] PCI: Add pci_resource_is_io() and\n pci_resource_is_mem()\n helpers","In-Reply-To":"<20260411080148.471335-3-kwilczynski@kernel.org>","Message-ID":"<22b1e95c-4741-66c3-3ef5-5a87daba6056@linux.intel.com>","References":"<20260411080148.471335-1-kwilczynski@kernel.org>\n <20260411080148.471335-3-kwilczynski@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"multipart/mixed; boundary=\"8323328-2046482584-1776079167=:962\"","X-Spam-Status":"No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]