[{"id":3676660,"web_url":"http://patchwork.ozlabs.org/comment/3676660/","msgid":"<22b1e95c-4741-66c3-3ef5-5a87daba6056@linux.intel.com>","list_archive_url":null,"date":"2026-04-13T11:19:27","subject":"Re: [PATCH v4 02/24] PCI: Add pci_resource_is_io() and\n pci_resource_is_mem()\n helpers","submitter":{"id":83553,"url":"http://patchwork.ozlabs.org/api/people/83553/","name":"Ilpo Järvinen","email":"ilpo.jarvinen@linux.intel.com"},"content":"On Sat, 11 Apr 2026, Krzysztof Wilczyński wrote:\n\n> Add helpers to check whether a PCI resource is of I/O port or\n> memory type. These replace the open-coded pci_resource_flags()\n> with IORESOURCE_IO and IORESOURCE_MEM pattern used across the\n> tree.\n> \n> Suggested-by: Ilpo Järvinen \n> Signed-off-by: Krzysztof Wilczyński \n> ---\n> include/linux/pci.h | 25 +++++++++++++++++++++++++\n> 1 file changed, 25 insertions(+)\n> \n> diff --git a/include/linux/pci.h b/include/linux/pci.h\n> index 1c270f1d5123..05aceb7f1f37 100644\n> --- a/include/linux/pci.h\n> +++ b/include/linux/pci.h\n> @@ -2295,6 +2295,31 @@ int pci_iobar_pfn(struct pci_dev *pdev, int bar, struct vm_area_struct *vma);\n> \tCONCATENATE(__pci_dev_for_each_res, COUNT_ARGS(__VA_ARGS__)) \t\\\n> \t\t (dev, res, __VA_ARGS__)\n> \n> +/**\n> + * pci_resource_is_io - check if a PCI resource is of I/O port type.\n> + * @dev: PCI device to check.\n> + * @resno: The resource number (BAR index) to check.\n> + *\n> + * Returns true if the resource type is I/O port.\n> + */\n> +static inline bool pci_resource_is_io(const struct pci_dev *dev, int resno)\n> +{\n> +\treturn resource_type(pci_resource_n(dev, resno)) == IORESOURCE_IO;\n> +}\n> +\n> +/**\n> + * pci_resource_is_mem - check if a PCI resource is of memory type.\n> + * @dev: PCI device to check.\n> + * @resno: The resource number (BAR index) to check.\n> + *\n> + * Returns true if the resource type is memory, including\n> + * prefetchable memory.\n> + */\n> +static inline bool pci_resource_is_mem(const struct pci_dev *dev, int resno)\n> +{\n> +\treturn resource_type(pci_resource_n(dev, resno)) == IORESOURCE_MEM;\n> +}\n> +\n> /*\n> * Similar to the helpers above, these manipulate per-pci_dev\n> * driver-specific data. They are really just a wrapper around\n> \n\nReviewed-by: Ilpo Järvinen ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=Jdl2iTNY;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-52423-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=\"Jdl2iTNY\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=198.175.65.15","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linux.intel.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvQ481r3Gz1yDF\n\tfor ; Mon, 13 Apr 2026 21:22:32 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id D12CE3008225\n\tfor ; Mon, 13 Apr 2026 11:19:42 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id D259130B514;\n\tMon, 13 Apr 2026 11:19:41 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.15])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id AA5B7237713;\n\tMon, 13 Apr 2026 11:19:39 +0000 (UTC)","from orviesa005.jf.intel.com ([10.64.159.145])\n by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2026 04:19:37 -0700","from ijarvine-mobl1.ger.corp.intel.com (HELO localhost)\n ([10.245.245.63])\n by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2026 04:19:30 -0700"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776079181; cv=none;\n b=rFfUiaZts1aNCEQdmh5WoVNfJXoO0Nx/xRIHfipoHILNk4GbMF3hFsOvwyvuutJH1pxcRoS8E9+nfE+vrVkLLiOFMNKLta1AxJ9MkZCBIzZnIs5COQmeKz9huGW4dLu/XZrzKdKH2AZZCQL1bpIureyoo6xVHRHnRQ+uQCKfj0E=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776079181; c=relaxed/simple;\n\tbh=CVbVKb2nM0zwk8+T+WrSIwjJaIItZ5z+YYob7tPm2q0=;\n\th=From:Date:To:cc:Subject:In-Reply-To:Message-ID:References:\n\t MIME-Version:Content-Type;\n b=m8QTml6RZ8c5JOamG2M8IVwf8gX8XvpHI2o4j/hgAv0OUBIUTWMnzypgvRNJ5gN/ORLlmxjq+QGSry9eQCWf8t5HAgg/Bhn51LZ8sbEibauw9jGMTYYWj9khrC9M0a4eYivs8KRUFKOo1QwcE40mSUIzXd+t2Ym78JrqwaPmsTM=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com;\n spf=pass smtp.mailfrom=linux.intel.com;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=Jdl2iTNY; arc=none smtp.client-ip=198.175.65.15","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776079179; x=1807615179;\n h=from:date:to:cc:subject:in-reply-to:message-id:\n references:mime-version;\n bh=CVbVKb2nM0zwk8+T+WrSIwjJaIItZ5z+YYob7tPm2q0=;\n b=Jdl2iTNYQEKqXAtoL7KS2RtWWqufOSG+YQLD1sCEAFSDuB4iU7CNZrAw\n 1zLu4Gb7n1/ZcU6hfvzCdBGvvm/lJ5o6YCr8SM/UEaWzl6F5Q3yIXwuQY\n skOrVBvNyvnRYSFAQOJTK3GauAzQVTaExotPl5JdTZrttqg/93lLS9kzr\n 7dkjPw1Mb7RfpU7KZUzKimGkjrPPct6a+8tfeTm7aXLNrojZrCc4mwM8l\n PNaee+UvGPolc3QmZguG2W7HvzKBgHePj4i6Jo7hkNs6WSN/ip8RSWvWb\n F8viwwctZI2aUtH1Cop7xUVM8TOtSM+HnRuAJiM/GHV53odDdZlibXGRx\n Q==;","X-CSE-ConnectionGUID":["Yguq/QBxRZWO94tPUdVjXA==","+OGPYEbfShKT7eOQV1rdjg=="],"X-CSE-MsgGUID":["LsE/VexkTbeXzNFKw1dVaQ==","gjMpAYX/ROeP86KL5DHTBg=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11757\"; a=\"80597612\"","E=Sophos;i=\"6.23,177,1770624000\";\n d=\"scan'208\";a=\"80597612\"","E=Sophos;i=\"6.23,177,1770624000\";\n d=\"scan'208\";a=\"234741721\""],"X-ExtLoop1":"1","From":"=?utf-8?q?Ilpo_J=C3=A4rvinen?= ","Date":"Mon, 13 Apr 2026 14:19:27 +0300 (EEST)","To":"=?iso-8859-2?q?Krzysztof_Wilczy=F1ski?= ","cc":"Bjorn Helgaas , Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?iso-8859-2?q?Krzysztof_Ha=B3asa?= ,\n Lukas Wunner , Oliver O'Halloran ,\n Saurabh Singh Sengar ,\n Shuan He ,\n Srivatsa Bhat , linux-pci@vger.kernel.org,\n linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org","Subject":"Re: [PATCH v4 02/24] PCI: Add pci_resource_is_io() and\n pci_resource_is_mem()\n helpers","In-Reply-To":"<20260411080148.471335-3-kwilczynski@kernel.org>","Message-ID":"<22b1e95c-4741-66c3-3ef5-5a87daba6056@linux.intel.com>","References":"<20260411080148.471335-1-kwilczynski@kernel.org>\n <20260411080148.471335-3-kwilczynski@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"multipart/mixed; boundary=\"8323328-2046482584-1776079167=:962\""}}]