[{"id":3676277,"web_url":"http://patchwork.ozlabs.org/comment/3676277/","msgid":"","list_archive_url":null,"date":"2026-04-11T15:40:32","subject":"Re: [PATCH v2 06/10] mach-snapdragon: Kconfig: changes / additions to\n support SPL","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Michael,\n\nOn 2026-04-11T00:00:12, Michael Srba wrote:\n> mach-snapdragon: Kconfig: changes / additions to support SPL\n>\n> An SoC to target has to be selected, e.g. SPL_TARGET_SDM845.\n> This will select reasonable defaults and enable per-SoC linker\n> script (if required).\n>\n> Signed-off-by: Michael Srba \n>\n> arch/arm/Kconfig | 31 +++++++++++++++++++++++++++-\n> arch/arm/mach-snapdragon/Kconfig | 44 ++++++++++++++++++++++++++++++++++------\n> 2 files changed, 68 insertions(+), 7 deletions(-)\n\n> diff --git a/arch/arm/mach-snapdragon/Kconfig\n> @@ -11,18 +11,12 @@ config SYS_VENDOR\n> -config SYS_MALLOC_LEN\n> - default 0x10000000\n\nYou are removing a duplicate SYS_MALLOC_LEN definition (0x10000000 vs\n0x800000). Please can you split this fix into a separate preparatory\npatch, since it is a bug fix unrelated to adding SPL support?\n\n> diff --git a/arch/arm/mach-snapdragon/Kconfig\n> +config SPL_TARGET_SDM845\n> + bool \"Set reasonable default values for running SPL in SRAM on sdm845 devices\"\n\nThis is missing a help text. Please add one explaining what this\nenables, perhaps referencing doc/board/qualcomm/spl.rst. Also, this\nshould probably have 'depends on SPL'\n\n> diff --git a/arch/arm/Kconfig\n> + select SPL_MMC if SPL\n\nJust to check - is SPL_MMC really needed for all Snapdragon SPL\nbuilds? The defconfig and documentation suggest only USB DFU is\ncurrently supported. If MMC is not actually used yet, maybe use imply\nrather than select\n\nReviewed-by: Simon Glass \n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=NQ6bO9x+;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"NQ6bO9x+\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftrJS4RPXz1y2d\n\tfor ; Sun, 12 Apr 2026 23:01:12 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 6E4498352B;\n\tSun, 12 Apr 2026 15:00:25 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 176ED8416F; Sat, 11 Apr 2026 17:40:50 +0200 (CEST)","from mail-ej1-x631.google.com (mail-ej1-x631.google.com\n [IPv6:2a00:1450:4864:20::631])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 28C8380077\n for ; Sat, 11 Apr 2026 17:40:48 +0200 (CEST)","by mail-ej1-x631.google.com with SMTP id\n a640c23a62f3a-b980b35534eso418778866b.1\n for ; Sat, 11 Apr 2026 08:40:48 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1775922047; cv=none;\n d=google.com; s=arc-20240605;\n b=Jp31O8fIxPhv50nbf6/DeagpHhHxBE3gHbLsP1SgQ91FO4XURl2hvj9DJXwxi9ZDBS\n swiZsT545WJfCqZ73bLMlg/9wt0G5Oel37q7Ozu2V2IPr8aG8TZSScLLBX1fYDcZqWOy\n EuLz9Fioa1cn17jdxaepkTXFfJhiPQd8VKPWQnGdtJJ3zV4Aj9no00Emi0+ZKWr3UofT\n ZEjdTs/MCk2VUiXxPHmkFmYYP9GWHc964B8J0g4N7Fxy6yCi9htoMsKOM8mXnNPL2Wkf\n Pn71UI/3ttQb8ZRbtwPr7mt5CB8Ua7+XKGFd1A581WRYmH9Enp9UfncPvBUcZBSIkoZL\n bIlA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=CJx+yrr5C0buVQJEkIgdM3pKZ9xk+9nnvxbKVjbEwOI=;\n fh=pKV29h6PBf5SbuSFTM/GZF+KoVG4OaOclZXc+5Qi1tM=;\n b=MQDyuFdqtm11cJB93foLdF618r1DS78Oax4KaJiS2KEggyXs9N0HZLXTt0NUMXEM7I\n zHAkjumi+nufftCaY3hqW8KKbSydtXkQiHgqmchqCb//RUGMx/S14i43a9SIfa5d093x\n fFvTPWXCBNGeuKxxvcNR3MjTYtrfQg94LLCxN4kmVymwLSf5pldGscuYorD9pOD0cT+q\n fhS4iq11/hhTTDXHLOEWd10SpSBdC0ZEcEihTaYO+VsIrjYR6x3ocm6WrkdDsikEq2cR\n tD8u/9Con2QftldwFqDa59GIQtIIoYgVGNz5Cj/VRKVH+wxdaTOOOrw/rAWsjqmhOt3D\n jS7A==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1775922047; x=1776526847; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=CJx+yrr5C0buVQJEkIgdM3pKZ9xk+9nnvxbKVjbEwOI=;\n b=NQ6bO9x+wg3ffwZEcObSKRfqzAeTLXLCY6mczSefowUjNsZOriQ/iyrymF6hjh+Jzh\n zfDf/R/7U7WO9rGt8iR69C7KLfobl/DRGrtPznd9ibOzb8cri+iSB8vSkeM+hWK+oGn7\n 0zmTSEqznz+Yg71Lu+f+T55p1XubOUEOb6KC8=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775922047; x=1776526847;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=CJx+yrr5C0buVQJEkIgdM3pKZ9xk+9nnvxbKVjbEwOI=;\n b=VgEdNAI44H7leT0TQrS9eahvRuL0e9Nqf8Bfe7F79ueqZrkPlal1Bmj75q5e214a7W\n PnL1/8T4FMgYwrwTWeTCUXFpjHtz2G/m7KuMhEN+yPmhJNfR/dPXb8/9IqbCnHuDOO/+\n XfFBIdK5j4+CjBGvF4Sryz+kbM3gVKi6rQnfP23grerw0BHftFOBjOumTW43XYdZHkk6\n EJbTcfzcyvKR1cVLxONmjD5A9qz3TtAU2zBkLzUlQh66FdRMVtRA+qPtB52A6W6jc4Ej\n 80NQG/c9kssme0SBgLDfUMUdJ0euFqdw2lfXUBDEJgPitvhv8M/zV1kbxR/TtWUdjI8r\n kRBw==","X-Gm-Message-State":"AOJu0YxxD+hAaeBGcS4zfY9dRWLOU9yAeHeNgO5XDac+ebxXPjSA/fFi\n bnzz8qBugIF5Px6RCWpcIlkOIdlc3Pyi3TzjSDyJGebMjM9Lu2gRZOjHIA8Tzb1quS9k3YipVCT\n hzyMQgFqmqupIciH02LhRdOXYVSn3kQ55Mr+oArlt","X-Gm-Gg":"AeBDietUIgH3HHYBxQ4MM1VfttJS4VTV5xnBF555uHVSw9HQ5U7xEW/VX3MGgR4RrZU\n U1ixXtBpj0erVtIZhE5eZZZhBQQh5QphOWV+WBJyhn5RgFVHqDShy2PMbEea/3w1zdKK1l9atok\n JofuM+vZgxqkj1A+RF0iv8faFqIwbdvqxfLti2K6+sK2kFR2zxmBfQm4on7F/jkQc+jTSxZPDED\n Hzk/DdLMrwmM3boC8AN88pftHXdHV3laiFDktA3k3rYqoF1gWKsVBfOeczEkSGrSsWeXJDck7nl\n gvdXjg==","X-Received":"by 2002:a17:906:3655:b0:b9d:7b9d:df02 with SMTP id\n a640c23a62f3a-b9d7b9e0c43mr243266266b.17.1775922047520; Sat, 11 Apr 2026\n 08:40:47 -0700 (PDT)","MIME-Version":"1.0","References":"<20260411-qcom_spl-v2-0-9609557cf562@seznam.cz>\n <20260411-qcom_spl-v2-6-9609557cf562@seznam.cz>","In-Reply-To":"<20260411-qcom_spl-v2-6-9609557cf562@seznam.cz>","From":"Simon Glass ","Date":"Sat, 11 Apr 2026 09:40:32 -0600","X-Gm-Features":"AQROBzBZj6vCsv0qTzXw741r25ZNmKezRuYj0UNb5xvQSKopsYb10KjgT8ndNSg","Message-ID":"\n ","Subject":"Re: [PATCH v2 06/10] mach-snapdragon: Kconfig: changes / additions to\n support SPL","To":"michael.srba@seznam.cz","Cc":"u-boot@lists.denx.de, Sumit Garg ,\n u-boot-qcom@groups.io,\n Tom Rini ,\n Ilias Apalodimas ,\n Simon Glass , Sughosh Ganu ,\n Anshul Dalal ,\n Peng Fan , Mattijs Korpershoek ,\n Quentin Schulz ,\n Heinrich Schuchardt , Andrew Davis ,\n Hrushikesh Salunke ,\n Dario Binacchi ,\n Ye Li , Andre Przywara ,\n Alif Zakuan Yuslaimi ,\n Leo Yu-Chi Liang ,\n Andrew Goodbody , Dhruva Gole ,\n Kaustabh Chakraborty ,\n Jerome Forissier ,\n Heiko Schocher ,\n Marek Vasut ,\n Lukasz Majewski ,\n Mateusz Kulikowski ,\n Dinesh Maniyam ,\n Neil Armstrong ,\n Patrice Chotard ,\n Patrick Delaunay ,\n Michal Simek ,\n Yao Zi , Peter Korsgaard ,\n Rayagonda Kokatanur ,\n Casey Connolly ,\n Tingting Meng ,\n Tien Fong Chee , Alice Guo ,\n George Chan ,\n Balaji Selvanathan ,\n Alexey Charkov , Ronald Wahl ","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailman-Approved-At":"Sun, 12 Apr 2026 15:00:19 +0200","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]