[{"id":3676274,"web_url":"http://patchwork.ozlabs.org/comment/3676274/","msgid":"","list_archive_url":null,"date":"2026-04-11T15:39:51","subject":"Re: [PATCH v2 03/10] drivers: allow clk_stub and spmi in SPL","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Michael,\n\nOn 2026-04-11T00:00:12, Michael Srba wrote:\n> drivers: allow clk_stub and spmi in SPL\n>\n> Only Makefile and Kconfig changes necessary.\n>\n> Signed-off-by: Michael Srba \n>\n> drivers/Makefile | 2 +-\n> drivers/clk/Kconfig | 6 ++++++\n> drivers/spmi/Kconfig | 6 ++++++\n> drivers/spmi/Makefile | 2 +-\n> 4 files changed, 14 insertions(+), 2 deletions(-)\n\n> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig\n> @@ -114,6 +114,12 @@ config CLK_STUB\n> +config SPL_CLK_STUB\n> + bool \"Stub clock driver\"\n> + depends on SPL_CLK\n> + help\n> + Enable stub clock driver in SPL\n\nPlease can you expand this to mention the use case, e.g. 'Enable this\nto provide a stub clock driver in SPL for non-essential clock\ncontrollers'\n\n> diff --git a/drivers/spmi/Kconfig b/drivers/spmi/Kconfig\n> @@ -8,6 +8,12 @@ config SPMI\n> +config SPL_SPMI\n> + bool \"Enable SPMI bus support in SPL\"\n> + depends on SPL_DM\n> + help\n> + Select this to enable SPMI bus support in SPL\n\nJust to check — should this also depend on SPMI? Since SPMI_MSM\ndepends on SPMI (not SPL_SPMI), you need SPMI enabled in U-Boot proper\nto get the driver compiled. Currently ARCH_SNAPDRAGON selects SPMI so\nit works, but the Kconfig relationship seems loose.\n\nReviewed-by: Simon Glass \n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=GhZ6asZI;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"GhZ6asZI\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftrJ0718Kz1y2d\n\tfor ; Sun, 12 Apr 2026 23:00:48 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id F1E288419E;\n\tSun, 12 Apr 2026 15:00:21 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id CE7298416F; Sat, 11 Apr 2026 17:40:08 +0200 (CEST)","from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com\n [IPv6:2a00:1450:4864:20::52e])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id D610880077\n for ; Sat, 11 Apr 2026 17:40:06 +0200 (CEST)","by mail-ed1-x52e.google.com with SMTP id\n 4fb4d7f45d1cf-65c0891f4e9so4995627a12.1\n for ; Sat, 11 Apr 2026 08:40:06 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1775922006; cv=none;\n d=google.com; s=arc-20240605;\n b=S6PG4dytTgTxS3Fi+1fgwPxceimmG2FbV669fKuG2Wr/VLUJnHx2VoguTHiZnSjcys\n vwmfDqubPixgzyUTwYMw/msZMP0OsfB3YZw0+70tiRFtMEEnPqVo1Ty/QO+wq4Ls1NsY\n bc9CnMapNm7Pttb/apr5a5ZCUjtHSuysBtvBs6bp7B0kCwkXrIaar3LhM2CbjkpG4sWw\n 4nowSmXe+ZBub3Ieed2kNmYobWu8uaPMuIP3C/u8ZuBPf/ngAJus9a9Q+7D9xQrDK/2U\n /kGAZ8QlLmKxEVNK0eIX8jLImcBLw/U6cRg7VZoNEzhpMb9ppztC0KJBktCCjWIXiCpS\n ntog==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=ACvPbFxuitcJYPNAzALjGMh3Zxop0O2RTIAODEWLe8c=;\n fh=pKV29h6PBf5SbuSFTM/GZF+KoVG4OaOclZXc+5Qi1tM=;\n b=ky3CbcqEjuRyKnf3osd2Y6/zv5eyLryB0XJnKmXgtrcDdjb/CrCQbe7GViVR+kevIz\n X4AP/zHuDCcJR26izMZfY57KuuIWHUtM+IkexgYkEvCLb3OXjZpgxaV2dEM23QwwKDKY\n SRx3fl3ltoFeb1vtwTfC/TQyjaWkcZyRJ+yjdkouZJysc8L0byLb9YXN0ij03gGqVzbm\n QmuBL74DfxWtnuxeM4yxVbNygBX6XXnoXdLNG9TXmE7YaneCydCt1I3r2BHkX3GKRVZY\n WLu/7FWKWDnEFpEvfWjTLypWtnoQ8MUBA23tneYPI1qopdPNYW0wp80MQVytZ13EgmfE\n aQUg==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1775922006; x=1776526806; darn=lists.denx.de;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ACvPbFxuitcJYPNAzALjGMh3Zxop0O2RTIAODEWLe8c=;\n b=GhZ6asZIRhrfDkx0JU5GfC0lg8li+efzmBfA4CUDwGsXuiMR4KiyfUoN3NzIh8MN8R\n +DUO6bgVBJWcgpVM4lMGypqbdbf9ea7Hnc+q5F7VSEMvNkFF42y8MOUjdhQWjn7DEABL\n K6+jR0QU7UyRlL8KAH+I9MNWwgvZbJnnKyCeg=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775922006; x=1776526806;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=ACvPbFxuitcJYPNAzALjGMh3Zxop0O2RTIAODEWLe8c=;\n b=Gn5fR2XZDPZylt+S09h35C/RZ9EsINpbe5AW6aYP56tqWS5SWfZ2UV1R1xPQhHTMj5\n h2jkK0JESfqVWb9c0Ew2VC2OebuGGf5Hxqiv3aOv8KdC5rDVG50S3eFHfasuJtRA+LIT\n W7Pgcx1FEMq6c7ET3ybPHx2HXc3Cw+kI9qk8CgmX+xopTgpL5TP4f0ia5yDnkzfPRULo\n Chf17FzAiPxZjQtHR9/mr+qS/s84Sv3c5hWaVNnMtdy02Xi7wKrA1kenGIHElSieGfaw\n uRbPPqJ3PP9Wup9sXf8RMXyuwrXAo+z2FAflu0a2dG2xhNONxpyLWcEHWdNbDEqRHmDE\n mi6Q==","X-Gm-Message-State":"AOJu0YxcS+6lrVTZX8UMfQ4OC3jR5RL74xK+u+NVr8eDraVJzMKZYKah\n vWzmy1mqYzYYSwHh2OC3iCkcq9QAxUXH4ry0UgiR2ay0e7ttyIDlMjU263aNMiSdt2gqi5aEz3f\n k8vAQC8hS0zzCA0H793c2PCukiDXOTi0XRA9GzuCX","X-Gm-Gg":"AeBDievHSdQ13Q9txid1JO675TpAEhuYB6qSGRg/nwrrcfXKTTI+eEgyQ6GPeRQEh0f\n OnXTzFggKULMbknSW0YehvY1FEwRvB6icu+wa4NNTemgMfXdcXvGQVilDaUfzXyGnw4L7so90a4\n Ht7ubXmZpap56IvW82F8an6NNiGx5VKBRezWA15XAIyna0fo/hbVETcO5fScoUmPsnHVtCmfjWW\n 18gqE0a+AoDwIXbDe++IMXvOUV2HPS8dT7t08pDtLpkotqZvfJJAWysDAcSnRLMkOcTysTw7vkJ\n UOAfSw==","X-Received":"by 2002:a17:907:1582:b0:b9c:3ba2:2dbd with SMTP id\n a640c23a62f3a-b9d727ac3cbmr297834066b.53.1775922005950; Sat, 11 Apr 2026\n 08:40:05 -0700 (PDT)","MIME-Version":"1.0","References":"<20260411-qcom_spl-v2-0-9609557cf562@seznam.cz>\n <20260411-qcom_spl-v2-3-9609557cf562@seznam.cz>","In-Reply-To":"<20260411-qcom_spl-v2-3-9609557cf562@seznam.cz>","From":"Simon Glass ","Date":"Sat, 11 Apr 2026 09:39:51 -0600","X-Gm-Features":"AQROBzBhIGaW2UvVjEX2S9vA0YJWO8oZYLEERigLHyFS1-VOlOAtsiVRL_dxqpw","Message-ID":"\n ","Subject":"Re: [PATCH v2 03/10] drivers: allow clk_stub and spmi in SPL","To":"michael.srba@seznam.cz","Cc":"u-boot@lists.denx.de, Sumit Garg ,\n u-boot-qcom@groups.io,\n Tom Rini ,\n Ilias Apalodimas ,\n Simon Glass , Sughosh Ganu ,\n Anshul Dalal ,\n Peng Fan , Mattijs Korpershoek ,\n Quentin Schulz ,\n Heinrich Schuchardt , Andrew Davis ,\n Hrushikesh Salunke ,\n Dario Binacchi ,\n Ye Li , Andre Przywara ,\n Alif Zakuan Yuslaimi ,\n Leo Yu-Chi Liang ,\n Andrew Goodbody , Dhruva Gole ,\n Kaustabh Chakraborty ,\n Jerome Forissier ,\n Heiko Schocher ,\n Marek Vasut ,\n Lukasz Majewski ,\n Mateusz Kulikowski ,\n Dinesh Maniyam ,\n Neil Armstrong ,\n Patrice Chotard ,\n Patrick Delaunay ,\n Michal Simek ,\n Yao Zi , Peter Korsgaard ,\n Rayagonda Kokatanur ,\n Casey Connolly ,\n Tingting Meng ,\n Tien Fong Chee , Alice Guo ,\n George Chan ,\n Balaji Selvanathan ,\n Alexey Charkov , Ronald Wahl ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-Mailman-Approved-At":"Sun, 12 Apr 2026 15:00:19 +0200","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]