[{"id":3676276,"web_url":"http://patchwork.ozlabs.org/comment/3676276/","msgid":"","list_archive_url":null,"date":"2026-04-11T15:40:16","subject":"Re: [PATCH v2 05/10] mach-snapdragon: add u-boot-spl-elf-sdm845.lds","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Michael,\n\nOn 2026-04-11T00:00:12, Michael Srba wrote:\n> mach-snapdragon: add u-boot-spl-elf-sdm845.lds\n>\n> This custom linker script is required to produce a bootable ELF\n> for the sdm845 SoC. An xbl_sec.elf must be provided, which will\n> be put in a section in the ELF as required by the boot rom.\n>\n> Signed-off-by: Michael Srba \n>\n> arch/arm/mach-snapdragon/u-boot-spl-elf-sdm845.lds | 25 ++++++++++++++++++++++\n> 1 file changed, 25 insertions(+)\n\n> diff --git a/arch/arm/mach-snapdragon/u-boot-spl-elf-sdm845.lds b/arch/arm/mach-snapdragon/u-boot-spl-elf-sdm845.lds\n> new file mode 100644\n> @@ -0,0 +1,25 @@\n> +TARGET(\"binary\")\n\nPlease can you add an SPDX licence header? Other linker scripts like\narch/arm/cpu/armv8/u-boot-spl.lds have one.\n\n> @@ -0,0 +1,25 @@\n> + xbl_sec PT_LOAD FLAGS(5 | (0x5 << 24));\n\nThe FLAGS(5 | (0x5 << 24)) magic number could use a comment explaining\nwhat the upper bits represent — presumably some Qualcomm-specific\nsegment flag?\n\n> @@ -0,0 +1,25 @@\n> + . = 0x0000000014699000;\n\nThis address appears specific to a particular XBL_SEC build (cf.\nXBL_SEC_DONOR_SCM_ADDR in patch 7). Please can you add a comment\ndocumenting where this comes from and whether it applies to all sdm845\ndevices?\n\nReviewed-by: Simon Glass \n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=G43Ze4bQ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"G43Ze4bQ\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftrJG3WlQz1y2d\n\tfor ; Sun, 12 Apr 2026 23:01:02 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 82E6F841E6;\n\tSun, 12 Apr 2026 15:00:23 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id C58D78416F; Sat, 11 Apr 2026 17:40:32 +0200 (CEST)","from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com\n [IPv6:2a00:1450:4864:20::62a])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id D66D480077\n for ; Sat, 11 Apr 2026 17:40:30 +0200 (CEST)","by mail-ej1-x62a.google.com with SMTP id\n a640c23a62f3a-b9b1ffbb9f5so429279766b.2\n for ; Sat, 11 Apr 2026 08:40:30 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1775922030; cv=none;\n d=google.com; s=arc-20240605;\n b=BNQ9gQIlwYsYXbooHbvDGinGWSgdd9K+W1fYrKBwgrqx1PXDm9tD0PvMqR9WxlN/au\n 8rfhvz2OS+z3a147Duxa7t5OkfrtVyOuLm/ZyhWzSgeSLJ6b9dPxTWVZvk4n1hSHxciK\n f294l1qnwlw1Fbv7HAUKPn29u6MAvi9eobpM0IVbSIjg+DQRxDGoqkYyhzk0huDx7hI/\n Sv0KOTz5VwFYcTtCT7Oj6TlcY1ZZWlc0cxCVq5pg56RrOudPzKEISqwMGsz1GIEcXItQ\n ReQ3pyGfFNfemrHPGjq+e1KF/Nq7eQVeGsInXzLchB0fuxRqw5CA51gzE4p9PBpiTnnC\n Rxcw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=0r42ofB0eMuhhT15xLRsqkFbyqh9OfuigWoGXdZR7Cw=;\n fh=pKV29h6PBf5SbuSFTM/GZF+KoVG4OaOclZXc+5Qi1tM=;\n b=Y2d/4Ysifc3p5iZJyE9W0T7sec/G9ABIBKrjMl7xS4H3HkzvpZtARJAmsPRblsREHI\n rQfbktisg5ia5pafURSkxXhepo2gYW31pF1zPOkiGcel+9iPJzxnCqTXfK/So0ZFFkgJ\n sVY/W2oK2dmSivoAy3F3lLEeKDbEiHlhMCCZRf5GBWeut+7TXJ0uqaZf+fLL2ZMIMVvT\n aQntO2vSldE9eCRR3wRsltREzUOcYfHJkpGCxP3W7vEckV7By6Fg+L9HyxP99PMUgzk5\n 1ZPnQTEak4i77pYmGmFOsFyHRIo89wy88LfcF+jggXGjf1t6lFhPn/kRCEfO363C/SII\n 7ieQ==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1775922030; x=1776526830; darn=lists.denx.de;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=0r42ofB0eMuhhT15xLRsqkFbyqh9OfuigWoGXdZR7Cw=;\n b=G43Ze4bQPnarRPdDS0oBQPtaLogaYvZXQZAxIIn/djkJ7gc9mjtUT/M2PzthLXdJtc\n jabG+uzVGXz3iFHUP6Z1x3Qovb2Cj4yrxS0pQLNi83NhM3Wd0O5kyU4huRqeBLJsQK5y\n VNN676dNVu3WXYFbdneGCkfPvxOQssCsH/26g=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775922030; x=1776526830;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=0r42ofB0eMuhhT15xLRsqkFbyqh9OfuigWoGXdZR7Cw=;\n b=hbkWeKGcGCRZ2Gba/Nt84xtXsyUFYyjlR9L0SmmqugBYevINbt43MnX/OiuW7FvlDA\n cjftQw43XuEL5cnyN38MFhGtKYnX3K0B9pk48l18GbFAeba6lVTaGXrmzicNUbop2dED\n cZ4+0UZ59JAayVsQZGjV/hTIfvQ8Es8JQA4uUGB8KuHweKHnw70z/UMGZvmeokcENWfU\n NCyQfZsjXPvkOLckaaA6pAEl45n2oe8mytGlGcLXX4SA/hCZ7fPbyO87Ahq5QeZ9iy3t\n LRxVEjKjOUJgs+7rFYet+oPVvIwM0ZghgLF6B2AbsKReKlT2B4PaVcz1vhcSZoAzwPjq\n gXxg==","X-Gm-Message-State":"AOJu0YyGNN72MNqXw7TSWRy636+uLFfWsMTUhIL6/+/JDG/YXI9NAOQc\n Nd+LVXaaJmc9Xq5oqlFs51kN0ZXBuJ+UJkg/aDrXL5eAK/EyzjkAauWqNI13HQpTXv125HJTIzY\n o28Sfbvi+Et8475j3WcfoKeKjVfBV2/XIOLIWdsqi","X-Gm-Gg":"AeBDieuyvj2U2VNRNEIHHby8y17Df8/RNgzjq4zzHKF0H+Uz5UAaBwQoAjI1Fm9z/HD\n MC97JsgWOYdV6Jw10fbuWl1dkcINn/MSa7vIso2QhkYNZmmC+qnUVPD7TmBdK9pvgh5nuleD43k\n TzRPT1iFsDkoI3mS5CiJJc80CDgcLR7R+SecWQE6f1h6kOZd05kNRb2aNIrirXmY+oVcHaUNkO6\n cGmLInsnjJvWDwVDhvxI/xNuM+Y3Rz189pct8CaOY962xLxS8cSI8C4Wli0o04oP9dxI6kU38Z1\n M0M2Es7NCeHf2PNh","X-Received":"by 2002:a17:907:1b11:b0:b9c:b8b5:2dad with SMTP id\n a640c23a62f3a-b9d72499671mr402394966b.8.1775922030135; Sat, 11 Apr 2026\n 08:40:30 -0700 (PDT)","MIME-Version":"1.0","References":"<20260411-qcom_spl-v2-0-9609557cf562@seznam.cz>\n <20260411-qcom_spl-v2-5-9609557cf562@seznam.cz>","In-Reply-To":"<20260411-qcom_spl-v2-5-9609557cf562@seznam.cz>","From":"Simon Glass ","Date":"Sat, 11 Apr 2026 09:40:16 -0600","X-Gm-Features":"AQROBzCwMNDuLQM22zSB1vh-mttZzaYejODb-57TOHnS5SJdPeuAiGvEnouWPX0","Message-ID":"\n ","Subject":"Re: [PATCH v2 05/10] mach-snapdragon: add u-boot-spl-elf-sdm845.lds","To":"michael.srba@seznam.cz","Cc":"u-boot@lists.denx.de, Sumit Garg ,\n u-boot-qcom@groups.io,\n Tom Rini ,\n Ilias Apalodimas ,\n Simon Glass , Sughosh Ganu ,\n Anshul Dalal ,\n Peng Fan , Mattijs Korpershoek ,\n Quentin Schulz ,\n Heinrich Schuchardt , Andrew Davis ,\n Hrushikesh Salunke ,\n Dario Binacchi ,\n Ye Li , Andre Przywara ,\n Alif Zakuan Yuslaimi ,\n Leo Yu-Chi Liang ,\n Andrew Goodbody , Dhruva Gole ,\n Kaustabh Chakraborty ,\n Jerome Forissier ,\n Heiko Schocher ,\n Marek Vasut ,\n Lukasz Majewski ,\n Mateusz Kulikowski ,\n Dinesh Maniyam ,\n Neil Armstrong ,\n Patrice Chotard ,\n Patrick Delaunay ,\n Michal Simek ,\n Yao Zi , Peter Korsgaard ,\n Rayagonda Kokatanur ,\n Casey Connolly ,\n Tingting Meng ,\n Tien Fong Chee , Alice Guo ,\n George Chan ,\n Balaji Selvanathan ,\n Alexey Charkov , Ronald Wahl ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-Mailman-Approved-At":"Sun, 12 Apr 2026 15:00:19 +0200","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]