[{"id":3676280,"web_url":"http://patchwork.ozlabs.org/comment/3676280/","msgid":"","list_archive_url":null,"date":"2026-04-11T20:30:37","subject":"Re: [PATCH v2 08/10] mach-snapdragon: add board-spl.c and split out\n common code","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Michael,\n\nOn 2026-04-11T00:00:12, Michael Srba wrote:\n> mach-snapdragon: add board-spl.c and split out common code\n>\n> Code in board.c will now only be compiled into U-Boot proper,\n> and the new board_spl.c will only be built into SPL.\n> Code in board_common.c is common to both phases.\n>\n> Also split out mem_map.c, which is currently common to both\n> phases since it seems to not cause issues in SPL. In the future\n> it should probably behave differenly in SPL, especially if dram\n> initialization is supported.\n>\n> Signed-off-by: Michael Srba \n>\n> arch/arm/mach-snapdragon/Makefile | 8 +\n> arch/arm/mach-snapdragon/board.c | 358 +-------------------------------\n> arch/arm/mach-snapdragon/board_common.c | 56 +++++\n> arch/arm/mach-snapdragon/board_spl.c | 35 ++++\n> arch/arm/mach-snapdragon/mem_map.c | 318 ++++++++++++++++++++++++++++\n> arch/arm/mach-snapdragon/qcom-priv.h | 4 +-\n> 6 files changed, 429 insertions(+), 350 deletions(-)\n\nThe commit subject says board-spl.c but should say board_spl.c\n\nReviewed-by: Simon Glass \n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=RR8O9dIg;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"RR8O9dIg\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftrK30S72z1y2d\n\tfor ; Sun, 12 Apr 2026 23:01:43 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 8A1FA84223;\n\tSun, 12 Apr 2026 15:00:29 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id DE9DE84181; Sat, 11 Apr 2026 22:30:53 +0200 (CEST)","from mail-ed1-x530.google.com (mail-ed1-x530.google.com\n [IPv6:2a00:1450:4864:20::530])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id B67F784118\n for ; Sat, 11 Apr 2026 22:30:51 +0200 (CEST)","by mail-ed1-x530.google.com with SMTP id\n 4fb4d7f45d1cf-66bb6eb28acso3044810a12.0\n for ; Sat, 11 Apr 2026 13:30:51 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1775939451; cv=none;\n d=google.com; s=arc-20240605;\n b=A33VuR+wa1EPA51UFFLl77VdM4nLCgb1+5TzSju+ZWXdewbhFGMGm9Mow7QNLicwbG\n 8/zC6ouK4mIgbaQJZj5HM4KbUxP7YS9MaENMeVqXDycS1Xp5NPqo0vaXiKYAYicGYeO9\n yWdhyYu4zMSMER8jIxqz4bZJirr7afPpVZoCAvVXpQjQFQgQwJ1nRsJkzS2s9ftYDnq7\n 4AihaY8NahHFX7cKbPW6ThOUFIERS6qLJBo/80ThfR9f1kXYK+8uzIJWi5/cpadVPH/J\n kxrW8qntYZ6jJ4RW6V+vCaHUFCF/3OD6cCWOfo1PjIzohPyz/4klxRxYn6/URsg77EQV\n R55w==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=5CCO/Izxk1WHhUY/5yHeJFc6NA6XouOKFnvJrQ2m4XY=;\n fh=pKV29h6PBf5SbuSFTM/GZF+KoVG4OaOclZXc+5Qi1tM=;\n b=PPL5+1vYy13Traf1Jbyq2v1DfVJT4k72u58Fd8nWwaog8t7O/3WgaEORNOaofxyrpJ\n luIuIpzQinfqYoqjaU2T0wSxHJTO/5xk58G2TrGCyVkqy1xcnsIZ++1u+btAC1AaWXGC\n zyc2NIHVl7HYZMHLPkjLDMMHuMTFrzSVKMT1OB1u00+/aNTxDgpWtGBKamxB43fnkPyn\n UMKLx+w689z7MLJRhcL+Iu9UUuH6FJ+jNDprWzObJiu7MvhDO5sc1gBHuV4METF9o9Wh\n zSaNVor5Up9ZQQbcU7rDrmgsQY7ZFnZVX3xODrtlHd12t88yHfHmbWFTEFQois5IKPVL\n x6yQ==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1775939451; x=1776544251; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=5CCO/Izxk1WHhUY/5yHeJFc6NA6XouOKFnvJrQ2m4XY=;\n b=RR8O9dIg7HU7Ka2t1ntwqnMlm9O8ZsIe70Ln+huRZerzF9aafQ0ELdjRvs3ipnwyb7\n 4j6IMeYbsKX2prqa8OXU3Ond65C/RNAV38NoogbSS2B8KakQiD+d45bteXcDNJdJa7on\n ERBbv+WP0XHecdSSpBCLKqjjr8LRtr/Pj5sBo=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775939451; x=1776544251;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=5CCO/Izxk1WHhUY/5yHeJFc6NA6XouOKFnvJrQ2m4XY=;\n b=l5QgaxRJ2at8VwLfNZZQHexM1XdaMgzO800d0eWwtY7rFqHDmchtkpVIGhvUmk9AFu\n yFyWEUAKrZD2j2xdMGwBxsjob3PQwW9jLgCCCtR1Fvbp6pWKLsxa+ZXPZbG5U4ObLBbI\n bTCqRyOo/MqFI4Ns1SSWm36k1YAs52zySRA/fpb+kIMzvAYgn487hVLlwNgBjtvwMkLV\n tfP/K7fK+Uo2GD8RoWBrcf9qz+rdu/qU2KjmoqE/YKcFBMmnUrDYQNtWp9dQlSa5ayoX\n sF01slUfOZKqGk39tGl3YYv0/zlhelVwNAggdg4k30bfurREIO04CX6NIpmOvE7ufnh2\n jFoA==","X-Gm-Message-State":"AOJu0YwuTrvP71e6irZMHcPkePnuqRkByj1OC9rUjAmom/7oT99A+fw/\n Nt5k+MmqASttZQeiWF0XfPpMADxg37es/XjouCVG61r0vqYX32TFC6kaQaQwPIpFvXO6iufYVe/\n 1BwAvOurYDHNnO/pe4Xko9xY0AGy5hp5yZE+abUoe","X-Gm-Gg":"AeBDievkY5xHUcocbg2Po9kC8lyECXq72d+YusZ9qC9xfXvDLyPGfJrir0obKbm73rL\n hnacuP2FEUVmS9iSuYArQJGeKynCwnkA+GltIfWGS5MLu9cMFUd7iEqxmL63xNgyflqJ6MDtKLU\n YEkvLEeRLaVqZ02Gmo0cbQZwjovxNHFTgnFt1tzKDpR8zabQgFayMIJDiwBuXH6gMRfqox/1Vih\n Eu8YwM4SvB0jq2r76THlN1PzrlP8/tMUAhE2je/A3ThU9k3Q0f0nPKULZLjpUiucB4no4MUT3CT\n Xztu+A==","X-Received":"by 2002:a17:907:a46:b0:b9c:513e:34db with SMTP id\n a640c23a62f3a-b9d72635a40mr493501766b.23.1775939451048; Sat, 11 Apr 2026\n 13:30:51 -0700 (PDT)","MIME-Version":"1.0","References":"<20260411-qcom_spl-v2-0-9609557cf562@seznam.cz>\n <20260411-qcom_spl-v2-8-9609557cf562@seznam.cz>","In-Reply-To":"<20260411-qcom_spl-v2-8-9609557cf562@seznam.cz>","From":"Simon Glass ","Date":"Sat, 11 Apr 2026 14:30:37 -0600","X-Gm-Features":"AQROBzBtIpUs5eEPkuYZ59-Pt2KA8F5CT9gzWEmJbylSbP-MGHJNNfQfbBywcZA","Message-ID":"\n ","Subject":"Re: [PATCH v2 08/10] mach-snapdragon: add board-spl.c and split out\n common code","To":"michael.srba@seznam.cz","Cc":"u-boot@lists.denx.de, Sumit Garg ,\n u-boot-qcom@groups.io,\n Tom Rini ,\n Ilias Apalodimas ,\n Simon Glass , Sughosh Ganu ,\n Anshul Dalal ,\n Peng Fan , Mattijs Korpershoek ,\n Quentin Schulz ,\n Heinrich Schuchardt , Andrew Davis ,\n Hrushikesh Salunke ,\n Dario Binacchi ,\n Ye Li , Andre Przywara ,\n Alif Zakuan Yuslaimi ,\n Leo Yu-Chi Liang ,\n Andrew Goodbody , Dhruva Gole ,\n Kaustabh Chakraborty ,\n Jerome Forissier ,\n Heiko Schocher ,\n Marek Vasut ,\n Lukasz Majewski ,\n Mateusz Kulikowski ,\n Dinesh Maniyam ,\n Neil Armstrong ,\n Patrice Chotard ,\n Patrick Delaunay ,\n Michal Simek ,\n Yao Zi , Peter Korsgaard ,\n Rayagonda Kokatanur ,\n Casey Connolly ,\n Tingting Meng ,\n Tien Fong Chee , Alice Guo ,\n George Chan ,\n Balaji Selvanathan ,\n Alexey Charkov , Ronald Wahl ","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailman-Approved-At":"Sun, 12 Apr 2026 15:00:19 +0200","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]