[{"id":3676278,"web_url":"http://patchwork.ozlabs.org/comment/3676278/","msgid":"","list_archive_url":null,"date":"2026-04-11T15:40:42","subject":"Re: [PATCH v2 07/10] mach-snapdragon: boot0.h: add sdm845_spl_boot0.h","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Michael,\n\nOn 2026-04-11T00:00:12, Michael Srba wrote:\n> mach-snapdragon: boot0.h: add sdm845_spl_boot0.h\n>\n> On sdm845, running u-boot SPL in EL3 requires escalting by using\n> an unintentional feature in old builds of xbl_sec.elf. We do this\n> in boot0.h so the rest of U-Boot can stay blissfully unaware\n> of XBL_SEC. If we are already in EL3 for whatever reason, the\n> code is skipped.\n>\n> Signed-off-by: Michael Srba \n>\n> arch/arm/mach-snapdragon/include/mach/boot0.h | 4 +\n> .../include/mach/sdm845_spl_boot0.h | 120 +++++++++++++++++++++\n> 2 files changed, 124 insertions(+)\n\n> diff --git a/arch/arm/mach-snapdragon/include/mach/sdm845_spl_boot0.h b/arch/arm/mach-snapdragon/include/mach/sdm845_spl_boot0.h\n> @@ -0,0 +1,120 @@\n> +.macro movl Wn, imm\n> + movz \\Xn, \\imm & 0xFFFF\n> + movk \\Xn, (\\imm >> 16) & 0xFFFF, lsl 16\n> +.endm\n\nThe macro parameter is named Wn but the body references \\Xn - does\nthis actually build?\n\n> @@ -0,0 +1,120 @@\n> +.macro movq Xn, imm\n> + movz \\Xn, \\imm & 0xFFFF\n\nSimilar issue to above - also please use tabs to indent.\n\n> @@ -0,0 +1,120 @@\n> +el3_payload:\n> + /* disable the mmu for EL3 too */\n> + mrs x0, sctlr_el3\n> + and x0, x0, #~(1 << 0) // CTRL_M\n> + msr sctlr_el3, x0\n> +\n> + /* jump back to our code, but now in EL3 */\n> + movl x0, CONFIG_SPL_TEXT_BASE\n> + add x0, x0, (el3_ret_point - _start)\n> + br x0\n> +el3_payload_end:\n\nAfter disabling the MMU in EL3 shouldn't you have an ISB before the branch?\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=VtpfFFVP;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"VtpfFFVP\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftrJf4gwVz1y2d\n\tfor ; Sun, 12 Apr 2026 23:01:22 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id B0AA384207;\n\tSun, 12 Apr 2026 15:00:26 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 69AC08416F; Sat, 11 Apr 2026 17:40:57 +0200 (CEST)","from mail-ej1-x632.google.com (mail-ej1-x632.google.com\n [IPv6:2a00:1450:4864:20::632])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 7ADC780077\n for ; Sat, 11 Apr 2026 17:40:55 +0200 (CEST)","by mail-ej1-x632.google.com with SMTP id\n a640c23a62f3a-b941762394aso362175966b.1\n for ; Sat, 11 Apr 2026 08:40:55 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1775922055; cv=none;\n d=google.com; s=arc-20240605;\n b=DAvaSQMdUcu7g6k8w3/d/0anXC/TjN2u/eGJM0WWKlWkPMOm8Up1278TH2LXTDG1Cd\n P4Z6aoEl+PtEV//IWUZygsZH/nk3RnFgBIgFuPeNS60TCzr0EB9olsZ56q6j0l+OhFmy\n BiDyhg7hMBftRjDIod9TgYdozbh/38bsG1a4vu2XBQaYTtiOMEcsy3II3hoLcXpUG6nf\n MFVwfoETsd/o/Q5nHQLnNPgtkSYjrBYniU442xqqeV7LmOUSIO8xHQooNK2lZNJ9eTGQ\n E9qBXr3ftbmfLi+mBf9En8lWJ5DvOczBrOj74rL2U0a3gXgnWi6VSJ8g8EATfwrvFHAH\n ahGw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=gE+AvNUcfLRVvm7tg2N+YgmxqiOZOg/Iqlzom4tjc+U=;\n fh=pKV29h6PBf5SbuSFTM/GZF+KoVG4OaOclZXc+5Qi1tM=;\n b=cnCXi5rklWarNPRhBFQWWgFlvZF8MppR5sNeNm7UaBd/IQaQ0cd8mkBwUDhJz+HaNt\n v/wBJ+G4P5k2NDMtSAo0zKlUlCC88QSgCS8xztBVYWvUPn47OayLSE5zW6cAHA7SArjn\n uCWdV0gsYkSYvQOwx+d+0hQVeSZ9l2qZMCeNvEtLVaoFDfSo0VzGRP/yxIhXqLHfcXys\n iAWFcNsl//TYibvsPezkzmfXVVtbkdTKIDnCkyx9KP5eLStXo+2PBW+lfc79NSlKf212\n mnSgT3c9AwOEzfyObcbByU4Pz5cPKPdnDlXpewTXKOLj62K5ZG8RXS8LjdAPXR7eg1hq\n xeMw==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1775922055; x=1776526855; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=gE+AvNUcfLRVvm7tg2N+YgmxqiOZOg/Iqlzom4tjc+U=;\n b=VtpfFFVPDh0BIKjL3dXTG9PxVFRQ+QQiR6Yvt6N8ZudHxpvLaoCPY7a4e9YbG4twRV\n 0pzKAuUh1Pcpcdho/X2QXXhSby6NFfI2axehDFEk3iaqlNr9ygdVoIlVBshOfEBh/pw1\n Xmur2gkY1Yl7RgjFLuVmXT9hnZSjcEdijHiFQ=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775922055; x=1776526855;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=gE+AvNUcfLRVvm7tg2N+YgmxqiOZOg/Iqlzom4tjc+U=;\n b=rP/fZFwA0snPiiHaJrVpZuEn0FuOiCKkSBYXanWNK8RC9J+VJlePJk76lyn5QK6AaE\n 4O2witRee5mutyGUZS78w+qnAcieS43ZheZCvOycYOD1sCPoGfDniO4FqX0jwbaS1vX8\n BDD8zRxNJOn1QgjpLD7nXutFjz1TlHr+McuPVW6uaNr4NtxN1i46w2f+JBjNDBckQRpd\n 6834fsUJ5Tvrs4Y76P0DahBonAaSgAXfsVL3ORHo/PaKmPLlN+V3CT2sU93OTFrLXid+\n 5gLhXtYn9S5+EHA0kOV4eL0K2oz6Vwjz5sON0KAYgnrxmyb2Z9lvORsk/s2/psWy4cLx\n HtSg==","X-Gm-Message-State":"AOJu0Yy5qG6hNC7M8XxWhAuBx0EvqRDe5ArdBYMj/j/plFhVRx24BN7O\n VDvhyesxSy6wZd97QJyk1AURAt4In6/qVmmhvKKDny4qAOZAIh26z9A36f/qNk1ZEUL6sLqOnW5\n SboSCHb3lSLaAzW/nzyQRbEh426mKu8Oz3nzdZXsn","X-Gm-Gg":"AeBDiesR7IUcv4Dg+FZsH9NlDK0KU0ceKIpiyF7wWkL5yiHYImU5ZCsw1NMrRqJitgS\n nXUbuul166cpd4bdsdXJIPkJPXTrPuk+5Y2YSsD3T0pT48UlWsnfbm3D0jLDi/tbP/FT2ji/Tu5\n rGyKTCu4+pfxw0tLgD7YvnVca00/lzo5F5ofmdGlVtLQpi19PEMfdDZ25uAth3+J/Ifc6Djezp1\n 8v/tsQ5wOVjfiQ81Df0istE4jpBjm0h5o1AjA/jwTE3karZLwpEW/MOaexSAhB/PE3hbtBDRb05\n 3k4YJA==","X-Received":"by 2002:a17:907:d0d:b0:b9c:f69:598c with SMTP id\n a640c23a62f3a-b9d725ebe50mr416442366b.22.1775922054813; Sat, 11 Apr 2026\n 08:40:54 -0700 (PDT)","MIME-Version":"1.0","References":"<20260411-qcom_spl-v2-0-9609557cf562@seznam.cz>\n <20260411-qcom_spl-v2-7-9609557cf562@seznam.cz>","In-Reply-To":"<20260411-qcom_spl-v2-7-9609557cf562@seznam.cz>","From":"Simon Glass ","Date":"Sat, 11 Apr 2026 09:40:42 -0600","X-Gm-Features":"AQROBzAE1a4BMy9hrQBeMCD3Yz7xVgAZzLrlknIg5n-oX-ZKOizWn8LZYEH9iso","Message-ID":"\n ","Subject":"Re: [PATCH v2 07/10] mach-snapdragon: boot0.h: add sdm845_spl_boot0.h","To":"michael.srba@seznam.cz","Cc":"u-boot@lists.denx.de, Sumit Garg ,\n u-boot-qcom@groups.io,\n Tom Rini ,\n Ilias Apalodimas ,\n Simon Glass , Sughosh Ganu ,\n Anshul Dalal ,\n Peng Fan , Mattijs Korpershoek ,\n Quentin Schulz ,\n Heinrich Schuchardt , Andrew Davis ,\n Hrushikesh Salunke ,\n Dario Binacchi ,\n Ye Li , Andre Przywara ,\n Alif Zakuan Yuslaimi ,\n Leo Yu-Chi Liang ,\n Andrew Goodbody , Dhruva Gole ,\n Kaustabh Chakraborty ,\n Jerome Forissier ,\n Heiko Schocher ,\n Marek Vasut ,\n Lukasz Majewski ,\n Mateusz Kulikowski ,\n Dinesh Maniyam ,\n Neil Armstrong ,\n Patrice Chotard ,\n Patrick Delaunay ,\n Michal Simek ,\n Yao Zi , Peter Korsgaard ,\n Rayagonda Kokatanur ,\n Casey Connolly ,\n Tingting Meng ,\n Tien Fong Chee , Alice Guo ,\n George Chan ,\n Balaji Selvanathan ,\n Alexey Charkov , Ronald Wahl ","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailman-Approved-At":"Sun, 12 Apr 2026 15:00:19 +0200","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]