[{"id":3676360,"web_url":"http://patchwork.ozlabs.org/comment/3676360/","msgid":"<1853d555-808b-4816-aff3-216008359fd1@linaro.org>","list_archive_url":null,"date":"2026-04-12T18:34:52","subject":"Re: [PATCH 6/9] target/mips: add Octeon SHA3 crypto support","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 11/4/26 09:06, James Hilliard wrote:\n> Add the Octeon SHA3 register window and STARTOP selector.\n> \n> Model the dedicated 25-lane Keccak state and the Keccak-f[1600]\n> permutation so the COP2 SHA3 interface follows the hardware behaviour.\n> \n> Signed-off-by: James Hilliard \n> ---\n> target/mips/cpu.h | 22 +++++\n> target/mips/tcg/octeon_crypto.c | 155 ++++++++++++++++++++++++++++++++\n> target/mips/tcg/translate.c | 30 +++++++\n> 3 files changed, 207 insertions(+)\n\n\n> +static int octeon_sha3_dat_pos_from_sel(uint32_t sel)\n> +{\n> + if (sel >= OCTEON_COP2_SEL_HSH_DATW0 &&\n> + sel <= OCTEON_COP2_SEL_HSH_DATW14) {\n> + return sel - OCTEON_COP2_SEL_HSH_DATW0;\n> + }\n> + if (sel >= OCTEON_COP2_SEL_HSH_IVW0 &&\n> + sel <= OCTEON_COP2_SEL_HSH_IVW7) {\n> + return 16 + (sel - OCTEON_COP2_SEL_HSH_IVW0);\n> + }\n> +\n> + switch (sel) {\n\n case OCTEON_COP2_SEL_HSH_DATW0 ... OCTEON_COP2_SEL_HSH_DATW14:\n return sel - OCTEON_COP2_SEL_HSH_DATW0;\n case OCTEON_COP2_SEL_HSH_IVW0 ... OCTEON_COP2_SEL_HSH_IVW7:\n return 16 + (sel - OCTEON_COP2_SEL_HSH_IVW0);\n\n> + /*\n> + * SHA3_DAT15_READ aliases HSH_DATW15 at 0x024f, so a single case covers\n> + * both selector names.\n> + */\n> + case OCTEON_COP2_SEL_HSH_DATW15:\n> + case OCTEON_COP2_SEL_SHA3_DAT15_WRITE:\n> + return 15;\n> + case OCTEON_COP2_SEL_SHA3_DAT24:\n> + return 24;\n> + default:\n> + return -1;\n\n g_assert_not_reached();\n\n> + }\n> +}\nOtherwise patch LGTM.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=dTNV6ZfX;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftzkd0kFYz1xtJ\n\tfor ; Mon, 13 Apr 2026 04:35:51 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBze7-0001sj-Bv; Sun, 12 Apr 2026 14:34:59 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wBze5-0001sT-Ki\n for qemu-devel@nongnu.org; Sun, 12 Apr 2026 14:34:57 -0400","from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wBze4-0002oA-5f\n for qemu-devel@nongnu.org; Sun, 12 Apr 2026 14:34:57 -0400","by mail-wr1-x42e.google.com with SMTP id\n ffacd0b85a97d-43cfe71e5d3so2620430f8f.0\n for ; Sun, 12 Apr 2026 11:34:55 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d63dec295sm26182583f8f.14.2026.04.12.11.34.52\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Sun, 12 Apr 2026 11:34:53 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776018894; x=1776623694; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=4/nkn2EuheRh+RrQCq6mwDj18bK3dXhRRdqFxgobBZg=;\n b=dTNV6ZfXdn/K7qHoPaZmzIDzfxNkZP6N4vT+BkHuieLg3mHkiwTGfCpueOPVcMUfZ5\n 1T7Z4lHdN9FaEZC/nEdHLopcJQvGW3dx7b/wYFUbd/aHZLyO3jpR+XjhNzRk5vo9P6ea\n DTslt2sgTRBE662FBXryBTc0gv9BbzL7rtJ7TGR2gJS2LomMXLL7TTziQJ1dEF6HeCai\n bw+WBWYVkgh93yB9m2B+eD6+FgNUWdoGlwIHkAKH8/Gju5+/k5xjfkTMLyo3P5ajic9T\n dHpgqoX16yhF/XFHqf5RrxZPAUPcJOMQftVz47V6Ir3LdBFUOnboiwFa0KquLOj5k9Im\n Kxjg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776018894; x=1776623694;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=4/nkn2EuheRh+RrQCq6mwDj18bK3dXhRRdqFxgobBZg=;\n b=d93ES6wGEX1TuYoJd2hpN5NVwe22yZeFnkXr9k9CVuJUh49qJusfGB5zrjLXCocD6p\n YWwZYJEODzjNPsWG91r22qX7ekpFnfEmBh9oINyZZrRIja/vUdZ8yx/jYmKK1A7G8c20\n e3Yp8n7+qYJ5QuUhu1QUR/0dAvg28J2JX5KQ3UOhBh3a6IQ3rLRY6vc8EjUxQiILsMBL\n zjLRVGDJy6Use9ktTH40ZvgM4zNGq+xCKyluPfG/bCjOxETtO5GjR+jn7ZKGZy+3SnBt\n H4IpCTIDBZGO5AMQPNNP2SVTFZt7+gc4TbYGAqEgbgPV0096LjnO39t8VqxeLDKI9IQ7\n Gpyg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/i1e//7dmDFiJEKeVyNX3Cs3q6MCaIbm2/fZBwnsJQSw4tQ4PUswIUS0j54G1gKXxlWXOwN2OuEp8S@nongnu.org","X-Gm-Message-State":"AOJu0Yy/EmzNiiYZhISyCjm4p0IzyrTPwQCtwFvfFH6VfJHaFwQD6XIJ\n 8gu2WDgaLCY8gEAT1iavPFxKkUVTAf37JD0E36ehKkQWK0E8fPEQRdbaE+iMx/+VaFE=","X-Gm-Gg":"AeBDieuloqtNYAtDIdXw5ndgIHpe81e85ClRc2mMuKOKB44HnneruvGujvjUNlPlLWP\n HXcjY8NhbDRh+rGfJ7iVSRkJukXBNbSgYWT/Mbf4LUwbF8U7652HrL3JXk5CV/7EdKdWqM2L66q\n /q1F/U4r3CzpbyGx53GYPvIbVO/TTYiLDyvr/7hfB6V2vqV9sH6q6WZKtIhEa7woirSMZlYI2au\n EwD8Dk3zsHHe3Sb8mppqRUJq8i79WTYPjCr6olZMb9RVhkTN7yG8MdlZPclhTyPBQdfHCOKEaXQ\n XOhLrXHgtytGX3whcVBfvSrHj1hRB66rGLNV7NmaI4CRGfTOTw91zLHzRiT0PkKcctzEHb6bFzJ\n bb5mlCqbT3q+FIrq4vJLDRmJeczVnf6HEifQUkxy9J+Xi5aBmShpwqUVDWcLdcTpGNwWvEdcYUS\n YlmhDh4jkWominhGPcGS3ahkPFCvmPjofbrL3wMGM7xkAPQAOvFIGWbdSEQvqfp8pESw==","X-Received":"by 2002:a05:6000:240f:b0:43d:77f4:714e with SMTP id\n ffacd0b85a97d-43d77f4749fmr1955689f8f.48.1776018893979;\n Sun, 12 Apr 2026 11:34:53 -0700 (PDT)","Message-ID":"<1853d555-808b-4816-aff3-216008359fd1@linaro.org>","Date":"Sun, 12 Apr 2026 20:34:52 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 6/9] target/mips: add Octeon SHA3 crypto support","Content-Language":"en-US","To":"James Hilliard , qemu-devel@nongnu.org","Cc":"Laurent Vivier ,\n Pierrick Bouvier ,\n Aurelien Jarno , Jiaxun Yang\n , Aleksandar Rikalo ,\n Huacai Chen ","References":"<20260411070637.72421-1-james.hilliard1@gmail.com>\n <20260411070637.72421-6-james.hilliard1@gmail.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260411070637.72421-6-james.hilliard1@gmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::42e;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x42e.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]