[{"id":3676359,"web_url":"http://patchwork.ozlabs.org/comment/3676359/","msgid":"<8ba10582-c041-4ed7-a077-8d524837a1ab@linaro.org>","list_archive_url":null,"date":"2026-04-12T18:27:33","subject":"Re: [PATCH 5/9] target/mips: add Octeon SMS4 crypto support","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 11/4/26 09:06, James Hilliard wrote:\n> On Octeon, the SMS4 engine is exposed through selectors that alias the\n> AES register bank. Add the missing selectors and model the shared\n> RESULT, IV, and key state so the hardware interface matches the\n> processor behaviour.\n> \n> Use the in-tree SM4 tables to implement the block operation without\n> adding a host crypto dependency.\n> \n> Signed-off-by: James Hilliard \n> ---\n> target/mips/cpu.h | 18 +++++\n> target/mips/tcg/octeon_crypto.c | 114 ++++++++++++++++++++++++++++++++\n> target/mips/tcg/translate.c | 8 +++\n> 3 files changed, 140 insertions(+)\n\nTests welcome, otherwise patch LGTM.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=IAFyB7rg;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftzYl73t3z1yCx\n\tfor ; Mon, 13 Apr 2026 04:28:10 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBzX2-0000iT-Bo; Sun, 12 Apr 2026 14:27:40 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wBzX0-0000i9-K4\n for qemu-devel@nongnu.org; Sun, 12 Apr 2026 14:27:39 -0400","from mail-wm1-x330.google.com ([2a00:1450:4864:20::330])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wBzWz-00012H-50\n for qemu-devel@nongnu.org; Sun, 12 Apr 2026 14:27:38 -0400","by mail-wm1-x330.google.com with SMTP id\n 5b1f17b1804b1-488ba6366a7so46228005e9.0\n for ; Sun, 12 Apr 2026 11:27:36 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488d5396293sm223575825e9.15.2026.04.12.11.27.33\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Sun, 12 Apr 2026 11:27:34 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776018455; x=1776623255; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=5Gy6uAiK7aQcX3R9bMX2lARw4Fnyee7kyt6fQhTNNVU=;\n b=IAFyB7rg2o4yH9S1TBs+Q4xXXCqd80ieVR5573KNcuzWnOONBrboN4HTjwFWeagTRK\n cLLY/PuemBiRDBfRyT6/Je12i05osQBBZxUy1vFOSIClPBJVJLWYjdElkHMbp1+DAj9D\n JuTr8yG/lhrKuqrXjPo4KnJL7HZXfqNLYKLR0xqOEhxy8VjlkPjffbDJormX+6GWynY2\n B0gKir4CgFq3hEyW7RyYcAz7wo/M+y42spUe6fRxqmnkdAsnl7AZXIVV+dAKyuTop0YN\n 32dKbMUWFuwyn42+I1vAR07I685XJde81r6Xa/X/pDynCtiTsF/8TBC7W72q14EWbsNg\n iGoQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776018455; x=1776623255;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=5Gy6uAiK7aQcX3R9bMX2lARw4Fnyee7kyt6fQhTNNVU=;\n b=h5qHamE+RHwBDGxK0yMYVc3wJXVfwM8zdELffICCOF8+/YePXXagZ4bd8mDtDQpVH+\n mtU1RzAzTX7123H+csjTyXlvkVuE7mqvDlkA38Wsgfva8y+hLAkkpyEvuHRu148RQIUb\n uYzjhqv3AxJogxG6016qFok7XF9ozO/CLSx3wzTkCUSXvfwWH2NbWH/QVmJ6Sfzdq9B5\n YEdioOc35YgzaqgsxMI0+cY0s3TDCPv1buoqNMxdLObzl4ziqXnLKiFfEvqOIGQbZPWR\n YCIm0OgSos7U3Om2WGmMbm4ZosjUyi9B9cU4BOghNAsGi/2yOxBj0JkgqLxKbGV9Qc7e\n 2lsw==","X-Forwarded-Encrypted":"i=1;\n AJvYcCVUz0cSem9uIL72XxFLa73OFAhsUelAldK51F5CCkzK2g9eBoiIP7wYSWA1c2/I8OybrVSjho1TI/9d@nongnu.org","X-Gm-Message-State":"AOJu0YygkkbgtpjJJz+BQFd1NyrRTIdajsWm/EL2VNKOTuNxn4na4KDC\n AItS3KZxR0U1OuqDAGH+16t4HBUmPBV7E9q12KBRH7xSGggeSXPuYwqFerWK8feLPvU=","X-Gm-Gg":"AeBDieuYNYCgmcyGjHaIaCnietjYt5A943DOsMdLkILbfu++5kLpzEoXtrSI8HN9fkU\n gkk2kxSTq/wEM+sDWZXx+HBHdubHKsIwmgVlx3O6lmo4oLn7YwPvg9GwYVUhazGVvSqKUe+z8bF\n ffqOobFHUTC1HTVNxhi49qo8K7vAiLe43w8B7UFTUZtycNFtTFOC3B9UKM/3MQDe26ae2qJZHCc\n HO21Js8j0himFaBpW597xarpKSY8k5NiITwnTyZuCJu+gWLNmmY9hJp3/U2iWJkDX339TWIfWf5\n yMtFDwaMKHjNL5n3dJN/TlzyKuXQal1XA5uRXAV23x4fApLIy0WzmshHWobLevzmUn+2FWY3Kq0\n UZj9ukW/jM2wmRAiZPBFlpNzFYR1RAm9YkMfvevhtfcUSqeNTebBkfA5trHVL/8QmlexrJR+5jK\n fVdALBixdJDpCDyPcy8/LOK08EJ6760MNKPzOzCkrV364LUznku6EBw2lxBdsX9PT5T53NuuF71\n V8Y","X-Received":"by 2002:a05:600c:5298:b0:488:c014:34da with SMTP id\n 5b1f17b1804b1-488d688687cmr153273445e9.26.1776018455025;\n Sun, 12 Apr 2026 11:27:35 -0700 (PDT)","Message-ID":"<8ba10582-c041-4ed7-a077-8d524837a1ab@linaro.org>","Date":"Sun, 12 Apr 2026 20:27:33 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 5/9] target/mips: add Octeon SMS4 crypto support","Content-Language":"en-US","To":"James Hilliard , qemu-devel@nongnu.org","Cc":"Laurent Vivier ,\n Pierrick Bouvier ,\n Aurelien Jarno , Jiaxun Yang\n , Aleksandar Rikalo ,\n Huacai Chen ","References":"<20260411070637.72421-1-james.hilliard1@gmail.com>\n <20260411070637.72421-5-james.hilliard1@gmail.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260411070637.72421-5-james.hilliard1@gmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::330;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x330.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]