[{"id":3676362,"web_url":"http://patchwork.ozlabs.org/comment/3676362/","msgid":"<8cac2df2-7718-412a-8a58-2f49eac78dba@linaro.org>","list_archive_url":null,"date":"2026-04-12T18:37:26","subject":"Re: [PATCH 7/9] target/mips: add Octeon ZUC crypto support","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 11/4/26 09:06, James Hilliard wrote:\n> Add the Octeon ZUC START and MORE selectors and model the shared state\n> window used by the hardware interface.\n> \n> This covers the keystream and MAC engine state, including the\n> save-and-restore view that overlaps the HSH/SHA3 bank.\n> \n> Signed-off-by: James Hilliard \n> ---\n> target/mips/cpu.h | 7 +\n> target/mips/tcg/octeon_crypto.c | 323 ++++++++++++++++++++++++++++++++\n> target/mips/tcg/translate.c | 2 +\n> 3 files changed, 332 insertions(+)\n\n\n> @@ -1487,6 +1732,38 @@ target_ulong helper_octeon_cop2_dmfc2(CPUMIPSState *env, uint32_t sel)\n> MIPSOcteonCryptoState *crypto = &env->octeon_crypto;\n> int sha3_pos;\n> \n> + if (crypto->shared_mode == OCTEON_SHARED_MODE_ZUC) {\n> + if (sel >= OCTEON_COP2_SEL_HSH_DATW0 &&\n> + sel <= OCTEON_COP2_SEL_HSH_DATW7) {\n> + unsigned int idx = sel - OCTEON_COP2_SEL_HSH_DATW0;\n> +\n> + return octeon_zuc_pack_pair(crypto->zuc_lfsr[idx * 2],\n> + crypto->zuc_lfsr[idx * 2 + 1]);\n> + }\n> + switch (sel) {\n> + case OCTEON_COP2_SEL_HSH_DATW8:\n> + return octeon_zuc_pack_pair(crypto->zuc_fsm[0], crypto->zuc_fsm[1]);\n> + case OCTEON_COP2_SEL_HSH_DATW9:\n> + case OCTEON_COP2_SEL_HSH_IVW0:\n> + return octeon_zuc_pack_pair(crypto->zuc_window[0],\n> + crypto->zuc_window[1]);\n> + case OCTEON_COP2_SEL_HSH_DATW10:\n> + return crypto->zuc_window[2];\n> + case OCTEON_COP2_SEL_HSH_DATW11:\n> + case OCTEON_COP2_SEL_HSH_IVW3:\n> + return crypto->zuc_tresult;\n> + case OCTEON_COP2_SEL_SHA3_DAT15_READ:\n> + case OCTEON_COP2_SEL_SHA3_DAT24:\n> + return 0;\n> + case OCTEON_COP2_SEL_HSH_IVW1:\n> + return crypto->zuc_fsm[0];\n> + case OCTEON_COP2_SEL_HSH_IVW2:\n> + return crypto->zuc_fsm[1];\n> + default:\n> + break;\n\n g_assert_not_reached();\n\n> + }\n> + }\n> +\n> if (crypto->shared_mode == OCTEON_SHARED_MODE_SNOW3G) {\n> if (sel >= OCTEON_COP2_SEL_SNOW3G_LFSR0 &&\n> sel <= OCTEON_COP2_SEL_SNOW3G_LFSR7) {\n> @@ -1606,6 +1883,46 @@ void helper_octeon_cop2_dmtc2(CPUMIPSState *env, target_ulong value,\n> uint64_t q = (uint64_t)value;\n> int sha3_pos;\n> \n> + if (crypto->shared_mode == OCTEON_SHARED_MODE_ZUC) {\n> + if (sel >= OCTEON_COP2_SEL_HSH_DATW0 &&\n> + sel <= OCTEON_COP2_SEL_HSH_DATW7) {\n> + unsigned int idx = sel - OCTEON_COP2_SEL_HSH_DATW0;\n> +\n> + crypto->zuc_lfsr[idx * 2] = (q >> 32) & 0x7fffffffU;\n> + crypto->zuc_lfsr[idx * 2 + 1] = q & 0x7fffffffU;\n> + return;\n> + }\n> + switch (sel) {\n> + case OCTEON_COP2_SEL_HSH_DATW8:\n> + crypto->zuc_fsm[0] = q >> 32;\n> + crypto->zuc_fsm[1] = q;\n> + return;\n> + case OCTEON_COP2_SEL_HSH_DATW9:\n> + case OCTEON_COP2_SEL_HSH_IVW0:\n> + crypto->zuc_window[0] = q >> 32;\n> + crypto->zuc_window[1] = q;\n> + return;\n> + case OCTEON_COP2_SEL_HSH_DATW10:\n> + crypto->zuc_window[2] = q;\n> + return;\n> + case OCTEON_COP2_SEL_HSH_DATW11:\n> + case OCTEON_COP2_SEL_HSH_IVW3:\n> + crypto->zuc_tresult = q;\n> + return;\n> + case OCTEON_COP2_SEL_SHA3_DAT15_WRITE:\n> + case OCTEON_COP2_SEL_SHA3_DAT24:\n> + return;\n> + case OCTEON_COP2_SEL_HSH_IVW1:\n> + crypto->zuc_fsm[0] = q;\n> + return;\n> + case OCTEON_COP2_SEL_HSH_IVW2:\n> + crypto->zuc_fsm[1] = q;\n> + return;\n> + default:\n> + break;\n\n g_assert_not_reached();\n\nOtherwise patch LGTM.\n\n> + }\n> + }","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=J1DL45Jc;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftzmz2K2Mz1xtJ\n\tfor ; Mon, 13 Apr 2026 04:37:55 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBzgb-0002wE-4o; Sun, 12 Apr 2026 14:37:33 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wBzga-0002w3-FF\n for qemu-devel@nongnu.org; Sun, 12 Apr 2026 14:37:32 -0400","from mail-wr1-x433.google.com ([2a00:1450:4864:20::433])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wBzgY-0003ZR-MK\n for qemu-devel@nongnu.org; Sun, 12 Apr 2026 14:37:32 -0400","by mail-wr1-x433.google.com with SMTP id\n ffacd0b85a97d-43cff5dafc3so2680710f8f.1\n for ; Sun, 12 Apr 2026 11:37:30 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d63e5ccdasm28116444f8f.34.2026.04.12.11.37.26\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Sun, 12 Apr 2026 11:37:27 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776019048; x=1776623848; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=56SQG11dMJm3A9G48HJNr7gP0HZ0Dd3SGoiYkyCWZlY=;\n b=J1DL45JcMfDybL3/v60Jtkp8cJWYsUMeuyJb6D2rD9A0omMJKyw5tQNNdjs5fVLJPX\n N1SMS5bETPlxgI6q3m5E9fh36HBDmtMMiqYepslL8tzwpefBXanQFMcHc0q7ZroqEtU4\n xd5zknlvTe2QlK1YCAY5rpe9NY35yX9lGo8OQufvEj2LXIzX6Wh2zbS1XDcSIOXBrGFB\n jiajld2h3eZBYbU14vB8c9oq7dxDpRZokL+1fmroFkl4lVIabFE3b5HXzCPD5o1eT9c0\n Rz+hZ78Nxov8q41JkM5e53EckYRHHyy1Fj5zqeojz4gFvz9fi3WeIxoDQhr9iNCL8Nzb\n lXCQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776019048; x=1776623848;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=56SQG11dMJm3A9G48HJNr7gP0HZ0Dd3SGoiYkyCWZlY=;\n b=PqwMV7mee7NDQN+BC7KXXXvCLmzSPExR/RUrbOADXTZthTMYYMG9QELbrtdqPMv5KF\n SD6BBaTi7sjFw8igY1/49WAYvRnU4QYapDAO8bruDtkNChbKmPA7lXpm437H7P7Td9zX\n pCaA45JT8mWeVEiETlHGNcW5gwRjTNn6C7Tt5DdmnwlzFgYyOGqFT89fxDdhMFZMcOov\n 0WcvNhLmMuYrhS4sZ5ONkB+UNrJk+jnGbMmpibwGFnZW1qLjbG4+y5fjOPlSYmC6D5h8\n j7fklPvDSBxJmol9SNU3VM0BckOwQSD1Gvam0m0P3Cbx7IfEIXelYaqBrBjx6pvoSmsw\n wXWA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+pcKz6aldZrHkNARh52N91U9Aggg3uu0roPxQr9JBKutobvdM3/A43w4n+TgdRnm3onqZ48o5BMmTV@nongnu.org","X-Gm-Message-State":"AOJu0Yzm6Gdr2gdBd5dyp4Sp4/9ADHkszOAQ8Yjfl4lZ2xV+sq/ynMOb\n NklyZkmDy2VU57VX0i4t339P/HjOmNe8MbDfY5J7mCAFSeQvq68SuBmEoshgoIkhPgY=","X-Gm-Gg":"AeBDiety4PqJvIMx5T53HLtUM9ZuGTGGhS/y3Fev20e4apTx5W8AdFUEThST9l1uWCh\n h7YiylYt4QJWG3CRwgF6MBy9jAuX4g1WIitoQ3ZukyY2d2f5PZMmPLMqfjj4XBlZCLeCK9FcQnh\n gkGFzNjf4cuqpZ+yy4peodNNhRgPZYa1RklFlRUJVxGneS0+7/GefxRogi92amgCRnukSCiPESG\n 982hkjo15N9Hw7umSqMLBVu27+qn/izGUibxFgGqeXiNZeRoahuPy8pezhYpgEOtJwxCDiD3VZ+\n 2Kc+b5YImRteqBiqaEfIbDE2onwN/c+AWnMvRNKdTRNoT2uKvE1ftTgfeBoyqxonl4xdM4p0qX+\n eMkbTHXk4ynVJdXo9J1xNApb4RHhbtBaBYn2rhPo4sA5RYT5flsS4zigJ/l9FoFXCAhDzyYtvk8\n QulUCGknrufzni8lte+vMOBKPrr961QkEFe+Vv8nfPN1hgSGWDPr6EEX66VLBFwJp+ug==","X-Received":"by 2002:a05:6000:1847:b0:43b:45d1:f449 with SMTP id\n ffacd0b85a97d-43d642f18c7mr15907450f8f.51.1776019047634;\n Sun, 12 Apr 2026 11:37:27 -0700 (PDT)","Message-ID":"<8cac2df2-7718-412a-8a58-2f49eac78dba@linaro.org>","Date":"Sun, 12 Apr 2026 20:37:26 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 7/9] target/mips: add Octeon ZUC crypto support","Content-Language":"en-US","To":"James Hilliard , qemu-devel@nongnu.org","Cc":"Laurent Vivier ,\n Pierrick Bouvier ,\n Aurelien Jarno , Jiaxun Yang\n , Aleksandar Rikalo ,\n Huacai Chen ","References":"<20260411070637.72421-1-james.hilliard1@gmail.com>\n <20260411070637.72421-7-james.hilliard1@gmail.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260411070637.72421-7-james.hilliard1@gmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::433;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x433.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]