[{"id":3676970,"web_url":"http://patchwork.ozlabs.org/comment/3676970/","msgid":"","list_archive_url":null,"date":"2026-04-13T23:30:54","subject":"Re: [PATCH 1/9] target/arm: Replace MO_TE -> MO_LE for Aarch64","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/11/26 06:06, Philippe Mathieu-Daudé wrote:\n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> target/arm/tcg/helper-a64.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/target/arm/tcg/helper-a64.c b/target/arm/tcg/helper-a64.c\n> index 2dec587d386..dc3c8a036d9 100644\n> --- a/target/arm/tcg/helper-a64.c\n> +++ b/target/arm/tcg/helper-a64.c\n> @@ -1019,7 +1019,7 @@ static uint64_t set_step_tags(CPUARMState *env, uint64_t toaddr,\n> * the page dirty and will use the fast path.\n> */\n> uint64_t repldata = data * 0x0101010101010101ULL;\n> - MemOpIdx oi16 = make_memop_idx(MO_TE | MO_128, memidx);\n> + MemOpIdx oi16 = make_memop_idx(MO_LE | MO_128, memidx);\n> cpu_st16_mmu(env, toaddr, int128_make128(repldata, repldata), oi16, ra);\n> mte_mops_set_tags(env, toaddr, 16, *mtedesc);\n> return 16;\n\nHere's an amusing fact: we don't actually need any specific endianness here, because every \nbyte has the same value. So we could simply drop MO_TE. That would produce a store in \nhost-endianness, which will be fractionally more efficient on some hosts.\n\nAnyway,\nReviewed-by: Richard Henderson \n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=z2sUKNN6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvkFT5fVLz1yD4\n\tfor ; Tue, 14 Apr 2026 09:31:40 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCQkF-0006uo-TU; Mon, 13 Apr 2026 19:31:07 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCQkD-0006u6-Jg\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 19:31:05 -0400","from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wCQkB-0006RH-Mm\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 19:31:05 -0400","by mail-pf1-x429.google.com with SMTP id\n d2e1a72fcca58-82f41fce3e6so678450b3a.1\n for ; Mon, 13 Apr 2026 16:31:02 -0700 (PDT)","from ?IPV6:2401:d002:dc0f:2100:377f:61ec:6edd:e205?\n ([2401:d002:dc0f:2100:377f:61ec:6edd:e205])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82f0c34f7d0sm13138348b3a.14.2026.04.13.16.30.57\n for \n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 13 Apr 2026 16:31:00 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776123061; x=1776727861; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=A8BJNN/kVo8S9axiz6QuMHZKzhALQuyNX6Zbc5UdI8U=;\n b=z2sUKNN6Bi9/sPzFvVU6e/nbwDVkiq1WRC2FPg+gGIJHf1/908tIYIpdCGsIOajCv1\n XinvlhAJwQB49hyA2viyX9ANHJglGFs0NLJEDdgH13I/WgO/5fso15ghx6GADzwyyfje\n CiqtncnqcDWGOdq5yX/NVqwl41iahJGTxVMca0n+giGB4W/7DRxbx0h9x/1ZyGrUO9Mj\n K9Vxg0awuSbMrdf47aecoVjc56TtB+WiqBFB0KWIjCbp3vV17n9tm75cUUTGejhfJ/MN\n gPA3v2JlI8ycrBbDLdni0XQhPLa83pncvTvjQ+pWDTptTx/xZk59v0hMeWmyK2oWFxLD\n nTvQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776123061; x=1776727861;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=A8BJNN/kVo8S9axiz6QuMHZKzhALQuyNX6Zbc5UdI8U=;\n b=DP2Oba2f2EQ9V8/wwzC4Q+WzHQwCW7X+HwIZMQ/Q+Bptzhviw67nLEi/rsAu7Uo024\n /ylrorcOCHLtACPSGLuW3gBORe5Q4MWD8Nsw4UjwX027Whi0L04UOiK3J633SGvv0b6v\n utThx5g4ctf/0MdH/EzxIgOQwawomIXDY9OfuweJuczR7p7xLuyh/yUl0uPLIC8uz/5H\n CUUsJt9I4gAwRuY7AcFiV2Qhh2hH9cQ6NvQ3JRMX1WpkIj2Ip3t9nxVYaOWz+SYSQDB7\n htuWetGtAYTFhGBj41sM1r35Rjefuue1BunG9kp+3rCw03ZaJQxwMlDxapFOJUvAu+Aj\n hx4Q==","X-Gm-Message-State":"AOJu0YyP7VxP6CgPk5njuw7ayZaEncfuZhvzzefllXAPJDSMhe7nN8Ob\n 2Tee8jghcSs/udrFjTFSWI0FX0gwHP6nOGi5jZ25Fha5Hb2AbMIJ/RUM49s5FucaqLmhUAx18E5\n YH9GWtc8=","X-Gm-Gg":"AeBDietjDuOMEZOwiX0hqz/o+E3C1whmgb+A+eC4Pvb2ITSOD9X0U/uFEgZLSeskyWB\n pEET8gwati5PmH9Zwx9cksiEOkHx1yvIFdd8XiT3nxEDBJ223VRTw8C4VcVvcuZOPlFU+3BA6Jb\n +YwKmOfwDyrWnntdvLGI6XtXCWnOphXQM7qcV35WsfimaezvZ4kgDRaomP8WIyb6FpCDBs4VU06\n Kl2CHh5bRwW2QjmdzlPA9freE+UKpIwyTc8xbSqReVVx5/WLAbrSLIY15fVdZrDThodJoQZ4y2x\n hjDozhCMET4GRLs3KQXWLG0+FIZIYZ8PnakOv0AANmKXgeuKrM7emNjTGRt+UnY6KwlWSTr6zRt\n 18AWl+qYLmuXJLfMF7drGmdTZOTBZ1I/wXjZosAXwJMRLgqZeopyZ/EeWHVNatHPChvC+FwiHzK\n 5gz6x47YZaZXeJjlE3w9jZD+EYkCo4P4mRmyBr5Dw0rLBZ10YFblGgye98oDWQdmtDrXBavG26L\n o2P36NSwnZ69A==","X-Received":"by 2002:a05:6a00:114f:b0:82c:e0d7:2681 with SMTP id\n d2e1a72fcca58-82f0c276ff3mr15666449b3a.16.1776123061216;\n Mon, 13 Apr 2026 16:31:01 -0700 (PDT)","Message-ID":"","Date":"Tue, 14 Apr 2026 09:30:54 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 1/9] target/arm: Replace MO_TE -> MO_LE for Aarch64","To":"qemu-devel@nongnu.org","References":"<20260410200628.19378-1-philmd@linaro.org>\n <20260410200628.19378-2-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260410200628.19378-2-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::429;\n envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x429.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]