[{"id":3676981,"web_url":"http://patchwork.ozlabs.org/comment/3676981/","msgid":"<0c1cbc35-acc2-4ead-a8cd-419cf952a750@linaro.org>","list_archive_url":null,"date":"2026-04-13T23:47:10","subject":"Re: [RFC PATCH 5/9] target/arm: Introduce mo_endian() helper","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/11/26 06:06, Philippe Mathieu-Daudé wrote:\n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> target/arm/internals.h | 3 +++\n> target/arm/helper.c | 8 ++++++++\n> target/arm/tcg/mve_helper.c | 3 ++-\n> 3 files changed, 13 insertions(+), 1 deletion(-)\n> \n> diff --git a/target/arm/internals.h b/target/arm/internals.h\n> index e92a967f575..f21555a69fd 100644\n> --- a/target/arm/internals.h\n> +++ b/target/arm/internals.h\n> @@ -28,6 +28,7 @@\n> #include \"exec/hwaddr.h\"\n> #include \"exec/vaddr.h\"\n> #include \"exec/breakpoint.h\"\n> +#include \"exec/memop.h\"\n> #include \"accel/tcg/tb-cpu-state.h\"\n> #include \"hw/core/registerfields.h\"\n> #include \"tcg/tcg-gvec-desc.h\"\n> @@ -46,6 +47,8 @@\n> #define BANK_HYP 6\n> #define BANK_MON 7\n> \n> +MemOp mo_endian(CPUARMState *env);\n> +\n> static inline int arm_env_mmu_index(CPUARMState *env)\n> {\n> return EX_TBFLAG_ANY(env->hflags, MMUIDX);\n> diff --git a/target/arm/helper.c b/target/arm/helper.c\n> index 7389f2988c4..037d2bcf376 100644\n> --- a/target/arm/helper.c\n> +++ b/target/arm/helper.c\n> @@ -38,6 +38,14 @@\n> \n> static void switch_mode(CPUARMState *env, int mode);\n> \n> +MemOp mo_endian(CPUARMState *env)\n> +{\n> + if (!is_a64(env) && arm_cpu_data_is_big_endian_a32(env, arm_sctlr_b(env))) {\n> + return MO_BE;\n> + }\n> + return MO_LE;\n> +}\n\nFor use within tcg, which this is,\n\n EX_TBFLAG_ANY(env->hflags, BE_DATA)\n\nwould be better.\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=mG/MN2b5;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvkbv4Ckzz1yCv\n\tfor ; Tue, 14 Apr 2026 09:47:38 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCQzv-0002HB-UP; Mon, 13 Apr 2026 19:47:19 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCQzu-0002Gu-UV\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 19:47:18 -0400","from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wCQzt-0001eh-Aw\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 19:47:18 -0400","by mail-pg1-x532.google.com with SMTP id\n 41be03b00d2f7-c76b0cda2aeso2041962a12.2\n for ; Mon, 13 Apr 2026 16:47:16 -0700 (PDT)","from ?IPV6:2401:d002:dc0f:2100:377f:61ec:6edd:e205?\n ([2401:d002:dc0f:2100:377f:61ec:6edd:e205])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82f0c34f7d0sm13162625b3a.14.2026.04.13.16.47.13\n for \n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 13 Apr 2026 16:47:14 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776124035; x=1776728835; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=MxALAJRMrmCWLQPF+9QIvUXcd/yCenDPuIZmayH3Eac=;\n b=mG/MN2b5j9nCxmUZ1BwJCQxCNJ1SweySzg02GqzuUd1lUnB9J2Yoat1lGk/eKJxSfO\n 0mNI5r2QkSGDcmAQow2zduNPYVakXEr/jnPylD0kXbptg168FjkevCZ+QxGg54Q4IPB1\n of0p8Kz4PmTZy2DF7f1bwrUiQ7d4tkPD7hgxeWawR9OtP/S7LEVlIi7QS86DtaWh9O+W\n zX/++vB+YOPdRpjHUSF4QKXmyS/xG0wwQ+dOV+g/5vpOEBcIUQWHrKOyKEI0Il6+cBzZ\n Nkg/KcKmdRPfbsyLK+lWRcU4Wa8HDBBATH7Jq3SUQXwKb1bIU22mx1q6clZd1XPyXHvv\n F3WA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776124035; x=1776728835;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=MxALAJRMrmCWLQPF+9QIvUXcd/yCenDPuIZmayH3Eac=;\n b=e0AJ62ZkOgmf25nRMxm95Ctheu227SfiV3svUUfXMt4iVHHNtPHqn+o9fr2Q2biFC8\n OsB9jAydA97PsyhDch0ADqf4RrNzMsLfTBQev5cmIFfUd/W0rM+rIMzEtHQBfJ0OKjLI\n etZR/t4lUXYQ0/AbrSv/Fi0dXjAItVpYWT03IU0w1rNKZkhE1mWU/ORF5V92mTc98mG6\n Mg8uY3/JsvjDNs+shQbaaB+ssXeHQIxNnO3KoILPAoBy8WoIoHoYgbGY9qU5kakxqRR2\n pj7attnf12LRXScx0c9T3s7wCRdTeHYoilLm6lHEfcreN8EZ2jaEgtnrx3HQjN/bXUJl\n IIZg==","X-Gm-Message-State":"AOJu0YzbRwz5tRqkisCfCz8q04psMtozcYc1z4S5xy+9LqrCNmUwDru8\n HcdZO8x71ev+pqUCnxRsruzLmk/9B3nKEGxsplkdvTKHlU8fjkGXPd/Rk+jiK9IW9ip5GNVH3ss\n lGSZ1","X-Gm-Gg":"AeBDieukNgQufEDWbpbG0z0WZA58PgXfNbtJlzx0zEJ0vXrdPNfd1dqFOMX9NUZGxzi\n Pf4cRuWoZIhE/NoCl350TeqxOl8kDZe7goru7HwColnWp5FTT2kBwFQzQ98XGSNV+e4fWH01gfA\n xcbNO9eLwFNyz6f0SY2H0kjbo5Jw1LHH1UK3eNpziJ5XGjl+tewSGn2mJ8x3uC2t9xuY88Cz31O\n KDKWQx738wwPY6LCl/dp3uh3Cy3WIR+PuGBb5yR0KF1Gm+Verc+21jwcgavy0hFukICa06vWLgR\n uwQ+8z10Di2xlWg+VjQzhhDrPPRmlijGLwqoZwxE2yWjXNPNrqGBEpypdnw2kjc/syYTGOfmf61\n vLamgwXm7Clp3DbX48ya5Y6UFbLCqHJBBgmnKnNrlJxOpENRAFbe6NK2caoA0Cu2py1RDMLHYOz\n Jvr7R/vvy+ofbJQdi9gXLO8y3KxS0HtyHvIXZYXFIxgKJHZskxwYO3vYahJdOSUe0hArRQTok0o\n Nql9o1GmdBTTQ==","X-Received":"by 2002:a05:6a00:12cc:b0:82c:eafa:8875 with SMTP id\n d2e1a72fcca58-82f0c26b33bmr14779523b3a.2.1776124034940;\n Mon, 13 Apr 2026 16:47:14 -0700 (PDT)","Message-ID":"<0c1cbc35-acc2-4ead-a8cd-419cf952a750@linaro.org>","Date":"Tue, 14 Apr 2026 09:47:10 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [RFC PATCH 5/9] target/arm: Introduce mo_endian() helper","To":"qemu-devel@nongnu.org","References":"<20260410200628.19378-1-philmd@linaro.org>\n <20260410200628.19378-6-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260410200628.19378-6-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::532;\n envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x532.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3676991,"web_url":"http://patchwork.ozlabs.org/comment/3676991/","msgid":"","list_archive_url":null,"date":"2026-04-14T00:46:33","subject":"Re: [RFC PATCH 5/9] target/arm: Introduce mo_endian() helper","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 14/4/26 01:47, Richard Henderson wrote:\n> On 4/11/26 06:06, Philippe Mathieu-Daudé wrote:\n>> Signed-off-by: Philippe Mathieu-Daudé \n>> ---\n>>   target/arm/internals.h      | 3 +++\n>>   target/arm/helper.c         | 8 ++++++++\n>>   target/arm/tcg/mve_helper.c | 3 ++-\n>>   3 files changed, 13 insertions(+), 1 deletion(-)\n\n\n>> diff --git a/target/arm/helper.c b/target/arm/helper.c\n>> index 7389f2988c4..037d2bcf376 100644\n>> --- a/target/arm/helper.c\n>> +++ b/target/arm/helper.c\n>> @@ -38,6 +38,14 @@\n>>   static void switch_mode(CPUARMState *env, int mode);\n>> +MemOp mo_endian(CPUARMState *env)\n>> +{\n>> +    if (!is_a64(env) && arm_cpu_data_is_big_endian_a32(env, \n>> arm_sctlr_b(env))) {\n>> +        return MO_BE;\n>> +    }\n>> +    return MO_LE;\n>> +}\n> \n> For use within tcg, which this is,\n> \n>   EX_TBFLAG_ANY(env->hflags, BE_DATA)\n> \n> would be better.\n\nAh, I know somthing ougth to be better, thanks :)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=JWKNPjEd;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvlwP5FStz1yCv\n\tfor ; Tue, 14 Apr 2026 10:47:01 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCRvM-0006d2-PM; Mon, 13 Apr 2026 20:46:40 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wCRvL-0006cs-LN\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 20:46:39 -0400","from mail-wm1-x333.google.com ([2a00:1450:4864:20::333])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wCRvK-0007EG-99\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 20:46:39 -0400","by mail-wm1-x333.google.com with SMTP id\n 5b1f17b1804b1-483487335c2so54818365e9.2\n for ; Mon, 13 Apr 2026 17:46:37 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d7bc5f70fsm8932671f8f.3.2026.04.13.17.46.33\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 13 Apr 2026 17:46:34 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776127596; x=1776732396; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=HhWT+KTJmFWL3YfVm8UGn0lt9F9fnqn78XxEtKESSnY=;\n b=JWKNPjEd0fv84Iv2wwwSDPCnZOFS8Hk9wFH1z9m6O+zTHmRXisDF9tigawx+wziU2W\n ntXcvGH1EI8tAyVY50BfrooXN1ufvTf049hP6Jl0wYKVECrIIAce5PgWJ/sL8JHb9AUy\n s3S2SHFK3IeDC3pcx3wIquxutQOZjD1RpZcucdep4TE3vf3XCT2O5TPcEGWcUoAtWth+\n FA9PvOtNth05VIa1RCAct7y4DAwljtLKHU5GMsljMatjKzeFtopalYS9Uyn/E0pYPToV\n HcrEnOR59an42xn9xG0cy4c2ZOj0lbGA5Dl9cpZyZ1t7Y086s+FqmfTlzd1ZqPzRQona\n gcig==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776127596; x=1776732396;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=HhWT+KTJmFWL3YfVm8UGn0lt9F9fnqn78XxEtKESSnY=;\n b=jpADx3aJCwjZ3FBZjUSKiEW35g2GzF6yFtf5gywBktg+x83HJd4hZbX0CyO3yM4D+w\n tUA2+6sv9QwOvZvoUlb6cpQl/t58XBe2+EO8gIO6ub0cEbU0023+FFvuQSkSIG0EzQ7j\n Tf4eXKxqYNmvtBnBP6DNuA++6ACj83Rk9gWFYljY10y6mCO05jwGIjnmPm2TTBCruOvT\n 13FmaLAClgLiDLN1ExL/WGAEswXhXZtEdheitcMri43Lrfwmw+uxn43ech8y6HaP8aH4\n WiK9I6QnTMgMRKpL8dbuyfWi+yVV28xpcarVU4G9CrSHOVOJoktjvyrL/lA1gw/2aVq+\n zYbQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+xFXzcSF5K7GFJ6KhUat2WcISbxEAZARp8qbYi8yYlArZcZksgC5EvcKmaA08irKoigfnaYpSWnQuv@nongnu.org","X-Gm-Message-State":"AOJu0YwGADEvrx7WdhwEwrxxTkArFDvj1rjePcJS7AgbWvJO/ALeKX7M\n Ktqy7clQsA0zAh3tFXol+aI8T32R8/YUTrEMRNm2KdYISj62H+ZZRJI/c1OtGPO9dIE=","X-Gm-Gg":"AeBDiesVYluBZCQG/lKDaoBStY5DL0iQfksNwjD3ae4XHdHADb0i6Hlrs14iCuhNfXr\n CUDVusfDRwlPHA3YGZVHnIzIwCgGKKKTj0D/pELYCdVfJGoYdWTQi7j1OB+JLkkFnw6CTiwzLup\n qrKrP3RjzGGaZMfMQIjfULiwOx6SqswduJUWTXpsg20ykwEjgUImg5tmP2qRnxEX0ARGiuym08o\n gZ5GttRkFIm4ka9wVXEEhUQySWaa5wSVJ207rEMPBk3ClFlGM1yzdyqh7P91hBxTFbZgrmQUWwS\n DGakBG7XHAuaCGC7bmCFxZBQvf5sVSBABZi4iyQCRTo6CpDpQ/va+PI8CYYIRQYBe2IAPKOcrGp\n CPxp0fp4SncKpFOaSxJgOE8q27eqJcrd7RDRaZ1WwlMwzbQvxs9tHcKrvrCbSaS/nNDc2t+25Ow\n +ruPY9fWuphyxz4DiqnxixnKSsLHt/ncY+LAwYGcq3tBIYlRqi9NkVLVls2SV1g18/ug==","X-Received":"by 2002:a05:6000:1447:b0:43c:fdd9:1890 with SMTP id\n ffacd0b85a97d-43d642c999dmr21355173f8f.51.1776127596437;\n Mon, 13 Apr 2026 17:46:36 -0700 (PDT)","Message-ID":"","Date":"Tue, 14 Apr 2026 02:46:33 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [RFC PATCH 5/9] target/arm: Introduce mo_endian() helper","To":"Richard Henderson , qemu-devel@nongnu.org","References":"<20260410200628.19378-1-philmd@linaro.org>\n <20260410200628.19378-6-philmd@linaro.org>\n <0c1cbc35-acc2-4ead-a8cd-419cf952a750@linaro.org>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Content-Language":"en-US","In-Reply-To":"<0c1cbc35-acc2-4ead-a8cd-419cf952a750@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::333;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x333.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]