[{"id":3676448,"web_url":"http://patchwork.ozlabs.org/comment/3676448/","msgid":"","list_archive_url":null,"date":"2026-04-13T04:41:30","subject":"Re: [PATCH v2 19/27] monitor: Introduce HMPCommand::arch_bitmask\n field","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/11/26 05:53, Philippe Mathieu-Daudé wrote:\n> Add the @arch_bitmask field to the HMPCommand structure,\n> allowing to restrict a command to a set of target\n> architectures (represented by the QEMU_ARCH_* enum constants).\n> \n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> monitor/monitor-internal.h | 6 ++++++\n> monitor/hmp-target.c | 1 +\n> monitor/hmp.c | 4 ++++\n> 3 files changed, 11 insertions(+)\n> \n> diff --git a/monitor/monitor-internal.h b/monitor/monitor-internal.h\n> index 3ecd394ecf6..78281928e7a 100644\n> --- a/monitor/monitor-internal.h\n> +++ b/monitor/monitor-internal.h\n> @@ -74,6 +74,12 @@ typedef struct HMPCommand {\n> const char *params;\n> const char *help;\n> const char *flags; /* p=preconfig */\n> + /**\n> + * @arch_bitmask: bitmask of QEMU_ARCH_* constants\n> + * Allow to restrict the command for a particular set of\n> + * target architectures.\n> + */\n> + uint32_t arch_bitmask;\n> void (*cmd)(Monitor *mon, const QDict *qdict);\n> /*\n> * If implementing a command that takes no arguments and simply\n\nThis and coroutine could be placed better to avoid two holes.\n\nOtherwise,\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=wu98b1CK;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvFBM4KbWz1xtJ\n\tfor ; Mon, 13 Apr 2026 14:42:19 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wC97H-00025j-EP; Mon, 13 Apr 2026 00:41:43 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wC97G-00025J-0w\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 00:41:42 -0400","from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wC97D-0002MC-EO\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 00:41:41 -0400","by mail-pl1-x634.google.com with SMTP id\n d9443c01a7336-2b24fcc2b5dso26315815ad.1\n for ; Sun, 12 Apr 2026 21:41:38 -0700 (PDT)","from ?IPV6:2401:d002:dc0f:2100:a7b4:d4f1:5b23:321f?\n (bg30dj032xp6rdh0yngy.ip6.superloop.au.\n [2401:d002:dc0f:2100:a7b4:d4f1:5b23:321f])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b2d4f3a8f7sm101698425ad.71.2026.04.12.21.41.33\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Sun, 12 Apr 2026 21:41:36 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776055297; x=1776660097; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=QszutIL7wDTHLCDNTzcTvkrv//j2mQDdIveZtbTBtCI=;\n b=wu98b1CKnTBpisuaSaj1lGYAIE1prcX6oWbTQoXeOt+cl6vYFdl9bK6j2uSyPTpWPr\n 6otwinheWoTz65W2Q3z/Wn03gZ29Iwzx4egP9rI3jZUA3kg9zbf/jItpTJfrg/I3uEoD\n gVXkvV4Lgh4zDn5o7ukSqhwEmPeRvDY22lwuzBfgg7IovO2DJoiSbXBAYzLhjsXR9saX\n vyqgE+KvBVKCr2DQV4Qjr2c2O+W6XXUcydAAp7OZUK/T8lOlO3Cx7YoVEAxqwab1u/vN\n Se77AESoYwz1aX8TgFQ5pD2ceDC+oPWtTgosdhRkV9bd1jgoG54/AhZ78C2OY/RQk/CS\n NL7Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776055297; x=1776660097;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=QszutIL7wDTHLCDNTzcTvkrv//j2mQDdIveZtbTBtCI=;\n b=OW8A2i6W4aKQdoQFEw2zezvIDK1KUpKit1jV1CidB8uNSTIw4oYsvXHnFiQFLlk90K\n ypQOPhCNW6xcIr/caPP5KWA6yVBy6+iiw8CYGuwDYAk+RejfkdLxMWJr4+7FqB5EFqEe\n sIRTvYk/OHJJLdkXbYfJ4veZT3NyfKLKBYtfVnucmE+37yizRDBw7UJD5RFzx9XDWCQU\n BqIeIcSZlAIeTzTfGGXurfGm5RVhfszP6EOzHzpLvjUwgD0sA1IvWhUua0EZt+o5gJxk\n Y3DbXtS5pRFJgPmVglRV/j9FBjdbROXXCFIS9A1meA7Xt1GI9JSJ5eTEqqsN+gIgReI+\n tKpQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9wq4s1TQqHzUiuFpYBfkBjYvgd8Fk0olDuClX6yi0D7uVaD4Y3UeQsQ8f/8iqAOHhZ2UzL+CNxq4/i@nongnu.org","X-Gm-Message-State":"AOJu0YxLU2Sg8tTn9SSBugo+ZQSO+fxDaS1xml1HwMdFK1kZSoVwKcq4\n 4XBT0hhJ/d+emSoair8MEKEtH8ntXhv/eZKpK2D0bippZ1qEbUYQl9q9t9oOWDZgkYA=","X-Gm-Gg":"AeBDievbinJZnz51d6UGraNFfIOSuV8Ho/spUka+dYkcjaodVPD2W7A9qFInvibncoP\n YfhUplPpf8IY4MIw1vkw0YY4c0uLrvExwT+bvJoyXGyWLwEjHjt3wt9bHu95uiHaJJNq1VdwFy2\n MzzU89JF5ldX9rl8P5/CCUR52vcCypZqkGyggaukZ1i7gIv92NQOkSZy8JRY0Seg4IK33X+hcHH\n JM5tMkgzH5RsBZnY+9Hoy88/oASsO+Ld2yswNytAbw7n6uXlrNslnOEuBmG5+A0ZOILydC8iw5N\n nQkARz8nznhXP0ys3iwTfC98c7osl0kyTPeQVjKQaZDfq1r9T/aEOPlxEDgGlXrV/MMeUFj9XN8\n VDJ5EfbC+k4KK9HECEvlJCQs3C3y+8lsfVLyzM+Hk1JaAyy2VjL1/ZZkzgi4pjfekTiF4/tFEQk\n HFoET+bEXanXvOPN8msF5LAfnAJk1twbrex7cLgMw1GhpCDcFKxLv3qH9RCTwn2KyRNc5bAVwek\n lpKVmOVXCaEAeodi8XIrMr1vvmTSnHC4dLO15NSRz41s4MOFE+N1q8=","X-Received":"by 2002:a17:903:2c50:b0:2b4:5cb8:99eb with SMTP id\n d9443c01a7336-2b45cb89e2emr30003155ad.27.1776055297031;\n Sun, 12 Apr 2026 21:41:37 -0700 (PDT)","Message-ID":"","Date":"Mon, 13 Apr 2026 14:41:30 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 19/27] monitor: Introduce HMPCommand::arch_bitmask\n field","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"\"Dr. David Alan Gilbert\" ,\n Pierrick Bouvier , qemu-riscv@nongnu.org,\n Markus Armbruster , qemu-s390x@nongnu.org,\n kvm@vger.kernel.org, qemu-ppc@nongnu.org","References":"<20260410195323.17937-1-philmd@linaro.org>\n <20260410195323.17937-20-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260410195323.17937-20-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::634;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x634.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]