[{"id":3676441,"web_url":"http://patchwork.ozlabs.org/comment/3676441/","msgid":"","list_archive_url":null,"date":"2026-04-13T04:10:34","subject":"Re: [PATCH v2 13/27] monitor: Remove target_get_monitor_def()","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/11/26 05:53, Philippe Mathieu-Daudé wrote:\n> target_get_monitor_def() is now only a dead stub. Remove as pointless.\n> \n> Signed-off-by: Philippe Mathieu-Daudé\n> ---\n> include/monitor/hmp.h | 2 --\n> monitor/hmp.c | 7 +++----\n> stubs/target-get-monitor-def.c | 29 -----------------------------\n> stubs/meson.build | 1 -\n> 4 files changed, 3 insertions(+), 36 deletions(-)\n> delete mode 100644 stubs/target-get-monitor-def.c\n\n\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=gvNohYWJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvDVH4S2sz1xtJ\n\tfor ; Mon, 13 Apr 2026 14:11:03 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wC8dO-0006gS-UW; Mon, 13 Apr 2026 00:10:52 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wC8dI-0006dU-1Z\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 00:10:45 -0400","from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wC8dG-0004eO-F0\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 00:10:43 -0400","by mail-pg1-x52b.google.com with SMTP id\n 41be03b00d2f7-c70ea5e9e9dso1538233a12.1\n for ; Sun, 12 Apr 2026 21:10:40 -0700 (PDT)","from ?IPV6:2401:d002:dc0f:2100:a7b4:d4f1:5b23:321f?\n (bg30dj032xp6rdh0yngy.ip6.superloop.au.\n [2401:d002:dc0f:2100:a7b4:d4f1:5b23:321f])\n by smtp.gmail.com with ESMTPSA id\n 41be03b00d2f7-c79219c618asm8573976a12.18.2026.04.12.21.10.37\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Sun, 12 Apr 2026 21:10:39 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776053440; x=1776658240; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=YHxstGbvv+o2U3Arox7wQdoz5xYWtAgzeZVF1NT7J+E=;\n b=gvNohYWJtZ0dxP2q0Ql0OWURfEIVBaJxWZQBqz2VofhsXZziTfqA3L+QsKP+dgJztU\n xliAv/gZWaLXfYsXr6w9sjma0fueb8xJ1YoTN86KtUna4+639sLoT0fvMhvjoVc1doGV\n fUlcb74Yb77fll73v8tN0FQucA1XnGgioMNFntwKHIDzinIaDwnUr3MoO30fHtP4lwuP\n vuwkIjp7fPgNWl9lialwnpv77iytjC9V6569OQgiZlaBs5hX73AZWG+UEkOY3kIzI1X7\n nTJmWJoayQ9K0vKB+GE/4sPKZN8nDhXz3jibwDQHp2/ShSpNxKP8d2TKv4pbSU626U3b\n NanQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776053440; x=1776658240;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=YHxstGbvv+o2U3Arox7wQdoz5xYWtAgzeZVF1NT7J+E=;\n b=OG4RtpKibC/9x+RNAuStDpkT3X4mClEkVQ4kxnLuPY3uMEXVu5pDVUahoDIlSW2IP1\n kpjNNxvYPm8wEuZjOwm+B+fyNQwlXvg3ccDUckc1Vi4cJ8y/A/T5uFqBUavQQbc3eu+n\n 9QBD1oSwwz4Ox4cZ/Rvj+Wy2cWq54FBGbjLs24gQbuUHYJH2n0cFk6dIlqvN230PYodB\n 9VbOV+7vHhEz9mR39t/EdMSWk9rQf/cYf2kanXkZjRKw4gfK2Rly/DDX9F42kLcm8QU1\n uIAeGryKPw42VZbaCjW94sPW7/qZ4G0kyIvwp6usrJbqbStuTrBYLR3vOMYVsabEZMir\n 8Daw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+NsDwSorBVq5YTQeTB57Je/FKJy5b5cIxJQ3PRCh9gjSy064fFLO2hv2uQZ8lcvpHrkDkJ7bjti3o8@nongnu.org","X-Gm-Message-State":"AOJu0Yy6DvfD+YusSYFlZSRgKKTwiVE5TDS4IDWICfijmTsTcUNVDhqT\n FoZkWBSxdSjMq6XDgmhrbXnQ1TPC+UZ0T6hVEaUxNp0GWBhwgHMciOKAz+2z4VTsO0M=","X-Gm-Gg":"AeBDiesDTiRjr3RKdLlTmkpdlRKpluztGODM7iMlcf6YvIH+fN2HNNvH6Q2QNjfoeqK\n +pEbbnWVKOQJe+MjMEF+uBoG76ZLJqHIIgrrzC1k8yqAgpI7KSXfpW76Jc/l/07ziDoSPzIYgg6\n S3Vt3t3Y3W4WjoBg1KWm1NrOOcvo7hOfQzH28IWi0u7YEPKyroXallSXchMQX2z6RCCTOJfTSVj\n R28lyKnejfJVR2JXLaNtiMCZ94WDJVrm15gUHi/gr1OvkRJ99K9EdPnNKP3EBdveeAA3or/scdh\n pz2NK5O3udDY9jrqrz+bTe/oUGojB4IENplQcNybCgN4TlTcG0jyiEAgbqTKAnmvtYqRh0xm4Y5\n 7cSVcnZlRixyvShmVdb6fjay43UkBn4lOVB+JnmiqbwgQTxa9MeBdtzbQvKecxX/egBxtAqcrA6\n WLfn+AIDgWUl/9ExpyjmJ0Wt1Wh4B06rotypkesRJFQ1K85mr/7HGi/kRj5tmgbAECrVAKqnXcC\n i/LqfRu/Bfbpss1FpGe7kUm0UUk2xXSWErBuHXyjO0VqkntxAHpxVWr5CDCGdGXLg==","X-Received":"by 2002:a05:6a20:6a13:b0:398:a060:a97b with SMTP id\n adf61e73a8af0-39fe3c2d507mr12853568637.1.1776053439671;\n Sun, 12 Apr 2026 21:10:39 -0700 (PDT)","Message-ID":"","Date":"Mon, 13 Apr 2026 14:10:34 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 13/27] monitor: Remove target_get_monitor_def()","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","References":"<20260410195323.17937-1-philmd@linaro.org>\n <20260410195323.17937-14-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260410195323.17937-14-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::52b;\n envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52b.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]