[{"id":3676478,"web_url":"http://patchwork.ozlabs.org/comment/3676478/","msgid":"<4c99eb47-ec05-4d5c-b733-77114cb10855@linaro.org>","list_archive_url":null,"date":"2026-04-13T06:09:39","subject":"Re: [PATCH v2 21/27] monitor: Do not check TARGET_S390X to build\n s390x commands","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/11/26 05:53, Philippe Mathieu-Daudé wrote:\n> These commands are filtered at build-time for s390x binary.\n> By using the recently introducedHMPCommand::arch_bitmask flag\n> we can filter them at runtime, making it possible to compile\n> hmp-commands[-info].hx files once.\n> \n> Since the methods are used inconditionally within hw/s390x/,\n> define them in the same stub file.\n> \n> Signed-off-by: Philippe Mathieu-Daudé\n> ---\n> MAINTAINERS | 1 +\n> include/monitor/hmp.h | 7 +++++++\n> monitor/hmp-target.c | 5 -----\n> stubs/hmp-cmds-hw-s390x.c | 15 +++++++++++++++\n> hmp-commands-info.hx | 6 ++----\n> hmp-commands.hx | 6 ++----\n> stubs/meson.build | 1 +\n> 7 files changed, 28 insertions(+), 13 deletions(-)\n> create mode 100644 stubs/hmp-cmds-hw-s390x.c\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=lKoMPqwE;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvH8D1KBGz1yDF\n\tfor ; Mon, 13 Apr 2026 16:10:34 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCAUb-0007jN-KG; Mon, 13 Apr 2026 02:09:53 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCAUY-0007jA-53\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 02:09:50 -0400","from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wCAUV-0001e2-3m\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 02:09:48 -0400","by mail-pf1-x435.google.com with SMTP id\n d2e1a72fcca58-82cebbdbdccso1878473b3a.1\n for ; Sun, 12 Apr 2026 23:09:46 -0700 (PDT)","from ?IPV6:2401:d002:dc0f:2100:a7b4:d4f1:5b23:321f?\n (bg30dj032xp6rdh0yngy.ip6.superloop.au.\n [2401:d002:dc0f:2100:a7b4:d4f1:5b23:321f])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82f0c377318sm9595687b3a.26.2026.04.12.23.09.42\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Sun, 12 Apr 2026 23:09:44 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776060585; x=1776665385; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=TuC21pMdlK4M0FWowMlQiYUEtaQiSnTIDnzYdYSOpEI=;\n b=lKoMPqwECQ1mnlLVwul4aFi+OUJJnYdzoFumO1NN7OEJC2jeTBR0dw9BYb3LbfHwLH\n BXRIW/zWClMdZhRc04PBB82mnMro3Yeo2UnK1GvHIQvPxssVxzn7iGcaBtbup9nFLx9X\n mTn67xOIZ7egWvXxP9QpoEapRQXLol9DzpeazvnUba1sf/U6ncLwbuDcsF8fJGTN0iPW\n FiXiPa+G2abKcGfzfn3XlbENkJ3EgVt2MDIzU05+uyOaCXWTdQDwZXuKpiOMzFoGjm44\n PZMr/dFAR2Dv+ypM6ZnDjAR+GQAVH1pK8VLqHYCF1tL4ptoHKvMbD++2m8phbMYhi566\n eKNg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776060585; x=1776665385;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=TuC21pMdlK4M0FWowMlQiYUEtaQiSnTIDnzYdYSOpEI=;\n b=o5ML2k7aEB/LnYCNelF+yg5c0wuO3egiSkNNAA17zFMMmPyuPySM1t7WOyqm/MSCHa\n kWujV27URpCLKixkyQR/MSVxu4HWNC4ntvkhWK1tX2kcrAJGCf6jyPGI1/F+mlN/l5Xf\n NVNXHeWjPzCwjMJICj3aORVbUIliOyqZxM6OnZoJvLlwwN02tN27s2yISpEDpwQ/wkw/\n X/b4eKZz1Jhu/7YAbLF0UyvZ9ChvbypI2r5+NMb0GBxY1+iqrfS++ghUZLEIrxaSIsSA\n SWA59I3mKSXx6e+YnzuktDt0F07o9KV1YHxYd3QlZhhcD5RY81DOgoq/4x2bN9brVjYZ\n 01rg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9NNZwQPV/g85fjKkRVq0ZxFMdYcxUV/vY3L3bVvgJKeo6BalOiR86WVI+NyuUDEHwEyYjkLG7UW0Uy@nongnu.org","X-Gm-Message-State":"AOJu0YzDiRlPwUPeZJG/E/XBoO732DPPtWrNd/XREWP+Fg1DZDbN6TbX\n 5FWs86ykvOazfcqlY6Nh6BioJ6n/KeH+qkNulOnDBaKot4I3LAylHTpL7zHUhL2gOeNmTPL0/M7\n c9zjCR3Y=","X-Gm-Gg":"AeBDiesjG2Eh9w2j9I4QcQrL7g1FQ/VoruavtE0BjOl7oe0szPFbMNavOwp+EtfiuRh\n Jq73L5x5QE8MEJnM6uMfqnXe51wT2OdABmRCT+clmuINz8ndOHgUKN6voZ7J5ryaa2MXJn3i75J\n ioG28R2gJOEHaj+mJkzmGOhuQyFohr7vW1jc75QvvsSNC7xCkmPUJI0ywezky5VSsfY8jqjBmZq\n DOgmVAS7BTuhsIrEGtz+nPR0AoZ5Q1SPOAheIQdfNTUcdl3KqYR7rB+b6jyeXY3I7ptyXoPlQ+N\n Wq5nwnFjZDauntyi3LaPbBubVGushiM0vi0ogCoB4zt/b1fl0mkhYgV7IFeQluBy7yjUj+D2SDB\n oSZJA0oiavLI6FU2SMAZLaUO4OOhTjrgAInu0sZxtKICGPG87BOZsKXVHqmLJcztKxEQc+C56De\n Vn6khmMM7rgeYqKsBvOWDIoIopZUN0TuXceXBbal2gu33Lr+KmZgvOu8Cu1EEogtEiSOeJC+oqF\n yjYYKyjjjYwEFILpjoZSzNdo/b/J2F6YTnDaidvZwm4gb7vZR7xl5c=","X-Received":"by 2002:a05:6a00:4fcf:b0:82c:9c4e:66ca with SMTP id\n d2e1a72fcca58-82f0d0d190dmr9127151b3a.2.1776060584748;\n Sun, 12 Apr 2026 23:09:44 -0700 (PDT)","Message-ID":"<4c99eb47-ec05-4d5c-b733-77114cb10855@linaro.org>","Date":"Mon, 13 Apr 2026 16:09:39 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 21/27] monitor: Do not check TARGET_S390X to build\n s390x commands","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","References":"<20260410195323.17937-1-philmd@linaro.org>\n <20260410195323.17937-22-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260410195323.17937-22-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::435;\n envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x435.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3676537,"web_url":"http://patchwork.ozlabs.org/comment/3676537/","msgid":"<87zf37b7rf.fsf@redhat.com>","list_archive_url":null,"date":"2026-04-13T08:10:28","subject":"Re: [PATCH v2 21/27] monitor: Do not check TARGET_S390X to build\n s390x commands","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Fri, Apr 10 2026, Philippe Mathieu-Daudé wrote:\n\n> These commands are filtered at build-time for s390x binary.\n> By using the recently introduced HMPCommand::arch_bitmask flag\n> we can filter them at runtime, making it possible to compile\n> hmp-commands[-info].hx files once.\n>\n> Since the methods are used inconditionally within hw/s390x/,\n> define them in the same stub file.\n>\n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> MAINTAINERS | 1 +\n> include/monitor/hmp.h | 7 +++++++\n> monitor/hmp-target.c | 5 -----\n> stubs/hmp-cmds-hw-s390x.c | 15 +++++++++++++++\n> hmp-commands-info.hx | 6 ++----\n> hmp-commands.hx | 6 ++----\n> stubs/meson.build | 1 +\n> 7 files changed, 28 insertions(+), 13 deletions(-)\n> create mode 100644 stubs/hmp-cmds-hw-s390x.c\n\nAcked-by: Cornelia Huck ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=NZK1BkgY;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvKrG4gzYz1y2d\n\tfor ; Mon, 13 Apr 2026 18:11:58 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCCOV-0001NY-7i; Mon, 13 Apr 2026 04:11:45 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wCCNU-0001EF-Gv\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 04:10:41 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wCCNS-00087S-EI\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 04:10:40 -0400","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-39-p2UB40wqM2GMkQRHEBcGyg-1; Mon,\n 13 Apr 2026 04:10:34 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 410C5195609D; Mon, 13 Apr 2026 08:10:32 +0000 (UTC)","from localhost (dhcp-192-192.str.redhat.com [10.33.192.192])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id 10C5B19560AB; Mon, 13 Apr 2026 08:10:30 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776067837;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=CBy1Z9iAFrwDgubE854sZbP4t6wpVWhVvni7i4dtyXA=;\n b=NZK1BkgYtgzRjrGPlSNt6j7RdGskZSlFbOKmjaBobb5phe0OrbY/qiTLyP63lqECMdIZig\n aGAvLLRlAGRYUc8ecxlIZIzETJy+vGrqC/9hz2LruvAP/iFqw25ErGA+758PpoD3pg3kJH\n lnGrzyn6DJMw56rbC0QAewjxL+Ip6/U=","X-MC-Unique":"p2UB40wqM2GMkQRHEBcGyg-1","X-Mimecast-MFC-AGG-ID":"p2UB40wqM2GMkQRHEBcGyg_1776067832","From":"Cornelia Huck ","To":"Philippe =?utf-8?q?Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"Richard Henderson ,\n \"Dr. David Alan Gilbert\" ,\n Pierrick Bouvier , qemu-riscv@nongnu.org,\n Markus Armbruster , qemu-s390x@nongnu.org,\n kvm@vger.kernel.org, qemu-ppc@nongnu.org, Philippe =?utf-8?q?Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= , Eric Farman ,\n Matthew Rosato , Paolo Bonzini ","Subject":"Re: [PATCH v2 21/27] monitor: Do not check TARGET_S390X to build\n s390x commands","In-Reply-To":"<20260410195323.17937-22-philmd@linaro.org>","Organization":"\"Red Hat GmbH, Sitz: Werner-von-Siemens-Ring 12,\n D-85630 Grasbrunn,\n Handelsregister: Amtsgericht =?utf-8?b?TcO8bmNoZW4s?= HRB 153243,\n\t=?utf-8?b?R2VzY2jDpGZ0c2bDvGhyZXI6?= Ryan Barnhart, Charles Cachera,\n Avril Crosse O'Flaherty\"","References":"<20260410195323.17937-1-philmd@linaro.org>\n <20260410195323.17937-22-philmd@linaro.org>","User-Agent":"Notmuch/0.39 (https://notmuchmail.org)","Date":"Mon, 13 Apr 2026 10:10:28 +0200","Message-ID":"<87zf37b7rf.fsf@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=cohuck@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"7","X-Spam_score":"0.7","X-Spam_bar":"/","X-Spam_report":"(0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]