[{"id":3676421,"web_url":"http://patchwork.ozlabs.org/comment/3676421/","msgid":"","list_archive_url":null,"date":"2026-04-13T03:09:47","subject":"Re: [PATCH v2 04/27] monitor: Remove 'monitor/hmp-target.h' header","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/11/26 05:52, Philippe Mathieu-Daudé wrote:\n> he \"monitor/hmp-target.h\" header doesn't contain any\n> target-specific declarations anymore. Merge it with\n> \"monitor/hmp.h\", its target-agnostic counterpart.\n> \n> Signed-off-by: Philippe Mathieu-Daudé\n> Reviewed-by: Dr. David Alan Gilbert\n> ---\n> MAINTAINERS | 1 -\n> include/monitor/hmp-target.h | 42 -----------------------------------\n> include/monitor/hmp.h | 12 ++++++++++\n> hw/i386/sgx-stub.c | 1 -\n> hw/i386/sgx.c | 1 -\n> monitor/hmp-cmds.c | 1 -\n> monitor/hmp-target.c | 1 -\n> monitor/hmp.c | 1 -\n> stubs/target-monitor-defs.c | 2 +-\n> target/i386/cpu-apic.c | 1 -\n> target/i386/monitor.c | 1 -\n> target/i386/sev-system-stub.c | 1 -\n> target/i386/sev.c | 1 -\n> target/m68k/monitor.c | 1 -\n> target/ppc/monitor.c | 2 --\n> target/riscv/monitor.c | 1 -\n> target/sh4/monitor.c | 1 -\n> target/sparc/monitor.c | 1 -\n> target/xtensa/monitor.c | 1 -\n> 19 files changed, 13 insertions(+), 60 deletions(-)\n> delete mode 100644 include/monitor/hmp-target.h\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=s46mIY0P;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvC8Z5w07z1yDF\n\tfor ; Mon, 13 Apr 2026 13:10:38 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wC7gg-0002Iw-CC; Sun, 12 Apr 2026 23:10:10 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wC7ge-0002I9-9k\n for qemu-devel@nongnu.org; Sun, 12 Apr 2026 23:10:08 -0400","from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wC7gc-0000oP-Nx\n for qemu-devel@nongnu.org; Sun, 12 Apr 2026 23:10:08 -0400","by mail-pf1-x433.google.com with SMTP id\n d2e1a72fcca58-82f2385724aso934006b3a.0\n for ; Sun, 12 Apr 2026 20:10:05 -0700 (PDT)","from ?IPV6:2401:d002:dc0f:2100:a7b4:d4f1:5b23:321f?\n ([2401:d002:dc0f:2100:a7b4:d4f1:5b23:321f])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82f0c4e854fsm9589265b3a.49.2026.04.12.20.10.02\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Sun, 12 Apr 2026 20:10:04 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776049805; x=1776654605; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=f/shBeol6NdSR2RcjLmiMkLVbnFPGJITlIgbjucedfY=;\n b=s46mIY0Pzxu9SH3Koc6XzLfTWltWU7GBYUDknYH3hA94w1KiQMeLzpAxCcl52VO6he\n Q6JLMTPxvp36/tdXKbOA1EMBkUS+S/JIRG7Hv6xUpxo3/bi/fvmoKbh1aKVq+fHMbEyU\n OOrLx07fhOLlVjz3wMVreZRtn3aqA/fvmKF5LZPFvHKWwkotabCneYUz7VrBcn/LYaVZ\n bNDAQFiiEkuO1aimCT7xmfCX4MsAhpVOLDXEq29tddAnEa1llFLeYtBDkf+aaklTS0GH\n 29QDNUvz8NGURHC5MaLA9YStyK+6QcDSVj8uRw54usc1nDicN1m4SuA6hbhcOQ4k7q8W\n Xm7w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776049805; x=1776654605;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=f/shBeol6NdSR2RcjLmiMkLVbnFPGJITlIgbjucedfY=;\n b=gNdJJJcmrlNGtUjC15X5ksZUCKAzBmij1dvkWbzbsSyLObCaFPV4b8tAr6QUsC+QkD\n LrWdSH0W5ZDdVAKzNgNhcJw4o0lJvp5ahRdxk630lyPn0y6X9d6bfpgDEUa7YTpNWlRU\n xpkxrOAB+9olTwHBUiK6aV3YNet7jLJnWSnhcwriUMJpi59JMSc4jdcpm8ak7KT7EUy5\n 6X7A8L/GpKjvXa4Z+bXqmq6kbk75Ggp+7xc0n/GvA/ai1wHyy0uc16MH02p8WFYs6GRc\n d/4urYS/36Am1hPZsy4x0ak3bXr7jDdAR27j6fT17pr+viSXGq1o8/jTz7LnYVFxOI7v\n Anog==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9/3orJBmGRc341RbA+7l7AJgzhtgVB8dKfI3x/Syiiutnv2Xv3t8Tec7oIYNdXb6T6XuNyDadpEbPd@nongnu.org","X-Gm-Message-State":"AOJu0YwBkaHm/spWlFDC81GGE1yNZQpor4MRWJ9zTZDP0AMe3/3xNHsK\n KnSGe9mcNMc2X01k1FIYb1hpcmtRBZ410ogBd2IaHPRXd0BrOnJfRCLKVgF/6rNUR0A=","X-Gm-Gg":"AeBDieu5O6lln+vZ7AYIMz5/W4Xotx6S1TVLy+VtOqKJ9G9nUn3S69Wt9xpNee5LWwX\n dZRKLJLw4GS4r6gyq2QjQdc482NfTIyWM/z4Zo/uoYjdnhMkxrbMhzfex6gC8bFfyYhSfumrbkA\n wGB+WMFPC17HxUDn3lGhSjgPcwHTU2UOGr9+cX4qmrl+gCR6H5g6O1Tdn+rnSS1+bDJzT2GBZBh\n L9GAUmEGJ91iK+MwHbirrrC9l3aZ6Nqs5/1czyjC+RIW3slQWUtKB2KXuas6CAwz0O6KUSDWcUW\n +tr4bQ5irDWfd2m75WheEV0t+1YUmjsDACnFcQGcqaybVZYwIowyWHOUCf68eSIfxv8NdEmCfva\n ZyUufsfOYfbdwySdFrd+1PfglQq2hJ1NGa0gC+A94++Xbj+NG30UWuuwWXqvntCjG73hTWvnzgQ\n Mxd6uymA8hhkrGSEkqQ0NbpTxXn2gVfJXQIiWrzM/W3A9qUA3N3We/F+Jm6EUjlDUc86L90CsTl\n YL/BZDYDiyYWQ==","X-Received":"by 2002:a05:6a00:1ad1:b0:82c:e4b9:531c with SMTP id\n d2e1a72fcca58-82f0c1e6575mr11662172b3a.7.1776049804492;\n Sun, 12 Apr 2026 20:10:04 -0700 (PDT)","Message-ID":"","Date":"Mon, 13 Apr 2026 13:09:47 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 04/27] monitor: Remove 'monitor/hmp-target.h' header","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","References":"<20260410195323.17937-1-philmd@linaro.org>\n <20260410195323.17937-5-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260410195323.17937-5-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::433;\n envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x433.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]