[{"id":3676450,"web_url":"http://patchwork.ozlabs.org/comment/3676450/","msgid":"<59998758-bdb0-405d-a0ff-83bd54ad5a5d@linaro.org>","list_archive_url":null,"date":"2026-04-13T05:06:19","subject":"Re: [PATCH v2 20/27] hw/s390x: Reduce 'monitor/monitor.h' inclusions","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/11/26 05:53, Philippe Mathieu-Daudé wrote:\n> We want to make the HMP commands available for all targets,\n> move the declarations to \"monitor/hmp.h\" where all other\n> are, and only include the monitor headers in the source files.\n> \n> Signed-off-by: Philippe Mathieu-Daudé\n> ---\n> include/hw/s390x/storage-attributes.h | 4 ----\n> include/hw/s390x/storage-keys.h | 3 ---\n> include/monitor/hmp.h | 5 +++++\n> hw/s390x/s390-skeys.c | 2 ++\n> hw/s390x/s390-stattrib.c | 2 ++\n> 5 files changed, 9 insertions(+), 7 deletions(-)\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=GTB+1uYf;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvFlL2TGFz1xtJ\n\tfor ; Mon, 13 Apr 2026 15:07:24 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wC9VG-0004tm-Sj; Mon, 13 Apr 2026 01:06:30 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wC9VF-0004rs-Bz\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 01:06:29 -0400","from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wC9VD-0007ZT-TS\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 01:06:29 -0400","by mail-pf1-x42a.google.com with SMTP id\n d2e1a72fcca58-82cebbdab08so3074651b3a.2\n for ; Sun, 12 Apr 2026 22:06:27 -0700 (PDT)","from ?IPV6:2401:d002:dc0f:2100:a7b4:d4f1:5b23:321f?\n (bg30dj032xp6rdh0yngy.ip6.superloop.au.\n [2401:d002:dc0f:2100:a7b4:d4f1:5b23:321f])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82f0c36130csm9828910b3a.24.2026.04.12.22.06.23\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Sun, 12 Apr 2026 22:06:25 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776056786; x=1776661586; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=fSoNfsSvDYmTGidkH+WfEiZmjKBr48rGJ/dRvhy+ejA=;\n b=GTB+1uYfVm6yyxIJHlpSInjrE08//l3CdlzJdO+XxDYEzvaC2szriE1roAV0nCnsbO\n Coy0DclAxLUU+cc8+Ly9GcuJ7CrYDXpEoVJb2ymb99rd70yDat3KNSMT2BhPYqYd6Gdl\n qsMd6S7qFroQGNF5wWmtJxB2uubR1qsisINxiW7ITbU6E7KlRzWzRc4FbxEhtiuZvxir\n i0iHI9q5xQiniKOS/ISQohk6ePw3D5q+FeiB2xUPr5lmkKAhoetW/cKStKIuC9vroPzW\n uPVKunZMe4DtT6njvUPCMWtoUQM7ki+rzqyVHbZMfuguQ2RzZIDS2YqHQE6bxEcW9/jw\n C5TA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776056786; x=1776661586;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=fSoNfsSvDYmTGidkH+WfEiZmjKBr48rGJ/dRvhy+ejA=;\n b=GdSLE167OgogJ3iqZspZpM+IoFsgwuaLgv65GGRnyDK6FogfUzFRVQvxFsaxTdT+c+\n sBAQIbLPVz6wNABrsmTFhamMci0GOpQ8Rroqpzh7iadddSgco6+bEZ/07J2s/zI1Tlvi\n 8NR6o5PzvmiSKEhgZ7W865Z2Po2m3709QSpb0q5e2hqpZPswWZokL8j4H3ktw2hv6YJE\n mE+DYvU0rmTdEzSmOyaQwc8F69s8HwCNhHx5Fg/7z+yJ3ZGJWkDsIfS+FoDzzs21GX0b\n ij7cBpmEKtXyuWOSPt0j41W95Vvy6BvE1BT3PW1NT+sIHXno888NOs0ESS3K9+Wcp8n3\n y99A==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9surqe54gz8QwCmmfPvINNIj4CMLgyDNa+qoysjSrvGR8/IhXfxHCf/gq9S+feQtJwmffwheJU05r7@nongnu.org","X-Gm-Message-State":"AOJu0Yx810SVdS7gSNkIM/9s+4NwhOXamLdpMc7aOttDl/HVqgxZaFVz\n Kcurr+JhEeGpSTP0iNfZ3m0KZeAJDP024PhRmLmJ32DykcJcYDsn3SEsPaJ7uC3YrZE=","X-Gm-Gg":"AeBDievGL2NWDZapM82KAfXiQ9Tx8eTBxilwmobIRE9fbLy9pOKmWA426DIiiU6Kfps\n I0pPSnFf4WgEKvojx4klaEJbT0v2uuU8WcSjkoBDoretnmFcnpHq/T8MUlx1f7krPMjhpKNi6dx\n tm8vw7jmYQVIDnq7bWJxLmDGJF4rxESfCW33Tvv/aBp9YbWyc8GHDMQfZhtygw/JXp25e4QoeJV\n yBjuOOzXwjM5GEiYVaCBFJXBMABK83z3knzGj2pfEJL1VNnc5RBx2Y7WDsU9YNMuyCSzOTQ6S9Y\n f0J3UC5QD6uZiRWyDukTb7BTtVNu7fyTZsKujofTawS4UPflTUBZT6+hNpF1r+iQhCtKx+3/38d\n uI57zy+CUCrPCtNZFH6DQXz8J+FswcRTGsIzGCA1+wuQGwJwRaGOA0i/tDoZypvIRhNmN0eHCDt\n GvG/9CMzIaX4b0i0IdwFV900WlxtLCvKhvvC4kj9Yu3ZnLRxvBQnuuyiD3safcnhd6m8V/PsZrh\n iCzZdKSa52CCXC+Ohpx8FJl2uX0u/94z3+od0ZdY9VKaF2TlUtL5q0=","X-Received":"by 2002:a05:6a00:2c94:b0:82f:4628:4198 with SMTP id\n d2e1a72fcca58-82f46284fc1mr874450b3a.31.1776056785798;\n Sun, 12 Apr 2026 22:06:25 -0700 (PDT)","Message-ID":"<59998758-bdb0-405d-a0ff-83bd54ad5a5d@linaro.org>","Date":"Mon, 13 Apr 2026 15:06:19 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 20/27] hw/s390x: Reduce 'monitor/monitor.h' inclusions","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","References":"<20260410195323.17937-1-philmd@linaro.org>\n <20260410195323.17937-21-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260410195323.17937-21-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::42a;\n envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42a.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3676532,"web_url":"http://patchwork.ozlabs.org/comment/3676532/","msgid":"<87340zcmfl.fsf@redhat.com>","list_archive_url":null,"date":"2026-04-13T08:08:14","subject":"Re: [PATCH v2 20/27] hw/s390x: Reduce 'monitor/monitor.h' inclusions","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Fri, Apr 10 2026, Philippe Mathieu-Daudé wrote:\n\n> We want to make the HMP commands available for all targets,\n> move the declarations to \"monitor/hmp.h\" where all other\n> are, and only include the monitor headers in the source files.\n>\n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> include/hw/s390x/storage-attributes.h | 4 ----\n> include/hw/s390x/storage-keys.h | 3 ---\n> include/monitor/hmp.h | 5 +++++\n> hw/s390x/s390-skeys.c | 2 ++\n> hw/s390x/s390-stattrib.c | 2 ++\n> 5 files changed, 9 insertions(+), 7 deletions(-)\n\nAcked-by: Cornelia Huck ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=f7EyA2Rj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvKn55W6Dz1yDF\n\tfor ; Mon, 13 Apr 2026 18:09:13 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCCLN-0000Pt-Jk; Mon, 13 Apr 2026 04:08:29 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wCCLL-0000Oa-V3\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 04:08:27 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wCCLJ-0007aJ-GL\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 04:08:27 -0400","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-333-CbAt4Kt1MCe1UpMGu5q7jg-1; Mon,\n 13 Apr 2026 04:08:19 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 4C64B1801230; Mon, 13 Apr 2026 08:08:17 +0000 (UTC)","from localhost (dhcp-192-192.str.redhat.com [10.33.192.192])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id 1C86130001A1; Mon, 13 Apr 2026 08:08:15 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776067703;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=c3BQ9t6JgJ/XtutcXu6VPOQdYVtWZ1yKAaamJ9ZbD3E=;\n b=f7EyA2RjDQOIeDYOW8svitQnGBRHfLpKuv+TvsmX+x0wr/tuSOyCS5LSlLid3sm2puACp7\n U4RsYZ/YCgVABSQfYesHjxFoYG7gMk8ZZoT/7Qj8n8oQfGz4J7CSz50WbAsODuTtm5Ml1z\n x65PEa3mg4doItwKmXv5HzymGARdE8U=","X-MC-Unique":"CbAt4Kt1MCe1UpMGu5q7jg-1","X-Mimecast-MFC-AGG-ID":"CbAt4Kt1MCe1UpMGu5q7jg_1776067697","From":"Cornelia Huck ","To":"Philippe =?utf-8?q?Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"Richard Henderson ,\n \"Dr. David Alan Gilbert\" ,\n Pierrick Bouvier , qemu-riscv@nongnu.org,\n Markus Armbruster , qemu-s390x@nongnu.org,\n kvm@vger.kernel.org, qemu-ppc@nongnu.org, Philippe =?utf-8?q?Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= , Halil Pasic ,\n Christian Borntraeger ,\n Jason Herne , Eric Farman ,\n Matthew Rosato ,\n Ilya Leoshkevich , David Hildenbrand ","Subject":"Re: [PATCH v2 20/27] hw/s390x: Reduce 'monitor/monitor.h' inclusions","In-Reply-To":"<20260410195323.17937-21-philmd@linaro.org>","Organization":"\"Red Hat GmbH, Sitz: Werner-von-Siemens-Ring 12,\n D-85630 Grasbrunn,\n Handelsregister: Amtsgericht =?utf-8?b?TcO8bmNoZW4s?= HRB 153243,\n\t=?utf-8?b?R2VzY2jDpGZ0c2bDvGhyZXI6?= Ryan Barnhart, Charles Cachera,\n Avril Crosse O'Flaherty\"","References":"<20260410195323.17937-1-philmd@linaro.org>\n <20260410195323.17937-21-philmd@linaro.org>","User-Agent":"Notmuch/0.39 (https://notmuchmail.org)","Date":"Mon, 13 Apr 2026 10:08:14 +0200","Message-ID":"<87340zcmfl.fsf@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=cohuck@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]