[{"id":3676034,"web_url":"http://patchwork.ozlabs.org/comment/3676034/","msgid":"<02d3f91e3f199ae2863223205d2498751b733e9a.camel@infradead.org>","list_archive_url":null,"date":"2026-04-10T20:03:23","subject":"Re: [PATCH v2 17/27] monitor: Make Xen emulation commands generic\n ones","submitter":{"id":26,"url":"http://patchwork.ozlabs.org/api/people/26/","name":"David Woodhouse","email":"dwmw2@infradead.org"},"content":"On Fri, 2026-04-10 at 21:53 +0200, Philippe Mathieu-Daudé wrote:\n> In order to build hmp-commands.hx once we need to stop using\n> device target-specific check. Use the generic pattern to make\n> the command available on all targets, providing a stub with\n> kind error message when the feature is not available.\n> \n> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n\nAcked-by: David Woodhouse <dwmw@amazon.co.uk>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256\n header.s=desiato.20200630 header.b=SLNRpWpj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsnnQ3vG0z1yGS\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 11 Apr 2026 06:04:10 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wBI4s-0000VI-Dx; Fri, 10 Apr 2026 16:03:42 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from\n <BATV+40a191e5bd4967edb234+8265+infradead.org+dwmw2@desiato.srs.infradead.org>)\n id 1wBI4q-0000Ud-AP; Fri, 10 Apr 2026 16:03:40 -0400","from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from\n <BATV+40a191e5bd4967edb234+8265+infradead.org+dwmw2@desiato.srs.infradead.org>)\n id 1wBI4m-0007QP-Jh; Fri, 10 Apr 2026 16:03:40 -0400","from [172.31.31.148] (helo=u09cd745991455d.lumleys.internal)\n by desiato.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux))\n id 1wBI4a-0000000EBfm-0Qv1; Fri, 10 Apr 2026 20:03:24 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n d=infradead.org; s=desiato.20200630; h=MIME-Version:Content-Type:References:\n In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:\n Content-Transfer-Encoding:Content-ID:Content-Description;\n bh=BfeL/q27vFubqbVDSUFubDSRXIjwf0FMBPuEJmujvkQ=; b=SLNRpWpjeVr4Z3J/ySNS5/bxeb\n wUvJ9ZIrkONkoDNbjYmbt/XDzOoLuycMJ9YcnJdJ5XBGdniETxq+EmEVVLxm5p4BnXFV3W651hhz6\n 2vefS8+zNLh47D7rkgBKHfgR5a69aNQCBg7KvRG+4ogrJ+tbdPhzY1LzqqVN3Sz3OHqx07AgOljuJ\n G5BskdfHYWjVdCWlO+hl9tYQnzVVu4cTdraUQcDLBsEzGphu1i8fLwhlZzHpJMQBsaAFGu3kt4lby\n /KI7HM+saiwbNub5W1VzHr7eXNPw8aGyHb2Lx1uT7xo7XdaXFeQlv4spXJXPs4w/NOW2JoMKSO2js\n LXXoW1KA==;","Message-ID":"<02d3f91e3f199ae2863223205d2498751b733e9a.camel@infradead.org>","Subject":"Re: [PATCH v2 17/27] monitor: Make Xen emulation commands generic\n ones","From":"David Woodhouse <dwmw2@infradead.org>","To":"Philippe =?iso-8859-1?q?Mathieu-Daud=E9?= <philmd@linaro.org>,\n  qemu-devel@nongnu.org","Cc":"Richard Henderson <richard.henderson@linaro.org>, \"Dr. David Alan\n Gilbert\" <dave@treblig.org>, Pierrick Bouvier\n <pierrick.bouvier@linaro.org>, qemu-riscv@nongnu.org,  Markus Armbruster\n <armbru@redhat.com>, qemu-s390x@nongnu.org, kvm@vger.kernel.org,\n qemu-ppc@nongnu.org, Paul Durrant <paul@xen.org>, Paolo Bonzini\n <pbonzini@redhat.com>, \"Michael S. Tsirkin\" <mst@redhat.com>, Marcel\n Apfelbaum <marcel.apfelbaum@gmail.com>","Date":"Fri, 10 Apr 2026 21:03:23 +0100","In-Reply-To":"<20260410195323.17937-18-philmd@linaro.org>","References":"<20260410195323.17937-1-philmd@linaro.org>\n <20260410195323.17937-18-philmd@linaro.org>","Content-Type":"multipart/signed; micalg=\"sha-256\";\n protocol=\"application/pkcs7-signature\";\n boundary=\"=-uGPYLPTuULVdQjXKA3Go\"","User-Agent":"Evolution 3.52.3-0ubuntu1.1 ","MIME-Version":"1.0","X-SRS-Rewrite":"SMTP reverse-path rewritten from <dwmw2@infradead.org> by\n desiato.infradead.org. See http://www.infradead.org/rpr.html","Received-SPF":"none client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05;\n envelope-from=BATV+40a191e5bd4967edb234+8265+infradead.org+dwmw2@desiato.srs.infradead.org;\n helo=desiato.infradead.org","X-Spam_score_int":"-43","X-Spam_score":"-4.4","X-Spam_bar":"----","X-Spam_report":"(-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001,\n SPF_NONE=0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3676443,"web_url":"http://patchwork.ozlabs.org/comment/3676443/","msgid":"<1909e5aa-ed18-49a2-b196-7def6772062e@linaro.org>","list_archive_url":null,"date":"2026-04-13T04:20:10","subject":"Re: [PATCH v2 17/27] monitor: Make Xen emulation commands generic\n ones","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/11/26 05:53, Philippe Mathieu-Daudé wrote:\n> In order to build hmp-commands.hx once we need to stop using\n> device target-specific check. Use the generic pattern to make\n> the command available on all targets, providing a stub with\n> kind error message when the feature is not available.\n> \n> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n> ---\n>   hw/i386/kvm/xen-stubs.c | 12 ++++++++++++\n>   hmp-commands.hx         |  2 --\n>   2 files changed, 12 insertions(+), 2 deletions(-)\n\n\n\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\n\n\nr~","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=EiHp0Xqj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvDk21R6wz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 13 Apr 2026 14:21:12 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wC8mf-0007nz-0K; Mon, 13 Apr 2026 00:20:25 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wC8ma-0007km-6q\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 00:20:22 -0400","from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wC8mY-0006Jg-II\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 00:20:19 -0400","by mail-pl1-x632.google.com with SMTP id\n d9443c01a7336-2b2429f98d0so24709065ad.2\n for <qemu-devel@nongnu.org>; Sun, 12 Apr 2026 21:20:17 -0700 (PDT)","from ?IPV6:2401:d002:dc0f:2100:a7b4:d4f1:5b23:321f?\n (bg30dj032xp6rdh0yngy.ip6.superloop.au.\n [2401:d002:dc0f:2100:a7b4:d4f1:5b23:321f])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b2d4f25d83sm101957875ad.58.2026.04.12.21.20.13\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Sun, 12 Apr 2026 21:20:15 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776054016; x=1776658816; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=LNw0hoKQ41WblOWVXhwtYC1W/5fGL0BV9AzWD94r4e0=;\n b=EiHp0Xqj043T7DahHHkcBxxKCpA0SKbaW+bt25sXZFP14c4O5ABcOz2fhegEFYlAWC\n O3Lz9cLnytXYhJil49IuAzkAxzdXJGMt0GtRoAxQeJmwE3Ni+SNcMrQKkvfeq+1nvBHu\n Yxos6EfgF2aOhDFacJnwooE0JJpBlzxcamI9YodAegPysJXUiaaoGHxl0RdMLlCe+ncx\n 3VLOc3aZ0PisYfziVc7qhUMjGSAufnF/TbcIV8avdovGmG5vTlJqkSrudDNkLYHLtR2Q\n 3yJKViO1hA1Pg+y/L9n1AHtu8Gpqyik/jzwBZiwIXrBu1+r07Mt0UREpbDG5EHxfHYol\n W1FQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776054016; x=1776658816;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=LNw0hoKQ41WblOWVXhwtYC1W/5fGL0BV9AzWD94r4e0=;\n b=ls+cAoX+xnTri4bs6nlmNjBB8w3TFVWMqgXaOO+yNWey+VEjo8pOEL5wW3IHw1+WLD\n ybn38ZT3JMLfyPAADqMUIHfFkgjbEqYuyOE08V93If/TVyMICGwNpZ8H3tz8C6DJomH/\n tX/RGvtUxGmYFDa+Qfc4eIDMicoGZZ6NgtRp/Q5CdPPOwXF0DsxymfhL4snufR0u/hoS\n 4eDzqULXwxHSm5BhOYXnZ63eKCcJ+/BgW4AtYidBObGguLGWEww0PeFg5t8CgKgIjQSV\n RI4+yhZtXpd0YozmX2KBvOovuBORZzEk200HIKcfcf3kyf4ZLp/+i7roczLTX+qZa5d9\n p+Bg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9k8skTpE/8pFmOQsMhcdsVeHdV/6Ubm3Pd01M5nJBSPuDebh5zUxA053YRir8UKv0LGL8bppjGc/HD@nongnu.org","X-Gm-Message-State":"AOJu0YzRwHOPBmpFNqbYllEnTDFnNVqPycHUhnyZq2LIQQ91hU3C5KxL\n LoVduZ95uwzswJ6DyD7xzatNDRdIGfulhe80ATQ0mAWkQsd/L99YDbrSz4/I2bF0bQA=","X-Gm-Gg":"AeBDievPhfa0O1Zs+TxIexoEiUNXaxw3SXi+XOKqTiZgwPT0UX1ZNHIZl8yQiH0vcSI\n wZLLSVvWm9/uLt3XFA7V1b0Tel6UJLNtC4Lg/HYo7RiXx3KZvw/N7yBg3MV8JMs/iHZZ5nISPAG\n xT+XVqhYDFfpnV5LQ0JGnqj3rJ4bnXFAX6qKQzXlFGerLt9OiytTIlgoXjdHiNkJM3O40W8Ey+R\n 38Xi/2YGZaKOrQXMhGXjOcNTvjayXw3NVoBP7grO9I3BgDwHg8UCT8Mr4Qk4R+U9ZDU9ooJ7ukA\n 9sG6XERlcDbs8epAaMvXN5MPJHLujyRoA9B//HsQv8a703k5CvPGOOzI/TFMUf0xLVlb/GeDSCN\n g/UUhfjTMm+areOM+qBcWaUdxYfBVkudxG/gyPZOXJORIsBcL2Q9ogSLKv2fsMw6sP2ccIrV56e\n w54uDEcGJ0uGD4V9FIg+H7DZxd7Y9XihZIdwwavVFMhwxikrGg0AJJWXpy9uaS8hfyr8gw5UlCG\n kOf+aMel56x61LZeddG9cygadlG6/VwN/CE6dZ7FtizQC80R0+R9i8=","X-Received":"by 2002:a17:902:6acb:b0:2b0:5520:f497 with SMTP id\n d9443c01a7336-2b2d591ddc8mr89663365ad.9.1776054015513;\n Sun, 12 Apr 2026 21:20:15 -0700 (PDT)","Message-ID":"<1909e5aa-ed18-49a2-b196-7def6772062e@linaro.org>","Date":"Mon, 13 Apr 2026 14:20:10 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 17/27] monitor: Make Xen emulation commands generic\n ones","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n qemu-devel@nongnu.org","References":"<20260410195323.17937-1-philmd@linaro.org>\n <20260410195323.17937-18-philmd@linaro.org>","From":"Richard Henderson <richard.henderson@linaro.org>","Content-Language":"en-US","In-Reply-To":"<20260410195323.17937-18-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::632;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x632.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]