[{"id":3676415,"web_url":"http://patchwork.ozlabs.org/comment/3676415/","msgid":"<1fc32181-c4ad-48f5-80ff-d9195d6206c7@linaro.org>","list_archive_url":null,"date":"2026-04-13T02:54:36","subject":"Re: [PATCH v2 03/27] monitor: Reduce target-specific methods further","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/11/26 05:52, Philippe Mathieu-Daudé wrote:\n> get_monitor_def() doesn't use any target-specific declaration\n> anymore, move it to hmp.c to compile it once.\n> \n> Signed-off-by: Philippe Mathieu-Daudé\n> Reviewed-by: Dr. David Alan Gilbert\n> ---\n> monitor/monitor-internal.h | 1 -\n> monitor/hmp-target.c | 39 -------------------------------------\n> monitor/hmp.c | 40 ++++++++++++++++++++++++++++++++++++++\n> 3 files changed, 40 insertions(+), 40 deletions(-)\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=sZIQD8/U;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvBpq5JcPz1yDF\n\tfor ; Mon, 13 Apr 2026 12:55:15 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wC7Rq-00086H-Jd; Sun, 12 Apr 2026 22:54:50 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wC7Rp-00085c-DV\n for qemu-ppc@nongnu.org; Sun, 12 Apr 2026 22:54:49 -0400","from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wC7Ro-0006J9-1u\n for qemu-ppc@nongnu.org; Sun, 12 Apr 2026 22:54:49 -0400","by mail-pg1-x52d.google.com with SMTP id\n 41be03b00d2f7-c6dd5b01e14so1409085a12.0\n for ; Sun, 12 Apr 2026 19:54:47 -0700 (PDT)","from ?IPV6:2401:d002:dc0f:2100:a7b4:d4f1:5b23:321f?\n ([2401:d002:dc0f:2100:a7b4:d4f1:5b23:321f])\n by smtp.gmail.com with ESMTPSA id\n 41be03b00d2f7-c7921a20100sm8215970a12.29.2026.04.12.19.54.40\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Sun, 12 Apr 2026 19:54:45 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776048886; x=1776653686; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=4qQhs7WN5alTmwzimUY/uITGqs+KMD+QkfagNZ5IPKk=;\n b=sZIQD8/UGzBX2RauLRfaWcER8zR0WtK47D1xm9ppulyFq2PjJIbdvEAr+RWfvJtVuS\n FAioT/+PPM1YmxYv5CqF47w3yzDjgHYrdiFNjU2mTctyTUrbC6c6rzhtaypFzjKV4Tao\n K2XSXboPREEsPEjb4GDuxmWVlWv+4+VgCoBbOzp2OjFh4x36aA728Tw8UxEBXJeEm44p\n ZZJXLZyhw45MneYBopNR1A8bAxT1skKxXFaMqu/2B8UFVLuuIujJw3Ub7ONSaWBuiFaU\n 0DOHDJttQ88xkEyy1mVMgeDbrzvCrpogYn5+KAGfuY1+SuPMyq/gOK+J3CZ/OZt04Mbj\n i3Mw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776048886; x=1776653686;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=4qQhs7WN5alTmwzimUY/uITGqs+KMD+QkfagNZ5IPKk=;\n b=NLVepeMQ4i22hSTuz6lHTALM4pPK71nCTIzYjOV7h2L/Yak3DkpIGFZw7MzUpPjIMd\n 2e5xKpKuI6n+hubZu4C9Dngqy2jTIvugHbsDTZcRg56MDKTssFXD5O4CeQpcpd679sRX\n upemVxnp/Nz6udN9Y9fJJlMqnAZqnkbNfEfoWGxKFM19R9vxMFPZGQLTubcCAeateU6A\n /Krgw0oXp84UjwmznPQ7HCNc3q1SRlCyuT9a/hswHgR/ldSbQdp8LyolmVf01PN8OghA\n RxOrSVwdOsIVD+Xmi3a02X6bWyyjinECZVAQkxlW1/TH3GmkYzDaTak2O4QlRXYBUUTr\n YiAg==","X-Forwarded-Encrypted":"i=1;\n AJvYcCX2GrzZBeQbZ9aPWpdn1HzuSYoBlTijs63G3lAC7pZ7gB/ieZC6s/uhDbClie1dKB3TjkZy9IDdiw==@nongnu.org","X-Gm-Message-State":"AOJu0Ywpfqb3zaLTmmkUqEw/wUdRT2uCGRjSP8N4apOcwIg9ThEWHEjA\n 0M9RPz3ko0WpjNnkwnpn9omDQDe/USapXl5ZYrKztDXSBafM/h1YTe4HzN800Nsjaus=","X-Gm-Gg":"AeBDieu5UHYR5QhHZZBqC0DB+rWWU88sJB3jioJKsLQY8od5AcDn9roB5fD5+jN0JAM\n V679l8AZ9YyZT2d0IL/YCvYwivzM5LjfuBaF5rJN8dH34bzwOIev0rmi+zXeCalCKKDKCooURGQ\n FnGdGZ8ZiF3uodXMv3FqnegeL6O/7hjwinekdKDeUowy/7nxlwynbARX3mTyCIG+gHo2NYCz1kT\n cwsgrukHIxAnHtyK9jjraXlofPxMtioiSApy0W+5UXR1m5/ZdF4HPZKZA2EnH96hoj5l5w+T+iQ\n J5IYMKTDSnz+h8qJszAHJGDxzjAyAjp1CR07DxmvYWrk/VS+znjwDvmC5rqZi7Ga590IeGagqvb\n m6BrlYdEVcpTab6tG76LmDr/1fYXmuGfLzo1hNpeaxE9OZdPUdzwvWfnIp6fUn83ePzzGd7GfZl\n tpwshGoJ2M4pE9u0UmFuU6MbDL+kwciwyOlr87qHcGwmGa4PA1RqoSoow6mD4KW1V8ORAOxHyUG\n CMHixKZNtsIiA==","X-Received":"by 2002:a05:6a20:7f89:b0:398:7855:3e33 with SMTP id\n adf61e73a8af0-39fe409bbc8mr13028622637.56.1776048886144;\n Sun, 12 Apr 2026 19:54:46 -0700 (PDT)","Message-ID":"<1fc32181-c4ad-48f5-80ff-d9195d6206c7@linaro.org>","Date":"Mon, 13 Apr 2026 12:54:36 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 03/27] monitor: Reduce target-specific methods further","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"\"Dr. David Alan Gilbert\" ,\n Pierrick Bouvier , qemu-riscv@nongnu.org,\n Markus Armbruster , qemu-s390x@nongnu.org,\n kvm@vger.kernel.org, qemu-ppc@nongnu.org","References":"<20260410195323.17937-1-philmd@linaro.org>\n <20260410195323.17937-4-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260410195323.17937-4-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::52d;\n envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52d.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-ppc@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]