[{"id":3676416,"web_url":"http://patchwork.ozlabs.org/comment/3676416/","msgid":"<23fa80fc-52e7-4a56-984e-1b87e80969ac@linaro.org>","list_archive_url":null,"date":"2026-04-13T02:54:08","subject":"Re: [PATCH v2 02/27] monitor: Remove target_long use in\n get_monitor_def()","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/11/26 05:52, Philippe Mathieu-Daudé wrote:\n> Truncate manually, removing the need of target-specific\n> code in get_monitor_def().\n> \n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> monitor/hmp-target.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/monitor/hmp-target.c b/monitor/hmp-target.c\n> index 812714ada01..b9b79e8e927 100644\n> --- a/monitor/hmp-target.c\n> +++ b/monitor/hmp-target.c\n> @@ -93,7 +93,7 @@ int get_monitor_def(Monitor *mon, int64_t *pval, const char *name)\n> \n> ret = target_get_monitor_def(cs, name, &tmp);\n> if (!ret) {\n> - *pval = (target_long) tmp;\n> + *pval = target_long_bits() == 32 ? (int32_t)tmp : tmp;\n> }\n\nLikewise force the target to deal with int64_t.\nThere is only one user: riscv.\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=EPuJ74Ja;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvBpy5fCbz1yDF\n\tfor ; Mon, 13 Apr 2026 12:55:22 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wC7RS-0007yp-AA; Sun, 12 Apr 2026 22:54:26 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wC7RR-0007ya-Ao\n for qemu-devel@nongnu.org; Sun, 12 Apr 2026 22:54:25 -0400","from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wC7RP-0006F8-Le\n for qemu-devel@nongnu.org; Sun, 12 Apr 2026 22:54:25 -0400","by mail-pj1-x102a.google.com with SMTP id\n 98e67ed59e1d1-35d971fb6f1so3302779a91.0\n for ; Sun, 12 Apr 2026 19:54:23 -0700 (PDT)","from ?IPV6:2401:d002:dc0f:2100:a7b4:d4f1:5b23:321f?\n (bg30dj032xp6rdh0yngy.ip6.superloop.au.\n [2401:d002:dc0f:2100:a7b4:d4f1:5b23:321f])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-35e4133695bsm13543325a91.13.2026.04.12.19.54.14\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Sun, 12 Apr 2026 19:54:21 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776048862; x=1776653662; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=YRZzF1molMiU0mAe7mBsbNpM+GuMrYExyMffQk1r0Q4=;\n b=EPuJ74JaQPD/locpmWITFXwSRJrmY55CYjJqyQ5kPDo6jdAwgkCLL9IvwfDzKjnruw\n G49pZ6viaLu+jMK7ogeHFo7HDf3MFcUk9s26gdFqT1cpMqPGyr00OhUluazvLVi+b3RW\n iQHuAJD3OV5ymplY4Gh8xjzVfTtDUBtkLp/OL816DktjQQTmfm/Zegvw/8oU349fbfO1\n teSyNyNs+bxDUby2ZChpEBRyQNXZwv1KcGlutMTiq+Tpj7K6mfEmvegxRgpfghh3FMO5\n 7EwJ6EPbtqt9A32ipMi0K/9xeLJyRSzPCWLxYpF0UtsEOSZ8LFDZYxr7dObi9qPqBs/0\n QyTA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776048862; x=1776653662;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=YRZzF1molMiU0mAe7mBsbNpM+GuMrYExyMffQk1r0Q4=;\n b=N4NSZym8pK/uY5cNvhUSpxXP5092ogSYMtBpoXb9J5FPrgU2nXUQf3CHkDrLni/IcE\n Hc4XT4DQR4noajb8vYe1eR1mTbLihZUrHxIx8ZDpJa3MoEIIOoCl+cyDuf8nlgfyM/UI\n 9j9ZDha3XayzBw+CLC11rZYrHEcPk5g998TM6+9hLKT7alDXfMXon+m8a2lCpzDFNz7H\n RhFZ025/AWQBPjBLzk+DNSYGNJRwBIDaE92Z69dS8igr42CH9QL6JhysDBOsEoCJtjAm\n CYUDf3m2u5Bh7BBtaJ32oXoR2ZlhOvpeZqdmLUg5T6vhFkOK4CfFYmGWSzhIGaGKT7G1\n XfQw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ96UWbilQEn2ZMWKEKbNwt0n2QWdxkLK/N5jOIbu8kpSzUM2zASBgWL9DCZ7B1k5dnMFbwyMX1bec+G@nongnu.org","X-Gm-Message-State":"AOJu0YzngrxGQwIV87fK1Ssan6DULhxm1bOozr/KfyUis6MLf4UO5CEd\n /+bYiPVh9yrwqFX2bgP2jvrvSWBpQHegKKgGOIUTTmqf5iwxo1UsOEQ+AczNEuKHcUc=","X-Gm-Gg":"AeBDietVwFFkyVokpW4bByXTW/Dw4knmYeuT/rj2lG9Yrpd9yyOm6RphDJlMhVxsZ+W\n TJ7+fWRzCtrs+LBZPNeN67EXcGWYmJMoHorjliroDOYLcnrCd6vsX4xzTVBiMLfj7l5CMnjccSL\n A6fyYNLYLjuCnfKCyMNGwfAIZvLi64xDUZcp306LvfzVI38BzXt8ndHSYICIyMVLWRwATmnRQj3\n R3u1gwrg7cA08zn7RgQPkTTqkzGJ8VAcd3JHWWYbCBbOB1EbYsFoAhnVBz1dw8X/LCdFl5x+E+3\n MXiaZK98K9CNtAM5uEqodpfNQ+G4QOgHPcns27z23kdrCLEKsdxC8uwEwmZZF7xDYJdvep1UuVg\n b+xguaC7XZxfQUVKMx98YC8m8ObeQ5h2+zI0PynSvkO0eOnGNuCG3+oRZduG8Lx5fjxIU9DwDGM\n sa2bTcgpdeAzonKY9awhFUU8vSIWKReD+6QxYedqeu2T2CSIQVMiF/UWdQLneBttz5mwVHdUOWM\n g+RYGJ2vy9ed4/PbiBmpfDHFEsVj+oAFAtNqINo6V+5xGBXWF1LZig=","X-Received":"by 2002:a17:90a:d610:b0:35b:929f:7e95 with SMTP id\n 98e67ed59e1d1-35e42769f6bmr11324920a91.4.1776048861574;\n Sun, 12 Apr 2026 19:54:21 -0700 (PDT)","Message-ID":"<23fa80fc-52e7-4a56-984e-1b87e80969ac@linaro.org>","Date":"Mon, 13 Apr 2026 12:54:08 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 02/27] monitor: Remove target_long use in\n get_monitor_def()","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"\"Dr. David Alan Gilbert\" ,\n Pierrick Bouvier , qemu-riscv@nongnu.org,\n Markus Armbruster , qemu-s390x@nongnu.org,\n kvm@vger.kernel.org, qemu-ppc@nongnu.org","References":"<20260410195323.17937-1-philmd@linaro.org>\n <20260410195323.17937-3-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260410195323.17937-3-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::102a;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102a.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]