[{"id":3676422,"web_url":"http://patchwork.ozlabs.org/comment/3676422/","msgid":"<8f06d37b-111e-4255-8830-b63e5c8b143b@linaro.org>","list_archive_url":null,"date":"2026-04-13T03:10:27","subject":"Re: [PATCH v2 05/27] monitor: Forward-declare the MonitorDef type","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/11/26 05:52, Philippe Mathieu-Daudé wrote:\n> Rather than having core header forced to include \"monitor/hmp.h\"\n> to get the MonitorDef type declaration, forward-declare it in\n> \"qemu/typedefs.h\".\n> \n> Signed-off-by: Philippe Mathieu-Daudé\n> ---\n> include/monitor/hmp.h | 6 +++---\n> include/qemu/typedefs.h | 1 +\n> 2 files changed, 4 insertions(+), 3 deletions(-)\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=LV4+jHvL;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvC934cdbz1yDF\n\tfor ; Mon, 13 Apr 2026 13:11:02 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wC7hH-0002WP-Ty; Sun, 12 Apr 2026 23:10:49 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wC7hB-0002Uf-Cc\n for qemu-ppc@nongnu.org; Sun, 12 Apr 2026 23:10:42 -0400","from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wC7h8-0000sz-Qm\n for qemu-ppc@nongnu.org; Sun, 12 Apr 2026 23:10:40 -0400","by mail-pl1-x636.google.com with SMTP id\n d9443c01a7336-2b299b3c739so16216485ad.3\n for ; Sun, 12 Apr 2026 20:10:38 -0700 (PDT)","from ?IPV6:2401:d002:dc0f:2100:a7b4:d4f1:5b23:321f?\n ([2401:d002:dc0f:2100:a7b4:d4f1:5b23:321f])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b2d4f3ab3dsm103442415ad.74.2026.04.12.20.10.31\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Sun, 12 Apr 2026 20:10:36 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776049837; x=1776654637; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=SdhSIse2soKursAdJjmWecwFzqSOmdWCQ6ry2TyOSSY=;\n b=LV4+jHvLmSarQprs0NTcDs3awGTAdTXptjIBxpJXLdRwXbysfPIMC+iqYMCrbqLQAH\n OFQqv9DAtAqWVPYltmOHWThpklyCfahw2Tb8cLdwic5t6c1DIT+GjtF2bGwElQ1pwzyu\n brBOdHFAyFAzlHlHoKzd848YTjR+UmxKoQBWSY7lin7viAKqLuZwfQ42aI/uLCXFM4NY\n V0lqt56F49gkgGETcFc57ZIWUk5V8j+v75gKW0Z65jKTVTScqQSe1n5lma3LBD0r/8AY\n voIBdz+IpfPVKwDyI3pWpe5Ddbc0lrd2rFAm3NPW9vQgdpQlpACg/BU2OJREoEMHIcyB\n pNWA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776049837; x=1776654637;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=SdhSIse2soKursAdJjmWecwFzqSOmdWCQ6ry2TyOSSY=;\n b=SEZ38IS8ISd3Io8kMK9mttKz3OUgoY7472FRdcPVCIQAemRjO/IiD2iA0duGLLfT/s\n i8OZWPDwSp8JUwxqTOMj3w7RX69ipBZGY/sVr416J+XGIvme1kaRZ23GZHyDzQJZh5rQ\n BdfjGICHdflqJAWje8VyWQCGmGEr0IJ++OYnrjechEGXQPx7aBF1u2uVc8xhxH5GgLCA\n BDuC4n9TCXarE45JCQy1SKkLM5M63MG4GOYYbZFSDis4wi6VyXK3XkYcqyJFFHVZTOos\n 9meBXuWUxCG99yGza8EE4Bqb9mi70Y/48UOFcou6aijlqdXQsk1ePpexVs9iSdvh5A46\n uMdg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/poL2/mra6bkEZIXx3GZOw0GQ+XSnj33wXtvsRXL8MSpjrwoXr7sISFul+13D/jvD/VL/iK+pHYA==@nongnu.org","X-Gm-Message-State":"AOJu0Yz//FBJU/+emXmj5DOd1ldOFrr7bvjUxIL+MAROe2Agst6Z8AP7\n Ms9G6YI6Rwoe7E5s3GTMc8Lw6V9v5LypNoq2X4RcGDgZY4+INxTn0VZgJP05oe4zyeV3dSeqprw\n wGJKv4vA=","X-Gm-Gg":"AeBDieudS5iXzKX17ef7hSY/BNeLHuz3F1nbTktBO0LcUKtTpp6Pv24y75FPiiN/zrD\n XZBxXB05GmrK8XsseTR2GTCuLa1++4we17g1w3DNfY0SRB2hc/lmmkt5u0XLnDZzvsmBXIg4NEH\n RrVgimstwUvbGGErkoG7m36qrT0bwp2Wb5/LJn+a1twwxIEchkigB4csjw6HTGx+Fzi814YnsaG\n RbDhvEUBLuCrRElSOQWZK6/FkDpzAwO58eROVrJTsWOnrULruum8zGtJVmDByK4kbl6LHa/1LGp\n IqN2PRMBcsMDDSnSSQdSjJInHFdiBn2sZbPtsVGyx4TrO9+fYBR6qnlx5L7zF8UYS5xXCCGviUb\n R12i9KpajOfJZGu04+wwugRMvZOAWbCrEFd2bivDxs/tYx1cUjm01uer+UlnDXs5zSFTGkpfXEG\n NrtadoHJBSM1lS/QwgT7Zflf8SmriMGpk7OD6l6EoeYQHErkedcJrKwvXnweNewNYthi8xFATPo\n ACmET8Yghhtyw==","X-Received":"by 2002:a17:903:3c2f:b0:2b2:90f3:d774 with SMTP id\n d9443c01a7336-2b2d5938b4fmr114072035ad.2.1776049837082;\n Sun, 12 Apr 2026 20:10:37 -0700 (PDT)","Message-ID":"<8f06d37b-111e-4255-8830-b63e5c8b143b@linaro.org>","Date":"Mon, 13 Apr 2026 13:10:27 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 05/27] monitor: Forward-declare the MonitorDef type","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"\"Dr. David Alan Gilbert\" ,\n Pierrick Bouvier , qemu-riscv@nongnu.org,\n Markus Armbruster , qemu-s390x@nongnu.org,\n kvm@vger.kernel.org, qemu-ppc@nongnu.org","References":"<20260410195323.17937-1-philmd@linaro.org>\n <20260410195323.17937-6-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260410195323.17937-6-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::636;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x636.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-ppc@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]