[{"id":3676030,"web_url":"http://patchwork.ozlabs.org/comment/3676030/","msgid":"","list_archive_url":null,"date":"2026-04-10T19:48:08","subject":"Re: [PATCH] testsuite: Fix up g++.dg/reflect/type_trait14.C for\n -fimplicit-constexpr [PR124844]","submitter":{"id":4337,"url":"http://patchwork.ozlabs.org/api/people/4337/","name":"Jason Merrill","email":"jason@redhat.com"},"content":"On 4/10/26 3:30 PM, Jakub Jelinek wrote:\n> Hi!\n> \n> The g++.dg/reflect/type_trait14.C test FAILs with -fimplicit-constexpr,\n> because in that case NLType is actually a literal type rather than\n> non-literal type and so is structural type too.\n> \n> Fixed by making sure it is not a literal type even with\n> -fimplicit-constexpr.\n> \n> Tested on x86_64-linux, ok for trunk?\n\nOK.\n\n> 2026-04-10 Jakub Jelinek \n> \n> \tPR c++/124844\n> \t* g++.dg/reflect/type_trait14.C (NLType::~NLType): Move definition out\n> \tof the class.\n> \n> --- gcc/testsuite/g++.dg/reflect/type_trait14.C.jj\t2026-04-03 20:51:17.890904505 +0200\n> +++ gcc/testsuite/g++.dg/reflect/type_trait14.C\t2026-04-10 21:24:00.257567885 +0200\n> @@ -25,8 +25,9 @@ struct NLType {\n> NLType () : _M_i(0) { }\n> constexpr NLType (int __i) : _M_i(__i) { }\n> NLType (const NLType &__other) : _M_i(__other._M_i) { }\n> - ~NLType () { _M_i = 0; }\n> + ~NLType ();\n> };\n> +NLType::~NLType () { _M_i = 0; }\n> \n> static_assert (is_structural_type (^^int));\n> static_assert (is_structural_type (^^float));\n> \n> \tJakub\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=dZNjFSUQ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=dZNjFSUQ","sourceware.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","sourceware.org; spf=pass smtp.mailfrom=redhat.com","server2.sourceware.org;\n arc=none smtp.remote-ip=170.10.133.124"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsnRd2pxNz1yGS\n\tfor ; Sat, 11 Apr 2026 05:48:43 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 0E16F4BA23D4\n\tfor ; Fri, 10 Apr 2026 19:48:42 +0000 (GMT)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by sourceware.org (Postfix) with ESMTP id 3733D4BA2E10\n for ; Fri, 10 Apr 2026 19:48:14 +0000 (GMT)","from mail-qv1-f72.google.com (mail-qv1-f72.google.com\n [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-240-5PCcepJKN26TSOc31ruqUg-1; Fri, 10 Apr 2026 15:48:12 -0400","by mail-qv1-f72.google.com with SMTP id\n 6a1803df08f44-8a275472d89so40367776d6.1\n for ; Fri, 10 Apr 2026 12:48:12 -0700 (PDT)","from [192.168.50.130]\n (130-44-146-247.s12789.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com.\n [130.44.146.247]) by smtp.gmail.com with ESMTPSA id\n 6a1803df08f44-8ac84c4af3dsm29927516d6.31.2026.04.10.12.48.09\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 10 Apr 2026 12:48:09 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 0E16F4BA23D4","OpenDKIM Filter v2.11.0 sourceware.org 3733D4BA2E10"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 3733D4BA2E10","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 3733D4BA2E10","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775850494; cv=none;\n b=VIA7q1mwPN1ZLRyNMlsZhvWsDso+Z/u9MlmBKSoayeJ0a01UTJE6aqoTmmf7bH/sT9xGYF6NNoHzE1/FjNc5E7Dza7TvTxiJ6xRAxWkn5q4DQca16HM3R+xHg693KF4k//LOWe55abQT2YeNRb8LoBWwnH9j1gzd9R/SzkGNBiQ=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1775850494; c=relaxed/simple;\n bh=BjCOgj/ewS1B3IipwSu0hnHxHjTdf7LkTf8HCo4FqQM=;\n h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From;\n b=rMZ2cxAkDfl9Jpi14fs1mJEcpYrDhbepEaIaBdWWVt8RGgS2CQ7sSKuQet0zf5ZYkkEY3oWjmYRyfmxDDSH/cV8uRZKktvmLR6TVqBsP/8njv07DvRGsoA60Fq4Z2XmM6mkladxUOquP5Fwnf4ykgPEhywqnm923bdPLI0OfO/s=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775850493;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=ccRdqkp+bttK+mOH4C5eknug/5mqaGYJ06nYFQ8YR7Q=;\n b=dZNjFSUQ7jJRd5m9VMn79S3/te64+F+vSSF2XN9XLMbSZ1JUB/450Om7XgoFgXPU9a7Njt\n GAergEiMKMM/xEdkHpAHiE6pQJ47afF1UF3AaqqD1nek53iOLvnqDO7+TV24icieolNYEE\n C0MgW6zjOb59X0nbwRTYD5ZG18T1vLs=","X-MC-Unique":"5PCcepJKN26TSOc31ruqUg-1","X-Mimecast-MFC-AGG-ID":"5PCcepJKN26TSOc31ruqUg_1775850492","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775850491; x=1776455291;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=ccRdqkp+bttK+mOH4C5eknug/5mqaGYJ06nYFQ8YR7Q=;\n b=L4RvYjNLZDLc57waZGdMpbxKRuqwAIJF26OA7uPMywAJx6Y12rSSR+nolvVdiAUPhD\n RRd5Ha3eNL5u+GWEOhO1nzfbR0qK5rMWUWjNYOMvy1LJV43iXxhtg0TB5+NcILd0098i\n 6ZkS46WVNTyQC4a6DWcmzpISkdsGZPsxOP2hNRiELz2AJgfjywHPUU3s9v++5Iv8lDt8\n IyELeHAG3bTa4yi35BylTfWFWPgkSq1SggYI75GYMhSCIR40nUbYB85TNIFNLcfUhgwV\n M4IQXxqorukcHvgU6eRrnGM/AYWZHSXBgOVATrbCqnNXSVBazu34zFxXnZbXTzYe1aMs\n dVeg==","X-Gm-Message-State":"AOJu0YwAn3lO7J8xRdxta1PX/w745xoTiV2hhJ/2cmQfAzb0Q+1OlSJX\n c5wFHw0eBMjd5SYVQ1aepNzB8x8WVB7kJiD2Emiks87RHee7rMW8biuPoidkg82iRxrN7gGJTjr\n G4pXILwIRYmTzO1ckKjKpR3c2TwAYu1HiMX7qNEWp6lYedxbNtu/YaUMz/MG44mkrxpg=","X-Gm-Gg":"AeBDiesjnpXy7TAjqVCyBc0MZOSYuwChQUQK9M360caYed+bGV12Zb8l0iUEZTyDEE2\n a6UAdy8vcW495INy+FI8tQD2z/xFMDgvoqE6Oa1TyP7VCVr00yj4cNyU+Ebqk7IXlBqVNigoRhc\n MR7A0JkU5TPnHo6xsaaXlZjpRYK10BB1cM5NjM1MQrvW/Hz2QLOPDd6UzfUNOZvi4BzEYKEHAu2\n 87/4V7i17PH1Q1/K/parzqXkdCIUXiXQJxSjhd1qcQy9IIaVNUVfX/yQFcBcUIaL4eW6anyaJJV\n odLO6yLQJbKxSVvthvliuabLk4OHsRZEFwFZCglNwhAXGA7fLlNNfAIcTLQ+7wLbvXobYKYvVFt\n zLagwtSD68PT3ZEr9SU6pKNdyvK7TVjSLn0Z5i2GDNJpi19twMOqG4ARkFICGpsfucBRSQ4pNPZ\n Gu458C96Ed6YIm5vTvqe7m4kKF2Lz8wfM=","X-Received":["by 2002:a05:6214:e6d:b0:8ac:82f8:369c with SMTP id\n 6a1803df08f44-8ac861caae2mr67288686d6.29.1775850490884;\n Fri, 10 Apr 2026 12:48:10 -0700 (PDT)","by 2002:a05:6214:e6d:b0:8ac:82f8:369c with SMTP id\n 6a1803df08f44-8ac861caae2mr67288166d6.29.1775850490290;\n Fri, 10 Apr 2026 12:48:10 -0700 (PDT)"],"Message-ID":"","Date":"Fri, 10 Apr 2026 15:48:08 -0400","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] testsuite: Fix up g++.dg/reflect/type_trait14.C for\n -fimplicit-constexpr [PR124844]","To":"Jakub Jelinek ","Cc":"gcc-patches@gcc.gnu.org","References":"","From":"Jason Merrill ","In-Reply-To":"","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"X0vuaQ0k5_uZwraXFyBnSpPOEV0t7L2O2tWQmrWL37I_1775850492","X-Mimecast-Originator":"redhat.com","Content-Language":"en-US","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}}]