[{"id":3676210,"web_url":"http://patchwork.ozlabs.org/comment/3676210/","msgid":"<8fded74a-b72e-47f8-a298-07f78218ed27@linaro.org>","list_archive_url":null,"date":"2026-04-11T22:26:53","subject":"Re: [PATCH v2 43/67] ui/keymaps: introduce kbd_layout_free()","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 10/4/26 21:19, Marc-André Lureau wrote:\n> Enable callers to properly tear down keyboard layouts.\n> \n> Reviewed-by: Marc-André Lureau \n> ---\n> ui/keymaps.h | 1 +\n> ui/keymaps.c | 13 ++++++++++---\n> 2 files changed, 11 insertions(+), 3 deletions(-)\n\n\n> diff --git a/ui/keymaps.c b/ui/keymaps.c\n> index 2359dbfe7e6..d1b3f43dc8a 100644\n> --- a/ui/keymaps.c\n> +++ b/ui/keymaps.c\n> @@ -178,6 +178,14 @@ out:\n> return ret;\n> }\n> \n> +void kbd_layout_free(kbd_layout_t *k)\n> +{\n> + if (!k) {\n> + return;\n> + }\n> + g_hash_table_unref(k->hash);\n> + g_free(k);\n> +}\n> \n> kbd_layout_t *init_keyboard_layout(const name2keysym_t *table,\n> const char *language, Error **errp)\n\nWorth renaming kbd_layout_new/init?\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=js+2KCsb;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftSwB0184z1yGg\n\tfor ; Sun, 12 Apr 2026 08:27:21 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBgn5-0003lU-Ao; Sat, 11 Apr 2026 18:26:59 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wBgn4-0003lJ-Is\n for qemu-devel@nongnu.org; Sat, 11 Apr 2026 18:26:58 -0400","from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wBgn3-0004KN-40\n for qemu-devel@nongnu.org; Sat, 11 Apr 2026 18:26:58 -0400","by mail-wr1-x42d.google.com with SMTP id\n ffacd0b85a97d-43d7213b6ebso99942f8f.3\n for ; Sat, 11 Apr 2026 15:26:56 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d63e50200sm19098287f8f.29.2026.04.11.15.26.53\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Sat, 11 Apr 2026 15:26:54 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775946415; x=1776551215; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=rI3e81KRJR+NbKrOU+fL1YrFiQ9FlYizv25LmKP7ON8=;\n b=js+2KCsb/Ac+9MQH81IZKicQOEFBmTiXXEVg0lvf//aMYTdxHmA1jJdGwlk60n8mae\n /mDiEALrVJ9YgyYmvn2vCpTf94GJnUtaZZKJTYq+hrXTryKMvNElEyTGGL06h8vKsdja\n niEKqAjDsSATbRVo/TSwlLAFzRP0hTG+4fvrXpnnhmeRYbifbhUvDm9K6LAJEgaJBneJ\n nfXeKFCtki73NAO95Pk6jVIoeEBvll5nLnoCvRjbSlqarPgbGNvCdae+MmfMcYjJLYfq\n kAKB7eFhwBNsFiK/Dkc3vgZizqB5xrIKEgpIU33jYxeUxWp7jaPHim1wpO8ND+p7YMha\n KoVQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775946415; x=1776551215;\n h=content-transfer-encoding:in-reply-to:from:references:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=rI3e81KRJR+NbKrOU+fL1YrFiQ9FlYizv25LmKP7ON8=;\n b=d2WKFw2XnQNtQPfAnuxnNTfJP2PQFNzjeO1qT/gW1EFUqP3fxp39M45Ccw7792q5HC\n SrrwoyDH1IemqPijAeM02lwMwR2ZqOq8RgCU7fpNM4VsL7L40jbI8kVPy+psUcKuj5Zs\n 4qjs+mkJpElfqRO5P6I1cUrlMxak4rEK90OEb0vzQ2Fgl6yM4NcW8XNf5OsU3NSrzx40\n h5PSRCXfdkxlukRORoxDIKHNFxKBS8Zv9TDba/50Za9591nwIZD6GEbiQ24zVp4pwNEo\n UntQ1hcJ0byBIvs6vL4kNfmBMYOUy9Tv2zazLPBjJkkxAQJHCS1XcsuolIs/dcXtKvK0\n ukjg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9rnObMbD6z2uLTr+syYPakmWo4eLVNsErBy/lmkZIK5/ayFJlg6eLdi9YZswYTJ4Ns0limfzRilIxL@nongnu.org","X-Gm-Message-State":"AOJu0Yxxl5DJs+oG2HFmXlGBdXCL29e7L4d8MbnxsB76AJN8D6GhAzLw\n PiEOIMRtS42IfU2lke7VMwTLC0e6OrNF7owkrGpB4kGOHh+O2i/U9Z1GzTaxIdsOszc=","X-Gm-Gg":"AeBDieuoiTnIM/5x2eDQzIqhiOxdfCFigg32o29l+bcKnkOYExU53b23gHc74EVCJkQ\n koT2vJeUAoKzVo7RcgZhPMB8PYGwGLoMt6S39cGXi7T7Z+9OBgiInO9xcuoUgi6NfCb+ixdZoWQ\n oEy1Ag8aDM5A4ZBrfQ98ZPU6q2X1FgGZg6vLS5orffMdgi30zDBFhyuc54ZaDqiJdLb4fyMzF/s\n XZBNAa2FDAWy88wpd8iBaALqJ+eEo7aiQEESn9T6YSK+GRaZVNf3bY4i5lxnvq9wZ6w/GQUOv6g\n WduXG73lI/2vjCBmI3XN6qnLak8i5RFHeuNA7p4ZKdfzb3l6srz5vW6JrAXsOem+wd86zkMkgI8\n MUXCnLmb6aI9WNVLx1efSnPww/lCqVFyWUcZNCjwjW1YnHkVlZI8a645qFzHRE+rzOxyiAeDAhP\n qe0HQc9yEvQt1lS0K3Kcu+LHOCimKqLpSrFSMD28+UnnCIf+lvYawq1KtDmAZ5ELFbww==","X-Received":"by 2002:a05:6000:1847:b0:43b:4f0c:aefd with SMTP id\n ffacd0b85a97d-43d642b9e05mr11090047f8f.23.1775946414918;\n Sat, 11 Apr 2026 15:26:54 -0700 (PDT)","Message-ID":"<8fded74a-b72e-47f8-a298-07f78218ed27@linaro.org>","Date":"Sun, 12 Apr 2026 00:26:53 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 43/67] ui/keymaps: introduce kbd_layout_free()","Content-Language":"en-US","To":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n qemu-devel@nongnu.org","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>\n <20260410-qemu-vnc-v2-43-231416f76dc3@redhat.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260410-qemu-vnc-v2-43-231416f76dc3@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::42d;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x42d.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3676293,"web_url":"http://patchwork.ozlabs.org/comment/3676293/","msgid":"","list_archive_url":null,"date":"2026-04-12T14:10:51","subject":"Re: [PATCH v2 43/67] ui/keymaps: introduce kbd_layout_free()","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"content":"hi\n\nOn Sun, Apr 12, 2026 at 2:27 AM Philippe Mathieu-Daudé\n wrote:\n>\n> On 10/4/26 21:19, Marc-André Lureau wrote:\n> > Enable callers to properly tear down keyboard layouts.\n> >\n> > Reviewed-by: Marc-André Lureau \n> > ---\n> > ui/keymaps.h | 1 +\n> > ui/keymaps.c | 13 ++++++++++---\n> > 2 files changed, 11 insertions(+), 3 deletions(-)\n>\n>\n> > diff --git a/ui/keymaps.c b/ui/keymaps.c\n> > index 2359dbfe7e6..d1b3f43dc8a 100644\n> > --- a/ui/keymaps.c\n> > +++ b/ui/keymaps.c\n> > @@ -178,6 +178,14 @@ out:\n> > return ret;\n> > }\n> >\n> > +void kbd_layout_free(kbd_layout_t *k)\n> > +{\n> > + if (!k) {\n> > + return;\n> > + }\n> > + g_hash_table_unref(k->hash);\n> > + g_free(k);\n> > +}\n> >\n> > kbd_layout_t *init_keyboard_layout(const name2keysym_t *table,\n> > const char *language, Error **errp)\n>\n> Worth renaming kbd_layout_new/init?\n\nsure\n\n>\n> Reviewed-by: Philippe Mathieu-Daudé \n>\n\nthanks","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=cgzLg9uT;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=JssyZBMu;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftstg1vwpz1yCx\n\tfor ; Mon, 13 Apr 2026 00:12:21 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBvXE-0003Mm-S8; Sun, 12 Apr 2026 10:11:36 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBvWy-0003Lg-1i\n for qemu-devel@nongnu.org; Sun, 12 Apr 2026 10:11:21 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBvWv-0004mM-P0\n for qemu-devel@nongnu.org; Sun, 12 Apr 2026 10:11:19 -0400","from mail-pj1-f72.google.com (mail-pj1-f72.google.com\n [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-586-hjB29MjOPZSdBAEaHj9Vgg-1; Sun, 12 Apr 2026 10:11:07 -0400","by mail-pj1-f72.google.com with SMTP id\n 98e67ed59e1d1-35d9278587bso3438857a91.2\n for ; Sun, 12 Apr 2026 07:11:06 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776003072;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=7nr2A/dxJETpwBr73AVTmxj6GqBvVn0+bRRJPpY9sSQ=;\n b=cgzLg9uTo0wjSpSu5L+Xqjr0xMfx1gGSMKidoc1mhA/JbuTqWiFP5bArEWbRxFmiNji+NX\n qF9WCU9IMxS3GAAeYr8g6Z8hUgzWqPs27a9ajK6HoRLOR478LlqFcSg6F1EtXWEu2j1N3h\n XEqZ3Gia8n84BELXENfrb1XtqhkgnkQ=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1776003063; x=1776607863; darn=nongnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=7nr2A/dxJETpwBr73AVTmxj6GqBvVn0+bRRJPpY9sSQ=;\n b=JssyZBMuewP/KoZ0CbZ9lOD5zUmFbat4zWOfQorh7xlKFUJ9SoEn9roY9KFhkeF9NU\n AAOXXDekQMxmbNBLopL4OgE71IYJ3uveIFhlN5xvIA1Pk/jg75xNfWYnmU4sIxh/oss9\n B9fjqMkzthTyNByd2vypWhazsPSkXYm5Gwebpgz9kT0SI6IOWnaJhM1YVnQ+P3hniFNX\n hzoot5IiJhEGQBWUGM1y+lI12YkNCh0IzD3lQ5nJrfS28hqpjz8ehdHpT9UimdKaKPQt\n hdWIus7tc0l7Vu6VWIgjwa2hDLSrLWUQUhKoiRVPB5mIeoFec+it6/Rz6u/rClpEAro0\n DPMQ=="],"X-MC-Unique":"hjB29MjOPZSdBAEaHj9Vgg-1","X-Mimecast-MFC-AGG-ID":"hjB29MjOPZSdBAEaHj9Vgg_1776003063","ARC-Seal":"i=1; a=rsa-sha256; t=1776003063; cv=none;\n d=google.com; s=arc-20240605;\n b=fQwMXVM1+CF2yO7ArnBzmVJ8Lu9suk8xgZLHtoB5XSZIP9x92cd7u8hB7eU3ZUfKOw\n PaVOnpGTlnBbWCtwD3uNmaCc9wjECoLQPnxbwoLv08lrrq7p0uMOJxKTKl02EmcnD4Rt\n mo3cFina4VvHPVxVwycQZ40aGKIT+6CVM8nzjgC16vSuDFj3QYQKye8ubbvGvD0wYncd\n CXbjcN6BSOosPgct++rQsM5Lp4q5lOu+b0ZDxr/d8xg1OzbnUCWbqD8x+J/kylPAFwuI\n j6MIEAWazaonEumoumnrvrjL5Gj/OWgPPN+b8Funyup+0YaSiYn9SDCehIYcjFFO41SU\n lZnA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=7nr2A/dxJETpwBr73AVTmxj6GqBvVn0+bRRJPpY9sSQ=;\n fh=zpiKzW8LH3ELwKzluQ3AheUCgrr23INy4hQ6ZjBUBr4=;\n b=cCL5m8Vy75ZI3Zq9ouIHIHoTTj4UHNTR+Fl25o7Kr5CRYqap8T3cNbGquuytegQ72y\n 72FBmTTBzWZ2HVdKxFrpDZ8KK6OuZNo+VG/mWTFkmf0uBy5GJA6HLvj60Dlyn+wyEEnS\n 0L7qdPAGnOFxH+cncWHyzuMHmsnWJd7iJwDYtKzL5tJyVvkjCzFyQ9tarkY4XXJ0iMbd\n WCftQcpPWbL/cHW/LcMhfDzOplWw6Zlo+WJljKFS/cpDtAnDVzZAlX0rbkJRCIv/tQzO\n 28AKZPWakhVcFVRVIydRy6gG/xdhASHREJEnKWPff2gbxqmIPkP/LY9sYS0/UejWRCBx\n 6S/A==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776003063; x=1776607863;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=7nr2A/dxJETpwBr73AVTmxj6GqBvVn0+bRRJPpY9sSQ=;\n b=dUlKET7VQYMp1NdO4WIM7Yp8J3l797LiTiA3sqDXg/YfHlpEvOzdBTQ7QF8eD5zsVY\n atE9VYYa+YbKl4GBxoFlb0DjoEs7ytFn3oOanVWbyzykMSCaKHlEovGrRM8hEK+yqkHm\n Ln15qxrZ1ecQaMr4QFy3qOeOAvKr6nN0j3nvCqBI0w3SMN/EiCdWy+y6jWtgojt5P+aK\n nqQ6JJXiWgunLwa69vbIMzQhn8jtcRvX3bsYpXyyYqmeqfn8Ea+Z4gXyXkTSTi7pN8JC\n vo1IeOlTMpgCm4JxkT+gQmEWqMilIU1P6BG2g5Vr0Dg5BCN1aGJW9dvxuUSGD2CAk7RA\n Y1EQ==","X-Gm-Message-State":"AOJu0YwskWuNMvlAeOT6H2YOyV8fJl0U0YjmYVRFvK7h1e2d5TA/m1/a\n qFGy4R8kYWQDgdboi09H4uSw0gUdVomvkvN/S+VuNi9bnW2hNTx6C411u3Of/mmmuB5L907eU+b\n okiGzACWr/ZxNbCiJpJNknQaHRqrrSKwzcjO49HqdknCD9flsqi4lB0/gzzVCqOQ+bh6qAvxiWh\n Pwd2TV0XGjEc6pZRqTFzQ7antj18RkMVk=","X-Gm-Gg":"AeBDietaybTF47gDSNQBmGn9dT6SLG66zLQ6i+/4NFT7at49H/uLCWfVlbyMK+c7oKB\n qtgSz6CJdjPps8BsxodXNye8IGiEfAH634uU3YAYnEuchGxBdJw7GnIyDeyKC+9LU/m2HMAzSsy\n mDmyezpKEcVjuUELX5bLI/hZGpuUHtsm31NXMvhFoZltzflGuNOGsGx9V0PZq0lw37CY0MrKqdP\n QDP77bIovRa1b0xZsj/erz8mZXWwl+DtHZZP3h64HSyZJyyJ4HJobsyIWGbLIY7otelw6F6/V4q\n vZpii61WMKbZI3XXX6EKWA6i","X-Received":["by 2002:a17:90a:ad7:b0:35f:b1ad:fded with SMTP id\n 98e67ed59e1d1-35fb1ae0146mr1121042a91.18.1776003063242;\n Sun, 12 Apr 2026 07:11:03 -0700 (PDT)","by 2002:a17:90a:ad7:b0:35f:b1ad:fded with SMTP id\n 98e67ed59e1d1-35fb1ae0146mr1121028a91.18.1776003062783; Sun, 12 Apr 2026\n 07:11:02 -0700 (PDT)"],"MIME-Version":"1.0","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>\n <20260410-qemu-vnc-v2-43-231416f76dc3@redhat.com>\n <8fded74a-b72e-47f8-a298-07f78218ed27@linaro.org>","In-Reply-To":"<8fded74a-b72e-47f8-a298-07f78218ed27@linaro.org>","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Sun, 12 Apr 2026 18:10:51 +0400","X-Gm-Features":"AQROBzAOrUlKt197RKOOPd5Hv5nMCPKaLmLJ2Phixq5D_PL3nHfLuKLB_nGbw6I","Message-ID":"\n ","Subject":"Re: [PATCH v2 43/67] ui/keymaps: introduce kbd_layout_free()","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Cc":"qemu-devel@nongnu.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=mlureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3677608,"web_url":"http://patchwork.ozlabs.org/comment/3677608/","msgid":"","list_archive_url":null,"date":"2026-04-15T11:31:28","subject":"Re: [PATCH v2 43/67] ui/keymaps: introduce kbd_layout_free()","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"content":"On Fri, Apr 10, 2026 at 11:19:05PM +0400, Marc-André Lureau wrote:\n> Enable callers to properly tear down keyboard layouts.\n> \n> Reviewed-by: Marc-André Lureau \n> ---\n> ui/keymaps.h | 1 +\n> ui/keymaps.c | 13 ++++++++++---\n> 2 files changed, 11 insertions(+), 3 deletions(-)\n\nReviewed-by: Daniel P. Berrangé \n\n\nWith regards,\nDaniel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=CbfE1q0V;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwfBX3Y5Yz1yDF\n\tfor ; Wed, 15 Apr 2026 21:32:19 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCyTF-00051u-GF; Wed, 15 Apr 2026 07:31:50 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCyT6-000512-JZ\n for qemu-devel@nongnu.org; Wed, 15 Apr 2026 07:31:41 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCyT4-0003nH-3c\n for qemu-devel@nongnu.org; Wed, 15 Apr 2026 07:31:40 -0400","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-451-hyqRL8KRPpSqLDkqkl3bLg-1; Wed,\n 15 Apr 2026 07:31:33 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id C25A41800451\n for ; Wed, 15 Apr 2026 11:31:32 +0000 (UTC)","from redhat.com (headnet01.pony-001.prod.iad2.dc.redhat.com\n [10.2.32.101])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id DABDB180044F; Wed, 15 Apr 2026 11:31:31 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776252695;\n h=from:from:reply-to:reply-to:subject:subject:date:date:\n message-id:message-id:to:to:cc:cc:mime-version:mime-version:\n content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=ofzU0Pnj49p6YToi0WB+hVgeOjefnIIQw5bmgxBpy8k=;\n b=CbfE1q0V/WkHZM13FDnaa+2jAQm+3r3K6iPY/x0WyPsdx8APVspd3yoyfrOoWoX6Ibam1h\n ADQm5iwMZvJIxyxQsZ4d8vOgVoay7tX8BFB/V/4sPIzuNVEb/jFlc4rh6GpasiuZ0RjFAK\n kRzpLQwybdSLiWdGw7AGTmzetP0WMz8=","X-MC-Unique":"hyqRL8KRPpSqLDkqkl3bLg-1","X-Mimecast-MFC-AGG-ID":"hyqRL8KRPpSqLDkqkl3bLg_1776252693","Date":"Wed, 15 Apr 2026 12:31:28 +0100","From":"Daniel =?utf-8?b?UC4gQmVycmFuZ8Op?= ","To":"=?utf-8?q?Marc-Andr=C3=A9?= Lureau ","Cc":"qemu-devel@nongnu.org","Subject":"Re: [PATCH v2 43/67] ui/keymaps: introduce kbd_layout_free()","Message-ID":"","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>\n <20260410-qemu-vnc-v2-43-231416f76dc3@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260410-qemu-vnc-v2-43-231416f76dc3@redhat.com>","User-Agent":"Mutt/2.2.14 (2025-02-20)","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"Daniel =?utf-8?b?UC4gQmVycmFuZ8Op?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]