[{"id":3676215,"web_url":"http://patchwork.ozlabs.org/comment/3676215/","msgid":"<4a9327c0-889b-4907-9a83-9261ef1ac5b6@linaro.org>","list_archive_url":null,"date":"2026-04-11T22:38:28","subject":"Re: [PATCH v2 60/67] ui/console: rename public API to use consistent\n qemu_console_ prefix","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 10/4/26 21:19, Marc-André Lureau wrote:\n> Rename the display and graphic console public functions to follow a\n> consistent qemu_console_ (or qemu_graphic_console_) naming convention.\n> \n> The previous API used a mix of prefixes: dpy_, graphic_hw_,\n> graphic_console_, console_has_, and update_displaychangelistener().\n> Unify them under a common qemu_console_ namespace for better\n> discoverability and consistency.\n> \n> The main renames are:\n> - dpy_gfx_*() / dpy_text_*() / dpy_gl_*() → qemu_console_*()\n> - dpy_{get,set}_ui_info() → qemu_console_{get,set}_ui_info()\n> - graphic_hw_*() → qemu_console_hw_*()\n> - graphic_console_*() → qemu_graphic_console_*()\n> - console_has_gl() → qemu_console_has_gl()\n> - update_displaychangelistener() → qemu_console_listener_set_refresh()\n> \n> No functional changes.\n> \n> Signed-off-by: Marc-André Lureau \n> ---\n> include/ui/console.h | 108 +++++++++++++++---------------\n> hw/arm/musicpal.c | 4 +-\n> hw/display/artist.c | 4 +-\n> hw/display/ati.c | 16 ++---\n> hw/display/bcm2835_fb.c | 5 +-\n> hw/display/bochs-display.c | 14 ++--\n> hw/display/cg3.c | 6 +-\n> hw/display/cirrus_vga.c | 8 +--\n> hw/display/cirrus_vga_isa.c | 2 +-\n> hw/display/dm163.c | 6 +-\n> hw/display/exynos4210_fimd.c | 4 +-\n> hw/display/g364fb.c | 10 +--\n> hw/display/jazz_led.c | 8 +--\n> hw/display/macfb.c | 6 +-\n> hw/display/next-fb.c | 4 +-\n> hw/display/omap_lcdc.c | 4 +-\n> hw/display/pl110.c | 4 +-\n> hw/display/qxl-render.c | 12 ++--\n> hw/display/qxl.c | 14 ++--\n> hw/display/ramfb-standalone.c | 2 +-\n> hw/display/ramfb.c | 4 +-\n> hw/display/sm501.c | 6 +-\n> hw/display/ssd0303.c | 4 +-\n> hw/display/ssd0323.c | 5 +-\n> hw/display/tcx.c | 16 ++---\n> hw/display/vga-isa.c | 2 +-\n> hw/display/vga-mmio.c | 2 +-\n> hw/display/vga-pci.c | 6 +-\n> hw/display/vga.c | 40 ++++++-----\n> hw/display/vhost-user-gpu.c | 22 +++---\n> hw/display/virtio-gpu-base.c | 2 +-\n> hw/display/virtio-gpu-rutabaga.c | 10 +--\n> hw/display/virtio-gpu-udmabuf.c | 4 +-\n> hw/display/virtio-gpu-virgl.c | 20 +++---\n> hw/display/virtio-gpu.c | 26 ++++----\n> hw/display/virtio-vga.c | 2 +-\n> hw/display/vmware_vga.c | 12 ++--\n> hw/display/xenfb.c | 6 +-\n> hw/display/xlnx_dp.c | 10 +--\n> hw/vfio/display.c | 32 ++++-----\n> ui/console-vc.c | 12 ++--\n> ui/console.c | 140 +++++++++++++++++++--------------------\n> ui/curses.c | 8 +--\n> ui/dbus-console.c | 4 +-\n> ui/dbus-listener.c | 10 +--\n> ui/egl-headless.c | 4 +-\n> ui/gtk-egl.c | 6 +-\n> ui/gtk-gl-area.c | 6 +-\n> ui/gtk.c | 18 ++---\n> ui/sdl2-2d.c | 2 +-\n> ui/sdl2-gl.c | 2 +-\n> ui/sdl2.c | 6 +-\n> ui/spice-display.c | 16 ++---\n> ui/vnc.c | 22 +++---\n> hw/display/apple-gfx.m | 16 ++---\n> ui/cocoa.m | 10 +--\n> 56 files changed, 372 insertions(+), 382 deletions(-)\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Nivt8FZM;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftT9X1jL2z1yCv\n\tfor ; Sun, 12 Apr 2026 08:38:54 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBgyJ-0006R4-3r; Sat, 11 Apr 2026 18:38:35 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wBgyI-0006Qt-3s\n for qemu-devel@nongnu.org; Sat, 11 Apr 2026 18:38:34 -0400","from mail-wm1-x332.google.com ([2a00:1450:4864:20::332])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wBgyF-0005x7-Km\n for qemu-devel@nongnu.org; Sat, 11 Apr 2026 18:38:33 -0400","by mail-wm1-x332.google.com with SMTP id\n 5b1f17b1804b1-488ab2db91aso49011935e9.3\n for ; Sat, 11 Apr 2026 15:38:30 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488d67b46ffsm75380845e9.6.2026.04.11.15.38.28\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Sat, 11 Apr 2026 15:38:28 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775947109; x=1776551909; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=42U4D7cSh/x4jUGEvf5n81x+exxEiYajm+UJ+z2Xv+Q=;\n b=Nivt8FZMqMuSh+NKYvvFIsm68rDKEtgJ3c1iNJYverYh1ucPv5Gb7jgWqmWQkwCTvR\n Qo9hMLN29gYP8BvYQoO7pkeQRn/f7JBnPwgadk0OpoyYh1mVH11NucKF2eZsh/V5PO5n\n +KksBbHk73N9lDEWO0GSLb6I2MlXhyPm9hG4R30KJzmBuv7m1zW6kGI5LnF498fr8MgU\n oGMq2zBK9dLemdhSResK6APoWF+BjE8ixHA18wUX3GmNh63oZEoZGGCJG5ESeeNa6wh1\n lHc7784RCZwgprtbbVDJ9cxQWkx24atJobnp/MD358z8Y8RiW1meEe9wuI0LxX9OK3nZ\n by5w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775947109; x=1776551909;\n h=content-transfer-encoding:in-reply-to:from:references:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=42U4D7cSh/x4jUGEvf5n81x+exxEiYajm+UJ+z2Xv+Q=;\n b=WD/mF8DTcZ8ddT+bk0QfO97ITi7/lbTSK6yfFee3lmFJ9dvsozJPp09JUd9ewuh2yS\n CeQlaeqlwuqptXrEjqrGGnXvZjqqTXF/GiK3hUIj0QFRMNN1HdLat/odvzirsVwFhtTx\n aM5FoA8OKOgS5/oIwdenRdcL8pV3whHlkaEskYRYWB+WPHCHVP6S1DK0j57wPUxgQJPr\n q9Bv6Pw0xE+/tzYffQ9bbt8zUF8I8AFqn+5o3HzTTi8vWdp4PCw44mxJfCjRiGhicHve\n koaU+u6hUJ45BZe0Efz6NGgE19+oZsCdXC0r3MZhaVEZ/qGXHKL3CjHgSX+PaWf/3PaL\n r1Ag==","X-Forwarded-Encrypted":"i=1;\n AJvYcCWhYclLxCZqW2O5rMwjGVqOconmf4nqEmDobUVKladSBO5IlULkl9nAOB8t04uIlH9MvlYZ6Jn+P8/f@nongnu.org","X-Gm-Message-State":"AOJu0YxOhNKPgtfSXLYy0TLz0E7e7TOPuKTT4vbbJArNbojhTrgYyYsX\n pL5xRaUdALZkiCwAg9q4aN29bQ6xPnA7UvRAv6d2EvRGVrTtmdPEQa0MA0VXQdQfHkg=","X-Gm-Gg":"AeBDiesE3bIKhDcwJM5in7Zb+B+MZO2irYCO/L26bi0u73AImPDanx6+zBP8WMFhBzY\n zQj76ctDE3FY9ayzTfEXWgGRpFbMW5VuIt2Mwsr5BNRglxtjG7V0o2oDT/u6hPgqkV8uI0Pv3ch\n a2YxNzmGCQFwRQXcIQbIRAqtGFKLrubtUOnrlL6QAfnvsmLATAHIEOV/UKPoVJcytlUExssjcRD\n xGPtkTHLj0fCBzv5dSdJcg9lW2VN1k18MSTWI04RFMq24C9tfVnqNfA5BbjcAOXTSO/OySnc26T\n /9SteuMyo0v3e6NMFBopWTj2m5L3jK/8Mo8ND2yOUatEJWidkSx1txAu4l/Or48R/gDIf3v8TSl\n SU/mUWMIkpu5BlOHbdM3NvRet3Tc2dNP0M7BDrDzY6xczUIn1AUalU9TBsEylDIdARFBVnj81fL\n seIDWzo6H4cYdJueybc3oMhDfXXBSb4fIJt1qy+g+Iu496jU91bN4NiuXQ/ZXCXsOWPww/qLpno\n wDW","X-Received":"by 2002:a05:600c:890e:b0:488:bd79:94d8 with SMTP id\n 5b1f17b1804b1-488d684331emr71220895e9.18.1775947109529;\n Sat, 11 Apr 2026 15:38:29 -0700 (PDT)","Message-ID":"<4a9327c0-889b-4907-9a83-9261ef1ac5b6@linaro.org>","Date":"Sun, 12 Apr 2026 00:38:28 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 60/67] ui/console: rename public API to use consistent\n qemu_console_ prefix","Content-Language":"en-US","To":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n qemu-devel@nongnu.org","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>\n <20260410-qemu-vnc-v2-60-231416f76dc3@redhat.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260410-qemu-vnc-v2-60-231416f76dc3@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::332;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]