[{"id":3676217,"web_url":"http://patchwork.ozlabs.org/comment/3676217/","msgid":"<3a2f3e97-816c-4a41-b632-bbf8b3b16adf@linaro.org>","list_archive_url":null,"date":"2026-04-11T22:42:34","subject":"Re: [PATCH v2 08/67] ui/console-vc: fix off-by-one in CSI J 2 (clear\n entire screen)","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 10/4/26 21:18, Marc-André Lureau wrote:\n> The loop condition used `y <= s->height` instead of `y < s->height`,\n> causing vc_clear_xy() to be called with y == s->height. This clears\n> a row in the scrollback buffer beyond the visible screen.\n> \n> Reviewed-by: Daniel P. Berrangé \n> Signed-off-by: Marc-André Lureau \n> ---\n> ui/console-vc.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=z7BMqzmZ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftTG64BNpz1yGg\n\tfor ; Sun, 12 Apr 2026 08:42:54 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBh2H-0007Ri-Tg; Sat, 11 Apr 2026 18:42:41 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wBh2F-0007RP-Oc\n for qemu-devel@nongnu.org; Sat, 11 Apr 2026 18:42:39 -0400","from mail-wm1-x332.google.com ([2a00:1450:4864:20::332])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wBh2D-0006aT-Sc\n for qemu-devel@nongnu.org; Sat, 11 Apr 2026 18:42:39 -0400","by mail-wm1-x332.google.com with SMTP id\n 5b1f17b1804b1-488af96f6b2so42807845e9.0\n for ; Sat, 11 Apr 2026 15:42:37 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d63e50015sm20507085f8f.27.2026.04.11.15.42.34\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Sat, 11 Apr 2026 15:42:35 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775947356; x=1776552156; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=dvCq3Cy7wX+HL0FMrT+YMOuJcoj033MC/MGno2ssRlk=;\n b=z7BMqzmZR0vr1rpVxtZZEXX7z+n02Faeq9V5n7F4nWgj1fGRF0HB3YGbe/Smbsh15r\n 2sMYneS3Vv3xwOjIVtqtonqBYSBICVDwNYrsDlMYdJ9AIyMtkq1BgjP4ZK1iUq/8jLQW\n 6btLzVaLKf4c+tOF4gnW+wwMlHSxRKvfLiz8y3utOqWLffVRl8lQ/p9qX6OBtb9bf7Sg\n BorZu8xBTEbBHbrjCWvta8jjOA7OC/GAaMU1VMFLnpzQXNRFPXsvLV0F8bVdFJDljsPx\n ZNKPlGunZTpFIo4pPDPL3SGzCSiho/21mzWjBs3rSnmURBi3pZQ8xxHmpZe/AjYNfFWF\n 2h5g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775947356; x=1776552156;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=dvCq3Cy7wX+HL0FMrT+YMOuJcoj033MC/MGno2ssRlk=;\n b=dQB/0IkYM9fsqnq5WmsQXbHh+rKzL2exMIxGhxz9z+hPqpjBMgmzPKTrg+lPXzbpDU\n 3cYHiYOSSUoq6LF3UYkLT6MhS1Do0fHtuQJgwbAROcS+JZ2O9CBQwVgvWRfipHRQDl1q\n 4j820shep9uGt4JDcP/kal9OltqzPGWxfbaKL5WJ8nFJ/RE52nNe07UU4DfyTdmN9r+b\n 4mS56b0y5v3EmJkJ9vC1peCOmzeUHPeacyCciBUJicf8XBE7qiwyQiolEiJCYTJQnqN4\n jkDgfyoCo8GmHmGue+oqlTj8kOBThUZs2OejEMfBnPVNqUyIcT7zgs81VyfuJrQOQQBC\n g4Rg==","X-Forwarded-Encrypted":"i=1;\n AJvYcCVrxjErnzk15BkZq2/AM23BBc5jNDCF6t6Q7+6JgZb1k+QTHAFeeMYSkCwOqAX9bqMpJ3J8aEy+Ocpr@nongnu.org","X-Gm-Message-State":"AOJu0Yxu2sNNCwagce3EDw8xJCOsCg1GQgKT8KEEJh9Q99GgsEgi5+It\n TCeBmzTzI/cU3hYXj64ErnOy4nPLeIFnrQ/fARC20WwoGrC5tP0IpmFR6i2wEsH91Wk=","X-Gm-Gg":"AeBDievAS8O1Mmmjd3sqQZ9upWS7o4q/uZkUxWis4lspHK7v5uxHwF1WSWpjldcZ2gs\n I5LCDAhLDv/sX/FWENeSUnqgJgpe7Z8nGfUMzQGYeDBvvysZ/9TFPvPGKbBudMBr09lC1WZEq47\n H5cEAgxt1K0WBc/YLonbhjtFb7VCibJ9rIQo+8LwO/Mz9HU2baO4qroG2ErZbFc9kYAlSD1UshP\n 9O5ERshPvhB5xFD0LIY/2uXdRuXAbM5EIAs/Ax1oSYXxoMpGMLKy4G1zsPMLWc1PLTDbL5epte/\n wURLndAB9c95OJN1+vs26MOBYeIHk9iDr3GJ+VhtYVGQ0rjh/vn653D+RiwruiwMzPuUHQARWUq\n n8vnQ2GHxkFm/JgiVzydd8E0pJuP5BaVEgVlxEy7H3iQfTXvPHpwkaeTgXM/7qkIj+IYaSPwUPN\n RR+dpWxubb8VPier3c9eBK3iA8HbRWwqPn0va7/A7LVxXhbToCn/Y/n+hTCDcWyu4FOg==","X-Received":"by 2002:a05:600c:3acf:b0:485:35a4:939f with SMTP id\n 5b1f17b1804b1-488d68a8275mr93503425e9.28.1775947355989;\n Sat, 11 Apr 2026 15:42:35 -0700 (PDT)","Message-ID":"<3a2f3e97-816c-4a41-b632-bbf8b3b16adf@linaro.org>","Date":"Sun, 12 Apr 2026 00:42:34 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 08/67] ui/console-vc: fix off-by-one in CSI J 2 (clear\n entire screen)","Content-Language":"en-US","To":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n qemu-devel@nongnu.org","Cc":"=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>\n <20260410-qemu-vnc-v2-8-231416f76dc3@redhat.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260410-qemu-vnc-v2-8-231416f76dc3@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::332;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]