[{"id":3676578,"web_url":"http://patchwork.ozlabs.org/comment/3676578/","msgid":"","list_archive_url":null,"date":"2026-04-13T09:04:45","subject":"Re: [LTP] [PATCH] include/lapi: add leaf Makefile","submitter":{"id":74427,"url":"http://patchwork.ozlabs.org/api/people/74427/","name":"Li Wang","email":"wangli.ahau@gmail.com"},"content":"Jinseok Kim wrote:\n\n> Fixes : https://github.com/linux-test-project/ltp/issues/1262\n>\n> include/lapi and include/lapi/syscalls lack Makefiles, so 'make check'\n> does not work in these directories. Add minimal leaf Makefiles.\n>\n> Signed-off-by: Jinseok Kim \n\nReviewed-by: Li Wang ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=pCTxhGdC;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvM1Z55wCz1yDF\n\tfor ; Mon, 13 Apr 2026 19:05:05 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 370D33E2946\n\tfor ; Mon, 13 Apr 2026 11:05:02 +0200 (CEST)","from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [217.194.8.5])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 5657B3D9251\n for ; Mon, 13 Apr 2026 11:04:59 +0200 (CEST)","from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com\n [IPv6:2a00:1450:4864:20::22e])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-5.smtp.seeweb.it (Postfix) with ESMTPS id C6A026002AC\n for ; Mon, 13 Apr 2026 11:04:58 +0200 (CEST)","by mail-lj1-x22e.google.com with SMTP id\n 38308e7fff4ca-38be5e86918so41008221fa.3\n for ; Mon, 13 Apr 2026 02:04:58 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1776071098; cv=none;\n d=google.com; s=arc-20240605;\n b=AjTK1DohfmL48mmZEWEOtIdcBM99ZsGXML+CFp9MsAJkBxBJnx39Cr4QT5bXy16JND\n zPaKkoL7Ci7++Xlzj+R0YnSR96IefC3yAgu8X5drujoZdiw12PCY1USn7CXMSZIfdVmd\n Zzmug7S5mt7pJZPRlRc7Xm95StAfs+AujjZ+vSP1Td/eCogelc59O84jujzU2sikskxH\n wYM/ZLpOEFRVXlxjrSTjgQDRkZTlGwTQ+9TSblEXGL0FdARMKwjGirZH89JoLn0Orex7\n ZCWWJlVjmtE7aiMCvtPUK6RrtwDge8w03y5ltxJEHu4W9iIO9+4tSQkjw1QIX+SS+Uln\n t+Xg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=yIlOi3GvmMMMfuQOoGINci7ZSHQ3MWoTeVsquJCwIds=;\n fh=Ka/N13XSlqAN8mpqWOWPAvIrH2A6rBxVZCu4d4o5yGY=;\n b=FXEDcUQqkzp+FkOfoR9+LvGPICtlxjU13Rbe0ITpaWYf66GNA2tLz20L3pKgGZWSon\n 960Fl1dOGmAbc35MDI8XA/YArNE9G5DXSMTY/Xx6EhJK4RBsbPzbq5ji3b9fFroH79ZU\n agLq6ReyCXkaFNLIwT8mNmgitvPR0oddyOjiPWS24Yhbux0rKxpTZWKQnTDkRgfs0YLt\n g/HTj6mYDjfiRV+Tj/Mv0vyP4WfCjN2UnhC0oMSUX5mkiWnBEI5PmUALVtvEugr/EYOP\n qU53Pv1im8LARLF9gW8cscKxe7gLHotaUiCi4dWOVhJgq9msL5V6/qULFSM/WGX3BEUx\n v9vw==; darn=lists.linux.it","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776071098; x=1776675898; darn=lists.linux.it;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=yIlOi3GvmMMMfuQOoGINci7ZSHQ3MWoTeVsquJCwIds=;\n b=pCTxhGdCVY0vxSX3shNJXysbJbHwqktL81pJPsG09s4j8Fh7+adrITdT4r0kEz5Ih8\n Kj1HCrl86oED/w3FgCbSclR0l0LAXJJ6jSMqcK4zH+4heIbG+KFokgbXTpjN7YdW84Dw\n D0+CkSFhvjJ+X26Ed7vEQBMQ08KEhZR4vHOv/ltOYrNjc3C3yVoHSgW4PfeNC3GfNwU4\n 7YpDdr42jpUhaFa3RT96NCMUcdkLNsbZGOnPVnsNV+A24Dg5zJigNWk918ovNm8TOq/+\n CihlUVh7e51ZluaEYJWqRBtTubhqb6PQ1S42qhhNVnbs3lGdGoG7kl8crEgK0IsLiRHM\n py4A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776071098; x=1776675898;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=yIlOi3GvmMMMfuQOoGINci7ZSHQ3MWoTeVsquJCwIds=;\n b=IVGRZA1jYaX4xEkybu9DKpVT9aedNjVANyUvEaRC0nU9CRJqsMIsoxQVS6OtkRlPlQ\n WE7pAdv45fU6G5VCXefYzlzLhRoUZ+wDe1yxXdId0TB+SYEfwfYclfCNiCzzCCmbBCPk\n mijUBAIjM/jaaANegevkzR7sVUqDaxFVhNU2ZtrtunVyS4tWtPAMTV+D6q7ud8Qn97q4\n 0HXUmdfi3wfLTmp0Q2183biB/uJjifsPsVRAeU8WR5Zck94RGdTnVnPlAEFUvBF9WPqJ\n wudktbcV6rtNCC3ukSkl92NJLUaax4GgzFNbvTcCjLsRotmgLVA7uuAT2GKMXTruAb3t\n dweg==","X-Gm-Message-State":"AOJu0Yy0He639e/8B20SN/GYII8wbOjHCy70Ls+8wimI0zf6sZqTLTYh\n //0srC019ERfqbAGupeWKz9AEmVT1Xib7WWLcFk9jZOASRJByDEL1mFNKaZd8VlwshLtKpUwLhK\n aSZrUmNMqti38f/CwKaAokazt19H6BeIvBhKjFlLdXcdM","X-Gm-Gg":"AeBDiesdE+nkpxzhGwFLQYXNPVb5Q1n1T41+g2ZEP57HA5nE8cqznESM9FdQ6SHhL5J\n QN3Z/wcvQPTwOPycWAR2QYSpzWfneoFS8Ddw3HMGE/UjXD2BEW8ZVID0h+k9dG9pIh4soTdM3ZS\n G+tGtLZYBPPU9AjsmqLkA5v/FAGMNjwQtNQ9F+4qWDtH+UQgD29LiHz9DsLFUZ1UdSSGvEnety5\n OXfK9OFMvjq+yIuf4PKPkB+naSlrjAWl4qEmGpsOAq2gT6XtTBaovMw1BdVoslLhV0gizDjYc3b\n APYChvs=","X-Received":"by 2002:a2e:9fcb:0:b0:385:9b50:91a8 with SMTP id\n 38308e7fff4ca-38e4beea127mr40028001fa.15.1776071097626; Mon, 13 Apr 2026\n 02:04:57 -0700 (PDT)","MIME-Version":"1.0","References":"<20260410175031.16921-1-always.starving0@gmail.com>","In-Reply-To":"<20260410175031.16921-1-always.starving0@gmail.com>","From":"Li Wang ","Date":"Mon, 13 Apr 2026 17:04:45 +0800","X-Gm-Features":"AQROBzAbC2D7y_uNmpwGOAf-rfHY3OZuCsrrLtBWNesGecrLqNAK7WyT1cbq418","Message-ID":"\n ","To":"Jinseok Kim ","X-Spam-Status":"No, score=1.3 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,FORGED_GMAIL_RCVD,\n FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Level":"*","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-5.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-5.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH] include/lapi: add leaf Makefile","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}},{"id":3676929,"web_url":"http://patchwork.ozlabs.org/comment/3676929/","msgid":"<20260413212007.GA164377@pevik>","list_archive_url":null,"date":"2026-04-13T21:20:07","subject":"Re: [LTP] [PATCH] include/lapi: add leaf Makefile","submitter":{"id":70792,"url":"http://patchwork.ozlabs.org/api/people/70792/","name":"Petr Vorel","email":"pvorel@suse.cz"},"content":"Hi Jinseok,\n\nThanks for fixing this!\n\n> Fixes : https://github.com/linux-test-project/ltp/issues/1262\n\nnit: Please next time avoid space before ':'.\n\nFixes: https://github.com/linux-test-project/ltp/issues/1262\n\n> include/lapi and include/lapi/syscalls lack Makefiles, so 'make check'\n> does not work in these directories. Add minimal leaf Makefiles.\n\nnit: Also it'd go here.\n\n> Signed-off-by: Jinseok Kim \n> ---\n> include/lapi/Makefile | 8 ++++++++\n> include/lapi/syscalls/Makefile | 8 ++++++++\n> 2 files changed, 16 insertions(+)\n> create mode 100644 include/lapi/Makefile\n> create mode 100644 include/lapi/syscalls/Makefile\n\n> diff --git a/include/lapi/Makefile b/include/lapi/Makefile\n> new file mode 100644\n> index 000000000..83ef85c77\n> --- /dev/null\n> +++ b/include/lapi/Makefile\n> @@ -0,0 +1,8 @@\n> +# SPDX-License-Identifier: GPL-2.0-or-later\n> +# Copyright (C) 2026 Jinseok Kim \n> +\n> +top_srcdir ?= ../../\n> +\n> +include $(top_srcdir)/include/mk/env_pre.mk\n> +\n> +include $(top_srcdir)/include/mk/generic_leaf_target.mk\n> diff --git a/include/lapi/syscalls/Makefile b/include/lapi/syscalls/Makefile\n\n> new file mode 100644\n> index 000000000..e46c90ef5\n> --- /dev/null\n> +++ b/include/lapi/syscalls/Makefile\n> @@ -0,0 +1,8 @@\n> +# SPDX-License-Identifier: GPL-2.0-or-later\n> +# Copyright (C) 2026 Jinseok Kim \n> +\n> +top_srcdir ?= ../../../\n> +\n> +include $(top_srcdir)/include/mk/env_pre.mk\n> +\n> +include $(top_srcdir)/include/mk/generic_leaf_target.mk\n\nWhy do we need this file? This one should be deleted. Also, because make install\nworks for include directory, it should work here as well.\nI would just copy that header, update top_srcdir location and also include\ngeneric_trunk_target.mk to include/Makefile.\n\nI think this is a better version.\n\nKind regards,\nPetr\n\ndiff --git include/Makefile include/Makefile\nindex 6b31b046e4..84cd4ed6e3 100644\n--- include/Makefile\n+++ include/Makefile\n@@ -24,4 +24,4 @@ ac-maintainer-clean:: ac-clean\n \n vpath %.h $(abs_srcdir)\n \n-include $(top_srcdir)/include/mk/generic_leaf_target.mk\n+include $(top_srcdir)/include/mk/generic_trunk_target.mk\ndiff --git include/lapi/Makefile include/lapi/Makefile\nindex 83ef85c77c..2a66e5aff6 100644\n--- include/lapi/Makefile\n+++ include/lapi/Makefile\n@@ -1,8 +1,28 @@\n # SPDX-License-Identifier: GPL-2.0-or-later\n-# Copyright (C) 2026 Jinseok Kim \n+# Copyright (C) 2009, Cisco Systems Inc.\n+# Copyright (c) Linux Test Project, 2026\n+# Ngie Cooper, July 2009\n \n-top_srcdir ?= ../../\n+top_srcdir\t\t?= ../..\n \n include $(top_srcdir)/include/mk/env_pre.mk\n \n+INSTALL_DIR\t\t:= $(includedir)/lapi\n+\n+INSTALL_MODE\t\t:= 00644\n+\n+INSTALL_TARGETS\t\t:= *.h\n+\n+MAKE_TARGETS\t\t:=\n+\n+.PHONY: ac-clean ac-distclean ac-maintainer-clean distclean maintainer-clean\n+distclean:: clean ac-distclean\n+maintainer-clean:: distclean ac-maintainer-clean\n+ac-clean ac-distclean::\n+\t$(RM) -f config.h lapi/syscalls.h stamp-h1\n+ac-maintainer-clean:: ac-clean\n+\t$(RM) -f config.h.in\n+\n+vpath %.h $(abs_srcdir)\n+\n include $(top_srcdir)/include/mk/generic_leaf_target.mk\ndiff --git include/lapi/syscalls/Makefile include/lapi/syscalls/Makefile\ndeleted file mode 100644\nindex e46c90ef5f..0000000000\n--- include/lapi/syscalls/Makefile\n+++ /dev/null\n@@ -1,8 +0,0 @@\n-# SPDX-License-Identifier: GPL-2.0-or-later\n-# Copyright (C) 2026 Jinseok Kim \n-\n-top_srcdir ?= ../../../\n-\n-include $(top_srcdir)/include/mk/env_pre.mk\n-\n-include $(top_srcdir)/include/mk/generic_leaf_target.mk","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=TwRP1kOi;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.cz\n header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=53MSG9XD;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa\n header.b=TwRP1kOi;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=53MSG9XD;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=213.254.12.146; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=TwRP1kOi;\n dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=53MSG9XD"],"Received":["from picard.linux.it (picard.linux.it [213.254.12.146])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvgL11x25z1y2d\n\tfor ; Tue, 14 Apr 2026 07:20:25 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id D55A53E0CF2\n\tfor ; Mon, 13 Apr 2026 23:20:22 +0200 (CEST)","from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [217.194.8.3])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id D2C063D0106\n for ; Mon, 13 Apr 2026 23:20:19 +0200 (CEST)","from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 144821A0043E\n for ; Mon, 13 Apr 2026 23:20:18 +0200 (CEST)","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id 0A0676A8E6;\n Mon, 13 Apr 2026 21:20:17 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DD4BB4B0BD;\n Mon, 13 Apr 2026 21:20:16 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id V2ecNBBe3WnGDQAAD6G6ig\n (envelope-from ); Mon, 13 Apr 2026 21:20:16 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1776115217;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=lNKsYdFx3e9iXyfIBuNHatUHYVKCFQigXsACFH2OmUU=;\n b=TwRP1kOiNi8LkKm6J77oFzHBttPUwKQoPUG3xIgFnyY/FandXMCGiVN/EYYsVW1knkpe8t\n L53+EMf9NHqMy6ztaZA27BFf/8n3tCKxCeGOy2Yy4kWFWDgl13An9+Y9YkuLbkqUXwxOas\n C9zhs4LlISImI+x39CCzN87/daf0zXw=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1776115217;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=lNKsYdFx3e9iXyfIBuNHatUHYVKCFQigXsACFH2OmUU=;\n b=53MSG9XDoka88ZPplIQTCzgZynKAo/8H/LzQHHkNAtYXClOThjywXm2fAs6zds8Db5QwUx\n YJTo8EDI4yp34EBQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1776115217;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=lNKsYdFx3e9iXyfIBuNHatUHYVKCFQigXsACFH2OmUU=;\n b=TwRP1kOiNi8LkKm6J77oFzHBttPUwKQoPUG3xIgFnyY/FandXMCGiVN/EYYsVW1knkpe8t\n L53+EMf9NHqMy6ztaZA27BFf/8n3tCKxCeGOy2Yy4kWFWDgl13An9+Y9YkuLbkqUXwxOas\n C9zhs4LlISImI+x39CCzN87/daf0zXw=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1776115217;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=lNKsYdFx3e9iXyfIBuNHatUHYVKCFQigXsACFH2OmUU=;\n b=53MSG9XDoka88ZPplIQTCzgZynKAo/8H/LzQHHkNAtYXClOThjywXm2fAs6zds8Db5QwUx\n YJTo8EDI4yp34EBQ=="],"Date":"Mon, 13 Apr 2026 23:20:07 +0200","From":"Petr Vorel ","To":"Jinseok Kim ","Message-ID":"<20260413212007.GA164377@pevik>","References":"<20260410175031.16921-1-always.starving0@gmail.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20260410175031.16921-1-always.starving0@gmail.com>","X-Rspamd-Action":"no action","X-Rspamd-Server":"rspamd2.dmz-prg2.suse.org","X-Spamd-Result":"default: False [-3.71 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[];\n HAS_REPLYTO(0.30)[pvorel@suse.cz];\n NEURAL_HAM_SHORT(-0.20)[-1.000];\n R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[];\n DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n RCPT_COUNT_TWO(0.00)[2]; FREEMAIL_TO(0.00)[gmail.com];\n FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+];\n ARC_NA(0.00)[]; TO_DN_SOME(0.00)[];\n FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCVD_TLS_ALL(0.00)[];\n RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[];\n FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:dkim,suse.cz:replyto];\n RCVD_VIA_SMTP_AUTH(0.00)[]; TAGGED_RCPT(0.00)[];\n DKIM_TRACE(0.00)[suse.cz:+]; MISSING_XM_UA(0.00)[];\n REPLYTO_EQ_FROM(0.00)[]","X-Rspamd-Queue-Id":"0A0676A8E6","X-Spam-Score":"-3.71","X-Spam-Level":"","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-3.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-3.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH] include/lapi: add leaf Makefile","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"Petr Vorel ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}},{"id":3677052,"web_url":"http://patchwork.ozlabs.org/comment/3677052/","msgid":"","list_archive_url":null,"date":"2026-04-14T07:55:20","subject":"Re: [LTP] [PATCH] include/lapi: add leaf Makefile","submitter":{"id":74427,"url":"http://patchwork.ozlabs.org/api/people/74427/","name":"Li Wang","email":"wangli.ahau@gmail.com"},"content":"On Tue, Apr 14, 2026 at 5:20 AM Petr Vorel wrote:\n>\n> Hi Jinseok,\n>\n> Thanks for fixing this!\n>\n> > Fixes : https://github.com/linux-test-project/ltp/issues/1262\n>\n> nit: Please next time avoid space before ':'.\n>\n> Fixes: https://github.com/linux-test-project/ltp/issues/1262\n>\n> > include/lapi and include/lapi/syscalls lack Makefiles, so 'make check'\n> > does not work in these directories. Add minimal leaf Makefiles.\n>\n> nit: Also it'd go here.\n>\n> > Signed-off-by: Jinseok Kim \n> > ---\n> > include/lapi/Makefile | 8 ++++++++\n> > include/lapi/syscalls/Makefile | 8 ++++++++\n> > 2 files changed, 16 insertions(+)\n> > create mode 100644 include/lapi/Makefile\n> > create mode 100644 include/lapi/syscalls/Makefile\n>\n> > diff --git a/include/lapi/Makefile b/include/lapi/Makefile\n> > new file mode 100644\n> > index 000000000..83ef85c77\n> > --- /dev/null\n> > +++ b/include/lapi/Makefile\n> > @@ -0,0 +1,8 @@\n> > +# SPDX-License-Identifier: GPL-2.0-or-later\n> > +# Copyright (C) 2026 Jinseok Kim \n> > +\n> > +top_srcdir ?= ../../\n> > +\n> > +include $(top_srcdir)/include/mk/env_pre.mk\n> > +\n> > +include $(top_srcdir)/include/mk/generic_leaf_target.mk\n> > diff --git a/include/lapi/syscalls/Makefile b/include/lapi/syscalls/Makefile\n>\n> > new file mode 100644\n> > index 000000000..e46c90ef5\n> > --- /dev/null\n> > +++ b/include/lapi/syscalls/Makefile\n> > @@ -0,0 +1,8 @@\n> > +# SPDX-License-Identifier: GPL-2.0-or-later\n> > +# Copyright (C) 2026 Jinseok Kim \n> > +\n> > +top_srcdir ?= ../../../\n> > +\n> > +include $(top_srcdir)/include/mk/env_pre.mk\n> > +\n> > +include $(top_srcdir)/include/mk/generic_leaf_target.mk\n>\n> Why do we need this file? This one should be deleted. Also, because make install\n> works for include directory, it should work here as well.\n> I would just copy that header, update top_srcdir location and also include\n> generic_trunk_target.mk to include/Makefile.\n>\n> I think this is a better version.\n\nYes, this solution looks smarter, but tiny queries below.\n\n> ...\n> include $(top_srcdir)/include/mk/env_pre.mk\n>\n> +INSTALL_DIR := $(includedir)/lapi\n\nI'm doubting should we install the include/lapi/ local header files to\nthe /opt/ltp/include?\n\n> ...\n> --- include/lapi/syscalls/Makefile\n> +++ /dev/null\n\nDoes the `make check` still work (inside include/lapi/syscalls/)\nwithout this Makefile?","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=axiNiAGL;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvxR1748Vz1xtJ\n\tfor ; Tue, 14 Apr 2026 17:55:41 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id A2C683E293B\n\tfor ; Tue, 14 Apr 2026 09:55:39 +0200 (CEST)","from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::5])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id D44003C9917\n for ; Tue, 14 Apr 2026 09:55:35 +0200 (CEST)","from mail-qt1-x829.google.com (mail-qt1-x829.google.com\n [IPv6:2607:f8b0:4864:20::829])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-5.smtp.seeweb.it (Postfix) with ESMTPS id BF8D4600BC5\n for ; Tue, 14 Apr 2026 09:55:32 +0200 (CEST)","by mail-qt1-x829.google.com with SMTP id\n d75a77b69052e-50335b926c2so40886881cf.2\n for ; Tue, 14 Apr 2026 00:55:32 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1776153331; cv=none;\n d=google.com; s=arc-20240605;\n b=fDtybQ1g1BZEcKYGeOanOaeobV5fbU5eRpG8sf/xAddFArEEg2cczTSH9hEIfCZidV\n Z0pm8nwjhD1RKwb6dJVyWfRYIu7rcnnr9DmNVLmp95lICQy5TNiIy8D+ugMIrrt5Y1cj\n LRdFCzQ0EQrIV2OqStAyG7SJLprq4ZjNTTtvMAstzQ6CbYiWe5XXpDKJwN0F4ddphTfV\n I4UP3wIBgi62Uh1WwFjUuL27C0SkqRruYYAWMB+8JLxE4IgQgNDg9syf7ls05Sy6v/C4\n M+XeZWUUkxWfrsuKcQJmLXUKvJskteTvX+SXuyx38B42bVlR9g0u5n+movNvDpBUvRpc\n bBrg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=r3v1lbZR7B0T3CnTyAOj5AXcyFefKYKLS2mh7YhIzhI=;\n fh=aMPhV77tTa2z5uuKum8HpgPo3Z5oBthlq3E9SPtHWEg=;\n b=aZMS+SbA2PbLXPlYO24lDXpekFbdyo9O1J1KcaoO55jIzNQaCviP49YTYcGkn1a8+G\n 1igwn/JBwOwzwSOlRvp9aLRidJUxFnwoCoO67WOF/2QcBd5LnZqzSl/Mr8f/1B05cD/Y\n J0vkO2vwxNUewasmzpAuX6AjV00NMWtK01FwKEt5ll6qSTdCoeIKfgPBjXjTP9U+hbHm\n y7mWqUMbU0yjnrDxY9c2zILKPVoxWn1cuqtlNnOet31P2BkquNIPupkoGLEOuReYVSuC\n mnEwxcYQ7kt1NHPT1vZjAd1kUBfRZM8bDWJHeSxaP35nvAz89ySK+pNc1EQjVR4Elh1r\n mh2w==; darn=lists.linux.it","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776153331; x=1776758131; darn=lists.linux.it;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=r3v1lbZR7B0T3CnTyAOj5AXcyFefKYKLS2mh7YhIzhI=;\n b=axiNiAGL+KrffB0rpQDX6Rz4V2y6OS0/67DS98JNJqeb0C6lcqd9PzldIpRQGVDeN2\n nLiMHuj7/IqKJNyda7bF7A1OpdOF5Fw3hJg47st9jvRI0ru1hSWt9qd74x/ZH1/LwxmJ\n w3jbezgeKfzKzpRE7LCT5BpXlxPfdt4xVRhoTAIhC3hZLtNs3ibJBKTVWbOr7ka78Xxe\n laS3cWsAc584ATDZFvlhTidHGDFnBOKEfuWiB2DKQ4/mIuRCkd+8zqVPXNalZmAY0jgE\n cXwWfbl4xvQA+sDl7WM7ieWzRzp84iutBd/OdJ9WfRKTx9VrBnaf8q/9swkam9YSbRY+\n +Lxg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776153331; x=1776758131;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=r3v1lbZR7B0T3CnTyAOj5AXcyFefKYKLS2mh7YhIzhI=;\n b=WywNYJVqGD6tGrnsAAi+QoxdBDUWbECscseHZ2+NFU0JJNItFkoSqb7HU+cAmWB9hA\n YRBo0vHO1DzQYuqoLLGyddGzgKQ3LzNYuVUiFoQyrnh2euT9n1ixwpFamPrQ6zpZOZZ3\n CZM4n6qpIvyX7glxMmspgQWhHpkyuACfeIbdpio0J7q29AWLrHNaKVSqBVjvK9eZ9KUZ\n kexnNfannt++LpYF6TDhZjsy7O8fSyRJTT359S0HZC02wTpGwtwShZdVT7/Lufi+OrN5\n x8UQLbdcU10YWL5u8cE6Vq1j3Cvr5DTw4KBrOYvyEdPYd/Q0Cwxj3VAkPmek01uNXpg+\n K2Bw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9ojp995plnQN7x5y2sLtEvTfZbi8Qu/rXQOwzJ4BVnGAvBK1Oe+m0oZZ0l5EjAUym3dPI=@lists.linux.it","X-Gm-Message-State":"AOJu0YxWvFO80mSnuwRxaXQMeZ6gsieoeCaY4pVX4nLUDxglA/pwJHp2\n TAKXgHPeQWLZR+fSVmkUu6oKsg7yLR2PqGdI6pxbQLonveYkSVT6uyAI1I72XWrHrnVFwF5xxs9\n X+f7QSOVHG7VfVCHlNqoqaMvGzzWvAQ==","X-Gm-Gg":"AeBDievWd9m2QOcyUs7UBmVfjsTV4NnzMaT8Ne/IP8P4/wnd1ShugGHImIHwSOueudg\n CNdOh0UXgUO7hm+mzld86EcRCSibJSpdyEsBmG2/emqdzpOwDHF4ddqFxMXAfGhGC4p6LrO0zwv\n BcQljObBCL+f7cdz3dEUhwmln+rwA+XM1e7qOJtsbb19tEfS6i/vjIMTuxkpmEy1Kn9jd4h6U4D\n S7ICwZQRe8P0lJZsub9Q0A+gWsAf8LFa/KL6ZdilP3x/q4i95vqpCXIEdyudrvf+aoT3jM3+vzS\n K0BIZtjsK6kpnQvr","X-Received":"by 2002:a0c:f208:0:b0:899:e567:f04d with SMTP id\n 6a1803df08f44-8ac8613a0c1mr253701266d6.11.1776153331340; Tue, 14 Apr 2026\n 00:55:31 -0700 (PDT)","MIME-Version":"1.0","References":"<20260410175031.16921-1-always.starving0@gmail.com>\n <20260413212007.GA164377@pevik>","In-Reply-To":"<20260413212007.GA164377@pevik>","From":"Li Wang ","Date":"Tue, 14 Apr 2026 15:55:20 +0800","X-Gm-Features":"AQROBzC2lWy4W-kMitU_d-HHDV7WOJPZ4UOP1u3n19NQQejW9Xyr2UI1K-H3xzQ","Message-ID":"\n ","To":"Petr Vorel ","X-Spam-Status":"No, score=1.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,FORGED_GMAIL_RCVD,FREEMAIL_FROM,\n SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Level":"*","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-5.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-5.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH] include/lapi: add leaf Makefile","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]